Add eslint rule to disallow non-null-assertion (#4613)

* Add rule to disallow non-null-assertion * Fix all linting errors * Fix lint error * Delete samples/Calling/src/app/views/ErrorBoundary.tsx Signed-off-by: Porter Nan <jiangnanhello@live.com> --------- Signed-off-by: Porter Nan <jiangnanhello@live.com>
2024-10-24 14:37:07 -07:00 · 2024-10-24 14:37:07 -07:00 · 3f044549c3
--- a/packages/acs-ui-common/.eslintrc.js
+++ b/packages/acs-ui-common/.eslintrc.js
@ -27,6 +27,7 @@ module.exports = {
    ],
    '@typescript-eslint/no-explicit-any': 'error',
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    '@typescript-eslint/no-unused-vars': ['warn', { varsIgnorePattern: '^_' }],
    'no-restricted-imports': [
--- a/packages/calling-component-bindings/.eslintrc.js
+++ b/packages/calling-component-bindings/.eslintrc.js
@ -27,6 +27,7 @@ module.exports = {
    ],
    '@typescript-eslint/no-explicit-any': 'off',
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    '@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
    'no-restricted-imports': [
--- a/packages/calling-stateful-client/.eslintrc.js
+++ b/packages/calling-stateful-client/.eslintrc.js
@ -27,6 +27,7 @@ module.exports = {
    ],
    '@typescript-eslint/no-explicit-any': 'off',
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    '@typescript-eslint/no-unused-vars': ['warn', { varsIgnorePattern: '^_' }],
    'no-restricted-imports': [
--- a/packages/chat-component-bindings/.eslintrc.js
+++ b/packages/chat-component-bindings/.eslintrc.js
@ -27,6 +27,7 @@ module.exports = {
    ],
    '@typescript-eslint/no-explicit-any': 'off',
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    '@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
    'no-restricted-imports': [
--- a/packages/chat-stateful-client/.eslintrc.js
+++ b/packages/chat-stateful-client/.eslintrc.js
@ -27,6 +27,7 @@ module.exports = {
    ],
    '@typescript-eslint/no-explicit-any': 'off',
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    '@typescript-eslint/no-unused-vars': ['warn', { varsIgnorePattern: '^_' }],
    'no-restricted-imports': [
--- a/packages/communication-react/.eslintrc.js
+++ b/packages/communication-react/.eslintrc.js
@ -33,6 +33,7 @@ module.exports = {
    ],
    '@typescript-eslint/no-explicit-any': 'off',
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'react/display-name': 'off',
    '@typescript-eslint/no-unused-vars': ['warn', { varsIgnorePattern: '^_' }],
--- a/packages/fake-backends/.eslintrc.js
+++ b/packages/fake-backends/.eslintrc.js
@ -26,6 +26,7 @@ module.exports = {
      }
    ],
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'react/display-name': 'off',
    '@typescript-eslint/no-unused-vars': ['warn', { varsIgnorePattern: '^_' }],
--- a/packages/react-components/.eslintrc.js
+++ b/packages/react-components/.eslintrc.js
@ -31,6 +31,7 @@ module.exports = {
      }
    ],
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'react/display-name': 'off',
    '@typescript-eslint/no-explicit-any': 'error',
--- a/packages/react-components/src/components/Survey/TagsSurvey/TagsSurvey.tsx
+++ b/packages/react-components/src/components/Survey/TagsSurvey/TagsSurvey.tsx
@ -142,9 +142,9 @@ export const _TagsSurvey = (props: _TagsSurveyProps): JSX.Element => {
      if (checked) {
        if (issue) {
          setSelectedTags((prevState) => {
-            const existingIssues = prevState?.[issueCategory]?.issues;
-            if (existingIssues) {
-              prevState[issueCategory]!.issues = [...existingIssues, issue] as any;
+            const category = prevState?.[issueCategory];
+            if (category && category.issues) {
+              category.issues = [category.issues, issue] as any;
            } else {
              prevState[issueCategory] = { issues: [issue] } as any;
            }
--- a/packages/react-composites/.eslintrc.js
+++ b/packages/react-composites/.eslintrc.js
@ -33,6 +33,7 @@ module.exports = {
      }
    ],
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'react/display-name': 'off',
    '@typescript-eslint/no-explicit-any': 'error',
--- a/packages/react-composites/tests/browser/chat/hermetic/fixture.ts
+++ b/packages/react-composites/tests/browser/chat/hermetic/fixture.ts
@ -43,7 +43,7 @@ export const TEST_PARTICIPANTS: ChatParticipant[] = TEST_PARTICIPANTS_CHAT.map((
 * Default fake chat adapter args
 */
 export const DEFAULT_FAKE_CHAT_ADAPTER_ARGS = {
-  localParticipant: TEST_PARTICIPANTS[0]!,
+  localParticipant: TEST_PARTICIPANTS[0] as ChatParticipant,
  remoteParticipants: TEST_PARTICIPANTS.slice(1)
 };

--- a/packages/storybook8/.eslintrc.js
+++ b/packages/storybook8/.eslintrc.js
@ -37,6 +37,7 @@ module.exports = {
    '@typescript-eslint/no-explicit-any': 'off',
    '@typescript-eslint/no-unused-vars': ['warn', { varsIgnorePattern: '^_' }],
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'import/named': 'off', // very time consuming
    'import/namespace': 'off', // very time consuming
--- a/samples/CallWithChat/.eslintrc.js
+++ b/samples/CallWithChat/.eslintrc.js
@ -32,6 +32,7 @@ module.exports = {
      }
    ],
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'react/display-name': 'off',
    '@typescript-eslint/no-explicit-any': 'error',
--- a/samples/Calling/.eslintrc.js
+++ b/samples/Calling/.eslintrc.js
@ -32,6 +32,7 @@ module.exports = {
      }
    ],
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'react/display-name': 'off',
    '@typescript-eslint/no-explicit-any': 'error',
--- a/samples/CallingStateful/.eslintrc.js
+++ b/samples/CallingStateful/.eslintrc.js
@ -32,6 +32,7 @@ module.exports = {
      }
    ],
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'react/display-name': 'off',
    '@typescript-eslint/no-explicit-any': 'error',
--- a/samples/Chat/.eslintrc.js
+++ b/samples/Chat/.eslintrc.js
@ -32,6 +32,7 @@ module.exports = {
      }
    ],
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'react/display-name': 'off',
    '@typescript-eslint/no-explicit-any': 'error',
--- a/samples/ComponentExamples/.eslintrc.js
+++ b/samples/ComponentExamples/.eslintrc.js
@ -32,6 +32,7 @@ module.exports = {
      }
    ],
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'react/display-name': 'off',
    '@typescript-eslint/no-explicit-any': 'error',
--- a/samples/Server/.eslintrc.js
+++ b/samples/Server/.eslintrc.js
@ -26,6 +26,7 @@ module.exports = {
      }
    ],
    eqeqeq: 'warn',
+    '@typescript-eslint/no-non-null-assertion': 'error',
    'header/header': ['error', 'line', ' Copyright (c) Microsoft Corporation.\n Licensed under the MIT License.'],
    'react/display-name': 'off',