Address ARB comments for DNS (#5143)

* ARB comments

* Change files

change-beta/@azure-communication-react-37eb3183-231d-470a-a079-4233c7907215.json

@@ -0,0 +1,9 @@
+{
+  "type": "prerelease",
+  "area": "feature",
+  "workstream": "DNS",
+  "comment": "ARB comments",
+  "packageName": "@azure/communication-react",
+  "email": "97124699+prabhjot-msft@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

packages/calling-component-bindings/src/handlers/createHandlers.ts

@@ -47,6 +47,10 @@ export interface CallingHandlers extends CommonCallingHandlers {
 export type CallingHandlersOptions = {
   onResolveVideoBackgroundEffectsDependency?: () => Promise<VideoBackgroundEffectsDependency>;
   /* @conditional-compile-remove(DNS) */
+  /**
+   * Dependency resolver for deep noise suppression effect.
+   * @beta
+   */
   onResolveDeepNoiseSuppressionDependency?: () => Promise<DeepNoiseSuppressionEffectDependency>;
 };
 

packages/communication-react/review/beta/communication-react.api.md

@@ -507,7 +507,7 @@ export type CallAdapterClientState = {
     onResolveVideoEffectDependency?: () => Promise<VideoBackgroundEffectsDependency>;
     onResolveDeepNoiseSuppressionDependency?: () => Promise<DeepNoiseSuppressionEffectDependency>;
     deepNoiseSuppressionOnByDefault?: boolean;
-    hideNoiseSuppressionButton?: boolean;
+    hideDeepNoiseSuppressionButton?: boolean;
     selectedVideoBackgroundEffect?: VideoBackgroundEffect;
     acceptedTransferCallState?: CallState;
     hideAttendeeNames?: boolean;
@@ -1400,7 +1400,7 @@ export interface CallWithChatClientState {
     environmentInfo?: EnvironmentInfo;
     hideAttendeeNames?: boolean;
     // @beta
-    hideNoiseSuppressionButton?: boolean;
+    hideDeepNoiseSuppressionButton?: boolean;
     isTeamsCall: boolean;
     isTeamsMeeting: boolean;
     latestCallErrors: AdapterErrors;

packages/react-composites/src/composites/CallComposite/adapter/AzureCommunicationCallAdapter.ts

@@ -165,7 +165,7 @@ class CallContext {
       deepNoiseSuppressionOptions?: {
         onResolveDependency?: () => Promise<DeepNoiseSuppressionEffectDependency>;
         deepNoiseSuppressionOnByDefault?: boolean;
-        hideNoiseSuppressionButton?: boolean;
+        hideDeepNoiseSuppressionButton?: boolean;
       };
       callingSounds?: CallingSounds;
       reactionResources?: ReactionResources;
@@ -198,7 +198,7 @@ class CallContext {
       /* @conditional-compile-remove(DNS) */
       deepNoiseSuppressionOnByDefault: options?.deepNoiseSuppressionOptions?.deepNoiseSuppressionOnByDefault ?? true,
       /* @conditional-compile-remove(DNS) */
-      hideNoiseSuppressionButton: options?.deepNoiseSuppressionOptions?.hideNoiseSuppressionButton ?? false,
+      hideDeepNoiseSuppressionButton: options?.deepNoiseSuppressionOptions?.hideDeepNoiseSuppressionButton ?? false,
       selectedVideoBackgroundEffect: undefined,
       cameraStatus: undefined,
       sounds: options?.callingSounds,
@@ -1593,6 +1593,7 @@ export type CommonCallAdapterOptions = {
   /* @conditional-compile-remove(DNS) */
   /**
    * `DeepNoiseSuppressionEffect` options to be used for noise suppression.
+   * @beta
    */
   deepNoiseSuppressionOptions?: {
     onResolveDependency?: () => Promise<DeepNoiseSuppressionEffectDependency>;

packages/react-composites/src/composites/CallComposite/adapter/CallAdapter.ts

@@ -189,7 +189,7 @@ export type CallAdapterClientState = {
    * @beta
    * @default false
    */
-  hideNoiseSuppressionButton?: boolean;
+  hideDeepNoiseSuppressionButton?: boolean;
   /**
    * State to track the selected video background effect.
    */

packages/react-composites/src/composites/CallComposite/components/CallControls.tsx

@@ -113,7 +113,7 @@ export const CallControls = (props: CallControlsProps & ContainerRectProps): JSX
   }, [adapter, startDeepNoiseSuppression]);
   /* @conditional-compile-remove(DNS) */
   const showNoiseSuppressionButton =
-    adapter.getState().onResolveDeepNoiseSuppressionDependency && !adapter.getState().hideNoiseSuppressionButton
+    adapter.getState().onResolveDeepNoiseSuppressionDependency && !adapter.getState().hideDeepNoiseSuppressionButton
       ? true
       : false;
 

packages/react-composites/src/composites/CallWithChatComposite/state/CallWithChatAdapterState.ts

@@ -102,7 +102,7 @@ export interface CallWithChatClientState {
   /** State to track whether to hide the noise suppression button.
    * @beta
    */
-  hideNoiseSuppressionButton?: boolean;
+  hideDeepNoiseSuppressionButton?: boolean;
 
   /** State to track the selected video background effect */
   selectedVideoBackgroundEffect?: VideoBackgroundEffect;

packages/react-composites/src/composites/common/ControlBar/CommonCallControlBar.tsx

@@ -236,7 +236,7 @@ export const CommonCallControlBar = (props: CommonCallControlBarProps & Containe
   /* @conditional-compile-remove(DNS) */
   const showNoiseSuppressionButton =
     props.callAdapter.getState().onResolveDeepNoiseSuppressionDependency &&
-    !props.callAdapter.getState().hideNoiseSuppressionButton
+    !props.callAdapter.getState().hideDeepNoiseSuppressionButton
       ? true
       : false;
   /* @conditional-compile-remove(DNS) */