Add tsc:e2e typecheck command to composite (#2014)

* Add tsc:e2e typecheck command to composite
Add test typecheck into ci
Fix type errors

Co-authored-by: Nan Jiang <jinan@microsoft.com>
Co-authored-by: dmceachernmsft <94866715+dmceachernmsft@users.noreply.github.com>

.github/workflows/ci.yml

@@ -76,6 +76,9 @@ jobs:
       # Perform lint check
       - name: Run linter
         run: rush lint
+      # Type check test folder
+      - name: Type check test folder
+        run: cd packages/react-composites && rushx tsc:e2e
       # Builds
       - name: Build Packages
         run: rush build -t @azure/communication-react

change/@internal-react-composites-e22a3e99-3581-46d0-ac0a-0ccbaabddfee.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "Add tsc:e2e typecheck command to composite",
+  "packageName": "@internal/react-composites",
+  "email": "jinan@microsoft.com",
+  "dependentChangeType": "none"
+}

packages/react-composites/package.json

@@ -15,6 +15,7 @@
     "build:cjs": "rollup -c --silent --failAfterWarnings",
     "build:watch": "rushx build",
     "clean": "rimraf dist && rimraf preprocessed",
+    "tsc:e2e": "tsc -project tests/tsconfig.json",
     "build:e2e": "rushx _by-flavor \"rushx build:e2e:call && rushx build:e2e:chat && rushx build:e2e:callwithchat\"",
     "build:e2e:call": "rushx _by-flavor \"webpack-cli build --config ./tests/browser/call/app/webpack.config.js --mode=production --env production\"",
     "build:e2e:chat": "rushx _by-flavor \"webpack-cli build --config ./tests/browser/chat/app/webpack.config.js --mode=production --env production\"",

packages/react-composites/tests/browser/call/fixture.ts

@@ -18,7 +18,7 @@ type CallWorkerFixture = WorkerFixture<CallUserType>;
  *
  * The @returns values are available to reference in tests.
  */
-export const test = base.extend<unknown, CallWorkerFixture>({
+export const test = base.extend<Record<string, unknown>, CallWorkerFixture>({
   /** @returns string URL for the server. */
   serverUrl: [createTestServer({ appDir: APP_DIR, serverUrl: SERVER_URL }), { scope: 'worker' }],
 

packages/react-composites/tests/browser/callwithchat/fixture.ts

@@ -18,7 +18,7 @@ type CallWithChatWorkerFixture = WorkerFixture<CallWithChatUserType>;
  *
  * The @returns values are available to reference in tests.
  */
-export const test = base.extend<unknown, CallWithChatWorkerFixture>({
+export const test = base.extend<Record<string, unknown>, CallWithChatWorkerFixture>({
   /** @returns string URL for the server. */
   serverUrl: [createTestServer({ appDir: APP_DIR, serverUrl: SERVER_URL }), { scope: 'worker' }],
 

packages/react-composites/tests/tsconfig.json

@@ -7,10 +7,5 @@
       "@internal/acs-ui-common": ["../../acs-ui-common/src"]
     }
   },
-  "include": [
-    "./browser/**/*.test.ts",
-    "browser/chat/fixture.ts",
-    "browser/chat/fake-adapter/fixture.ts",
-    "browser/call/fixture.ts"
-  ]
+  "include": ["/browser/**/*.ts", "server/**/*.ts"]
 }