Arlo
c8f76d072d
Disable blank issue template
2024-10-31 08:52:52 -07:00
Arlo Godfrey
11d6d93ee5
Remove outdated issue templates for bug reports and feature requests
2024-10-31 08:43:40 -07:00
Michael Hawker MSFT (XAML Llama)
6bfe8a5d21
Update ReadMe.md with info about new repository ( #4936 )
...
* Update ReadMe.md with info about new repository
* Clarify original vNext section to go with new update
2023-09-21 15:31:18 -07:00
Arlo
2d608fdb83
Updated readme links to preview repos ( #4886 )
...
* Updated links to preview repos
* Added link and desc for WCT Labs
2023-06-12 12:34:45 -07:00
Michael Hawker MSFT (XAML Llama)
77b009ddf5
Merge pull request #4792 from michael-hawker/colorpickerslider-theme-change-fix
...
ColorPicker Slider Circle Accessibility Fix
2022-10-20 23:22:51 -07:00
michael-hawker
2cb5e837fc
Fix using statement order for StyleCop
2022-10-20 22:28:52 -07:00
robloo
1e178701e9
Handle theme changes in ColorPickerSlider
2022-10-20 22:28:52 -07:00
Michael Hawker MSFT (XAML Llama)
b22c1151b0
Merge pull request #4790 from michael-hawker/llama/fix4505
...
TaskResultConverter returns default value when task not set
2022-10-20 19:05:31 -07:00
michael-hawker
e3fe539d52
Remove ValueType support and reflection piece from TaskResultConverter
...
Update description to explicitly call out returning null instead of default if no task or task result not ready.
2022-10-20 16:29:31 -07:00
michael-hawker
1398210158
Fixes #4505 - TaskResultConverter properly returns default value in case task is not set or has not completed.
...
Updated description to include unset Task scenario (i.e. null being passed in)
Updated to include proper default value return for Value types
Included value passthru for non-Task values
2022-10-20 16:29:31 -07:00
michael-hawker
b8ec35e080
Add new test cases which show issues with current TaskResultConverter.
2022-10-20 16:29:31 -07:00
michael-hawker
0e3b4e0b64
Use new C# new initialization for vars
2022-10-20 16:29:31 -07:00
Michael Hawker MSFT (XAML Llama)
aa39ee5d70
Merge pull request #4791 from CommunityToolkit/revert-4333-feature/extended-tree-helpers
...
Revert "Feature/extended tree helpers"
2022-10-20 16:28:24 -07:00
Michael Hawker MSFT (XAML Llama)
7a37ad1f36
Revert "Feature/extended tree helpers"
2022-10-20 15:34:26 -07:00
Michael Hawker MSFT (XAML Llama)
b2b1c238e6
Merge pull request #4789 from CommunityToolkit/update-nuget
...
Update NuGet Version in build pipeline
2022-10-19 15:07:54 -07:00
Michael Hawker MSFT (XAML Llama)
4eadc8740c
Update NuGet Version in build pipeline
2022-10-19 12:09:40 -07:00
Michael Hawker MSFT (XAML Llama)
2233ac655f
Merge pull request #4786 from michael-hawker/llama/tokenizingtextbox-fix4749
...
Fix Text initialization and updating for TokenizingTextBox
2022-10-18 10:25:43 -07:00
Michael Hawker MSFT (XAML Llama)
5d901493fc
Merge pull request #4730 from HavenDV/fix-color-picker-button-binding-issue
...
fix: Fix color picker button binding failure issue
2022-10-18 10:25:10 -07:00
Konstantin S
7f49e981db
fix: Fix color picker button binding failure issue
2022-10-18 09:31:21 -07:00
Michael Hawker MSFT (XAML Llama)
cd1afd0062
fix comment in typo based on PR
2022-10-18 09:30:24 -07:00
michael-hawker
21e5a35a07
Add test to check changing the Text of a TokenizingTextBox
2022-10-18 09:30:24 -07:00
michael-hawker
ac1723d1fb
Fix manually tested issue where initial character press of overwriting token wasn't being set to box (aggressive if)
...
Also realized we would no longer raise the text changed event in that scenario, so changed logic for text changed event.
We'll need to create integration tests for these keyboard driven scenarios in the new test setup from Labs (when it's finished) in 8.0. These would make good keyboard driver tests.
2022-10-18 09:30:24 -07:00
michael-hawker
6e9441635d
Add tests and fix issues with setting Text to delimited items.
2022-10-18 09:30:24 -07:00
michael-hawker
c0ada84646
Fix issue #4749
...
Hook up initialization and change detection of parent Text property to update corresponding inner text of TokenizingTextBoxItem
Failing tests from previous commit now pass.
2022-10-18 09:30:24 -07:00
michael-hawker
9f018956ea
Remove invalid binding - add failing tests to show problems for #4749
...
Think we maybe used to bind to the text directly, but there's no Text property directly on the TokenizingTextBoxItem, so this binding is meaningless. It doesn't effect the behavior of the textbox in practical usage, but somehow was doing something which was masking the problem for us to be able to detect within a test case.
Removing it to reduce confusion.
The text sync between the parent TokenizingTextBox collection of items (and the current edit) and the item is maintained through code-behind with text changing events. Though work is being done to resolve issues in this sync process. See issue https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/4749
2022-10-18 09:30:24 -07:00
michael-hawker
39925b9982
Switch to using VisualUITestBase for general TokenizingTextBox tests, use proper async tests
...
Also splits out Clear test into two separate tests.
2022-10-18 09:30:24 -07:00
michael-hawker
d039aa88a8
Fix issue building release mode tests locally
...
See https://devblogs.microsoft.com/nuget/announcing-nuget-6-3-transitive-dependencies-floating-versions-and-re-enabling-signed-package-verification/#new-warnings-when-duplicate-packagereference-packageversion-or-packagedownload-are-found for info about increased warning level.
Also see https://github.com/dotnet/sdk/issues/24747
Not sure where the duplicate reference is coming from though...
2022-10-18 09:30:24 -07:00
michael-hawker
2b606e1f0b
Fix issues with building in debug Any CPU (again?)
...
(Don't set Release as that effects CI)
2022-10-18 09:30:24 -07:00
Michael Hawker MSFT (XAML Llama)
acf30d6d46
Merge pull request #4787 from michael-hawker/llama/fix4784
...
RadialGauge and WeakEventListener optimizations
2022-10-18 09:28:01 -07:00
michael-hawker
5ba956ee4f
Fix #4784 unregister event handlers in RadialGauge before Re-registering
2022-10-18 01:08:40 -07:00
michael-hawker
60d61ad62a
Clean-up some issues with WeakEventListener Usage, make OnEventAction lambda's static
...
See https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/3029#issuecomment-547543581
and https://github.com/MicrosoftDocs/WindowsCommunityToolkitDocs/issues/262#issuecomment-912522699
2022-10-18 01:08:38 -07:00
michael-hawker
70f7ab8919
Register Keyboard Handlers for RadialGauge once and make lambda functions static
...
Contributes to https://github.com/CommunityToolkit/WindowsCommunityToolkit/issues/4784
2022-10-18 00:24:42 -07:00
Michael Hawker MSFT (XAML Llama)
b2ea7ba59c
Change version back to 7.1.x series based on current planning
2022-10-14 13:21:55 -07:00
Arlo
ca55adeae0
Fixed StringFormatConverter ignoring Language parameter, cleanup ( #4764 )
...
* Added CultureInfo to StringFormatConverter
* Cleanup uneeded CultureInfo property
* Only construct CultureInfo if needed
* Remove unnecessary tests
* Remove unused decimal
Co-authored-by: tutkus <tutka.pawel@gmail.com>
2022-10-11 15:29:28 -07:00
Arlo Godfrey
cadc08b9b3
Properly attach / detach events when the characteristic is changed
2022-10-11 13:53:38 -07:00
Arlo Godfrey
c9895b218b
Fixed an issue where expression nodes created with custom param names were incorrectly cleared during internal cleanup
2022-10-11 12:43:19 -07:00
Diederik Krols
06aec3eb6a
Update RadialGauge to use KeyboardAccelerators ( #4456 )
...
* Update RadialGauge to use KeyboardAccelerators
Replace KeyDown event handling by KeyboardAccelerators. This does not change the behavior. It improves performance by not reacting to just any key stroke. I also removes the call to CoreWindow.GetKeyState - an API that doesn't exist in WinUI 3.
* Update RadialGauge.cs
Fixed StyleCop issues
* Formatted code, fixed remaining regressions
* Update Microsoft.Toolkit.Uwp.UI.Controls.Input/RadialGauge/RadialGauge.cs
Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com>
Co-authored-by: Arlo <arlo.godfrey@outlook.com>
2022-10-11 09:30:28 -07:00
Michael Hawker MSFT (XAML Llama)
0249f738c7
Merge pull request #4720 from Arlodotexe/fix/imagecropper-aspect-ratio-not-updating-on-image-load
...
Fixed ImageCropper AspectRatio not updating on image load
2022-09-29 15:19:07 -07:00
Nikola Metulev
bdcfa43420
Merge pull request #4589 from CommunityToolkit/fabricbot-configuration-migration
2022-09-29 14:50:09 -07:00
Nikola Metulev
306ebd575c
Merge branch 'main' into fabricbot-configuration-migration
2022-09-29 14:48:39 -07:00
Arlo
4ea8826e5a
Merge branch 'main' into fix/imagecropper-aspect-ratio-not-updating-on-image-load
2022-09-26 11:32:39 -05:00
Arlo Godfrey
5b47d71d8c
Removed extra call to UpdateMaskArea
2022-09-26 11:31:39 -05:00
Arlo Godfrey
311d05c70a
Merge branch 'fix/imagecropper-aspect-ratio-not-updating-on-image-load' of https://github.com/Arlodotexe/WindowsCommunityToolkit into fix/imagecropper-aspect-ratio-not-updating-on-image-load
2022-09-26 11:29:05 -05:00
Arlo Godfrey
7c70926bd6
Removed unused using statement
2022-09-26 11:28:57 -05:00
Arlo
eaea805d0a
Update Microsoft.Toolkit.Uwp.UI.Controls.Media/ImageCropper/ImageCropper.Logic.cs
...
Co-authored-by: hhchaos <HHChaos@outlook.com>
2022-09-26 11:26:24 -05:00
Michael Hawker MSFT (XAML Llama)
c4d62eea10
Merge pull request #4757 from CommunityToolkit/PR4750Fix
...
AttachedDropShadowCrashFix
2022-09-22 09:10:51 -07:00
LalithaNadimpalli
3ca0e49c4b
AttachedDropShadowCrashFix
...
Adding a null reference check to AttachedDropShadow crash issue
2022-09-15 09:30:55 -07:00
Arlo Godfrey
6eee40a930
Removed extra call to TryUpdateImageLayout
2022-09-14 20:08:56 -05:00
Arlo Godfrey
5dc8958077
Removed second extra call to UpdateMaskArea
2022-09-14 20:05:08 -05:00
Arlo Godfrey
bc40536f6d
Removed extra call to UpdateMaskArea
2022-09-14 20:00:53 -05:00