Граф коммитов

2512 Коммитов

Автор SHA1 Сообщение Дата
Shane Neuville 2f416f2735
Bring ImageButton API additions in line with current code (#4328)
* Bring ImageButton API additions in line with current code

* [Core] putting things in better places

* [Core] first round of changes

* fix issue with checking if bindable properties are set
2018-11-10 12:25:01 -07:00
Rui Marinho c3f5f1bcc5
[Android] Fix TabbedPage appearing when inside other PageContainer (#4309) fixes #4303
* [Controls] Add repo for issue #4303

* [Android] Don't fire Appearing if we are inside a PageContainer
2018-11-09 23:17:39 +00:00
E.Z. Hart 003cc44549 Add fake Platform property to Page to keep Previewer happy (#4355) fixes #4351
* Add fake Platform property to Page to keep Previewer happy: fixes #4351

* Make the fake Platform property internal

* Add unit tests to verify Previewer-required stuff in Core has not be changed

* Adding Obsolete to Page.Platform
2018-11-09 22:18:01 +00:00
Shane Neuville 63f34daa00
remove implicitly included files from csproj (#4364) 2018-11-09 12:31:31 -07:00
Stephane Delcroix 07b697c84d Merge branch '3.4.0' 2018-11-09 12:53:09 +01:00
Stephane Delcroix f3c5405033
Resilient xaml (#4096)
* [Xaml] un-obsolete XamlLoader.Create

now that we plan to load Xaml files without compiling the ctor, keeping
XamlLoader.Create makes sense.

* [Xaml] add FallbackTypeResolver

* Additional tests

* More tests

* Further tests

* [Xaml] provide an mock App

* [C] allow re-registering implicit styles

* Some tweaks and reinstated test with missing resource key

* Add StyleAppliedToDerivedTypesAppliesToDerivedUnknownType test

* Renamed some stuff for consistency. Added some CSS tests.

* Remove use of ValueTuple

* Temporarily disable failing tests

* redirect valueprovider exceptions to the handler, allow the handler to intercept excpetion with Create()

* fix the CSS situation

* new callback, works for CSS
2018-11-09 10:03:17 +01:00
E.Z. Hart 124117c5ac
Mitigate race conditions for UI test 1469 2018-11-08 17:18:07 -07:00
Stephane Delcroix aac2aeea6b
[XamlC] resolve props on generics for bindings (#4352)
Somehow, we weren't doing that up to now...

- fixes #4348
2018-11-08 20:52:52 +01:00
Gerald Versluis 405630225e [Core] Unseal Span (#4331) fixes #4083 2018-11-08 18:24:25 +00:00
Stephane Delcroix 968f7640cf
fix dependon for Controls.csproj (#4350)
properly populate DependOn xaml and code behind
2018-11-08 14:14:01 +01:00
Stephane Delcroix f76cb5e790 Port Xaml.Unitests proj to SDK-Style (#4349)
This should avoid most of the merge conflicts in the future
2018-11-08 12:32:43 +00:00
Pavel Yakovlev 31c5a5ae95 fixes the link to contribution file in the readme (#4345) 2018-11-08 12:00:26 +01:00
Stephane Delcroix 55b08eaea3
[XamlC] accept internal for x:Static (#4334)
- fixes #4326
2018-11-08 11:17:11 +01:00
Stephane Delcroix 7d75429ad1 [XamlC] resolve properties in base interfaces (#4332) fixes #4227
- fixes #4227
2018-11-08 03:20:34 +00:00
Andoni Morales Alastruey 14c2974965 [Xaml] Support correctly custom resource providers (#4236) 2018-11-07 15:07:18 +01:00
Edward Brey 8af4dd8c71 Make ToolbarItem constructor match properties (#4333)
This changes the `ToolbarItem` constructor's `name` parameter to `text`, to match the non-obsolete `Text` that gets the value. Without the change, it's confusing when tracing data flow related to `Text`, since it doesn't appear at first that it's being set.
2018-11-07 14:12:24 +01:00
Stephane Delcroix 59abb82670 test 4215 for compiledBindings 2018-11-07 11:21:19 +01:00
Stephane Delcroix 3544bed1a5 fix test for 4215 2018-11-07 11:17:50 +01:00
Akihiko Odaki b9713b7af1 Correct names of files under Xamarin.Forms.Controls.Issues.Shared (#4320) 2018-11-07 08:55:20 +01:00
masonyc af0bc40eec [iOS] Label HorizontalTextAlignment="Center" not working in conjunction with LineHeight on iOS (#4275)
* fix issue#4262
Label HorizontalTextAlignment="Center" not working in conjunction with LineHeight on iOS

* Add missing parameter for macOS due to the previous method param change

* merge

* Added using UITextAlignment = AppKit.NSTextAlignment; as maintainability requested

* Revert "merge"

This reverts commit 939b6e1bc8ebd538af0db91dd8656e7eb2d31203.

* Revert "merge"

This reverts commit 939b6e1bc8ebd538af0db91dd8656e7eb2d31203.

* make test case more clear
2018-11-06 15:34:28 -07:00
Andrei 9c1c7aa542 [macOS] ContextActions on ListView not working (TextCell for example) (#4243)
* fixed context menu

* fixed ctor protection level
2018-11-06 15:01:20 -07:00
Ione Souza Junior 696646f9e7 Changed the namespace for all the Issues in the control gallery to *Xamarin.Forms.Controls.Issues* (#4234)
* Changed the namespace for all the issues to Xamarin.Forms.Controls.Issues

* Moved some classes to Control directory with namespace Xamarin.Forms.Controls to fix conflicts after namespaces changes

* Fixed missed namespace for ButtonExtension

* Fixed namespace reference of Bugzilla42602 in WindowsUniversal/CustomRenderers.cs
2018-11-06 15:00:08 -07:00
Akihiko Odaki bc9da00af5 [XamlC] Explicitly cast values for ldc.i4 (#4301) 2018-11-06 20:09:28 +01:00
Gerald Versluis e8b7f93a37 [iOS] Fix for issue 4295 text decorations gone wild after text update (#4322)
fixes #4295
2018-11-06 20:06:52 +01:00
Rui Marinho eacde03bb6 Merge branch '3.4.0' 2018-11-06 18:19:49 +00:00
Rui Marinho 03d00c5605 Merge branch '3.3.0' into 3.4.0 2018-11-06 18:18:46 +00:00
ShaneN 9997b024f2 Merge branch '3.4.0' 2018-11-06 10:44:33 -07:00
Shane Neuville d7c20b7466 [Android] Convert android projects to package reference (#4310)
* [Android] Package Reference

* [Android] forwarders

* add package id to fix nuget restore confusion

* adding packageid to the more relevant projects
2018-11-06 16:09:31 +00:00
Rui Marinho bf0497a571
[Build] Update to XCode 10.1 2018-11-06 14:23:30 +00:00
Andoni Morales Alastruey 4d5414b90f [GTK] Fix synchronization context fairness (#4237)
GLib.Idle.Add enqueues functions in the main loop
with the lowest priority, so while the UI is updating
tasks will be queued in the main loop.
Using Gtk.Application.Invoke they are interleaved with UI
updates and handled with more fairness.
2018-11-06 11:12:58 +00:00
Kevin Behrens f6009cecff Move github files to .github dir (#4288)
This change is completely non-functional, the files moved will function identically in the .github dir, but don't cruft up the root dir.
2018-11-06 11:10:34 +00:00
Ione Souza Junior 485a58e1f5 Added UI test to B44338 (#4307) fixes #2379 2018-11-06 11:10:07 +00:00
ShaneN 494b9137fd fix merge issues 2018-11-05 19:08:08 -07:00
ShaneN 1d19f71810 merge 3.4.0 into master 2018-11-05 18:43:06 -07:00
Shane Neuville da01349946
[iOS] make button constructor public (#4313) 2018-11-05 15:26:48 -07:00
Andrei ee91ac4439 xamarin/Xamarin.Forms/issues/2315 (#4190) fixes #2315 2018-11-05 17:19:16 +00:00
Stephane Delcroix 885fa9ae68
[C] Add Default value to OnIdiom (#4225)
* [C] Add Default value to OnIdiom

- fixes #4006
- closes #4025

* add test
2018-11-05 14:13:37 +01:00
Shane Neuville 7917719c9d
ImageButton (#1974)
* ImageButton Implementation

* [Android] rename BorderBackgroundManager

* [Android] copy AspectFill changes to ImageButton

* [UITests] fix order of gallery pages to work with tests

* [Android] Account for changing image region with border/shadows

* [Android] check for api 18 and add setpadding call back in

* [Android] throw exception instead of crash when image fails to load

* Addressing issue comments and adding additional test cases to Issue demo

- fixes #1724
2018-11-03 16:45:28 -06:00
Shane Neuville bb58503c1a
[UITests] fix dismiss page crash (#4251) 2018-11-01 10:38:16 -06:00
Andrei e6d060087e Removed custom entitlements entry for iOS simulator builds (#4257) 2018-11-01 10:08:03 -06:00
Rasto 791fb0461e ListView should convert item to string when ItemTemplate is not specified (#4016)
* Convert item to string, when ListView has no ItemTemplate

* ToStringValueConverter tests

* Format value using parameter in ToStringValueConverter
- fixes #3715
2018-11-01 10:04:47 -06:00
Noam Yogev dbfa47c978 Add Editor.IsTextPredictionEnabled property (#4023)
* Add Editor.IsTextPredictionEnabled property

* simplfy UpdateInputType logic

* modify IsTextPredictionEnabledProperty BindingMode to Default

* undo changes of commit 5db2456d

* [UITests] update namespace for UI Tests

- Fixes #3555
2018-11-01 10:03:23 -06:00
Rui Marinho 276fad975e
[UnitTest] Remove UnitPlatform 2018-11-01 12:18:01 +00:00
E.Z. Hart 505a855cad
Move GetNativeSize to PlatformServices, remove IPlatform (#4235) 2018-10-31 15:12:22 -06:00
Andrei 1ec929f92f [iOS] Change CALayer.Transform in MainThread (#4160)
* fixes #1480

* Added test case

* Update Xamarin.Forms.Platform.iOS/VisualElementTracker.cs

Co-Authored-By: AndreiMisiukevich <andrei.misiukevich@gmail.com>

* updated test case
2018-10-30 20:13:28 -04:00
Jason Smith 5340b5c21d [iOS] Fix issue where entry would emit a change notification without a user triggered change (#3433)
* [iOS] Fix issue where entry would emit a change notification without a user triggered change

* Add repro
2018-10-30 16:07:00 -06:00
Pavel Yakovlev e0e10f16c1 [UWP] Fix ActivityIndicator width in absolutelayout (#3224)
* [Core] Fix autosize elements in absolute layout

* revert the Hasflag extension

* - refactoring to the local UWP fix for Activity Indicator
- fixes #1399
2018-10-30 15:52:51 -06:00
Andoni Morales Alastruey 491947606d [GTK] Fix several memory leaks in the GTK backend (#4112)
* [GTK] Don't recreate master or detail if it didn't change

* [GTK] Fix several memory leaks using the Destroy pattern

Gtk objects must be disposed using the Destroy function that will
automatically iterate over the children and destroy them too:
https://developer.gnome.org/gtk2/stable/GtkWidget.html#gtk-widget-destroy

The gtk-sharp bindings discourage the use of Dispose and don't even call
the base class, leaving it without effect:
https://github.com/mono/gtk-sharp/blob/gtk-sharp-2-12-branch/gtk/Object.custom#L98

In the Controls, that inherits directly from native Gtk objects, the
overrides of the Dispose function are changed to override the Destroy
function.  In the Renderers, that inherit from VisualElementRenderer,
the Destroy funtion is called in the dispose implementation so
subclasses only have to override Dispose (bool disposing) as they do
now.

* [GTK] Don't recreate the toolbar on each change

* [GTK] Fix leak connecting to the PropertyChanged event twice
2018-10-30 11:06:47 -06:00
Andrei 91dc760533 [MacOs] Image from file not getting searched in the bundle fixes #2322 (#4247) 2018-10-30 15:37:49 +00:00
Stephane Delcroix 3461982fa4 notify me of changes to XamlC 2018-10-29 10:06:36 +01:00