Граф коммитов

2512 Коммитов

Автор SHA1 Сообщение Дата
Stephane Delcroix 9d9140eeb6
[C] fallback nicely in case of IndexOutOfRangeEx (#4525)
This PR does 3 things:
- In case of Binding path with indexer, lookout for
  IndexOutOfRangeException in addition to KeyNotFoundException.
- in case of KeyNotFound or IndexOutOfRange, use the FallbackValue if
  any.
- in case of an uncaught exception, throw that exception instead of a
  TargetInvocationException.

- fixes #4516
2018-11-24 11:08:15 +01:00
Shane Neuville 94e6621f72 [Enhancement] Add Visual progress behind feature flag (#4449) fixes #4435
* Visual

* add progress bar and fix ui tint color

* Progress Bar Updates

* ios padding fixes

* padding fix and button image positioning fixes

* added button themes

* disable tint and open up material android button

* change image to bank

* add overrides for Material Frame Renderer

* remove commented out code

* change back to Full linker

* applying comment fixes

* change comparison
2018-11-23 17:40:15 +00:00
Pavel Yakovlev 9b10e2dbb4 [Android] fix tabs from element with a tabstop false (#4362) 2018-11-23 11:17:53 +00:00
Akihiko Odaki e7bf945978 [Xaml] Add provided value to collection (#4456) 2018-11-23 10:00:46 +01:00
Matthew Leibowitz 87dc917bea Copy UITest for running UI tests (#4517) 2018-11-23 01:26:07 +00:00
Shane Neuville 52c8fe0dbd [Android] set image to null when view is disposed (#4507) 2018-11-22 16:30:29 +00:00
Stephane Delcroix 09353676ef DefaultItems are there, no need for dupes (#4514) 2018-11-22 15:20:39 +00:00
Matthew Leibowitz 5959c40c94 Move last projects over to PackageReference (#4492)
* Move the first few projects over to PackageReference

* Move the first few projects over to PackageReference

* Moved the remainder of the projects to PackageReference

* Copy the nunit test adapters for the test apps

* Update the unit tests version of json.net

* Don't use relative paths

* Make sure to also copy sub folders

* Remove the trailing slash

* Keep the directory structure
2018-11-22 14:25:56 +00:00
Stephane Delcroix d0456e2d6e
[Xaml] OnIdiomMarkupExt uses converters on BPs (#4500)
Up to now, OnPlatform and OnIdiom markup extensions were checking for
type converters on
- target type
- the property being set

in case of a bindable property, the converter on the BP getter or
GetBP() static method (for attached BPs) wasn't checked.

This PR adds the check for that, plus a unit test.

- fixes #4319
2018-11-22 10:05:21 +01:00
Stephane Delcroix fbf59e12c7
[C] avoid Enum.TryParse for resolving NamedSizes (#4501)
Enum.TryParse is quite expensive. replace that by simple value check for
known values. Keep the TryParse as a safeguard in case we ever add new
values to it.
2018-11-22 10:04:56 +01:00
Rui Marinho 65b172e7e7 [Android] Fix Label size when using Hint text (#4433)
* [Controls]Add repo for issue #2580

* [Android] Clear Hint before sizing Label

* [Controls]Update issue 2580 with more info
2018-11-21 14:39:50 -07:00
Rui Marinho 11e579090e
[Android] Remove WebViewRenderer dependency on Activity (#4428) fixes #4107
* [Android] Remove WebViewRenderer dependency on Activity

* [Android] Don' t try cast Context as Activity
2018-11-21 12:23:40 +00:00
Shane Neuville 6173e6bf43 [UWP] update test nugets and establish baseline for current passing UWP tests (#3601)
* [UWP] update test nugets and ignore some test for uwp to establish baseline

* [UWP] update selenium and webdriver libraries
2018-11-21 11:48:05 +00:00
Ione Souza Junior 3ecb5e7276 Added UI test to B44044 (#4486) fixes #2377 2018-11-21 11:42:36 +00:00
Stephane Delcroix c74fd02df4 [tests] Change namespace of tests (#4502)
Change the namespace of some tests, allowing me to isolate the slow
running ones and avoid running them every single time.
2018-11-21 11:39:29 +00:00
Stephane Delcroix 3cf544c1a7
bump our build dependencies (#4496) 2018-11-21 11:43:12 +01:00
Akihiko Odaki 6126d99f7e [XamlC] Resolve parameters in nested generics (#4061) 2018-11-21 09:06:16 +01:00
Stephane Delcroix b2d7a4e1c1
[C] Allow recursive parts of binding path (#4028)
- fixes #3994
2018-11-21 08:33:15 +01:00
Stephane Delcroix 17f5ce556b
[C] support TargetNullValue in TypedBindings (#4490)
Call base.GetSourceValue so the TargetNullValue is returned in case of a
null value. I have no idea why the code was there, but commented out,
and I don't want any of you to start digging at the why it wasn't
enabled before.

- fixes #4103
2018-11-21 08:32:32 +01:00
Stephane Delcroix 3b6374893b
[XamlC] comp binding to generic properties (#4483)
- fixes #4438
2018-11-21 08:32:09 +01:00
Stephane Delcroix e38776cdec
[iOS] ScrollViewRenderer: clear the renderer (#4489)
On Dispose(), the Renderer is supposed to be cleared on the element.
That's taken care of by VisualElementRenderer`1.Dispose().
Unfortunately, ScrollViewRenderer doesn't inherit from it.

I find it strange that this never was triggered before the Shell, but
I'm learning to live surrounded by strange behaviors.

-fixes #4381
2018-11-21 08:31:33 +01:00
Alan Grgic 63b371422d [iOS] Add JavaScript dialog delegate to WkWebView (#4254)
* basic implementation of js alerts for wkwebview

* add ui test and adjust to mimic uiwebview alerts

* fix proj file

* rename navigation delegate

* Add WkWebView Gallery

* input cancel should return false; dedup logic

* Load correct galley for WkWebView

Co-Authored-By: alanag13 <alan.grgic@gmail.com>

* ensure wkwebview and webview galleries render similarly

* corrections
- Fixes #4253
2018-11-20 14:29:16 -07:00
Stephane Delcroix 288c73d3f4 [CSS] allow ImageButton Styling (#4482)
- fixes #4470
2018-11-20 10:13:40 -07:00
Stephane Delcroix 42b7c31bc8
[C] Binding can't convert to valueTypes (#4453)
Binding type coverter wasn't chacking for valuetypes on null inputs.

- fixes #4446
2018-11-20 09:47:22 +01:00
Stephane Delcroix 4f789b9bda [XamlC] Port #1035 to comiled bindings (#4454)
And share the TryConvert implementation to avoid future diverges
2018-11-19 17:11:51 -08:00
Stephane Delcroix 4871781069 [C] Fix check for CollectionView flag (#4471)
If Device.Flags is null, the code supposed to check for the presence of
the flags throws a NullReferenceException. Most users will get that
instead of the helpful version of it. Which is not very inclusive of the
people too lazy to read the docs.
2018-11-19 11:32:16 -07:00
Stephane Delcroix fdfa582059 Merge branch '3.4.0' 2018-11-19 09:04:08 +01:00
Stephane Delcroix 157bc72fe8
[tests] fix msbuild tests (#4450)
* [tests] fix msbuild tests

those tests are failing sice the move to SDK-style project for
Xaml.UnitTests

* [Build] Copy xaml.unittests artifacts

* [build] Xaml.UnitTests lives in the debug/net47 foder
2018-11-17 13:13:23 +01:00
Stephane Delcroix 2fd438db0e [C] perf fixes on BindingExpression.TryConvert (#4443)
BindingExpression.TryConvert is a hot path, the string operation should
use the StringComparison. Also (less hot as it's a fallback), we should
avoid throwing for catching the exception a few line later.
2018-11-16 12:54:57 -08:00
Rui Marinho 1a424e6a83 [Controls]Use propotional values on test 1914 (#4434) 2018-11-16 10:07:12 -07:00
Stephane Delcroix 99b8525383
[C] ToStringValueConverter shouldn't be public (#4442) 2018-11-16 15:40:05 +01:00
Seungkeun Lee d6ddd53ed5 Add ImageButton Renderer on Tizen (#4436) 2018-11-16 11:00:45 +00:00
shmin 86d4d43a67 [Tizen] Fix ToolbarItem (#4416) 2018-11-15 13:00:06 +00:00
kingces95 3e006edb1a add uap symbols to nuget package (#4411) 2018-11-15 11:46:10 +00:00
Shane Neuville 41e5358169
[Android] fix removed NativeSizeChanged (#4395) 2018-11-13 12:22:49 -07:00
Andrei Nitescu 3ad537c6b1 [iOS] fix for SearchBar background color (#4229)
* iOS fix for SearchBar background color

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

* Fix Merge Issues
- fixes #4194
2018-11-13 11:00:39 -07:00
James Montemagno 63e290a899 GH-4367 Clarify Readme for deps & commandline build (#4368)
* Clarify Readme for deps & commandline build

Ensure everyone knows to install .NET 4.7 dependency and also simplify msbuild into single action!

* Update README.md

Specify Android SDK
2018-11-13 08:52:48 -07:00
Rui Marinho b08323c8cb Merge branch '3.4.0' 2018-11-13 15:10:35 +00:00
Rui Marinho 26d8b1fc08 Merge branch '3.3.0' into 3.4.0 2018-11-13 15:09:01 +00:00
Rui Marinho ad6fe44ca2
[Build] Fix jenkins job id and add triggers 2018-11-13 15:07:45 +00:00
Rui Marinho 64f3682e9a Merge branch '3.4.0' 2018-11-13 12:54:34 +00:00
Rui Marinho 9b7bd368de Merge branch '3.3.0' into 3.4.0 2018-11-13 12:53:56 +00:00
E.Z. Hart aabe44fe7d [Enhancement] Add CollectionView progress behind feature flag (#4265)
* The barest beginnings of starting a spike for LV2

* Very basic RecyclerView

* Very, very basic UICollectionView

* Start setting up galleries

* De-duplicate some gallery code

* Android horizontal layout

* Very basic horizontal/vertical text lists for iOS

* Vertical list views working in iOS, stashing while trying to figure out what the deal is
with horizontal views and frames with heights of 1

* Working on rotation issues in iOS

* Fix name of renderer in UWP; make horizontal scrolling work for horizontal
lists on UWP

* Set up gallery to generate different sizes of lists for testing

* Respond to items source updates on UWP

* Add gallery for GridLayout; Add GridLayout;
begin GridLayout implementation UWP

* Basic UWP gridness

* Add demo page for grid layouts with text;
Handle grid layout spans on UWP; handle grid layout span changes on UWP;

* Implement span updates on Android grid layouts;

* Ironed out most of the iOS text cell layout issues

* iOS vertical/horizontal text lists now working reliably;

* In progress on UWP DataTemplate stuff

* Dumping the data template into the itemsource

* Vertical list basically working with DataTemplate; horizontal list having image size issues

* Clean up names and move classes to their own files

* Adding some notes for FormsContentControl

* Rolling back platform test on UWP

* Fix Tizen build

* Fix typo and roll back old test code

* Remove old testing comments

* Make basic data templates work on Android

* Update measure to work horizontally

* Remove old testing code

* Terser rectangles

* Use nameof()

* Rename FormsContentControl to ItemContentControl

* Use CreateRenderer instead of GetOrCreateRenderer

* Clean up TemplateCodeCollectionViewGallery

* Add grid galleries for templates

* Nicer example templates

* Create gallery to test removing items from collections

* Smooth single item removal on Android

* Smooth item insertion on Android

* Observable collection item adds working on UWP

* UWP Remove

* Split files

* Add gallery for snap points; start implementation of snap points on Android;

* Move snap handling to separate class; implement Start snapping (horizontally)

* Debugging vertical overlap issues on Android

* Temporarily add IsClippedToBounds to generators to force clipping on Android

* Start and End SnapHelpers are working horizontally and vertically

* Consolidate some snap code on Android

* Mandatory Single Snapping working for Center/Start horizontally

* Throwing together scrollto gallery

* Super basic "ScrollTo" implementation for Android, plus test page

* Expand ScrollTo test harness;

* Move ScrollToRequestEventArgs to its own file

* Mostly working Carousel renderer; needs some cleanup and its own gallery pages

* Carousel gallery

* Naming cleanup

* Make parameter name consistent

* Finally some basic data template functionality for lists

* Checkpoint; sort of working

* Working out estimate size hacks

* Working out cell optimizations

* Checkpoint before some serious refactoring

* Collapsing closer to a solution; text lists and grids working;
template lists and grids working; uniform size hint mostly implemented;

* Remove awkward Update method

* No longer hard-coding list item heights estimates

* Consolidate more code

* Get rid of event on ItemsViewLayout

* Remove public NeedsEstimate stuff

* Get rid of IConstrainedCell

* Watch for Span changes on iOS

* Indexed ScrollTo on iOS

* Implement removal/insertion of items on iOS

* Handle Move, Reset, Replace on Android

* Add screens to test ScrollTo Item; implement ScrollTo Item for iOS

* ScrollTo Item working on Android, but only works for MakeVisible

* Implement Android ScrollTo Animated ScrollToPosition

* Ugly but functional non-animated scroll with ScrollToPosition

* Move Scroll logic into helper class for clarity and maintenance

* Fix Start snapping with grids (hard-coded span of 1)

* Fix next/previous row/col snapping bug for EndSnapHelper

* Remove some debug statements

* Clean up example code

* Fix missing delegate setting on CollectionView

* Add filtering example

* Watching the adapter and handling empty view from the renderer

* Add debugging for all the FindViewHolder methods

* Suuuuper basic but functional EmptyView

* Allow EmptyView to be turned on and off

* Building tests for all the EmptyView scenarios

* Set Platform on EmptyView (for now)

* Templated EmptyView on Android

* Clean up merge errors

* Require flag to use CollectionView on Android

* Require flag to use CollectionView on UWP

* Restore Label functionality commented out during testing

* Adding a note for myself

* Add flags for iOS; flags for Android CarouselView;

* Remove Calabash out-commenting

* Undo changes to DotSettings; remove outdated TODOs

* Fix formatting

* Remove debugging code; remove outdated todos; remove unnecessary comments

* Undo randon VS changes

* Include CollectionView in experimental renderer testing

* Use correct property in nameof() call

* Rename ScrollToRequestEventArgs Animate -> IsAnimated

* Rename Constrain -> ConstrainTo for consistency

* Add Core flags feature; add flag verification for CollectionView features

* Make sure no one is subclassing native CollectionView stuff without flag

* Set CollectionView flags for unit tests

* Make flags depend on Application.Current

* Fix iOS 9.3 exception when laying out CollectionView

* Use Device.Flags

* Move CV flag check to CollectionView; use Device.Flags on native platforms;

* Move classes into their own files

* Make CollectionView flag check method non-browseable

* Remove old TODO

* Remove Element.Platform sets

* stubbed toolbox entries and snippets for Carousel and Collection

* updated CV snippet to include layout

* Remove Linq using statement

* Remove unused using statement

* Turn off CollectionView in Control Gallery

* Move PropertyChangedEventArgsExtensions to internal on each platform

* Clean up debugging code

* Fix broken test setup

* Remove ToString overrides

* Fix broken test screen
Fix broken test screen

* Fix rebase errors

* Update submodule

* Fix rebase error
2018-11-13 12:49:08 +00:00
Rui Marinho a7d6d2ce59
[UITests] Try fix iOS failing tests (#4264)
* [UITests] Try fix iOS failing tests

* [UITests] Try fix 1931 test

* [UITests] WaitForElement on test for 1469
2018-11-13 12:46:56 +00:00
Rui Marinho 4b70803c70
[Build] Add azure pipeline definition (#4385)
* [Build] Add azure pipeline build definition

* [Scripts] Add docs and provisioning scripts
2018-11-13 12:43:14 +00:00
Shane Neuville 60b9ee6c4a
[Core] Delete left over file (#4383) 2018-11-12 18:18:51 -07:00
Andrei 5ec989c455 [MacOs] Implemented InsertPageBefore (#4242)
* implemented InsertPage for MacOs

* Removed TODO

* fixed insert before method for mac
- fixes #4030
2018-11-12 18:06:04 -07:00
Andrei 8205d3fbef [iOS] ControlsGallery, shake gesture to navigate to the root page (#4263)
* #3724 new approach for navigating to the root page

* Changed the way of registering Application and ApplicationDelegate

* removed "5 taps to navigate to the root screen" code
- fixes #3724
2018-11-12 16:48:38 -07:00
Daniel Chalmers ee3353e1a7 Update README.md (#4290)
* Update README.md

* Fix UWPMapsAuthKey link

* VSTS -> Azure DevOps

Co-Authored-By: danielchalmers <daniel.chalmers@outlook.com>
2018-11-12 20:07:16 +00:00
Rui Marinho 3c3ecfd454 Merge branch '3.4.0' 2018-11-12 12:53:42 +00:00