Граф коммитов

268 Коммитов

Автор SHA1 Сообщение Дата
Rui Marinho 31b8ad198d Merge branch '3.2.0' into 3.3.0 2018-10-02 23:34:32 +01:00
Shane Neuville 4c367911b9 Only set the Page Padding via SafeAreaInset on iOS (#3811)
* only set the Page Padding via SafeAreaInset on iOS
-fixes #3809

* [Controls] add waits for clicks in ui tests

* [Controls] remove wrong category

* [iOS] Move inset logic down into ios renderer
2018-10-02 09:43:53 +02:00
ShaneN f3f39f8022 Merge 3.2.0 into 3.3.0 2018-10-01 19:14:48 -06:00
Shane Neuville 379adeb380 [iOS] fix full width issues for TitleView (#3939)
* [iOS] fix full width issues for TitleView

* [iOS] simplified iOS 10

fixes #3881
fixes #3679
2018-10-01 10:53:47 -07:00
Rui Marinho 8bf897ac5d [iOS] Use UIApperance default color for UISwitch (#3819)
* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API
2018-09-19 14:06:37 -07:00
Rui Marinho 181b1ae57d
Merge branch '3.2.0' 2018-09-03 12:28:59 +01:00
Rui Marinho 6c94e6e0c8
[iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139
* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139
2018-09-03 10:36:54 +01:00
Samantha Houts 7422cb8b17 Merge branch '3.2.0' 2018-08-31 14:19:27 -07:00
Samantha Houts a8260b0075 [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633
* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch
2018-08-31 18:20:30 +01:00
Shane Neuville 8f03f5ec5c [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)
* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null
2018-08-31 12:32:37 +01:00
Gerald Versluis 203d4ffcf0 MaxLines property on Label (#3318)
* Implemented MaxLines on iOS, Mac OS, Android, UWP and WPF

Introduced new MaxLines property on Label

* Set default value to -1

* Implemented reverting to default value

* More improvements

Update measurement when MaxLines property value changes and updates to default values.

fixes #2060
fixes #1706
2018-08-16 07:25:47 +00:00
Rui Marinho 0610191b3d Merge branch '3.2.0' 2018-08-15 20:19:45 +01:00
Rui Marinho 689a0bb9bc
[iOS] Fix sizing issue on MDP (#3515) fixes #3458
* [iOS] Fix sizing of MDP when rotating

* [Controls]Add a NavigationPage to MDP FlowDirectionGallery so we can have the toggle button
2018-08-15 20:06:16 +01:00
Samantha Houts a7b4a47396 [iOS] Implement `ForceUpdateSize` for `TableView` (#3300) fixes #2842
* Add repro for #2842

* [iOS] Implement ForceUpdateSize for TableView

fixes #2842

* Revert changes to TableViewModelRenderer
2018-08-06 15:23:22 +01:00
kingces95 1ee8e7d577
[iOS] WebView renderer that replaces UIWebView with WkWebView (#3346)
* wkwebview

* Remove default UITest

* PR changes
2018-08-01 22:45:49 -10:00
Stephane Delcroix 2535c2098c Merge branch '3.2.0' 2018-07-30 10:39:42 +02:00
Stephane Delcroix 2b74434ba0 Merge branch '3.1.0' into 3.2.0 2018-07-30 10:39:09 +02:00
E.Z. Hart 457f4c0156
[iOS] Remove iOS Platform Casts (#3361)
* [iOS] Move dispose helpers to their own static class (and off Platform)

* Add null checks on Elements
2018-07-26 10:40:09 -06:00
Shane Neuville 72ad5cac3d Remove math on scroll view container for RTL (#3299)
* fixes #3000 remove math on scroll view container for RTL
- setup RTL scrollviews to all start scrolled all the way to the right

* * formatting and renaming fixes

* - don't move scroll if not set to RTL
2018-07-23 11:11:01 -07:00
Alan Grgic 97d2f30f6b [Enhancement] Allow underline and strikethrough text decorations on labels and spans (#2221)
* Fixes #1632

* Allow underline and strikethrought text decorations on labels and spans

* revert some files

* pr feedback adjustments

* remove docs

* rename interface

* reorder enum

* clean up whitespace

* adjust tizen renderer

* add gallery demo for setting both underline and strike

* allow multiple values of enum to be set in xaml/css

* use normal null check

* use nameof

* include paragraph style

* tab alignment

* rebase from upstream

* pass control to update method on UWP

* correct text decorations type converter

* reset run text instead of label text on UWP when spans are used

* add tests for text decoration converter
2018-07-20 17:57:11 -06:00
Rui Marinho 57994e7d8d Merge branch '3.1.0' 2018-06-28 17:07:59 +01:00
Rui Marinho 5d14e5e945
[iOS] Fix layout lines on secondary items 2018-06-28 11:23:21 +01:00
Rui Marinho 508686bbbe
[iOS] Fix NRE when child wasn't added yet to NavigationPage (#3162)
* [Controls] Add test 15 and rename issues 1583_1

* [iOS] Do not try to layout if no child was added yet

* Update NavigationRenderer.cs
2018-06-27 22:33:12 +01:00
Rui Marinho b15de064fe
[iOS] Fix iOS WebView load url with port number (#3120) fixes #3073
* [Controls,iOS] Add repo for url with port

* [iOS] Use Url.Authority that contains domain and port

* [Controls] Try fix test 1583

* [iOS] Try fix test again
2018-06-27 17:21:50 +01:00
Rui Marinho 9073cf788d
[iOS] Try another fix for toolbar items layout (#3123) fixes #2798
* [Controls] Push new page on repo

* [iOS] Do not set the same frame on toolbaritem
2018-06-26 16:36:00 +01:00
Rui Marinho 9fe5372c1d Merge branch '3.1.0' 2018-06-26 15:10:42 +01:00
Samantha Houts 4d5a1f5482 TitleView (#2586)
* Stop crashing when I accidentally click on the Perf gallery

* [Core] Add TitleView to NavigationPage

- also add unit tests
- fixes #1716

* [Android] Add ClearRenderer static method to Platform

* [Android] Use Platform.ClearRenderer

it's a straight extract from this class

* [Android] Implement TitleView and TitleIcon on AppCompat backend

using lessons (and some duplicated code) from ListView header/footer views.

* [iOS] Implement TitleView

* [UWP] Implement TitleIcon and TitleView

* [Core] Add NavigationPage.BarHeight

* [Android] Use BarHeight

* NavigationBarGallery updates

* [Core] Add iOS HideNavigationBarSeparator Platform Specific

* [iOS] Implement HideNavigationBarSeparator Platform Specific

* sample search page

* Convert BarHeight to Android platform specific

* Reset BarHeight when leaving the gallery

* Add a sample TitleView xaml page

* VisualElement >> View

* Fix comment

* Improved SearchTitle sample page

* [Core] Set TitleView Parent on Changing instead of Changed

Changing is too late for the iOS layout

* [iOS] Fix layouts in iOS10

* [iOS] Stop content clipping

* Expanded test page

* [iOS] Fix HideNavigationBarSeparator for iOS<11

* [iOS] Layout TitleView with margins

* More tweaks to test page

* [UWP] Fix OnDetailPropertyChanged if/else

* [UWP] Comment empty setters

* Convert commented code to more useful comment.

* Adjust performance test async call
2018-06-25 13:00:03 +01:00
Shane Neuville d6810346d1 [iOS] If the UITableView hasn't rendered anything yet don't try to sync cells (#3090) fixes #1342 fixes #1542 fixes #1927
* [iOS] fixes #1342 - verify the UITableView has rendered cells before trying to synchronize to collection

* - let reset through on CollectionChanged
2018-06-22 16:08:56 +01:00
Samantha Houts ad2522354a [iOS] RecycleElement ListView should not crash when bound to ObservableCollection (ArgumentNullException & ArgumentException) (#3042) fixes #1900 fixes #3026
* [iOS] Default to TextCell in GetPrototypicalCell

fixes #3026

* [iOS] Don't throw exception when Index doesn't match in RecycleElement

fixes #1900

* Add repros for #1342, #1900, #1927

* errant space

* Remove repros for #1342 and #1927 (tbc in another branch)

* Update Issue1900.cs

* Revert exception type

did not mean to change that! yay for ui tests

* Update Issue1900.cs
2018-06-20 22:14:26 +01:00
Rui Marinho a8ec456ac0
Merge branch '3.1.0' 2018-06-16 01:00:51 +01:00
Stephane Delcroix 584846fe00 Fix broken 2499 test (#3037)
* Fix broken 2499 test

SelectedIndex being a BP, setting it's value might be delayed, and as
both ios and android PickerRenderer do not update on individual property
changes, but have a single UpdatePicker method, some properties might be
out-of-date, causing a crash.

This doesn't attemps to fix the renderers, but only prevents a crash to
happen.

* [Android] Apply fix to AppCompact picker

* [iOS] Enable linker for sdk

* [UITests] Better test for issue 2499
2018-06-15 19:01:21 +01:00
Rui Marinho a5bae7c47d Merge branch '3.0.0' to 3.1.0 2018-06-15 19:00:48 +01:00
Rui Marinho 48e2e2fbbc
[Android,IOS] Fix inserting page and popping current (#3021) fixes #2837
* [Controls] Add Issue2837 repo

* [Android] Correctly remove the previous element from the fragmentstack if  there's only 1 element

* [iOS] Do not't remove the wrong viewcontroller

* [Android]Make sure we have the correct stack before running stuff from appeaing

* [iOS] Revert iOS changes

* [iOS] Avoid popping the wrong controller
2018-06-15 18:56:49 +01:00
E.Z. Hart 07ade1c455 Avoid infinite loop when removing refresh indicator on iOS; fixes #1799 (#3046) 2018-06-15 12:31:25 +01:00
Rui Marinho a6bbcfdd2c Merge branch '3.1.0' 2018-06-08 09:43:31 -07:00
Rui Marinho 5dfe751da8
Merge branch '3.0.0' into 3.1.0 2018-06-07 16:58:21 -07:00
Matthias Bruzek 3b2be6912c [iOS] Correct encoding in WebViewRenderer.LoadUrl (#2854) Fixes #2736
* [iOS] Fix regression from commit 14aa258 which escaped all URLs including crucial symbols (/,:,#,?)

- Fixes #2736

* Fix UITest for android
2018-06-07 10:49:50 -07:00
E.Z. Hart e6451a4aa1 Use UpdateOnTap setting for Slider to fix broken gesture bubbling test; (#2964) 2018-06-07 00:10:13 -07:00
Sivamuthu Kumar f30ab27ae8 Fix macOS label renderer Italic Font attributes (#2729) fixes #2728 2018-06-05 16:03:33 -07:00
Rui Marinho 1a29b0142a Merge branch '3.1.0' 2018-06-04 16:16:30 -07:00
Rui Marinho a2c6cfa91c
[iOS] Fix secondary toolbaritems (#2870) fixes #2798
* [Controls] Add more secondary toolbar items

* [iOS] Don't try redraw toolbaritems if available size doesn't change
2018-06-04 10:46:02 -07:00
Samantha Houts 14af670f5a Merge branch '3.1.0' 2018-05-23 11:27:58 -07:00
Samantha Houts a6a3b25ade Merge branch '3.0.0' into 3.1.0 2018-05-23 11:26:13 -07:00
Henric Müller cd6b01832c Controlling Caret position on iOS,Android,UWP and color on iOS (#2539) Fixes #1667
* [iOS,Android] Support for controlling caret position in Entry

Refs #1667 Adding support for getting and setting
caret position on a text Entry on iOS and Android.

* [UWP] Support for controlling caret position in Entry

Refs #1667 Adding support for getting and setting
caret position on a text Entry on UWP.

* [iOS] Support for setting cursor color

Refs #1667 Updating iOS `UITextField.TintColor` when setting cursor
color on `Entry`.

Adding `IsSet` checks for cursor properties before making changes
to underlying control.

* Adding null checks and UITest

* Making CursorColor iOS specific and adding UITests

Refs #1667

* Fix for BeginningOfDocument being null if not first responder

Moving call to `BecomeFirstResponder` to an earlier stage, before
we call `BeginningOfDocument` since it may be null if called
before text view has focus.
2018-05-23 18:07:39 +01:00
Samantha Houts 3d01f09517 [Core] Remove Guid.NewGuid() calls from performance tracking (#2791)
* Use out parameter to avoid boilerplate

* Swap Guid reference for long reference

* Remove unnecessary null check
2018-05-22 16:54:21 -07:00
Pavel Yakovlev 53a0551c0c [iOS, Android, UWP] Added padding to Button control (#2426) Fixes #1702 2018-05-14 16:19:43 +01:00
Javier Suárez Ruiz 088c2f5b3b [Enhancement] Rounded corners on BoxView (#1998)
* Added CornerRadius property to BoxView

* Added CornerRadius definition

* Removed unnecessary code

* Updated macOS BoxViewRenderer

* Changed BoxView CornerRadius Property definition

* Updated CornerRadius class (added Equals, operator ==, operator !=, GetHashCode and Deconstruct)
Added CornerRadiusTypeConverter

* Fixed namespaces (removed .Core)

* Changes from PR feedback

* Changes from PR feedback

* Fixed build error
Change FormsBoxView to internal

* Fixed build error

* Fixed build errors

* Changes in MacOS BoxViewRenderer
2018-05-08 11:34:13 +02:00
Ravinder Jangra 7fb100048d [Core,iOS,Android] Placeholder and PlaceholderColor on Editor (#2012) fixes #1907
* Revert "Merge branch 'Slider' into master"

This reverts commit 0aa3d01b68, reversing
changes made to 8961c28315.

* editor placeholder

* Updated Editor + docs

* UWP Added

* iOS Editor Placeholder

iOS Editor Placeholder text handling while setting text to null or ""

* remoed comment

* New EditorRenderer for iOS

Got some help from forum

* Delete Editor.xml

* Added placeholder to EditorGallery
2018-05-08 10:11:25 +01:00
Henric Müller 5112f0928f Adding line height to Label and Span (#2132)
* Adding LineHeight to Label and Span

Fixes #1734 by adding LineHeight property to Label and Span.

Setting LineHeight on Span doesn't work on UWP ince it's not supported
on the Run class corresponding to Span in Xamarin Forms.

On Android the separate LineHeight on span only has effect if
the text has linebreaks within the string. Then it's possible
to set different line heights for individual lines using Span.
If the lines are automatically split using WordWrap for instance,
it seems like Android will use the LineHeight set on the last Span.

* Moving LineHeight to LineHeightElement

Calling InvalidateMeasureInternal when line height is changed.
Making line-height CSS property Inheritable.

Refs #1734

* Making sure LineHeight on Span works on iOS

Apparently LineBreakMode needs to be set before
the `NSMutableParagraphStyle` attribute is set on the
`NSAttributedString` in order for different line heights
within the same label to work (using `Span`s).

Refs #1734
2018-05-08 10:13:05 +02:00
Adam 500a8cda76 [All] Span GestureRecognizers (#2173)
* Bindable Text Property on Span

* Minor fix and cleanup

* Cleanup of code after review

* Android TapGestureRecognizer for Span

* iOS Span TapGestureRecognizer enabled

* Corrected Android issue with LineHeights

* UWP code cleanup for new Span properties

* WPF Span GestureRecognizers added

* Set Parent and reduce calls to Text property

* Add gesture recognizer to label if not present.

* Label Changed to handle Span and GestureRecognizer changes.
iOS updated to accomodate new CompositeGestureRecognizer

* Move Android to new Label structure

* Overridden Collection Clear events

* Refactoring code

* Refactor to extensions for span position calculations

* Further refactor and cleanup after rebase

* Fixed rebase issues

* Bug fixes, refactoring and performance improvements

* Moved to region and supported triggering overlapping regions, including inflation

* Inflation added

* Region inflate, and GestureElement

* Refactoring

* Refactoring of naming and loops

* Cleanup

* Removed command

* UWP tap span fix

* Detect child gesture recognizers in Android

* BackgroundColor support on span for WPF

* Remove trailing tabs

* Region UnitTests

* Refactor based on review

* Further code cleanup
2018-05-07 19:02:28 +01:00