Граф коммитов

268 Коммитов

Автор SHA1 Сообщение Дата
Samantha Houts 67bc2d5488 [iOS/Android] Fixes "jumping" when navigation to a page with a NavigationBar from a page without one (#962)
* Add repro

* [iOS] Set IgnoreContainerArea when no Nav Bar

* [Android] Layout bar and page at the same time

* Add custom renderer to turn off transitions

* Fix test case number

* Remove superfluous category set

* Fix test automation, add TabbedPage
2017-06-22 10:25:35 +01:00
Stephane Delcroix b7b0bf559a [iOS] workaround a weird iOS behavior. (#987) 2017-06-21 02:00:58 +01:00
Samantha Houts ec75b998fa [iOS] Picker no longer allows arbitrary text to be typed with keyboard (#996)
* Add repro

* [iOS] Reset text on editing

* Add instructions, fix test case number
2017-06-20 19:11:40 +01:00
kingces95 6f5d6ce8da Provide better exception for bad INotifyCollectionChanged index bounds (#948) 2017-06-14 16:14:08 -07:00
kadiryazgan 0834d2d13f make OnShouldReturn protected (#906)
* make OnShouldReturn protected

There are situations where we don't want to dismiss the keyboard when return key is pressed.
Making OnShouldReturn protected will let custom renderers to disable ResignFirstResponder behaviour.

* added virtual keyword to OnShouldReturn
2017-05-26 12:41:51 +01:00
Rui Marinho 8f7b1f7f17 [iOS] Handle user popping pages out of order (#934)
* [iOS] Handle when user can call pop a page that was already disposed/removed

* [Controls] Fix bug number
2017-05-24 10:29:09 -07:00
Stephane Delcroix 9a443a8508 Fix animations with GLViews (#931)
* null guard _displayLink (bz42755)

* change NSRunLoop mode (fix bz41413)
2017-05-23 19:04:25 +01:00
Samantha Houts 4e83b8ee0f [All] Rename Accessibility -> AutomationProperties (#912)
* [All] Renamed Accessibility -> AutomationProperties

* Update docs

* Restore doc summaries

* Revert unintended csproj changes
2017-05-10 18:20:57 +01:00
Samantha Houts 20bfa5b503 [iOS] Null Element before disposing trial renderers in uneven ListViews (#894)
* Add repro for 55745

* [iOS] Null Element before disposing trial renderers
2017-05-02 16:18:05 -07:00
E.Z. Hart cdc4055128 Better error handling for image loading errors on iOS/Android (#849)
* First run at removing async void image update methods

Consistent error logging and IsLoading on Android,iOS,UWP

Move error logging into image handlers for better messages

Add demo of custom ImageRenderer error handling

Update docs

Make the test smaller so the results don't get pushed offscreen

Fix namespace error

* Update error handling for fast image renderer

* Update 37625 test to use image we control

* Add java disposed check to avoid ObjectDisposedException in async operations

* Add disposed checks to legacy renderer; null check element before SetIsLoading

* Check disposed on GetDesiredSize for fast renderer
Use local disposed member where possible for disposed check

* Check for disposal after async handlers in iOS

* Add disposal checks after async methods in Windows

* Reset linker settings on project; reduce redundant casts in ImageViewExtensions
2017-04-25 19:16:25 +01:00
Samantha Houts 17c7d8ed5c [iOS] Prevent NRE in ListView OnItemSelected (#883)
* Add repro

* [iOS] Prevent NRE in ListView

* [Android] Prevent NRE in ListView

Not observed, but adding defensive check just in case
2017-04-25 11:14:16 -07:00
kingces95 093a4efa2d Implicit impl of controller ifaces (#807)
* Simplify ICtrl callsites

* Rebase fix
2017-04-11 19:02:06 +01:00
kingces95 45a6a80b4c Fix 52962; Cont refresh even when pullToRefresh is disabled (#810) 2017-04-06 22:47:12 +01:00
adrianknight89 6966dd6cc7 [iOS] ActivityIndicator should not disappear when used in a ViewCell (#495)
* preserve activity indicator state

* changed to using listviewrenderer

* remove whitespace

* moved message to constructor

* add sample code

* remove message sending

* changes

* remove curly braces
2017-04-06 19:25:47 +01:00
Samantha Houts 1eae24b051 [iOS] Prevent NRE when page is switched on Appearing (#840) 2017-03-27 11:31:04 +01:00
adrianknight89 27de335bf1 [iOS] Platform specifics to control ScrollView content touch delay (#563)
* can delay content touches optionally

* revert bug fix

* add back _tapGesture

* remove extra declaration
2017-03-24 12:07:59 -07:00
Samantha Houts eea0bdcc6e [iOS] Don't skip row height estimation for grouped lists (#838)
* Nest bugzilla 51536 classes for less pollution

* Add repro for 53834

* [iOS] Don't skip row height estimation for grouped lists
2017-03-24 11:02:59 +00:00
Samantha Houts c65a9a8c57 [iOS/Win] Label will not unnecessarily expand (#827)
* Add repro for 53362

* [iOS] Label will not unnecessarily expand

* [Win] Label will not unnecessarily expand
2017-03-22 10:43:17 +00:00
James Clancey 4e9d99fea4 iOS renderers now properly look up the ImageSourceHandler for FileImageSource (#826) 2017-03-21 15:02:39 +00:00
adrianknight89 ea4673c8cb [iOS] Use UIButtonType.System for Button and utilize UIButton.Appearance (#554)
* Change button style and use UIButton appearance

* added sample code

* change references

* setting other properties

* add comment

* refactor proxy setter

* made control states array static

* remove category declaration

* changes

* add sample code

* changes

* Fix identation

* Update ButtonRenderer.cs
2017-03-20 15:53:54 +00:00
kingces95 ce06819328 Adopt iOS status bar visibility defaults (#822) 2017-03-18 18:55:40 +00:00
kingces95 e6d5186c8a Remove InternalsVisibleTo from Core to XF.Platforms.* (#782)
* Remove InternalsVisibleTo from Core to XF.Platforms.*

* Changes per Jason's code review

* Move LockableObservableListWrapper to internals namespace

* Changes per Stephane's code review

* update docs

* Touch code to get CI to run tests

* Rebase; Update documentation
2017-03-07 14:56:24 -05:00
Joris Vergeer 38c0b34e91 Fix for nullreferenceexception when a TabbedPage is rendered without a set CurrentPage (#669) 2017-03-03 12:25:49 +00:00
Chris King 217a59e587 update IEditorController callsites 2017-02-21 10:24:12 +00:00
Samantha Houts 8c457a0e14 [iOS] Label should not return infinite width 2017-02-21 10:17:18 +00:00
Chad Kimes 7edc1013b1 [iOS] Fix extra tab icon appearing in iOS for TabbedPage (#448)
commit 1ba6ff67a745a0e802f67b7a4f36db4f8385466e
Merge: e3f1937 a1d4b64
Author: Stephane Delcroix <stephane@delcroix.org>
Date:   Thu Jan 26 10:11:08 2017 +0100

    Merge branch 'master' of git://github.com/ckimes89/Xamarin.Forms into ckimes89-master

commit a1d4b6485c51c0800e16d476ba8749bd1a0a6b28
Author: Chad Kimes <chad.kimes@iticentral.com>
Date:   Tue Oct 11 13:42:28 2016 -0400

    [iOS] Fix extra tab icon appearing in iOS 10

commit 07cd17df33aa9eb61e2507ca04ecf30d3416e16b
Author: Chad Kimes <chad.kimes@iticentral.com>
Date:   Tue Oct 11 13:38:30 2016 -0400

    [iOS] Add static check method for iOS 10
2017-02-17 10:45:36 +00:00
adrianknight89 1d8e098e2a [iOS] MasterDetailPage master icon should be changeable from any page on the stack (#608)
* master detail page master icon could be changed from any page on the stack

* change icon names

* added titles
2017-02-15 11:39:02 +00:00
adrianknight89 340a705c5e [iOS] Dispose pickers properly and automate GC checks (#632)
* dispose datepicker

* add dispose to other pickers

* add ui test

* add dispose to picker model

* change class name
2017-02-15 11:38:22 +00:00
adrianknight89 56e3629c82 [iOS] Fix NavigationPage memory leak when back button title is set (#523)
* fix memory leak

* fix parent

* added comment
2017-02-09 16:03:41 +00:00
adrianknight89 28237b7b27 [iOS/Android] Handle item selection highlight when ListView cell is tapped erratically (#520)
* Fix multi tap selection highlight

* added sample code

* add ios fix
2017-02-06 11:59:11 +00:00
Softlion (Benjamin Mayrargue) c29403ac31 TabbedRenderer / load icons from custom sources (from embbedded svg for example) (#574)
* Enable ios tab bar icons to be set by a custom renderer (using xamsvg for example)

* Fix space => tabs

* space => tabs / newline

* space / newlines
2017-02-06 11:53:44 +00:00
Ice Jovanoski c84bb83676 [iOS] Expose row animation properties in ListViewRenderer (#733) 2017-02-03 08:45:55 +01:00
adrianknight89 0dff517c22 [iOS] Dispose Entry and Editor properly and automate GC checks (#628)
* fix entry leak

* change code style

* reduce indentation

* fix editorrenderer

* add uitest

* revert editorrenderer changes

* Fix Editor
2017-02-03 08:18:22 +01:00
Kangho 9a6c9a0896 Add pressed and released events to Button (#446)
* Add pressed and released events to Button

* Update ButtonRenderer.cs

* Apply safely casting to android button renderer

* Use safety casting for Android buttin renderer

* [Windows] Fix modal pages being laid out below soft buttons (#395)

* Add sample HanselForms and TwitterDemo to ControlGallery (#651)

* [Controls] Add Hanselforms sample

* Remove extra twitter sample

* [Controls]Add TwitterDemo sample

* [Controls] Fix build

* Slider should show user-set value on initial load (#378)

* [UWP] Use toolbar foreground color on primary items (#640)

* Avoid duplicating code in OmPlatform (#591)

* [iOS] Entry should not pass a newline to the next responder (#397)

* UITextField should not return so that the next field does not get passed a newline

* Added code sample

* [XamlC] import members on x:Static and factories (#642)

* [Xaml] support short Properties for PropertyCondition (#645)

* Xamlc compile data triggers (#648)

* [Xaml] DataTrigger and PropertyCondition no longer use a ServiceProvider

* [XamlC] avoid generating ServiceProvider for unused ProvideValue

* fix tests

* Fix comment typo

* [UWP] Fix TextBox style for foreground focus color (#618)

* Adding image to use for CellsGalleryImageUrlCellList UI test

* Update ImageCellListPage to use an image we control;
Update CellsGalleryImageUrlCellList test to wait longer than 1s for images
to load if necessary

* fix nre when changing content in datepickerselected (#494)

* Make CellsGalleryImageUrlCellList test finish early if possible

* [iOS] Change keyboard type while keyboard is visible (#443)

* Change keyboard while changing text

* add sample code

* [Android] Fix NavigationPage dispose crash when it parents a MasterDetailPage (#577)

* fix navigation page dispose crash

* changes after review

* [XamlC] detect duplicate x:Name at compile time (#655)

* [XamlC] detect duplicate x:Name at compile time

* invoking methods with the right arguments produces better results

* Make UWP toolbar display rules consistent with other platforms (#638)

* Allow subscriber to be collected if MessagingCenter is the only reference to it (#617)

* Repro

* Make messaging center callbacks weak references

* Preserve attribute

* Fix test method name

* Watch for collection of actual delegate target instead of wrapper delegate

* Preserve the original platform instance when changing main page

* Better tests for lambda situations

* Update tests, make callback target a weakreference if it's the subscriber

* Ensure old Platform MessagingCenter subs are gone before creating new Platform

* [iOS] Prevent multiple ListView cells from being swiped simultaneously (#578)

* disable multiple cell swipe

* add sample code

* refactored

* convert to weakreference

* remove null setting

* change weakreference setting place

* remove if

* revert isopen changes

* add instructions

* [WinRT/UWP] Apply BackgroundColor to Stepper buttons (#581)

* [WinRT/UWP] Apply BackgroundColor to Stepper buttons

* Add explanatory text; use nameof

* Move explanatory text to a label

* Return group instead of internal class (#461)

* [iOS/Android] Move Map camera to correct region on layout change (#548)

* Move to region on layout change

* remove visibility check

* [iOS] Platform specifics for controlling Picker SelectedIndex change behavior (#540)

* picker selected index could change when picker view is dismissed

* use enum

* [iOS] Ignore intermittent failing test on XTC (#666)

* [UITest] Update to UITest 2.0.5 (#665)

* Rebase the current branch onto upstream latest
2017-02-02 18:23:31 +00:00
Samantha Houts ae59382c90 [All] Basic Accessibility Support (#713)
* [Core] Add accessibility properties

* [Controls] Add accessibility gallery

* [iOS] Implement accessibility properties

* [Android] Implement accessibilty properties

* [Win] Implement accessibility properties

* [Win] Select ListView item on selected for a11y

* Update docs

* TODO: macOS accessibility

* [iOS] Fix failing UI Tests
2017-01-31 11:49:15 -08:00
Paul DiPietro 6296c4478f [iOS] Remove "Enabled" usage on AdjustsFontSizeToFitWidth (#696)
* [iOS] Remove "Enabled" usage on AdjustsFontSizeToFitWidth

* Update docs
2017-01-30 23:50:49 +00:00
Rui Marinho 52fc04724f MacOS (#650)
* [MacOS] Add SwitchRenderer

* [MacOS] Add TimePickerRenderer

* [MacOS] Cleanup TimePcikerRender

* [MacOS] Add WebViewRenderer

* [MacOS] Add Javascript evaluate to webview

* [MacOS] Fix build error on WebViewRenderer

* [MacOS] Add Base and TextCell renderers

* [MacOS] Start on ListViewRenderer

* [MacOS] Cleanup

* [MacOS] Vertical center text on default NSTextField

* [MacOS] Center NSTextField vertically

* [MacOS] Add ImageCellRenderer

* [MacOS] Add SwitchCellRenderer

* [MacOS] Add SwitchCellRenderer

* [iOS] Allow to set background color on other CellRenderers

* [MacOS] Fix selection mode on ListView

* [MacOS] Set background on Entry of entry cell

* [MacOS] Fix casting bug on CellRenderer

* [MacOS] Other fix on CellRenderer background

* [MacOS] Add ViewCellRenderer

* [MacOS] Fixes and cleanup on cells

* [MacOS] Add NSScrollView so NSTableView can scroll

* [MacOS] Add HeaderView to ListView

* [MacOS] Cleanup

* [Controls] Add Header support to ListView

* [MacOS] NSView reuse on NSTableView

* [MacOS] Some fix on layour order

* [MacOS] Add CarouselPageRenderer

* [MacOS] Implement EventTracker on PageRenderer

* [MacOS] Cleanup CarouselPageRenderer

* [MacOS] Add MasterDetailPage renderer

* [MacOS] MDP renderer don't allow drag of splitter

* [MacOS] Add TabbedPage renderer

* [MacOS] Initial sketch of NavigationPageRenderer

* [MacOS] Send disappearing of CurrentPage on Dispose on NavigationPageRenderer

* [MacOS] Add Gallery page for Mac

* [MacOS] Add MacOSExpressionSearch

* [MacOS] Fix ColorExtension

* [MacOS] Fix MDP renderer layout

* [MacOS] Implement native selection on ListViewRenderer

* [MacOS] Deselect a item on NSTableView

* [MacOS] Remove previous SplitViewItems

* [MacOS] Fix navigationpage height

* [MacOS] Add toolbar for NavigationPageRenderer

* [MacOS] Don't remove selection for now (crashing)

* [MacOS] Refactor page and back button title on NavigationPageRenderer

* [MacOS] Fix bug when native navigate back

* [MacOS] Hide layer when transition

* [MacOS] ListviewRenderer fix BbackgroundColor

* [MacOS] Fix background on ScrollViewRenderer

* [MacOS] Fix header measure on ListViewRenderer

* [MacOS] Add Mac twitter demo

* [Controls] Spaces for easy reading

* [MacOS] More xaml cleanup

* [Core] Add Mac as aTargetPlatform

* [MacOS] Add alerts and actionsheets

* [MacOS] Add GestureRecognizers

* [MacOS] Fix Layout issues when adding children, enable transformations

* [MacOS] Fix title on tab item, move to tabbed navigation based on segmented control

* [MacOS] Hide toolbar when not needed, this allows to work with tabbed page, cleanup

* [MacOS] Add NativeBindings and NativeViewWrapper

* [MacOS] Fix AssemblyInfo

* [MacOS] FIX NRE on SetBackgroundColor BoxView

* [MacOS] Fix NavigationPageRenderer

* [MacOS] Fix build

* [MacOS] Also update page when it resizes

* [MacOS] Add LayoutRenderer for handle items position when the bounds change.

* [MacOS] Refactor/Cleanup

* [MacOS] Add toolbar items support to NavigationPage

* [MacOS] Resize images for TabViewITems

* [MacOS] Fix TabbedPage resize issues , allow users to override some features when creating TVI

* [MacOS] Fix hide/show Navigation toolbar

* [MacOS] Redo CarouselPageRenderer with NSPageController

* [MacOS] Add support for Modal pages

* [MacOS] Refactor navigation from platform

* [Nuget] Add nuget for MacOS

* [Nuget]Fix nuspec

* [Nuget] Add variables for CI

* [Controls] Remove MainMenu from MacOS

* [MacOS] Add TableView renderer (no headers yet)

* [MacOS] Refactoring, marking extensions as internal

* [MacOS] Add group headers for TableViewRenderer

* [MacOS] Workaround for updates on listview collection

* [MacOS] Handle updates of rows in the ListViewRenderer properly

* [MacOS] Fix navigation animation

* Fix navigation header issues with modal pages

* [MacOS] Fix MDP issues with resizing

* [MacOS] Fix general dispose

* [MacOS] Add a ViewControllerWrapper for NSSplitView

* [MacOS] MDP renderer fix animation

* [MacOS] Fix ListView selection bug

* [MacOS] Fix rendering MDP Layout inside wrappers

* [MacOS] Re write the MainToolbar handler

* [MacOS] Don't use Sierra new extensions so we can run in stable channel

* [MacOS] Another way to hide the toolbar (smarter i think)

* [MacOS] Fix MDP bug and remove debug color

* [Controls] Add HanselForms sample

* [MacOS] Fix NRE WebviewRenderer

* [MacOS] Fix uneven rows on ListView renderer

* [MacOS] Fix NRE on load (can+t find the reason this happens)

* [MacOS] Fix uneven rows

* [MacOS] Fix header sizing on ListViewRenderer

* [Controls] More stuff on HanselForms

* [MacOS] Remove warning from ListViewRenderer

* [MacOS] Fix PageRenderer bug double init

* [MacOS] Don't calculate height if RowHeight is provided

* [Controls] More Hanselforms stuff

* [MacOS] Once again a new implementation for the NavigationBar, this time using a custom view to support BackgroundColor

* [MacOS] Fix build

* [MacOS] Refactoring AwesomeBar related controls

* Fix build

* [MacOS] NavigationBar update background and t test colors

* [MacOS] Fix when we remove navigation so it works when the NavigationRenderer wasn't removed from the parent controller like in a TabbedPage

* [MacOS] Add support for ListView  grouping

* [MacOS] Fix image extension method.

* [MacOS] Add base Maps project

* [MacOS] Export MapRenderer

* [MacOS] Add pin click and geocoderbacked for Maps

* [MacOS] Add extra binding project for API not in stable.

* [MacOS] Add MacOS Maps lib

* [MacOS]Fix build on alpha

* [MacOS] Remove MacOS Maps extra binding

* [UITest] Basic macOS setup

* [UITest] Add MacOSApp wrapper implementation

* [MacOS] Set AutomationID

* [UITests] Add ActionSheetUITests to MacOS UITest

* [MacOS] Fix bug on Picker

* [UITests] Link basic uitest basefixture and related files

* [MacOS] Fix pickers reuse

* [UItests] Fix MacOS app path

* [UITest] Ignore UItest for appearing on macOS for now

* [UITest] Update macOS for 2.0.3

* [UITest] Refactor EnterText MacOS app

* [UITest]Fix ViewQuery on MacOS

* [UITest]Fix IsEnabled UItest on macOS

* [UITest] Implement Enter, mark some tests inconclusive fix others

* [MacOS] Implement Entry Completed event

* [UITests] Fix UITest for IsVisible, ignore ToolbarItem test for now

* [UITests] Fix ISVisible again add extra category

* [Controls] Cleanup macOS gallery

* [MacOS] Fix Assembly info

* [Docs] Fix docs

* Fix build

* [Nuget] Fix nuspec

* [Controls] Link files on MacOS

* [Core] Update Forms stack before firing a event saying page was removed, possible breaking change

* [MacOS] Implement RemovePage on NavigationPAgeRenderer

* [UItest] Ignore some , implement back on MacOS UITest app

* [MacOS] Add default back button name (needs to be translated)

* [MacOS] Fix dispose

* [UITest] Make 29257 work on MacOS

* [MacOS] Rename stuff

* [MacOS] More renaming and cleanup

* [MacOS] Share implementations for iOS

* [MacOS] Reuse more IOS extensions

* [MacOS] Reuse FontExtensions

* [MacOS] Share NativeViewWrapper related stuff

* [MAcOS] Share event args and ExportRenderer

* [MacOS] Share platform effect

* [MacOS] Fix build

* [Docs]Fixing docs

* [MacOS] Fix ViewCell reuse

* [Core] Support ListView CachingStrategy on MacOS

* [MacOS] Fix issues with TextCell and ImageCell (we can’t set null to a NSControl value)

* [MacOS] Fix MDP child sizing bug
[UITest] Query marked by id and text

* [MacOS] Comment test related with context actions

* [MacOS] Implement missing stuff on ticker

* [MacOS] Make sure VisualElemenTracker calls the ticker update

* [UITests]Ignore context actions and not possible to test

* [MacOS] Fix Grouping bug on Listview

* [MacOS] Fix selection on Listview when using grouping

* [MacOS] Update navbar when page is popped

* [MacOS] Cleanup NavigationBar

* [Controls] More info on exceptions

* [MacOS] Fix bug animation pop modal

* [MacOS] Bring back BackgroundColor of NavigationBar

* [MacOS] Fix UITest animation delay

* [MacOS] Treat warnings as errors

* [MacOS] Center title on toolbar

* [Core] Add Platform configuration specific for MacOS

* [MacOS] Implement TabbedPage platform specific to handle TabItems on NavigationPage bar

* [MacOS] Fix warning

* [MacOS] Fix bug on SearchBar color

* [MacOS]Fix build

* [MacOS] remove extra dll from maps

* [Docs] Update docs

* [MacOS]Cleanup and refactoring

* Revert "[MacOS] remove extra dll from maps"

This reverts commit 73b948937001fea3f28449a963d0b94943e07aa0.

* [MacOS] Fix wrong refactoring

* [MacOS] Remove gallery and uitest project

* [MacOS] dix formatting

* [MacOS] Remove extra stuff

* Merge branch 'master' into macOS-gallery

* [MacOS] Fix rebase

* [MacOS] Fix TargetPlatform

* fix docs

* [MacOS] Fix bug on TabbedPageRenderer no title

* [MacOS] Remove FormsNSView

* [MacOS] Cleanup on dispose on MDP renderer

* [MacOS] Update current page when source changes

* [MacOS] More cleanup

* [MacOS] Make sure we show the previous page when popping a Modal

* [MacOS] Fix issue with sizing the Header and visibility, remove for now header renderer reuse

* [MacOS] Clean CustomNSTableView

* [MacOS] Share LabelRenderer with iOS

* [MacOS] Share ResourcesProvider with iOS

* [MAcoS] Share VisualElementPackager with iOS

* [MacOS] Share ViewRenderer with iOS

* [MacOS] Merge with VisualElementTracker from iOS

* [MacOS] Merge with EventTracker from iOS

* [MacOS] Merge with VisualElementRenderer of iOS

* [MacOS] Make sure we always have a layer

* [MacOS] Fix Tracker merge with iOS version

* [MacOS] Fix bug with tabbed page on modal without navigation

* [Core] Rever change on core

* [MacOS] Clear renderers before setting them MDP

* [MacOS] Update tabbedPage ContainerArea

* [MacOS] Fix ListViewRenderer

* [MacOS] Make sure we don’t pass null to TextField string value

* [MacOS] Support for multiple clicks in same selected item on NSTableView

* [MacOS] Support Focus on EntryRenderer

* [MacOS] Fix index bug on TablevIewDataSource

* [MacOS] Fix SelectedItem TableViewDataSource

* [Nuget] Add Mac to Maps nuspec

* [Nuget]Fix path

* [macOS] Fixed Tab NSImage crash in TabbedPageRenderer (#705)

* [macOS] Fixed Tab NSImage crash in TabbedPageRenderer

* Coding Style

* Coding Style

* [MacOS] Fix previous merge with master

* [MacOS] Possible simple fix for click on views overlapping

* [MacOS] Rename to IsOnViewCell

* [MacOS] Cleanup, Address feedback from Samantha’s review
2017-01-26 15:33:15 +00:00
adrianknight89 6b2a69d930 [iOS/Critical] Fix ListView memory leaks (#524)
* fix memory leaks

added sample code

changed page name

Changed page title

add screen instructions

fix copy paste error

change subview dispose logic

Fix context action memory leak

add sample code

change custom page names

Revert "change custom page names"

This reverts commit 7aaab2625d9526080ca5c51c02e909f09ee3f610.

changed class names

changes

UI test for 32206

update ui test

fix whitespace

UITests done

* run UI tests on iOS only

* fix code style

* dispose prototype

* fix child renderer issue

* add null check
2017-01-26 14:24:31 +00:00
E.Z. Hart 2c56d6211d Reduce overhead of pushing existing navigation stack (#672)
* Make StackCopy less awkward

* Clean up comment

* Update docs

* Update docs

* Replace SecondToLast with an arbitrarily deep Peek method

* Update docs

* Handle negative depths in Peek()
2017-01-23 12:42:38 -07:00
Stephane Delcroix 5f9e5e56bb [iOS] redraw Frame on CornerRadius changed (#697) 2017-01-21 12:51:20 +00:00
Jimmy Garrido c9b384ce18 [iOS] Fix NRE when re-adding header/footer (#702) 2017-01-21 00:36:59 +00:00
Samantha Houts 3af99cbbe1 [iOS] Labels with WordWrap or CharacterWrap will Expand (#529)
* Add reproduction for 28650

* [iOS] Expand the label to fill width if wrapping

Also, simplify the `if` statement, since `LineBreakMode` is not a flags
enum and the only excluded member was `None`.

* Test two small labels next to each other in horizontal layout
2017-01-12 11:48:30 -08:00
Sandro Cavazzoni f81e41b11b [iOS] Fix child view position when the Navigation Bar is translucent (#659) 2017-01-12 19:38:24 +00:00
adrianknight89 a0417309b8 [iOS] Register effects for ScrollView and WebView (#641)
* fix effects

* move effect utilities to core

* use core class

* move to internals namespace

* remove IEffectControlProvider from IVisualElementRenderer
2017-01-09 10:53:15 +00:00
adrianknight89 24d8dab897 [iOS] Platform specifics for controlling Picker SelectedIndex change behavior (#540)
* picker selected index could change when picker view is dismissed

* use enum
2017-01-04 13:11:09 +00:00
adrianknight89 ffab6dd82e [iOS] Change keyboard type while keyboard is visible (#443)
* Change keyboard while changing text

* add sample code
2016-12-30 15:14:13 -07:00
adrianknight89 4ea528643e fix nre when changing content in datepickerselected (#494) 2016-12-28 16:15:45 -07:00
adrianknight89 0c87fcff41 [iOS] Entry should not pass a newline to the next responder (#397)
* UITextField should not return so that the next field does not get passed a newline

* Added code sample
2016-12-22 10:46:57 -08:00
E.Z. Hart 2a9c6f75cf
Removing now non-existent IsiOS8OrNewer check 2016-12-14 14:11:39 -07:00
Jason Smith 9535315986 Deprecate versions of iOS older than 8 (#630) 2016-12-14 20:38:46 +00:00
E.Z. Hart 5ad5752f3c Disable using EstimatedRowHeight for uneven rows with known heights (#454) 2016-12-13 13:33:49 -08:00
Jason Smith 899e2bd591 Revert "Deprecate iOS 8 and earlier (#626)"
This reverts commit c4b1c88f50.
2016-12-09 10:17:27 -08:00
Paul DiPietro c4b1c88f50 Deprecate iOS 8 and earlier (#626) 2016-12-09 11:29:04 +00:00
adrianknight89 fb76107f4f dispose tap gesture (#601) 2016-12-04 14:44:40 +01:00
Rui Marinho ccef9cbaa4 [iOS] Avoid using DrawRect on base VisualElementRenderer (#570)
* [Controls] Add retro for Bugzilla 48158

* [iOS] Avoid using DrawRect as this will make some properties not being applied to the layer

* [iOS] Make sure BoxRenderer calls base LayoutSubviews

* [iOS] Better fix for adding the Blur effect and avoid override draw’s

* [Controls] Remove extra nunit category
2016-11-30 12:09:57 -08:00
Rui Marinho fc66448bbd [iOS] Revert changes in popping navigation (#547)
* [iOS] Revert changes in popping navigation

* [iOS] Remove unified if
2016-11-18 12:32:48 -08:00
Paul DiPietro b2e2a8ff2a Platform specifics naming adjustments (#526) 2016-11-18 13:38:30 +01:00
E.Z. Hart 122f0e3e60 Run multiple UI tests without restarting ControlGallery (#539)
* Allow UI tests to bypass "manual" navigation to isses pages

* Add missing Preserve attribute

* Make Issue198 test work with direct navigation

* Remove empty UI tests

* Fix error handling for iOS

* Use navigation which works for subsequent TestNavigationPages on iOS

* Fix race condition in 39530 test
Remove master page nesting when doing direct nav for UI tests

* Set up and run a single instance of Control Gallery for UI tests

* Force NavigateToIssue to wait for main page appearing to deal with iOS timing

* Move remaining UI tests into Issues namespace

* Change the connection check URL so it'll work on iOS

* Make Appearing Gallery tests work without restarting app

* Prevent ContextActions tests from stepping on each other

* Make context menu test more robust

* Move ButtonExtensions back to Controls namespace

* Have test 774 dismiss the action sheet before ending

* Update UITest package to 2.0.0 stable

* Make 2948 restore orientation when it's done

* Null check on PageController before calling SendDisappearing

* Adding a wait for the root page in the core tests

* Add consecutive tests reset to prevent memory slog on older iOS devices
2016-11-16 13:07:30 -08:00
Stephane Delcroix acc6efb3d7 [W] Support 0 as valid BorderWidth (#537) 2016-11-16 13:05:28 -08:00
Paul DiPietro 281bfa2b0a [iOS] Update Editor text from autocorrect when losing focus (#535) 2016-11-16 12:59:21 -08:00
adrianknight89 eb243bcea4 Set TabBarItem properly (#530) 2016-11-16 12:55:15 -08:00
Samantha Houts 20adf7ec74 [iOS] Add Platform Specific option to not adjust the status bar text color based on the luminosity of the NavigationBar text color (#517)
* Add reproduction for 37431

* [Core] Add iOS PS StatusBarTextColorMode

* [iOS] Implement StatusBarTextColorMode on NavPage

* Add reproduction for 44777

* Add instructions to 44777 repro

* Update docs
2016-11-16 12:14:00 -08:00
Stephane Delcroix e5af21fdc3 [C] Use a Binding for ItemsSource object selection 2016-11-16 12:03:13 -08:00
E.Z. Hart bc7755ca56 Use static method syntax to prevent mono compiler error (#538) 2016-11-16 10:14:17 -07:00
Paul DiPietro 98235e0eea [iOS] Add Platform Specific features for PrefersStatusBarHidden/UIStatusBarAnimation (#463)
* [iOS] Add Platform Specific features for PrefersStatusBarHidden/UIStatusBarAnimation

* Update docs
2016-11-16 11:02:54 +01:00
adrianknight89 0ccae8a3af [iOS] Text should not overflow Entry if it can't fit inside the bounds (#400)
* Entry subviews should clip to parent bounds

* Adding sample code

* Adding sample code

* Adding sample code

* remove sample

* remove sample

* add back the sample code

* add back missing include

* use spaces instead of tabs
2016-11-15 15:17:29 -07:00
Andrei N 4554e822e3 Added CornerRadius property To Frame control 2016-11-15 11:56:03 -08:00
Paul DiPietro 8d03598812 [iOS] Add Platform Specific feature for setting AdjustsFontSizeToFitWidth on Entry (#429)
* [iOS] Add Platform Specific feature for setting AdjustsFontSizeToFitWidth on Entry

* Update docs
2016-10-20 15:17:00 -05:00
adrianknight89 6f00e078ec [iOS] Entry should correctly update Text when typing aid is used (#401)
* Entry should be able to detect typing aid changes correctly

* Added comment
2016-10-20 12:31:33 -07:00
E.Z. Hart 50ac8e06da Fix MasterDetailPage/NavigationPage leaks on iPad (#426)
* Remove Master page property changed handler to eliminate leak

* Fix memory leaks with MasterDetailPage and NavigationPage on iOS
2016-10-12 11:46:18 +01:00
Stephane Delcroix ec81d3f32a Merge branch 'adrianknight89-ios-scrolltoposition' 2016-10-11 20:34:18 +02:00
adrianknight89 47b61aab59 Fixed bug 43993 by removing call to base ViewWillAppear (#333)
* Fixed bug 43993 by removing call to base ViewWillAppear

* Removed commented code and reduced nesting
2016-10-04 17:31:15 +01:00
Stephane Delcroix d34dcf2cbc Merge branch 'ios-scrolltoposition' of https://github.com/adrianknight89/Xamarin.Forms into adrianknight89-ios-scrolltoposition 2016-10-04 09:34:35 +02:00
adrianknight89 5372d216df Tab children should be cast to Page (#398) 2016-10-03 12:09:28 +01:00
Adrian Knight e9606cd6e2 using internal Clamp method 2016-09-23 05:05:08 -05:00
Adrian Knight a708ad9593 iOS ScrollView should not scroll out of place on scrolling to element 2016-09-23 00:32:32 -05:00
Rui Marinho eb79ff842e Remove iOS classic from CI system (#353)
* [CI] Remove classic from build

* [Build] Remove classic forwarder

* [Nuget] Remove classic from Pages azure

* [Build] Remove classic csproj

* [IOS] Remove _UNIFIED_
2016-09-14 22:56:17 +01:00
Paul DiPietro 420ceb37d0 [iOS] Adjust Started/Ended hooks in pickers for iOS 10 (#339) 2016-09-08 15:00:57 -07:00
Samantha Houts 5e553f6195 Platform Specifics (#301)
* Playing around with how the platform specifics interfaces etc. might work

* Sample implementation of iOS navigation translucency

* Very slightly reduced code

* Better vendor stuff

* Drop single-implemenation interfaces

* Generics on NavigationPage

* On-demand vendor stuff

* Remove functionally duplicate classes and make ControlGallery work again

* Namespace all the things. XAML test.

* Can use Effect to attach platform specific

* Attach Effect on PropertyChanging for XAML support!

* Rename IConfigPlatform interfaces for readability

* Some renaming to match the documents

* Split class files

* Clear out test-only code

* Re-namespace

* Added On method to rendered Elements

* Allow for removal of platform suffix, convenience methods on specific platforms

* Creating a gallery page for specifics

* Add rudimentary Platform Specifics gallery; make CollapseStyle work on UWP;
Add CollapsedPaneWidth specific property

* Toolbar now working with both collapse styles

* MDP now displaying Content title; toolbar routing around title

* Add a gallery for the iOS NavigationPage stuff

* Add Navigation Page as detail page to verify it works with new Toolbar options

* Make titlebar/toolbar background colors consistent

* ToolbarPlacement now working on NavigationPage

* Toolbar Placement working for tabbed and nav pages

* Fix bug where phone doesn't get default toolbar placement on start

* [Core] Add PS WindowSoftInputModeAdjust

[Core] Make Application extendable

* Toolbar placement now working on Nav, Tabbed, and Master pages on desktop/phone

Remove unnecessary style indirection

Fix build errors

* [A] Add PlatformConfigurationExtensions

* SetSoftInputMode test page

* [A] SetSoftInputMode

Known issue: Status bar color does not work in AdjustResize mode

* [Core] Add PS Blur

* [iOS] Configure renderer for blur

* Add test page

* Move to blur VisualElement for broader support

* Move test pages to gallery

* Update docs

* Use lazy initializer for PlatformConfigurationRegistry
2016-08-30 10:46:14 -07:00
Rui Marinho 52dc625bce [iOS] Change when we updated the XF INavigationPageController after popping a page natively, Cleanup UITest references (#291) 2016-08-16 11:31:53 -07:00
Samantha Houts 33303a09df [iOS] Fixed bug that made pull-to-refresh indicator always visible after 2+ pulls (#307)
* Add repro for Bugzilla 43214

* [iOS] Undo change to ListViewRenderer

was attempting to prevent multiple unnecessary calls to SendRefreshing,
but this caused unintended problems.
2016-08-16 10:56:37 -07:00
Samantha Houts d5ad18b3e9 [A, iOS] ListView Pull-To-Refresh indicator animates when navigating back to it (#274)
* Add repro for 33561

* [A] ListView refreshing on created shows indicator

* [iOS] Refresh indicator restarts when appeared

* Remove superfluous get
2016-08-02 22:48:25 +01:00
ytn3rd d1885b4465 ixed issues where you could not force rotation with a NavigationPage on iOS. (#254) 2016-07-18 16:25:47 -07:00
Samantha Houts eb84f968f2 [All] Crash fixes for ListViews (#243)
* [Controls] Add repro for 42277

* [Android] No crash if GroupHeaderTemplate=null

* [Android] Fix DataTemplateSelector crash

* [Core] Expose ListProxy on TIL

* [iOS] Fix DataTemplateSelector crash

* [Win] Fix DataTemplateSelector crash

* [Docs] Update docs

* [Core] Implement ListProxy explicitly

Allows ListProxy property to stay internal.

* [Controls] Revert unnecessary change to shproj
2016-07-01 21:51:38 +01:00
Samantha Houts 0772a5278b [iOS] Default BarTextColor/BarBackgroundColor will no longer override values set in custom renderers (#233)
* [Controls] Improve TabbedPage test case

iOS should default to the color used in a custom renderer instead of to
the global default color.

* [iOS] TabbedPage Bar*Color default is better

Will use the color set by a custom renderer, if any, instead of always
pulling from global appearance.
2016-06-28 11:25:45 +01:00
Samantha Houts 925fc0aa58 Prep Cell & friends for removal of InternalsVisibleTo (#142)
* Prep Cell & friends for removal of InternalsVisibleTo

Includes:
- Cell
- EntryCell
- ListView
- MenuItem
- TableView
- ViewCell
- Toolbar

Moved extensions to Internal & removed TPH

* Update docs

* [Controls] Ignore Issue2411 on iOS <9

* [Controls] Formatting for Issue2411
2016-06-17 11:10:18 +01:00
Rui Marinho 87f1418d2f [iOS] Call UpdateLeftBarButtonItem when page is removed (#209) 2016-06-16 17:20:12 +01:00
E.Z. Hart d5be2f0144 Prep Page for removal of InternalsVisibleTo (#150) 2016-06-16 16:45:09 +01:00
Shawn Castrianni 7ae7dbaa96 Fix Bug 39486 (#153) 2016-05-11 11:07:23 +01:00
E.Z. Hart a8acdcc117 Add IMasterDetailPageController and update renderers (#146) 2016-05-04 15:22:34 +01:00
E.Z. Hart 5b9094241b Prep StreamImageSource for removal of InternalsVisibleTo 2016-05-04 14:08:54 +01:00
E.Z. Hart a2148444ba Add INavigationPageController (#149) 2016-05-04 13:18:40 +01:00
E.Z. Hart d11bc09e75 Prep Image for removal of InternalsVisibleTo (#140) 2016-05-02 14:56:03 -06:00
E.Z. Hart 93f22aaf28 Prep SearchBar for removal of InternalsVisibleTo (#137) 2016-05-02 14:55:43 -06:00
E.Z. Hart 2d9288eee6 Prep Entry for removal of InternalsVisibleTo (#139)
* Prep Entry control for removal of InternalsVisibleTo

* Update docs
2016-04-27 07:55:09 -04:00
Jason Smith 409e105284 Carousel clean (#135)
CarouselView moving to preview repo
2016-04-26 15:35:52 -04:00
E.Z. Hart 07df05ced2 Remove ToolBar from Core; Remove ToolBar renderers and unit tests (#124) 2016-04-25 12:52:48 -04:00
E.Z. Hart 6c0c11960b Prep WebView and renderers for removal of InternalsVisibleTo (#120)
* Create custom event args class for script eval requests
Make IWebViewRenderer public

* Add IWebViewRenderer docs

* Add EvalRequested docs

* Move EvalRequested to Internals
IWebViewRenderer -> IWebViewDelegate

* Add docs
2016-04-25 12:26:40 -04:00
Rui Marinho feac1ba3ed [iOS] Fix issue with WebView dispose and resizing (#128) 2016-04-24 09:38:40 -04:00
E.Z. Hart a98f3fb2aa Add TextColor Property to Picker, TimePicker, DatePicker (#84)
* Add TextColor property to TimePicker
Add TextColor page to TimePicker gallery
Add TimePicker color toggling to color toggle test page
Split color toggle tests up among tabs

* Implement TimePicker.TextColor in iOS

* Implement TimePicker.TextColor for WinRT tablet

* Add IsEnabled=false tests to DefaultColorToggleTest Button and TimePicker
Consolidate ColorStates array
Fix IsEnabled changing color bug on iOS

* Implement TimePicker.TextColor for WP8

* Add TextColor property to DatePicker
Add DatePicker section to DefaultColorToggleTest
Impement DatePicker.TextColor for WP8

* Implement DatePicker.TextColor for WinRT/UWP/Windows Phone 8.1

* Implement DatePicker.TextColor for iOS

* Add TextColor to DatePicker Gallery Page

* Implement DatePicker.TextColor for Android

* Add Picker Gallery page for TextColor
Implement Picker.TextColor on Android
Consolidate TextColor management for Button, Picker, DatePicker, TimePicker
Implement

* Add untracked TextColorSwitcher
Implement Picker.TextColor in iOS

* Implement Picker.TextColor in WinRT/UWP/Windows Phone 8.1
Remove Pioker Loaded handlers in Dispose

* Implement Picker.TextColor in WP8

* Removed unused field
Update ignored warnings

* Update docs

* Use nameof() for BindableProperties

* Cleanup

* Fix custom renderer crashes for classes using TextColorSwitcher

* Correct property name references

* Fix typo and 'if' formatting

* Add missing else
2016-04-19 00:01:58 -07:00
kingces95 d51b17aece Whitespace fixes (#110) 2016-04-18 23:57:22 -07:00
kingces95 0d57b35f21 CarouselView Fixes (#101)
* Fix CarouselView.Item

* CarouselView formatting

* Move ItemsView.Count to IItemsViewController

* Remove dead code: CarouselView.IndexOf

* CarouselView re-layout subviews on resize.

* Add ItemTemplate to resources.xaml on UWP

* Docs
2016-04-18 11:39:23 -07:00
Samantha Houts 75f1124002 BarBackgroundColor and BarTextColor on TabbedPage (#96)
* [Core] Add properties to TabbedPage

* [Controls] Add properties to test page

* [iOS] Added BarBackgroundColor & BarTextColor to TabbedPage

* [A] Added BarBackgroundColor & BarTextColor to TabbedPage

* [UWP] Added BarBackgroundColor & BarTextColor to TabbedPage

* [WinRT] Format file

* [WinRT] Added BarBackgroundColor & BarTextColor to TabbedPage

* [Docs] Updated docs
2016-04-18 09:46:51 -07:00
Rui Marinho 2223efdd4f [iOS] Restore VisualElementTracker on WebViewRenderer (#99) 2016-04-16 14:39:22 -07:00
Jason Smith e7f30c34d5 Page renderer effects (#85)
* [I]PageRenderer Effect support

* [I]Add Effect supprt for NavigationPage

* [I]Enable Effects on remaining pages
2016-04-13 16:38:38 -07:00
Samantha Houts 90d8976cfd [iOS] Resolve Warning 0108 (#64)
[iOS] Resolve warning 0114

`Selected` is overridable, but current behavior is to hide it, so we're
going to add the `new` keyword.

[iOS] Resolve warning 0618

[iOS] Resolve warning 0414, 0649, 0169

[iOS] Resolve warning 0105

Update dispose to override base dispose (#67)

Add an optional extended description…
2016-04-11 18:05:28 -07:00
Jason Smith df24270915 Resharper warnings are slightly different for some reason than WError, resolve these (#66) 2016-04-11 17:33:34 -07:00
Paul DiPietro b2ad3e53a8 Enable CS0618 warnings as errors (#72)
CS0618 occurs when using an obsolete property or method.

https://msdn.microsoft.com/en-us/library/x5ye6x1e.aspx
2016-04-11 09:50:28 -07:00
kingces95 870f9c98ff [A, iOS] CarouselView Bug Fixes (#49)
* CarouselView programatic scrolling fixes; swipe back fixes

* Make iOS CarouselView events consistant with Android

* bump swipe distance; add Screenshot on Exception

* Formatting. No logical change.

* Comment out [Test] on UITest and fix TestCloud failures later.
2016-04-07 22:55:19 +01:00
kingces95 fae68e21b9 Reformat methods to original order 2016-04-05 16:34:42 -07:00
Jason Smith a6964ab96f Merge pull request #20 from xamarin/fix-bugzilla21177
[iOS] PageRenderer no longer swallows touches
2016-04-04 15:22:30 -07:00
E.Z. Hart 17e2a4b94d Add options for specifying layout of button text/image content
Also make the layout and layout defaults consistent across platforms
2016-03-30 16:22:35 -06:00
Samantha Houts 1688728737 [iOS] PageRenderer no longer swallows touches
Will allow users to create custom renderers that have touch events.
2016-03-30 12:01:54 -07:00
E.Z. Hart 41ae551eb8 Make spacing in lock statement consistent with code style 2016-03-29 13:41:41 -06:00
Samantha Houts 7fdd7ed0c2 Merge pull request #19 from xamarin/reformatUsings
Reformat using statements
2016-03-28 10:58:13 -07:00
Chris King b3365b7f7d Reformat using statements 2016-03-25 13:53:19 -07:00
Chris King 735b130893 Add using statement to dispose stream 2016-03-24 12:41:07 -07:00
Jason Smith 17fdde66d9 Initial import 2016-03-22 16:13:41 -07:00