7ff17ee3ad
Merge pull request #14089 from electron/appveyor-gn-simplify
...
ci: [win] simplify call to electron.exe in appveyor
2018-08-14 14:30:11 -07:00
dda6bb135a
Merge pull request #14017 from electron/node-gn
...
build: build node with GN
2018-08-14 14:29:17 -07:00
9989195f19
fix: notify request context shutdown on IO before cleanup ( #14058 )
2018-08-14 14:07:53 -07:00
379f40ef93
ci: [win] simplify call to electron.exe in appveyor
...
the python junk was there previously because PowerShell is bad at exit
codes
2018-08-14 11:31:22 -07:00
49ee5167c3
Update DEPS
2018-08-14 10:43:55 -07:00
8c21762bee
Merge pull request #14081 from electron/vs2017-15-4-5
...
ci: Use VS2017 15.4.5 for Chromium 66
2018-08-14 09:50:55 -07:00
1c509c4743
Use VS2017 15.4.5 for Chromium 66
2018-08-14 09:34:34 -07:00
3ac8aad495
chore: bump libcc ( #14071 )
...
* chore: bump libcc submodule to d6411e421b0b2f0105d274ac4e5c90dc979463ca
* chore: bump libcc in DEPS to d6411e421b0b2f0105d274ac4e5c90dc979463ca
2018-08-14 06:46:33 -07:00
b9490177da
Revert "[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear ( #13956 )"
...
This reverts commit 1c0bb06d4a
2018-08-13 16:16:04 -07:00
1c0bb06d4a
[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear ( #13956 )
...
* refactor: desttroy URLRequestContextGetter on IO thread
* Accepts a factory class that can customize the creation of URLRequestContext
* Use a separate request context for media which is derived from the default
* Notify URLRequestContextGetter observers and cleanup on IO thread
* Move most of brightray net/ classes into atom net/
* refactor: remove refs to URLRequestContextGetter on shutdown
* refactor: remove brigtray switches.{cc|h}
* refactor: remove brightray network_delegate.{cc|h}
* refactor: make AtomURLRequestJobFactory the top level factory.
* Allows to use the default handler from content/ for http{s}, ws{s} schemes.
* Removes the storage of job factory in URLRequestContextGetter.
2018-08-13 15:22:45 -07:00
cb4b3e7be0
Merge pull request #14049 from electron/fix-flaky-sandbox-tests
...
fix: Fix flaky sandbox tests
2018-08-13 13:26:52 -07:00
828e317360
Fix flaky sandbox tests
...
Windows apparently has issues running opening two windows at once which is causing flakiness on the mixed sandbox tests.
2018-08-13 09:30:20 -07:00
a53a5ac071
Merge pull request #14045 from electron/enable-mixed-sandbox
...
fix: re-enable mixed-sandbox tests
2018-08-13 08:48:19 -07:00
2ac3d89279
fix: lint js and docs alongside clang-format ( #14044 )
...
* fix: lint js and docs alongside clang-format
* chore: change lint scripts to colon format
2018-08-13 08:20:55 -07:00
23541b5b2a
feat: On macOS, Closing Notifications Triggers the 'close' Event ( #13306 )
...
* feat(macOS): implement NotificationDismissed() for Cocoa
* feat(macOS): emit NotificationDismissed() when closing "Alert" notifications
* feat(macOS): emit NotificationDismissed() when closing "Banner" notifications
* fix(macos): Remove calls to private APIs from MAS builds (github.com/electron/electron/pull/13306)
2018-08-13 23:09:25 +12:00
590ae5cd29
fix: re-enable mixed-sandbox tests
2018-08-12 21:29:29 -07:00
c0959bd534
refactor: add 'npm run bootstrap', 'npm run build' ( #14034 )
...
* docs: update package.json and build docs
* fix build release
* address feedback from review
* whoops forgot one
* fix build script
* address feedback from review
2018-08-12 14:01:46 -07:00
b785f45852
fix: override fs.realpathSync.native and fs.realpath.native ( #14031 )
...
* fix: override fs.realpathSync.native and fs.realpath.native
* spec: test new native functions
2018-08-12 00:10:55 -07:00
8dae1c8447
fix: make asarStatsToFsStats nherit from fs.stats ( #14030 )
2018-08-11 23:20:33 -07:00
c0dfc4b2eb
ci: [gn] build 32-bit node modules on 32-bit linux ( #14021 )
2018-08-11 12:21:34 -05:00
ae79fd1bb3
docs: update GN developer docs ( #14018 )
2018-08-11 12:20:19 -05:00
db7cec8d86
ci: build x86 builds on GN in appveyor ( #14019 )
2018-08-10 17:52:54 -05:00
702cc84bd3
Don't pass preloadPath via ELECTRON_BROWSER_SANDBOX_LOAD for security reasons ( #13031 )
2018-08-10 17:19:49 -05:00
e08ce7127a
Merge pull request #13877 from electron/gn-ci-win-appveyor
...
ci: [gn] add ci build for gn on windows
2018-08-10 13:40:44 -04:00
6d277ec784
[wip] build: try building node with GN
2018-08-10 10:06:27 -07:00
19cb5bad94
feat: Add creationTime function to process ( #13542 )
...
* Add process creation time
* Making docs clear for process creation time
* Address comments for process creation time
* Add process info cc file
* fixing comments around documentation
* Update doc for return val
* Capitalize number in docs
* chore: bump electron-typescript-definitions
2018-08-10 09:03:30 -05:00
9902d42760
docs: cancelId works on windows ( #13882 )
...
The note about cancelId not working on windows is not valid. Tried on Windows 7 and Windows 10 and it works in both cases (tested on electron 1.8.7).
2018-08-10 16:07:39 +10:00
1c879870ee
chore: add a Mac App Store Private API Rejection template ( #14009 )
2018-08-10 15:35:30 +10:00
637280e060
core: add security report issue template ( #14010 )
...
Basically tell people not to raise an issue but to send an email to our security email address. This hasn't happened yet but we should do everything we can to send people in the right direction 😄
2018-08-10 15:30:24 +10:00
7c7543cb39
spec: re-enable app.getAppMetric API ( #13962 )
2018-08-09 13:35:29 -05:00
271d582aac
refactor: make methods const, cleanup ( #13937 )
2018-08-09 10:15:23 -07:00
9005803667
Fix typos ( #13999 )
2018-08-09 10:04:03 -05:00
9a1ad2b93f
fix: ipcRemote.sendSync regression after moving away from JSON for return values ( #13941 )
2018-08-09 19:45:10 +10:00
a7052efaf4
fix: make menu.popup options optional ( #13977 )
...
* add empty object as default param for options
* update docs
* add spec for optional options
* fix: add null check for options
2018-08-08 17:38:52 -05:00
fc4499ebd4
chore: roll libcc
2018-08-08 09:33:02 -07:00
29f07889e6
feat: add location url to "Node.js Integration with Remote Content" warning ( #13973 )
...
* docs: fix typo
* feat: add location url to Node+Remote warning
2018-08-07 20:40:21 -05:00
e6e621515f
chore: disable flaky isCurrentlyAudible test ( #13970 )
2018-08-07 14:23:48 -05:00
06786e7bb8
Merge pull request #13828 from nornagon/gn-ci-mac
...
ci: [gn] add Mac support to VSTS build
2018-08-06 10:54:22 -04:00
2551837ffb
docs: min windows server version for building is 2012 ( #13935 )
2018-08-03 17:32:07 -07:00
379998e2f6
docs: recommend windows 10 as the minimum build OS
...
I'm pretty sure building on windows 7 doesn't work.
2018-08-03 15:42:12 -07:00
9f328abe19
refactor: remove instances of createDeepCopy ( #13703 )
...
* add new native_mate converters for base::Value
* fix converter swapping
* remove createDeepCopy from browser/api
* replace missing ListValue converter
* convert bulk of remaining createDeepCopy instances
* convert last remaining instances of createDeepCopy
* incremental progress and helper methods for value conversion
* convert Get and add template function for GetString
* final DictionaryValue method conversions
* remove usage of base::DictionaryValue in web_contents_preferences
* use IsEnabled helper where possible
* Update atom_api_web_view_manager.cc
2018-08-04 07:23:07 +10:00
cecb8fb0c4
chore: roll libcc and node DEPS ( #13931 )
2018-08-03 12:36:56 -07:00
f904057104
fix: add missing "simple" property in several APIs to prevent proxying of return values ( #13905 )
...
* fix: add missing "simple" property in several APIs to prevent proxying of return values
* add tests
2018-08-03 12:07:27 -07:00
e0735baff2
docs: [gn] update build instructions
2018-08-03 11:54:21 -07:00
96c39923b6
ci: [gn] add builders for 32-bit linux
2018-08-03 11:08:12 -07:00
fceed0fcbc
fix: dipToScreenRect / screenToDipRect - window can be null ( #13903 )
2018-08-03 13:08:42 +10:00
03293d78a2
chore: roll libcc DEPS ( #13917 )
2018-08-03 10:55:49 +10:00
23440a5ec3
fix: Improve --enable-features/--disable-features handling ( #13920 )
...
As it turns out, we can reinitialize the feature list directly after the
user JS script has been executed instead of much later. This allows
modifications to `--enable-features`/`--disable-features` to work with a
greater set of features.
2018-08-03 10:53:54 +10:00
48ae9b7a9c
docs: update node upgrade doc ( #13891 )
...
Updates the node upgrade doc to take path changes into account as well as to incorporate the new `get-patch` script which simplifies work significantly.
2018-08-01 23:33:37 -07:00
c068bc7d3d
test: make nativeImage relative path test robust to different cwd
2018-08-01 15:19:26 -07:00
John Kleinschmidt
Robo
Jeremy Apthorp
Roller Bot
Charles Kerr
Shelley Vohr
Sidney
Shelley Vohr
Milan Burda
Husayn
secult
Samuel Attard
GhostlyDark
Dominic
Birunthan Mohanathas