* fix: point to ~kubeflow/styles/fonts.scss
It seems like the path to this file recently changed by #7062,
which is now preventing the centraldashboard Docker image to
build wich fails with a SassError when trying to import fonts.scss.
This commit points to the right path.
* tests: replace keyboard_backspace with arrow_back
The latest changes made the CI to only build the images for different
archs, but not push for the tag value of the commit.
While next steps, for pushing the latest tag or a release version tag
will work we still want to ensure we push an image with a tag.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
Previously we omitted the ARCH env var, which resulted in the last step
to not push for all architectures, but only for amd64.
This commit will set a default ENV var with all architectures, which
will be picked up by the build-push make rule we have.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* Run build steps for multi-arch sequentially
We saw that if we try to build using an ENV var containing all the
architectures then docker buildx will run 3 parallel jobs.
This made the GH runners crash in some cases because they were
over-utilizing the resources.
To mitigate this we'll sequentially build each image for each arch.
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* review: Build first for amd64
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
---------
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* Make principals dynamic in Profiles Controller
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* review: Use dynamic principal of IGW in KFAM
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* review: Add env vars to manifests
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* review: Add pipelines-ui principal
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* Update golang to 1.19 for unit tests to succeed
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* review: Include KFP UI principle in profiles/kfam
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
---------
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
* Bump the controller-runtime version to 0.16.2
There are a lot of improvements, optimizations and bug fixes in the
latest version, related to the controller-runtime client which is used
in admission-webhook.
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
* Set logger for controller-runtime
The latest version of controller-runtime client requires to set in
advance a logger, used by the client.
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
* Use golang version 1.21 for container build
The latest version of controller-runtime package requires golang v.1.21
for building.
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---------
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
The change introduced by kubeflow/kubeflow#6736 removed the default GPU vendors
list, which causes an issue when trying to select a vendor from the dropdown menu
if the vendors list is not configured.
This commit can be reverted if proper documentation is provided for users/distributions
to configure the dropdown menu.
Fixes#7273
* build: minor doc improvement triggering build pipe
* fix: viewer-spec.yaml
Two fields are either not correctly indented or named incorrectly
* fix: add volumes definition required by controller
* feat: use filebrowser:v2.24.2 enabling tus uploads
* Add pvcviewer support to volumes backend
* Modifying volumes manifests for pvcviewer support
* viewer-spec is now valid
* Add frontend integration
* Fix flake8 errors
* Use material spinners to display wait times
* Default PVCViewer SA to default-editor
* fix: remove superfluous space in docker builds (#7224)
* Update role_binding.yaml
roleRef.name now matches role.metadata.name
* Remove invalid creationTimestamp: null fields
* Use commonLabels over labels
to comply with old kustomize version being used in integration tests
* Use vars in favor of replacements
* web-apps(front): Define theme and typography
In this commit:
* Create a styles folder that contains all sccs files.
* Define the generic theme and typography.
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Use the style of the specified body-1 level
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Use the styles of the specified title and headline levels
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Use primary color in snackbar component
Signed-off-by: Elena Zioga <elena@arrikto.com>
* web-apps(front): Change back button
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Fix imports after restructuring
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Add mat-typography class in index.html
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Use the style of the specified title level
Signed-off-by: Elena Zioga <elena@arrikto.com>
* jwa(front): Use primary color
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Fix imports after restructuring
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Add mat-typography class in index.html
Signed-off-by: Elena Zioga <elena@arrikto.com>
* vwa(front): Use the style of the specified title level
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix typo
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Add mat-typography class in index.html
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix imports after restructuring
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Use primary color
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix formatting
Signed-off-by: Elena Zioga <elena@arrikto.com>
* twa(front): Fix ui test
Signed-off-by: Elena Zioga <elena@arrikto.com>
---------
Signed-off-by: Elena Zioga <elena@arrikto.com>
* Disabling multiple architecture build for PRs
* Disabling multiple architecture build for PRs on Poddefaults
* Disabling multiple architecture build for PRs on NB Controller
* Disabling multiple architecture build for PRs on JupyterWeb App
* Disabling multiple architecture build for PRs on Profile & KFAM
* Disabling multiple architecture build for PRs on Profile Controller
* Disabling multiple architecture build for PRs on VWA
* Disabling multiple architecture build for PRs on TWA
* Disabling multiple architecture build for PRs
* Disabling multiple architecture build for PRs on Poddefaults
* Disabling multiple architecture build for PRs on NB Controller
* Disabling multiple architecture build for PRs on JupyterWeb App
* Integrating volumes viewer into volumes ui backend
* Integrating volumes viewer into volumes ui frontend
* Modified the volume viewer's manifests to be in accordance with the volumes viewer changes
* Bootstrapping/creating VolumesViewer Controller
* Changed/reverted image definitions
* Fixed code style issues
* Run prettier on index-default.component.ts
* Reverted accidental method call change back to getSelectedNamespace2
* Reverted package-lock.json
* Now using the VOLUME_VIEWER_IMAGE env variable in the viewer's podTemplate
* Set readinessProbe.initialDelaySeconds=2 for new viewers
* Removed downward api references in favor of Python variable expansion
* Revised crd schema
- Now includes a status.URL field
- Reverted changes to status.py to minimize diff
* Providing NAME as a possible var for var expansion
* Return and use the VolumesViewer.Status.URL
* Reconcile status while deletion ongoing
* Restored empty line to get file off diff
* Reducing diff on get.py
* Run prettier
* Updated OWNERS/README
* Changes to schema comments / renaming
* Improved test performance and reliability
By cleaning up resources created by tests in afterEach()
Also: Pod watch now only triggers for non-terminating RUNNING/PENDING pods, reducing the number of reconciliation calls
* Renaming VolumesViewer -> PVCViewer as discussed in community meeting
* Moving changes to volumes frontend to another PR as discussed in community meeting
* Renaming file names
* Renaming PVCViewerSpec.PodTemplate -> PodSpec
* Renaming PVCViewerSpec.Service -> Networking
* Adding the Spec.PVC field and validating/defaulting webhooks
* Adding the option to load a default podSpec from file
* Introduced PVCViewer.Status.Conditions
* Validator requires the PVC to be used in podSpec
* Added tests for the validating webhook
* Removed debug log message
* Updating manifests to work with new webhooks
* Updating documentation
* Refactored manager according to specs
* Modifying pvcviewer OWNERS
* Makefile & renaming comp -> pvcviewer-controller
* Changing nameprefix to pvcviewer-
* Setting imagePullPolicy: IfNotPresent
* Adding a base directory
* Generating TLS certs for make run
* Adding a log time encoder
* # backend
Adding /api/metrics endpoint for `resourceChartsLink` and `resourceChartsLinkText` field.
Adding PrometheusMetricsService class implementing MetricsService
Adding `prometheus-query` package
## MetricsService
Adding `getChartsLink(): MetricsInfo` to MetricsService. It will be used to send client the info about the metrics (resourceChartsLink and resourceChartsLinkText).
## env
- PROMETHEUS_URL: url for prometheus query
- METRICS_DASHBOARD: if defined, will add a button under graphs to go to the url defined
## Prometheus query
- getNodeCpuUtilization: `sum(rate(node_cpu_seconds_total[5m])) by (instance)`
- getPodCpuUtilization: `sum(rate(container_cpu_usage_seconds_total[5m]))`
- getPodMemoryUsage: `sum(container_memory_usage_bytes)`
# frontend
Adding iron-ajax to `/api/metrics`.
Adding `metrics` properties to main-page and dashboard-view.
Making footer of `ressource-chart.js` hidden if resourceChartsLink is undefined.
* Fixing package-lock.json
* Adding Unit Tests and Improvements
These flag in scanners:
golang.org/x/net v0.0.0-20211209124913-491a49abca63 0.0.0-20220906165146-f3363e06e74c go-module GHSA-69cg-p879-7622 High
golang.org/x/net v0.0.0-20211209124913-491a49abca63 0.7.0 go-module GHSA-vvpx-j8f3-3w6h High
golang.org/x/sys v0.0.0-20211029165221-6e7872819dc8 0.0.0-20220412211240-33da011f77ad go-module GHSA-p782-xgp4-8hr8 Medium
golang.org/x/text v0.3.7 0.3.8 go-module GHSA-69ch-w2m2-3vjp High
Signed-off-by: Dan Lorenc <dlorenc@chainguard.dev>
Daniela Plascencia
Kimonas Sotirchos
Tobias Goerke
dependabot[bot]
Tzvetomir Stoyanov
boarder7395
Ikko Eltociear Ashimine
Lingqing Gan
Mathew Wicks
Diana Atanasova
Pranav Pandit
Elena Zioga
Narayanamurthi Mari
Souheil
axel7083
Jack Homan
一条肥鱼
amitmukati-2604
Dr. Sebastian Lehrig
deepk2u
dlorenc