Граф коммитов

14784 Коммитов

Автор SHA1 Сообщение Дата
Andrew Hall (METAL) 0a24790d60 Fix one case where immutable should have been mutable 2024-07-10 14:07:01 -07:00
Andrew Hall (METAL) 55a8a699f0 Missed a few places 2024-07-10 13:04:46 -07:00
Andrew Hall (METAL) 6f2626f14d PR feedback part 2 2024-07-10 12:42:00 -07:00
Andrew Hall def15fb703 PR feedback and cleanup 2024-07-09 18:28:48 -07:00
Andrew Hall dce846792c Merge branch 'main' into pooled_arrays 2024-07-09 13:34:01 -07:00
Andrew Hall b34f0ec815 A few more locations 2024-07-09 13:23:40 -07:00
Chris Sienkiewicz b24cd9cb14
Improve perf in generator cache cases (#10577)
* Manually validate if additional files and metadata references have actually changed
* Short circuit metadata ref comparer
* Add tests
2024-07-09 11:16:22 -07:00
dotnet-maestro[bot] 068df13f6c
[main] Update dependencies from dotnet/arcade (#10590)
* Update dependencies from https://github.com/dotnet/arcade build 20240702.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24352.1 -> To Version 9.0.0-beta.24352.2

* Install .NET 8 runtime

* Update dependencies from https://github.com/dotnet/arcade build 20240702.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24352.1 -> To Version 9.0.0-beta.24352.2

* Disable BuildWithNetFrameworkHostedCompiler

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jan Jones <janjones@microsoft.com>
2024-07-09 11:51:59 +02:00
David Wengier 63e225dfab
Clean up code actions code (#10582)
This PR is a style-only clean up of our code actions handlers and
related code. Definitely could have gone further (more collection
pooling, returning concrete types etc.) but I wanted to try to have it
serve as an indication for what we consider our current idiomatic coding
style* and to avoid conflicts with the extract to component work.



<sub>* Current style is subject to change at any time, and are not well
documented. To quote a great Australian film, [it's just the
vibe](https://www.youtube.com/watch?v=nMuh33BMZYY).</sub>
2024-07-09 14:13:30 +10:00
David Wengier ce9be80f6c Fix build 2024-07-09 13:47:01 +10:00
David Wengier dfdb3146b7 PR Feedback (except things that could cause conflicts) 2024-07-09 11:59:57 +10:00
Andrew Hall (METAL) 89db3c8f6a Convert a lot of usages to pooled objects 2024-07-08 18:46:42 -07:00
Alex Gavrilov f7465617aa
Removing unnecessary Razor Legacy Editor feature flag (#10591)
* Removing unnecessary Razor Legacy Editor feature flag

AFAIK it was introduced for new LSP editor rollout several years ago before we had Tools/Options/HTML Editor/Advanced/Use legacy Razor Editor option. Now that rollout is over, and there is a public non-preview mechanism for users to switch to the old editor if needed, the feature flag is no longer necessary and creates confusion (and extra code to test/maintain).

* Fixing a unit test (test matrix)

* Fixing spacing per CR suggestion

Co-authored-by: David Wengier <david.wengier@microsoft.com>

---------

Co-authored-by: David Wengier <david.wengier@microsoft.com>
2024-07-08 23:13:12 +00:00
David Wengier b17a0e8ece
Explicitly pass formatting options to Roslyn APIs (via External Access) (#6166)
Requires:
- [x] https://github.com/dotnet/roslyn/pull/59679
2024-07-08 10:55:23 +10:00
David Wengier c5de6625c4 Make minimal 2024-07-08 08:33:01 +10:00
David Wengier dbacc56eda Whitespace 2024-07-08 08:30:55 +10:00
David Wengier e0e78bb712 Actually fix the bug by not calling TryApplyChanges on the workspace 2024-07-08 08:20:23 +10:00
David Wengier 50a650ad5b Updates after merge 2024-07-07 22:24:19 +10:00
David Wengier abf6053c46 Merge remote-tracking branch 'upstream/main' into FormattingOptions
# Conflicts:
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/CSharpFormatter.cs
#	src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/CSharpOnTypeFormattingPass.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting/FormattingLanguageServerClient.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Formatting/TestRazorFormattingService.cs
2024-07-07 21:41:46 +10:00
David Wengier ca5327e7a8
Unskip bound attribute test (#10580)
Since we were talking in the working group meeting, thought I'd give it
a go and see if it passes
2024-07-04 17:53:21 +10:00
David Wengier 254d9dee6d Clean up code actions code 2024-07-04 15:58:24 +10:00
David Wengier 4e25c1d325 Unskip bound attribute test 2024-07-04 09:01:02 +10:00
Andrew Hall ef0a3b046c
Handle InsertReplaceEdit for completion (#10563)
Partially complete #8829
2024-07-03 22:01:56 +00:00
David Wengier 85c16a68d5
Don't call C# for Uri or Text presentation (#10575)
As discussed offline, Roslyn doesn't support the Uri or Text
presentation endpoints, and recent LSP client changes have caused
erroneous failure telemetry to be logged as a result. This PR fixes that
by just not calling Roslyn.
2024-07-04 07:33:32 +10:00
Dustin Campbell 013d660d07
Move IVTs from AssemblyInfo into project files (#10573)
I've been meaning to do this for a long while now. This change removes
all of the IVTs from `AssemblyInfo.cs` files and places them in the
relevant project file. I've also added a target to process
`RestrictedInternalsVisibleTo`, though that's only used by
MS.ANC.Razor.LanguageServer to restrict the IVT to the
"Microsoft.AspNetCore.Razor.LanguageServer.Hosting" namespace.
2024-07-03 11:33:32 -07:00
Dustin Campbell 768f03b334 Fix BOM 2024-07-03 08:15:02 -07:00
dotnet-maestro[bot] 568ac36723
[main] Update dependencies from dotnet/arcade (#10534)
* Update dependencies from https://github.com/dotnet/arcade build 20240624.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24324.7

* Update dependencies from https://github.com/dotnet/arcade build 20240624.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24324.7

* Update dependencies from https://github.com/dotnet/arcade build 20240624.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24324.7

* Update dependencies from https://github.com/dotnet/arcade build 20240624.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24324.7

* Update dependencies from https://github.com/dotnet/arcade build 20240626.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24326.4

* Update dependencies from https://github.com/dotnet/arcade build 20240626.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24326.4

* Update dependencies from https://github.com/dotnet/arcade build 20240628.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24328.2

* Update dependencies from https://github.com/dotnet/arcade build 20240628.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24328.2

* Update dependencies from https://github.com/dotnet/arcade build 20240702.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.24321.3 -> To Version 8.0.0-beta.24352.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2024-07-03 11:08:32 +02:00
David Wengier bf9f3d03e6 Don't call C# for Uri or Text presentation 2024-07-03 15:29:44 +10:00
David Wengier 50bc1188d9
Use System.Text.Json for serialization (#10551)
Fixes https://github.com/dotnet/razor/issues/10539

This PR switches us to use System.Text.Json for server to client
communication, and opts us in to using it for client to server
communication too.

Needs
https://devdiv.visualstudio.com/DevDiv/_git/WebTools/pullrequest/561188
to flow to VS main, then I'll kick off a final integration test run for
good measure. Without that PR the Wrap With Tag functionality doesn't
work.

TODO:
 - [x] Test VS Code
2024-07-03 14:02:47 +10:00
David Wengier 66a18d73f2 Add package source mapping 2024-07-03 13:37:32 +10:00
David Wengier c61b0d53d5 More slightly educated guesses at package versioning 2024-07-03 12:00:40 +10:00
David Wengier db9efe4c9b Try publish binlogs from mac and linux 2024-07-03 11:42:42 +10:00
David Wengier fd6d6cc27f Try bump some more packages 2024-07-03 11:31:29 +10:00
David Wengier d70c96c4c9 Merge remote-tracking branch 'upstream/main' into dev/dawengie/STJ
# Conflicts:
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Completion/LegacyRazorCompletionEndpointTest.cs
#	src/Razor/test/Microsoft.AspNetCore.Razor.LanguageServer.Test/Completion/LegacyRazorCompletionResolveEndpointTest.cs
2024-07-03 10:49:39 +10:00
David Wengier fb2ab650f8 Explicit null check because the VSSDK analyzer is fussy 2024-07-03 10:45:11 +10:00
Alex Gavrilov e7bc6023a4
Removing support for legacy completion endpoint, tests, and option (#10571)
* Removing support for legacy completion endpoint, tests, and option to turn it on

* Removing more unnecessary code per CR suggestion
2024-07-03 00:41:01 +00:00
David Wengier ca2bba251d Nullability 2024-07-03 09:51:32 +10:00
David Wengier 5981abd272 Update all the packages!! 2024-07-03 09:51:17 +10:00
Dustin Campbell 228bb2e4c0 Move MS.ANC.Razor.Test.Common IVTs to project file 2024-07-02 15:45:38 -07:00
Dustin Campbell dffee73a68 Move MS.VS.LegacyEditor.Razor IVTs to project file 2024-07-02 15:45:38 -07:00
Dustin Campbell 57d5c321c6 Move MS.VS.LanguageServices.Razor IVTs to project file 2024-07-02 15:45:38 -07:00
Dustin Campbell 7b051d7d0f Move MS.VS.LanguageServer.ContainedLanguage IVTs to project file 2024-07-02 15:45:37 -07:00
Dustin Campbell 47266af6ef Move MS.CA.Remote.Razor IVTs to project file 2024-07-02 15:45:37 -07:00
Dustin Campbell 473c578b5a Move MS.CA.Razor.Workspaces IVTs to project file 2024-07-02 15:45:37 -07:00
Dustin Campbell c2e2c4b9bc Move MS.ANC.Razor.ProjectEngineHost IVTs to project file 2024-07-02 15:45:37 -07:00
Dustin Campbell 7c4b0addd5 Move MS.ANC.Razor.LanguageServer IVTs to project file 2024-07-02 15:45:37 -07:00
Dustin Campbell 0328fcab5e Move MS.ANC.Razor.EA.RoslynWorkspace IVTs to project file 2024-07-02 15:45:36 -07:00
Dustin Campbell 906173ad57 Move MS.ANC.Razor.Utilities.Shared IVTs to project file 2024-07-02 15:45:36 -07:00
Dustin Campbell 54b32fa2e7 Move MS.ANC.Razor.Test.Common IVTs to project file 2024-07-02 15:45:36 -07:00
Dustin Campbell 9fb27097c0 Move MS.CA.Razor.Compiler IVTs to project file 2024-07-02 15:45:36 -07:00