2dd34b8dd8
Expand RazorProject.GetItem to take in FileKinds when getting items.
...
- Obsoleted old `GetItem` API.
- Updated tests to take new API.
- Added a new test to verify the broken scenario.
#8972
2019-04-02 13:32:35 -07:00
9d7fd089a6
Ensure _TargetingNETCoreApp30OrLater is available for older design time targets ( #386 )
...
* Ensure _TargetingNETCoreApp30OrLater is available for design time targets
2019-04-02 13:00:22 -07:00
b5b1647646
Prevent build failures and warnings when building 2.x projects ( #382 )
...
* Move targets for component design time generation to
Components.targets
* Provide a better error message when referencing a 2.x Razor.Design
package in a 3.0 project
* Do not produce a warning for unresolved configuration when building
2.x projects
2019-04-01 22:38:09 -07:00
ef7d82a7ff
Fixes : #5640 FormatException from diagnostic
...
This was just a badly written diagnostic format string
2019-04-01 20:44:26 -07:00
d80fcacaa7
Update dependencies from https://github.com/aspnet/Extensions build 20190330.2
...
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview4.19180.2
- Microsoft.AspNetCore.Testing - 3.0.0-preview4.19180.2
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview4.19180.2
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview4.19180.2
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview4.19180.2
2019-03-31 15:17:29 -07:00
c94aa5cd02
[master] Update dependencies from dotnet/core-setup and aspnet/Extensions ( #380 )
...
* Update dependencies from https://github.com/dotnet/core-setup build 20190329.11
- Microsoft.NETCore.App - 3.0.0-preview4-27529-11
Dependency coherency updates
- System.Diagnostics.DiagnosticSource - 4.6.0-preview4.19179.4 (parent: Microsoft.NETCore.App)
- System.Text.Encodings.Web - 4.6.0-preview4.19179.4 (parent: Microsoft.NETCore.App)
- Microsoft.Extensions.DependencyModel - 3.0.0-preview4-27529-11 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19179.4 (parent: Microsoft.NETCore.App)
* Update dependencies from https://github.com/aspnet/Extensions build 20190329.2
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview4.19179.2
- Microsoft.AspNetCore.Testing - 3.0.0-preview4.19179.2
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview4.19179.2
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview4.19179.2
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview4.19179.2
2019-03-30 22:21:43 -07:00
5f74fae0d2
Prevent newlines from being encoded in the output ( #374 )
...
* Prevent newlines from being encoded in the output
2019-03-29 13:04:15 -07:00
fe9c0e8651
[master] Update dependencies from dotnet/core-setupaspnet/Extensions ( #378 )
...
* Update dependencies from https://github.com/dotnet/core-setup build 20190328.14
- Microsoft.NETCore.App - 3.0.0-preview4-27528-14
Dependency coherency updates
- System.Diagnostics.DiagnosticSource - 4.6.0-preview4.19178.7 (parent: Microsoft.NETCore.App)
- System.Text.Encodings.Web - 4.6.0-preview4.19178.7 (parent: Microsoft.NETCore.App)
- Microsoft.Extensions.DependencyModel - 3.0.0-preview4-27528-14 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19178.7 (parent: Microsoft.NETCore.App)
* Update dependencies from https://github.com/aspnet/Extensions build 20190328.4
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview4.19178.4
- Microsoft.AspNetCore.Testing - 3.0.0-preview4.19178.4
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview4.19178.4
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview4.19178.4
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview4.19178.4
2019-03-29 10:46:02 -07:00
cc207a4257
Update LegacyProjectEngineFactory_3_0.cs ( #377 )
2019-03-29 08:58:33 -07:00
4fd3a280f9
[master] Update dependencies from dotnet/core-setup and aspnet/Extensions ( #376 )
...
* Update dependencies from https://github.com/dotnet/core-setup build 20190328.01
- Microsoft.NETCore.App - 3.0.0-preview4-27528-01
Dependency coherency updates
- System.Diagnostics.DiagnosticSource - 4.6.0-preview4.19177.9 (parent: Microsoft.NETCore.App)
- System.Text.Encodings.Web - 4.6.0-preview4.19177.9 (parent: Microsoft.NETCore.App)
- Microsoft.Extensions.DependencyModel - 3.0.0-preview4-27528-01 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19177.9 (parent: Microsoft.NETCore.App)
* Update dependencies from https://github.com/aspnet/Extensions build 20190327.11
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview4.19177.11
- Microsoft.AspNetCore.Testing - 3.0.0-preview4.19177.11
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview4.19177.11
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview4.19177.11
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview4.19177.11
2019-03-28 09:30:58 -07:00
bcc77db762
Remove base.BuildRenderTree calls ( #368 )
2019-03-28 12:46:36 +00:00
3ea8e98794
Do not specify `name` of the default (hosted) pools ( #375 )
...
- aspnet/AspNetCore#8862
- add `vmImage` for Linux job
2019-03-27 22:14:31 -07:00
3b647f5437
[master] Update dependencies from dotnet/core-setupaspnet/Extensions ( #369 )
...
* Update dependencies from https://github.com/aspnet/Extensions build 20190325.2
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview4.19175.2
- Microsoft.AspNetCore.Testing - 3.0.0-preview4.19175.2
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview4.19175.2
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview4.19175.2
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview4.19175.2
* Update dependencies from https://github.com/dotnet/core-setup build 20190327.02
- Microsoft.NETCore.App - 3.0.0-preview4-27527-02
Dependency coherency updates
- System.Diagnostics.DiagnosticSource - 4.6.0-preview4.19176.11 (parent: Microsoft.NETCore.App)
- System.Text.Encodings.Web - 4.6.0-preview4.19176.11 (parent: Microsoft.NETCore.App)
- Microsoft.Extensions.DependencyModel - 3.0.0-preview4-27527-02 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19176.11 (parent: Microsoft.NETCore.App)
2019-03-27 10:10:08 -07:00
6824620cb0
Skip running ModelDirective pass for component documents ( #372 )
2019-03-27 09:52:34 -07:00
c161cbfc44
Fix Import reseting on ProjectState when host project changes.
...
- Added a test to verify the new behavior.
aspnet/AspNetCore#8849
2019-03-27 08:55:34 -07:00
abbfe00bdc
Better support for _Imports.razor ( #357 )
...
* Better support for _Imports.razor
* Special case component imports when generating code
* Prevent a future VS crash
* Rebased and updated
* update
* Removed unnecessary newline
2019-03-26 17:58:37 -07:00
ac08ad3659
Add support for C# 8 using variable declarations and add more C# 8 coverage.
...
- When adding additional C# 8 tests found that we didn't fully support this.
- Updated the C# 8.0 test to fully encompass everything C# 8.0.
- Added a feature flag to control using variable declaration errors when not top level.
- Added using variable declaration specific tests.
aspnet/AspNetCore#5092
2019-03-26 17:37:12 -07:00
ecf298e6f9
Merge pull request #370 from aspnet/javiercn/regenerate-baselines
...
Regenerate baselines to fix issues with new added tests
2019-03-26 10:23:30 -07:00
0ea411b62b
Regenerate baselines to fix issues with new added tests
2019-03-26 09:50:01 -07:00
5a73c2abe9
Fixup invalid configuration error message ( #365 )
...
* Fix invalid parameter used in error message
* Re-organize test code
2019-03-26 08:58:38 -07:00
3009045206
bind-Value on EditText often results in the wrong thing ( #364 )
...
Updates the bindtaghelperdescriptorprovider to use the changed event property type name on the bound attribute instead of the value property type attribute.
2019-03-26 10:06:18 +01:00
76c1352d2c
Update more test files.
2019-03-25 20:26:36 -07:00
c9e0d2a60f
Design update.
2019-03-25 20:26:36 -07:00
1df8128b87
Enforce nullability for user code.
...
- Expanded the `ProjectWorkspaceStateGenerator` to extract the C# language version when building the `ProjectWorkspaceState`. This approach enables all platforms to get nullability support without any changes (as long as they support `ProjectWorkspaceState`, which they do). Also, Roslyn suggested that we avoid dealing with LangVersion directly because there are several factors that impact its "effective" value on a project when run in tooling.
- Updated the `LinePragma` code generation to include `#nullable restore` and `#nullable disable` lines to allow for project restored nullability state for user code.
- Added a new `RazorProjectEngineBuilderExtensions` class that adds Roslyn specific project engine modifications. In this case it allows us to set the C# language version for a project engine and configure underlying features accordingly.
- Added a `SuppressNullabilityEnforcement` flag that only turns on if C# < 8 is specified.
- Updated LiveShare, VS4Mac and RazorGenerate to understand CSharpLanguageVersion.
- Added a single test output to show the change.
#5092
2019-03-25 20:26:36 -07:00
e9ff3dcec3
Remove manual component detection
...
- aspnet/AspNetCore-Internal#2067
- now done automatically
2019-03-24 20:19:23 -07:00
f7a9567150
Merge pull request #358 from aspnet/eilon/license
...
Fix license
2019-03-24 20:02:22 -07:00
8146264bdb
[master] Update dependencies from dotnet/core-setup and aspnet/Extensions ( #360 )
...
* Update dependencies from https://github.com/dotnet/core-setup build 20190322.10
- Microsoft.NETCore.App - 3.0.0-preview4-27522-10
Dependency coherency updates
- Microsoft.Extensions.DependencyModel - 3.0.0-preview4-27522-10 (parent: Microsoft.NETCore.App)
* Update Extensions packages to version 3.0.0-preview4.19173.1 from build 20190323.1
2019-03-23 21:19:12 -07:00
da168188b4
Add .razor files to UpToDateCheckInput ( #359 )
...
Fixes https://github.com/aspnet/AspNetCore/issues/8181
2019-03-23 14:05:21 -07:00
738f395703
Fix license
2019-03-22 16:39:16 -07:00
26c03424ea
Move to BYOC queues
...
- aspnet/AspNetCore-Internal#2033
- also use recommended internal macOS queue when appropriate
- no change needed for Linux builds
- leave main build alone for now; needs more VS components
2019-03-22 14:26:58 -07:00
b7392f1f84
Fixed generic components with fully qualified names ( #356 )
2019-03-22 14:22:12 -07:00
343f37748e
Support importing components with @using directives ( #276 )
...
* Support importing components with @using directives
* Suppress taghelper directive completion in component documents
* feedback
* More feedback
* Update tests
* Update CodeAnalysis.Razor tests
* Flow filekind
* Changes
* More code gen tests
* More tests
* fix
* Added more tests
* Made stuff internal
* Filter out temporary tag helper descriptors
* update
* Do the needful
2019-03-22 10:29:38 -07:00
14704054f2
Add support for _Imports.razor ( #354 )
...
* Added support _Imports.razor
* Feedback
2019-03-22 09:19:56 -07:00
30562e7a4e
[master] Update dependencies from dotnet/core-setupaspnet/Extensions ( #355 )
...
* Update dependencies from https://github.com/dotnet/core-setup build 20190322.01
- Microsoft.NETCore.App - 3.0.0-preview4-27522-01
Dependency coherency updates
- System.Diagnostics.DiagnosticSource - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App)
- System.Text.Encodings.Web - 4.6.0-preview4.19164.7 (parent: Microsoft.NETCore.App)
- Microsoft.Extensions.DependencyModel - 3.0.0-preview4-27522-01 (parent: Microsoft.NETCore.App)
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19164.7 (parent: Microsoft.NETCore.App)
* Update dependencies from https://github.com/aspnet/Extensions build 20190322.1
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview4.19172.1
- Microsoft.AspNetCore.Testing - 3.0.0-preview4.19172.1
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview4.19172.1
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview4.19172.1
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview4.19172.1
2019-03-22 08:10:07 -07:00
ca1e656f6b
Bring back errors for missing tags in component documents ( #351 )
2019-03-21 12:22:28 -07:00
e2b1df744e
Allow some warnings ( #353 )
...
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/2050
2019-03-21 12:10:16 -07:00
84bc53671f
Do not restore as part of test ( #350 )
2019-03-21 09:28:44 -07:00
5ffd84e56d
Allow markup in local functions and @functions.
...
- Allow markup to exist in all code blocks. Prior to this change whenever we'd see nested curly braces we would do dumb brace matching to skip over any potentially risky code; now we treat every curly brace as an opportunity to intermingle Markup.
- One fix I had to introduce was now that functions blocks are parsed like `@{}` blocks I ran into cases where certain reserved keywords would get improperly parsed. This exposed a bug in our parsing where we’d treat **class** and **namespace** as directives without a transition in a `@{}` block. For instance this:
```
@{
class
}
```
would barf in the old parser by treating the `class` piece as a directive even though it did not have a transition. To account for this I changed our reserved directives to be parsed as directives instead of keywords (it's how they should have been parsed anyhow). This isn't a breaking change because the directive parsing logic is a subset of how keywords get parsed.
- One quirk this change introduces is a difference in behavior in regards to one error case. Before this change if you were to have `@if (foo)) { var bar = foo; }` the entire statement would be classified as C# and you'd get a C# error on the trailing `)`. With my changes we try to keep group statements together more closely and allow for HTML in unexpected or end of statement scenarios. So, with these new changes the above example would only have `@if (foo))` classified as C# and the rest as markup because the original was invalid.
- Added lots of tests,
- Modified the feature flag to maintain the old behavior when disabled.
aspnet/AspNetCore#5110
2019-03-20 10:38:50 -07:00
9b2b32e27a
Fix core-setup URI
2019-03-20 09:41:46 -07:00
cfee40a19e
Infer Razor Configuration \ RazorLangVersion based on TFM ( #343 )
...
* Infer Razor Configuration \ RazorLangVersion based on TFM
Fixes https://github.com/aspnet/AspNetCore/issues/6392
2019-03-19 16:33:26 -07:00
491aae2dfa
Flow relative path when creating RSD in DocumentState ( #348 )
2019-03-19 15:17:45 -07:00
25fe68e2bc
Manually (and coherently) update dependencies from core-setup and Extensions
2019-03-18 12:25:05 -07:00
08651acc42
Manually update dependencies from CoreFx, core-setup and Extensions
...
- previous update was incoherent and not caught until we reached aspnet/AspNetCore
- upgrades core-setup and Extensions dependencies but downgrades CoreFx to achieve coherency
2019-03-17 19:25:01 -07:00
595f18e2ea
[master] Update dependencies from dotnet/core-setup and aspnet/Extensions ( #339 )
...
* Update dependencies from https://github.com/dotnet/core-setup build 20190316.06
This change updates the following dependencies
- Microsoft.Extensions.DependencyModel - 3.0.0-preview4-27516-06
- Microsoft.NETCore.App - 3.0.0-preview4-27516-06
* Update dependencies from https://github.com/aspnet/Extensions build 20190316.1
This change updates the following dependencies
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview4.19166.1
- Microsoft.AspNetCore.Testing - 3.0.0-preview4.19166.1
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview4.19166.1
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview4.19166.1
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview4.19166.1
2019-03-17 15:33:05 -07:00
283e574a6d
Missed change ( #337 )
2019-03-16 14:41:11 -07:00
b8a26a76cb
[master] Update dependencies from 3 repositories ( #338 )
...
* Update dependencies from https://github.com/dotnet/corefx build 20190314.7
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19164.7
- System.Text.Encodings.Web - 4.6.0-preview4.19164.7
- System.Diagnostics.DiagnosticSource - 4.6.0-preview4.19164.7
* Update dependencies from https://github.com/dotnet/core-setup build 20190315.05
This change updates the following dependencies
- Microsoft.Extensions.DependencyModel - 3.0.0-preview4-27515-05
- Microsoft.NETCore.App - 3.0.0-preview4-27515-05
* Update dependencies from https://github.com/aspnet/Extensions build 20190314.7
This change updates the following dependencies
- Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview4.19164.7
- Microsoft.AspNetCore.Testing - 3.0.0-preview4.19164.7
- Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview4.19164.7
- Microsoft.Extensions.NonCapturingTimer.Sources - 3.0.0-preview4.19164.7
- Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview4.19164.7
2019-03-16 11:48:06 -07:00
f7e10ccacb
Don't reference FilePathComparison in RazorDirectiveCompletionProvider ( #335 )
2019-03-15 15:53:56 -07:00
057d4f3570
Flow RootNamespace from MSBuild ( #331 )
...
- Flow Root namespace through in command line builds
- Flow Root namespace through in design time builds
- Feedback
2019-03-13 14:18:07 -07:00
8005745f6a
[master] Update dependencies from dotnet/corefxdotnet/core-setup ( #328 )
...
* Update dependencies from https://github.com/dotnet/corefx build 20190312.12
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19162.12
- System.Text.Encodings.Web - 4.6.0-preview4.19162.12
- System.Diagnostics.DiagnosticSource - 4.6.0-preview4.19162.12
* Update dependencies from https://github.com/dotnet/core-setup build 20190312.18
This change updates the following dependencies
- Microsoft.Extensions.DependencyModel - 3.0.0-preview4-27512-18
- Microsoft.NETCore.App - 3.0.0-preview4-27512-18
2019-03-13 07:34:46 -07:00
e262de05ce
Update dependencies from https://github.com/dotnet/arcade build 20190312.7
...
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19162.7
2019-03-13 07:34:02 -07:00
N. Taylor Mullen
Pranav K
Ryan Nowak
dotnet-maestro
dotnet-maestro[bot]
Ajay Bhargav Baaskaran
Steve Sanderson
Doug Bunting
Eilon Lipton
Javier Calvarro Nelson
Doug Bunting