Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.24059.4 -> To Version 8.0.0-beta.24060.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* [ClickOnce] Handle multiple apphost.exe files that could be published with an EXE to EXE P2P dependency
* Bump version
---------
Co-authored-by: Ladi Prosek <laprosek@microsoft.com>
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 8840417 (#9566)
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 8840161
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 8840161
* Update dependencies from https://github.com/dotnet/arcade build 20231220.2 (#9574)
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23580.1 -> To Version 8.0.0-beta.23620.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* [vs17.9] Update dependencies from nuget/nuget.client dotnet/roslyn (#9575)
* Update dependencies from https://github.com/nuget/nuget.client build 6.9.0.67
NuGet.Build.Tasks
From Version 6.9.0-preview.1.64 -> To Version 6.9.0-preview.1.67
* Update dependencies from https://github.com/dotnet/roslyn build 20231221.4
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-3.23615.7 -> To Version 4.9.0-3.23621.4
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* [vs17.9] Update dependencies from nuget/nuget.client dotnet/roslyn (#9580)
* Update dependencies from https://github.com/nuget/nuget.client build 6.9.0.70
NuGet.Build.Tasks
From Version 6.9.0-preview.1.67 -> To Version 6.9.0-preview.1.70
* Update dependencies from https://github.com/dotnet/roslyn build 20231229.3
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-3.23621.4 -> To Version 4.9.0-3.23629.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
---------
Co-authored-by: dotnet bot <dotnet-bot@dotnetfoundation.org>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com>
* Update dependencies from https://github.com/nuget/nuget.client build 6.9.0.70
NuGet.Build.Tasks
From Version 6.9.0-preview.1.67 -> To Version 6.9.0-preview.1.70
* Update dependencies from https://github.com/dotnet/roslyn build 20231229.3
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-3.23621.4 -> To Version 4.9.0-3.23629.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/nuget/nuget.client build 6.9.0.67
NuGet.Build.Tasks
From Version 6.9.0-preview.1.64 -> To Version 6.9.0-preview.1.67
* Update dependencies from https://github.com/dotnet/roslyn build 20231221.4
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-3.23615.7 -> To Version 4.9.0-3.23621.4
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23580.1 -> To Version 8.0.0-beta.23620.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/nuget/nuget.client build 6.9.0.64
NuGet.Build.Tasks
From Version 6.9.0-preview.1.50 -> To Version 6.9.0-preview.1.64
* Update dependencies from https://github.com/dotnet/roslyn build 20231215.7
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-3.23608.9 -> To Version 4.9.0-3.23615.7
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/arcade build 20231130.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 8.0.0-beta.23580.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23475.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Bump minimum MSBuild and xcopy version for post-build
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
* Update dependencies from https://github.com/nuget/nuget.client build 6.9.0.50
NuGet.Build.Tasks
From Version 6.9.0-preview.1.45 -> To Version 6.9.0-preview.1.50
* Update dependencies from https://github.com/dotnet/roslyn build 20231208.9
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-3.23602.1 -> To Version 4.9.0-3.23608.9
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Update Microsoft.BuildXL.Processes
The primary motivation behind this update is to bring in a bug fix related to the BuildXL.Process assembly depending on BuildXL.Tracing, which is not available in the package.
This change also adjusts a breaking change to ChildProcessesToBreakawayFromSandbox, as well as added some extra logic associated with the reason behind the breaking change which supports dotnet scenarios better. This is just future-proofing though since reporting file accesses via detours is currently only available in MSBuild.exe.
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-2.23575.1 -> To Version 4.9.0-3.23602.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1922736
Context
CredentialScanner detected .\src\Tasks.UnitTests\TestResources\mycert.pfx that had certificate keys. Since it's legitimate unit test PFX file, this is false positive.
Changes Made
Suppress the CredScan error from the UT PFX file.
Testing
Verified the run with this experimental branch. The CredScan error was eliminated.
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20231125.1
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-2.23567.2 -> To Version 4.9.0-2.23575.1
* Update dependencies from https://github.com/nuget/nuget.client build 6.9.0.45
NuGet.Build.Tasks
From Version 6.9.0-preview.1.36 -> To Version 6.9.0-preview.1.45
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20231117.2
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-2.23562.2 -> To Version 4.9.0-2.23567.2
* Update dependencies from https://github.com/nuget/nuget.client build 6.9.0.36
NuGet.Build.Tasks
From Version 6.9.0-preview.1.23 -> To Version 6.9.0-preview.1.36
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231115.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23556.3 -> To Version 8.0.0-alpha.1.23565.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231115.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23556.3 -> To Version 8.0.0-alpha.1.23565.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231115.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23556.3 -> To Version 8.0.0-alpha.1.23565.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231115.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23556.3 -> To Version 8.0.0-alpha.1.23565.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
In the switch to Central Package Management (#8317), I missed that
PrivateAssets doesn't apply to PackageVersion items, which caused us to
have an extraneous dependency from some of our packages to
`Microsoft.VisualStudio.Setup.Configuration.Interop` for 17.6, 17.7, and
17.8.
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-2.23556.1 -> To Version 4.9.0-2.23562.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23516.4 -> To Version 8.0.0-alpha.1.23556.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20231106.1
Microsoft.Net.Compilers.Toolset
From Version 4.9.0-1.23527.10 -> To Version 4.9.0-2.23556.1
* Update dependencies from https://github.com/nuget/nuget.client build 6.9.0.23
NuGet.Build.Tasks
From Version 6.9.0-preview.1.22 -> To Version 6.9.0-preview.1.23
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Find and replace `\s+$` in `{*.cs,*.props,*.targets}`, then reverted
`src/Build.OM.UnitTests/Construction/WhiteSpacePreservation_Tests.cs`
since it was explicitly working with whitespace.
* Update dependencies from https://github.com/dotnet/roslyn build 20231018.7
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23510.8 -> To Version 4.8.0-3.23518.7
* Update dependencies from https://github.com/dotnet/roslyn build 20231024.11
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23510.8 -> To Version 4.8.0-3.23524.11
* Update dependencies from https://github.com/nuget/nuget.client build 6.9.0.22
NuGet.Build.Tasks
From Version 6.8.0-rc.122 -> To Version 6.9.0-preview.1.22
* Update dependencies from https://github.com/dotnet/roslyn build 20231027.10
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23510.8 -> To Version 4.9.0-1.23527.10
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Suppress package-compat warnings related to #9330.
Co-authored-by: Mariana Dematte <magarces@microsoft.com>
Co-authored-by: Gang Wang <v-gaw@microsoft.com>
* Update dependencies from https://github.com/dotnet/arcade build 20231016.4
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23463.1 -> To Version 8.0.0-beta.23516.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23475.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Revert the dotnet version
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231016.4
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23475.1 -> To Version 8.0.0-alpha.1.23516.4
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23504.4 -> To Version 4.8.0-3.23510.8
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23501.1 -> To Version 4.8.0-3.23504.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20230924.3
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-3.23465.5 -> To Version 4.8.0-3.23474.3
* Update dependencies from https://github.com/nuget/nuget.client build 6.8.0.117
NuGet.Build.Tasks
From Version 6.8.0-rc.112 -> To Version 6.8.0-rc.117
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20230901.4
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23451.4
* Update dependencies from https://github.com/nuget/nuget.client build 6.8.0.90
NuGet.Build.Tasks
From Version 6.8.0-preview.1.82 -> To Version 6.8.0-preview.1.90
* Update dependencies from https://github.com/dotnet/roslyn build 20230909.2
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23459.2
* Update dependencies from https://github.com/nuget/nuget.client build 6.8.0.110
NuGet.Build.Tasks
From Version 6.8.0-preview.1.82 -> To Version 6.8.0-rc.110
* Update Newtonsoft.Json from 13.0.2 to 13.0.3
* Update dependencies from https://github.com/dotnet/roslyn build 20230915.5
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-2.23426.1 -> To Version 4.8.0-3.23465.5
* Update dependencies from https://github.com/nuget/nuget.client build 6.8.0.112
NuGet.Build.Tasks
From Version 6.8.0-preview.1.82 -> To Version 6.8.0-rc.112
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
* Revert "Ship BuildXL assemblies in our VSIX and not our NuGet packages (#9185)"
This reverts commit 0974273375.
* Revert "Merge pull request #8726 from dfederm/project-cache-vnext"
This reverts commit 462a9175d2, reversing
changes made to 5958b59b3e.
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23424.1 -> To Version 8.0.0-alpha.1.23428.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Ship BuildXL assemblies in our VSIX
* Specify 3rd-party cert for 3rd-party file
* Remove BuildXL NuGet dependencies
Because BuildXL is not pushed to nuget.org, it's an inconvenient
dependency. But it's not required for API completion so mark it
as a private dependency--it can be satisified by the VS install.
This change add "cache add" functionality to project caching.
Today project caching exposes a hook to plugins for "I'm about to build this thing, do you want to take over instead?" and that's it. This change adds a few more hooks which report file accesses and processes (via Detours) and also for when a project finishes building. This allows a plugin to collect the file accesses and add entries to the cache for future replayability.
* Update dependencies from https://github.com/dotnet/roslyn build 20230826.1
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23419.1 -> To Version 4.8.0-2.23426.1
* Update dependencies from https://github.com/nuget/nuget.client build 6.8.0.82
NuGet.Build.Tasks
From Version 6.8.0-preview.1.69 -> To Version 6.8.0-preview.1.82
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23419.1 -> To Version 8.0.0-beta.23425.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23418.1 -> To Version 1.0.0-beta.23423.1 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This fixes a portion of the assemblies described in https://github.com/dotnet/source-build/issues/3599 that are showing up as reference assemblies in the source-built SDK. The reason they're showing up as ref assemblies is the same reason that's described in https://github.com/dotnet/msbuild/pull/9158, which is a related issue.
It's not known whether the existence of these ref assemblies causes a functional issue as it does with https://github.com/dotnet/msbuild/pull/9158. But we do know that the source-built 7.0 SDK doesn't define these as ref assemblies but rather implementation assemblies. So to maintain parity with 7.0 and avoid potential risk, it's best to ensure these are represented as implementation assemblies in the output.
These are the assemblies that are fixed by these changes:
* System.CodeDom
* System.Resources.Extensions
* System.Security.Cryptography.Xml
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23421.1 -> To Version 8.0.0-alpha.1.23424.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
When .NET is source-built with the mono runtime, there can be scenarios where MSBuild is made to attempt to load a reference assembly for System.Security.Permissions. See dotnet/source-build#3571 (comment) for such a scenario.
The reason a reference assembly exists in this case is because MSBuild has a reference to the 7.0.0 version of System.Security.Permissions. When building with source-build, it loads that reference from SBRP (which only contains reference assemblies) in order to fulfill compile time references. The problem is that the assembly is also getting included in the output. This should have been detected by poison leak detection but that doesn't yet handle reference assemblies.
The solution is to update Version.Details so that the "live" version of System.Security.Permissions, that was previously built with source-build, will flow to the build of the MSBuild repo. Essentially, this causes the SystemSecurityPermissionsVersion property to be overridden with the live version.
Fixesdotnet/source-build#3571
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23414.1 -> To Version 8.0.0-alpha.1.23421.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23419.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23418.1 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20230819.1
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23412.1 -> To Version 4.8.0-1.23419.1
* Update dependencies from https://github.com/nuget/nuget.client build 6.8.0.69
NuGet.Build.Tasks
From Version 6.8.0-preview.1.60 -> To Version 6.8.0-preview.1.69
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23408.2 -> To Version 8.0.0-alpha.1.23414.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/arcade build 20230811.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23404.2 -> To Version 8.0.0-beta.23411.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23381.1 -> To Version 1.0.0-beta.23408.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Remove unnecessary APICompat suppression
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <v-gaw@microsoft.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20230812.1
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23406.1 -> To Version 4.8.0-1.23412.1
* Update dependencies from https://github.com/nuget/nuget.client build 6.8.0.60
NuGet.Build.Tasks
From Version 6.8.0-preview.1.56 -> To Version 6.8.0-preview.1.60
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23407.1 -> To Version 8.0.0-alpha.1.23408.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Fix to properly serialize TargetFinishedEventArgs.TargetOutput
* New extended EventArgs for custom events data
* Make ExternalProject*EventArgs serialize without BinaryFormatter
* Issue warnings only on dotnetcore runtime.
* Make deser constructors internal
---------
Co-authored-by: YuliiaKovalova <ykovalova@microsoft.com>
Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23381.3 -> To Version 8.0.0-alpha.1.23407.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23378.2 -> To Version 8.0.0-beta.23404.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23374.1 -> To Version 1.0.0-beta.23381.1 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20230806.1
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23378.8 -> To Version 4.8.0-1.23406.1
* Update dependencies from https://github.com/nuget/nuget.client build 6.8.0.56
NuGet.Build.Tasks
From Version 6.8.0-preview.1.44 -> To Version 6.8.0-preview.1.56
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Fix an merge error in GenerateResource.NothingOutOfDate
Avoid the complex state in WriteLines when Lines are empty. /question just always returns true. Add a test.
Add Tracker to bootstrap, makes dogfooding C++ easier.
Add SkipUnchangedFiles to avoid extra copy.
* Dev/yuehuang/main rar (#1)
* Add Question switch to stop the build when targets are not incremental.
* Add question property to tasks.
* Add tests
* Clean up IIncrementalTask interface.
* Add additional tasks.
* Test and Question on this repro.
* fix build
* Fix question in -m. Fix BindingRedirect to target incremental.
* Fix tests for Linux.
* WIP
* Fix feedbacks
* .
* Revert condition.
* fix feedback.
* touch to rerun.
* Fix merge.
* Fix merge pt2
* Fix merge p3
* Fix fileState when it couldn't resolve some files.
* Fix merge
* Address feedbacks
* Fix test.
* Clean up.
* WIP
* Fix Feedback
* Fix Feedback.
* Update tests
* Address some feedbacks.
* Fix merge conflict
* .
* Improve the messaging for ResGen in question mode.
* Fix Style
* Revert GenerateResource into separate PR.
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230615.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23315.1
* Remove clashing reference
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230616.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23316.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230619.4
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23319.4
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230619.4
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23319.4
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230623.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23323.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230626.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23326.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230628.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23328.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230629.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23329.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230630.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23330.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230705.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23355.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230706.4
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23356.4
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230710.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23360.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230711.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23361.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230712.3
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23362.3
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230712.3
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23362.3
Dependency coherency updates
Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks
From Version 1.1.0-beta-21480-02 -> To Version 8.0.0-beta.23211.2 (parent: Microsoft.DotNet.Arcade.Sdk
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230718.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23368.2
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230721.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23371.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230724.3
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23368.2 -> To Version 8.0.0-alpha.1.23374.3
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230728.3
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23368.2 -> To Version 8.0.0-alpha.1.23378.3
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230731.3
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23368.2 -> To Version 8.0.0-alpha.1.23381.3
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com>
Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20230728.8
Microsoft.Net.Compilers.Toolset
From Version 4.8.0-1.23372.1 -> To Version 4.8.0-1.23378.8
* Update dependencies from https://github.com/nuget/nuget.client build 6.8.0.44
NuGet.Build.Tasks
From Version 6.8.0-preview.1.41 -> To Version 6.8.0-preview.1.44
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23371.1 -> To Version 8.0.0-beta.23378.2
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23368.1 -> To Version 1.0.0-beta.23374.1 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/arcade build 20230721.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23213.1 -> To Version 8.0.0-beta.23371.1
Dependency coherency updates
Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks
From Version 8.0.0-beta.23211.2 -> To Version 8.0.0-beta.23361.2 (parent: Microsoft.DotNet.Arcade.Sdk
* Update NuGet.config
* Update dependencies from https://github.com/dotnet/arcade build 20230721.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23364.2 -> To Version 8.0.0-beta.23371.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23360.1 -> To Version 1.0.0-beta.23368.1 (parent: Microsoft.DotNet.Arcade.Sdk
* Update Nuget
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
* Disable IDE0005
To be correctly enabled, this requires documentation files, which are disabled in our repo at the moment.
* Update dependencies from https://github.com/dotnet/arcade build 20230714.2
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.23213.1 -> To Version 8.0.0-beta.23364.2
Dependency coherency updates
Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks
From Version 1.1.0-beta-21480-02 -> To Version 8.0.0-beta.23361.2 (parent: Microsoft.DotNet.Arcade.Sdk
* Remove explicit xunit.core and xunit.assert package reference because they are referenced implicitly
* Remove the attributes in Xunit.NetCore.Extensions which are included in Microsoft.DotNet.XUnitExtensions
* Mark obsolete legacy serialization support APIs using the SYSLIB0051 diagnostic code and suppress SYSLIB0050 warning
* Replace Assert.Same with Assert.Equal
* Work around deprecated Serialization/Deserialization of BinaryFormatter
* Use default source-build job template
* Update dependencies from https://github.com/dotnet/roslyn build 20230718.11
Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23361.9 -> To Version 4.8.0-1.23368.11
* Update dependencies from https://github.com/nuget/nuget.client build 6.8.0.35
NuGet.Build.Tasks
From Version 6.7.0-rc.111 -> To Version 6.8.0-preview.1.35
* Update sourcebuild baselines for Arcade + SDK 8
* Minimize STJ reference
* Suppress CP1002
I think this is being fired because the old package targets net7 and the new one targets net8, causing it to fail to load the old reference. We don't have the references available easily to use PackageValidationReferencePath, so suppressing it.
* Revert PackageVersion of xunit.console back to eng/Package.props and comment on PackageVersion of xunit.core in individual project
* Further simplify xunit ref in extensions library
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
Co-authored-by: Gang Wang <v-gaw@microsoft.com>
Co-authored-by: Michael Simons <msimons@microsoft.com>
Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23329.1 -> To Version 4.7.0-3.23361.9
Dependency coherency updates
Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks
From Version 1.1.0-beta-21480-02 -> To Version 8.0.0-beta.23211.2 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Make IDE0251 a suggestion
It fires in some very funky places like Dispose methods
where it's not _wrong_ but it would be _weird_.
* Put expected and actual in the right places for some tlbimp tests
* Explicit System.IO.Compression reference on framework
* Suppress the error PKV006 for Net 7.0, since we're intentionally dropping it
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
Co-authored-by: Gang Wang <v-gaw@microsoft.com>
I copy/pasted a sample usage of WriteOnlyWhenDifferent--the one with
the casing `True`, which sparked a discussion over what
MSBuild style should be. It should be lowercase.
Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23324.1 -> To Version 4.7.0-3.23329.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
NuGet.Build.Tasks
From Version 6.7.0-rc.106 -> To Version 6.7.0-rc.111
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23318.1 -> To Version 4.7.0-3.23324.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
Microsoft.Net.Compilers.Toolset
From Version 4.7.0-3.23311.1 -> To Version 4.7.0-3.23318.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn
Subscription: 848bf81b-14ec-482f-6736-08da008bd46a
Build: 20230611.1
Date Produced: June 12, 2023 5:51:35 AM UTC
Commit: 4cbfec964e59687cd9cc8601df42b936c9c06f63
Branch: refs/heads/main
Updates:
Microsoft.Net.Compilers.Toolset: from 4.7.0-3.23303.1 to 4.7.0-3.23311.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Contributes to https://github.com/dotnet/source-build/issues/3043
Declaring the `System.Configuration.ConfigurationManager` dependency in `Version.Details.xml` will allow source-build to replace the currently used `7.0.0` version with the `n-1` version coming from previously source-built artifacts in the product / VMR build.
Without this change, once repo PvP is enabled, the source-build of `msbuild` will fail in the product build.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Subscription: fc4faec0-9ee6-43b9-bc7a-08da8607f4c7
Build: 20230601.1
Date Produced: June 1, 2023 4:37:15 PM UTC
Commit: 2b9ccd49bbcca2156e229b00a140a8a018baac58
Branch: refs/heads/release/6.0
Updates:
Microsoft.DotNet.Arcade.Sdk: from 6.0.0-beta.23254.1 to 6.0.0-beta.23301.1
Microsoft.DotNet.XUnitExtensions: from 6.0.0-beta.23254.1 to 6.0.0-beta.23301.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Context
Contributes to dotnet/source-build#3435
Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter SourceBuild* files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))
Changes Made
added comments to source-build files asking for the inclusion of the source-build team in PRs that alter SourceBuild* file.
Microsoft.Net.Compilers.Toolset
From Version 4.7.0-2.23276.4 -> To Version 4.7.0-3.23303.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
NuGet.Build.Tasks
From Version 6.7.0-preview.2.50 -> To Version 6.7.0-preview.2.51
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This pull request updates the following dependencies
From https://github.com/nuget/nuget.client
Subscription: 3fe128a9-5a85-4aba-f7ba-08da008becb5
Build: 6.7.0.50
Date Produced: May 24, 2023 7:19:58 PM UTC
Commit: a6fff16af6f44927a83851448a99beb1d2801600
Branch: dev
Updates:
NuGet.Build.Tasks: from 6.7.0-preview.2.47 to 6.7.0-preview.2.50
Microsoft.Net.Compilers.Toolset
From Version 4.7.0-2.23271.1 -> To Version 4.7.0-2.23276.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20230521.1
Microsoft.Net.Compilers.Toolset
From Version 4.6.0-2.23171.5 -> To Version 4.7.0-2.23271.1
---------
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
NuGet.Build.Tasks
From Version 6.7.0-preview.2.41 -> To Version 6.7.0-preview.2.47
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 6.0.0-beta.23221.7 -> To Version 6.0.0-beta.23254.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
NuGet.Build.Tasks
From Version 6.7.0-preview.2.33 -> To Version 6.7.0-preview.2.41
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Remove MockTerminal in favor of internal fields on Terminal itself.
* Reference Verify library for acceptance testing.
* Convert existing tests to Verify.
NuGet.Build.Tasks
From Version 6.7.0-preview.1.20 -> To Version 6.7.0-preview.2.33
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/nuget/nuget.client build 6.7.0.19
NuGet.Build.Tasks
From Version 6.7.0-preview.1.16 -> To Version 6.7.0-preview.1.19
* Update dependencies from https://github.com/nuget/nuget.client build 6.7.0.20
NuGet.Build.Tasks
From Version 6.7.0-preview.1.16 -> To Version 6.7.0-preview.1.20
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Subscription: fc4faec0-9ee6-43b9-bc7a-08da8607f4c7
Build: 20230421.7
Date Produced: April 21, 2023 7:07:19 PM UTC
Commit: 3d9c9a4d3d893e903bb3295fd5b55b8e40699888
Branch: refs/heads/release/6.0
Updates:
Microsoft.DotNet.Arcade.Sdk: from 6.0.0-beta.23167.1 to 6.0.0-beta.23221.7
Microsoft.DotNet.XUnitExtensions: from 6.0.0-beta.23167.1 to 6.0.0-beta.23221.7
NuGet.Build.Tasks
From Version 6.5.0-rc.149 -> To Version 6.7.0-preview.1.16
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Forgind <12969783+Forgind@users.noreply.github.com>
Context
MSBuild had been added to the code validation pipeline but was missing the tsa config file. Per the instructions here and after talking to Matt, adding this file
Changes Made
Added a tsa config file by copying from SDK
Testing
Not sure how to test this. I pushed an internal build but the checks didn't run as I'm told they run nightly in a separate pipeline.
Notes
Validation pipeline: https://dev.azure.com/dnceng/internal/_build/results?buildId=2157183&view=results
* Enable prebuilt detection
- Baseline a 7.0 dependencies until msbuild targets net8.0 and uses an 8.0 arcade and an arcade fix comes in
- Add SBRP dependencies (with subscription) and source build tags
System.Security.Principal.Windows is inbox since net6.0
System.Net.Http is inbox since netcoreapp2.0
System.Reflection.Metadata is inbox since netcoreapp2.0
System.Threading.Tasks.Dataflow is inbox since netcoreapp2.0
Remove System.Net.Http package references which aren't needed as they underlying assembly is inbox on both .NETFramework and .NETCoreApp.
By avoiding the dependencies, we minimize the dependency graph and with that the attack surface.
cc @MichaelSimons (removes netstandard1.x dependencies)
Today the bootstrap doesn't have `NuGet.RestoreEx.targets` (or `NuGet.Build.Tasks.Console.exe` even), so it falls back to the "regular" restore. This change brings in those bits via the `NuGet.Build.Tasks.Console` package.
This PR adds "question" switch to msbuild.exe that will error out if a target or a task fails incremental check. Targets will fail if both Inputs and Outputs are present and not skip. Tasks changes are individually modified to support the interface IIncrementalTask, which sets the question boolean. Each task will need to be updated this interface take part.
I have started with the following tasks and fixed some of the issues within MSBuild enlistment. And there are more, see the notes below. Tasks updated: ToolTask, Copy, MakeDir, Touch, WriteLinesTofile, RemoveDir, DownloadFile, Move, ZipDirectory, Unzip, GenerateResource, GenerateBindingRedirects.
Using question investigate incremental issues is orders of magnitude easier. Reading the logs is simpler and repros are more consistent. In this PR, it includes a few fixes to the common targets which address some issues.
Fixes#7348
Microsoft.Net.Compilers.Toolset
From Version 4.6.0-2.23166.9 -> To Version 4.6.0-2.23171.5
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Update dependencies from https://github.com/dotnet/arcade build 20230221.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 6.0.0-beta.23114.5 -> To Version 6.0.0-beta.23121.1
Microsoft.Net.Compilers.Toolset
From Version 4.6.0-2.23152.6 -> To Version 4.6.0-2.23166.9
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.Net.Compilers.Toolset
From Version 4.6.0-2.23126.2 -> To Version 4.6.0-2.23152.6
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.Net.Compilers.Toolset
From Version 4.6.0-1.23109.10 -> To Version 4.6.0-2.23126.2
From https://github.com/dotnet/roslyn
Subscription: 848bf81b-14ec-482f-6736-08da008bd46a
Build: 20230226.2
Date Produced: February 26, 2023 12:50:36 PM UTC
Commit: 4641f2bff815fb7743be8aa2bdafe82b74a1f756
Branch: refs/heads/main
Updates:
Microsoft.Net.Compilers.Toolset: from 4.6.0-1.23109.10 to 4.6.0-2.23126.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 6.0.0-beta.23073.7 -> To Version 6.0.0-beta.23114.5
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn
Subscription: 848bf81b-14ec-482f-6736-08da008bd46a
Build: 20230209.10
Date Produced: February 10, 2023 1:44:22 AM UTC
Commit: 73338d92270b9f26982eca2e8872037a0214b912
Branch: refs/heads/release/dev17.6
Updates:
Microsoft.Net.Compilers.Toolset: from 4.5.0-6.23101.20 to 4.6.0-1.23109.10
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Bumps Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.3 to 3.3.4.
Release notes
Sourced from Microsoft.CodeAnalysis.BannedApiAnalyzers's releases.
v3.3.4
Release build of Roslyn-analyzers based on Microsoft.CodeAnalysis 3.3.1 NuGet packages. Works with VS 2019 16.9 or later.
Contains important functionality and performance bug fixes on top of v3.3.3 release
Commits
22ea642 Merge pull request #6436 from ViktorHofer/patch-1
9018071 Fix buildtransitive vs buildTransitive difference
afa5665 [main] Update dependencies from dotnet/arcade (#6423)
afee469 Merge pull request #6427 from mavasani/CodeAnalysisTreatWarningsAsErrors_Glob...
b858999 Merge pull request #6430 from dotnet/locfiles/be3abf9f-1f22-469b-b26d-7648587...
0cbc3c5 Localized file check-in by OneLocBuild Task: Build definition ID 830: Build I...
113dadc Merge pull request #6429 from dotnet/revert-6364-net7-tests
356147f Revert "Move tests to target .NET 7"
1d7244a Update documentation for CodeAnalysisTreatWarningsAsErrors implementation
6c028d3 Re-implement CodeAnalysisTreatWarningsAsErrors with globalconfig files
Additional commits viewable in compare view
From https://github.com/dotnet/roslyn
Subscription: 848bf81b-14ec-482f-6736-08da008bd46a
Build: 20230201.20
Date Produced: February 2, 2023 5:54:27 AM UTC
Commit: 6dad5961f644841633aad59a70ea01fb580a7b12
Branch: refs/heads/release/dev17.5-vs-deps
Updates:
Microsoft.Net.Compilers.Toolset: from 4.5.0-3.23062.15 to 4.5.0-6.23101.20
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Subscription: fc4faec0-9ee6-43b9-bc7a-08da8607f4c7
Build: 20230123.7
Date Produced: January 23, 2023 9:41:46 PM UTC
Commit: 05a8ec6db75694246db7a7b9ab680c9be91bf1d6
Branch: refs/heads/release/6.0
Updates:
Microsoft.DotNet.Arcade.Sdk: from 6.0.0-beta.23060.6 to 6.0.0-beta.23073.7
Microsoft.DotNet.XUnitExtensions: from 6.0.0-beta.23060.6 to 6.0.0-beta.23073.7
This pull request updates the following dependencies
From https://github.com/nuget/nuget.client
Subscription: 3fe128a9-5a85-4aba-f7ba-08da008becb5
Build: 6.5.0.149
Date Produced: January 20, 2023 9:44:54 PM UTC
Commit: ca5029046d7b6e55f322c45abb7b342054543710
Branch: release-6.5.x
Updates:
NuGet.Build.Tasks: from 6.5.0-preview.3.136 to 6.5.0-rc.149
* added IDE code style checks as warning, set the currently violated rules to suggestion
* auto-fixed IDE0011 - add braces to statement
* auto-fixed IDE0036 - Modifiers are not ordered
* auto fixed IDE0040 - Accessibility modifiers required
* auto-fixed IDE0055 - fix formatting
* auto-fixed SA1110 and SA1111 - parenthesis formatting
manually fixed unresolvable cases
* auto-fixed IDE0073 - A source file contains a header that does not match the required text
* moved IDE rules to .editorconfig as they need to be filtered
* added IDE0020 - use pattern matching to be excluded
* extra disable format due to chunk of code conditioned for DEBUG only
* added comment in Version line to bypass the check
clarified CTA on how to bypass the error
* extra disable format due to chunk of code conditioned for DEBUG only
* net7 packages
* Bump version to try to avoid conflicts, get latest pushed
* Update pkgdef for S.Resources.Extensions
To match what we ship, 7.0.0.0 now.
This pull request updates the following dependencies
From https://github.com/nuget/nuget.client
Subscription: 3fe128a9-5a85-4aba-f7ba-08da008becb5
Build: 6.5.0.136
Date Produced: December 27, 2022 10:54:46 AM UTC
Commit: 743503cb3c7e9ced2602ee2e29c38d63cc339451
Branch: dev
Updates:
NuGet.Build.Tasks: from 6.5.0-preview.3.126 to 6.5.0-preview.3.136
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Subscription: fc4faec0-9ee6-43b9-bc7a-08da8607f4c7
Build: 20230110.6
Date Produced: January 10, 2023 8:51:11 PM UTC
Commit: 74b7648c106865057c78ca1e4b2ffcb5e9bce071
Branch: refs/heads/release/6.0
Updates:
Microsoft.DotNet.Arcade.Sdk: from 6.0.0-beta.22601.5 to 6.0.0-beta.23060.6
Microsoft.DotNet.XUnitExtensions: from 6.0.0-beta.22601.5 to 6.0.0-beta.23060.6
Fixes-ish #7903
Context
Our previous analyzer is not helpful due to #7903. This switches to using a more modern api analyzer.
Notes
The note that inspired this suggested including a version as well, but the documentation I found didn't mention a version.
* Update dependencies from https://github.com/dotnet/roslyn build 20221208.26
Microsoft.Net.Compilers.Toolset
From Version 4.4.0-2.22458.3 -> To Version 4.5.0-2.22608.26
* Un-ref InternableString.Simple
This triggered some C# compiler errors with newer versions of the
compiler:
```
S:\msbuild\src\StringTools\InternableString.Simple.cs(130,39): error CS8170: Struct members cannot return 'this' or other instance members by reference [S:\msbuild\src\StringTools\StringTools.csproj::TargetFramework=net35]
S:\msbuild\src\StringTools\InternableString.Simple.cs(130,20): error CS8347: Cannot use a result of 'InternableString.Enumerator.Enumerator(ref InternableString)' in this context because it may expose variables referenced by parameter 'spanBuilder' outside of their declaration scope [S:\msbuild\src\StringTools\StringTools.csproj::TargetFramework=net35]
```
Since this implementation is purely for the MSBuildTaskHost net35
compatibility case and self-describes as "inefficient", I think it's ok
to make it a regular non-ref struct.
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
This pull request updates the following dependencies
From https://github.com/nuget/nuget.client
Subscription: 3fe128a9-5a85-4aba-f7ba-08da008becb5
Build: 6.5.0.126
Date Produced: December 9, 2022 7:03:04 PM UTC
Commit: 31f2a1cb6fe3dababe67cdb84e9d6ddb9e3ace04
Branch: dev
Updates:
NuGet.Build.Tasks: from 6.5.0-preview.2.108 to 6.5.0-preview.3.126
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This fixes an exception when trying to use a locally built and bootstrapped msbuild, specifically in the NuGet SDK resolver:
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Extensions.FileProviders.Abstractions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' or one of its dependencies. The system cannot find the file specified.
File name: 'Microsoft.Extensions.FileProviders.Abstractions, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
at NuGet.Commands.ContentFileUtils.GetContentFileGroup(NuspecReader nuspec, List`1 contentFileGroups)
at NuGet.Commands.LockFileUtils.AddContentFiles(ManagedCodeConventions managedCodeConventions, LockFileTargetLibrary lockFileLib, NuGetFramework framework, ContentItemCollection contentItems, NuspecReader nuspec)
at NuGet.Commands.LockFileUtils.AddAssets(String aliases, LockFileLibrary library, LocalPackageInfo package, ManagedCodeConventions managedCodeConventions, LibraryIncludeFlags dependencyType, LockFileTargetLibrary lockFileLib, NuGetFramework framework, String runtimeIdentifier, ContentItemCollection contentItems, NuspecReader nuspec, IReadOnlyList`1 orderedCriteria)
at NuGet.Commands.LockFileUtils.<>c__DisplayClass2_0.<CreateLockFileTargetLibrary>b__0()
at System.Lazy`1.CreateValue()
at System.Lazy`1.LazyInitValue()
at NuGet.Commands.LockFileBuilder.CreateLockFile(LockFile previousLockFile, PackageSpec project, IEnumerable`1 targetGraphs, IReadOnlyList`1 localRepositories, RemoteWalkContext context, LockFileBuilderCache lockFileBuilderCache)
at NuGet.Commands.RestoreCommand.BuildAssetsFile(LockFile existingLockFile, PackageSpec project, IEnumerable`1 graphs, IReadOnlyList`1 localRepositories, RemoteWalkContext contextForProject)
at NuGet.Commands.RestoreCommand.<ExecuteAsync>d__45.MoveNext()
at NuGet.Commands.RestoreRunner.<ExecuteAsync>d__7.MoveNext()
at NuGet.Commands.RestoreRunner.<CompleteTaskAsync>d__10.MoveNext()
at NuGet.Commands.RestoreRunner.<RunWithoutCommit>d__3.MoveNext()
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 6.0.0-beta.22458.2 -> To Version 6.0.0-beta.22601.5
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
NuGet.Build.Tasks
From Version 6.4.0-preview.3.107 -> To Version 6.5.0-preview.2.108
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dfederm
dotnet-maestro[bot]
dotnet-maestro[bot]
Jan Krivanek
Rainer Sigwald
Ladi Prosek
sujitnayak
github-actions[bot]
dotnet-maestro-bot
AR-May
Ella Hathaway
Roman Konecny
Gang Wang
Farhad Alizada
Jenny Bai
YuliiaKovalova
Mariana Dematte
Matt Thalman
Jan Krivanek
Nikola Milosavljevic
Yue (Felix) Huang
Milena Hristova
Chaojie
dependabot[bot]
MilenaHristova
Oleksandr Didyk
David Federman
Oleksandr Didyk
Marc Paine
Matt Mitchell
Viktor Hofer
Vlada Shubina
Forgind
Forgind
Ben Villalobos