Microsoft.Net.Compilers.Toolset
From Version 4.11.0-3.24329.1 -> To Version 4.11.0-3.24352.5
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20240621.9
Microsoft.Net.Compilers.Toolset
From Version 4.11.0-3.24313.9 -> To Version 4.11.0-3.24321.9
* Update dependencies from https://github.com/nuget/nuget.client build 6.11.0.105
NuGet.Build.Tasks
From Version 6.11.0-rc.101 -> To Version 6.11.0-rc.105
* Update dependencies from https://github.com/dotnet/roslyn build 20240629.1
Microsoft.Net.Compilers.Toolset
From Version 4.11.0-3.24313.9 -> To Version 4.11.0-3.24329.1
* Update dependencies from https://github.com/nuget/nuget.client build 6.11.0.122
NuGet.Build.Tasks
From Version 6.11.0-rc.101 -> To Version 6.11.0-rc.122
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* fix bug
* add test
* small fix
* small fix
* improve InvokeLoggerCallbacksForSimpleProject
* rename to _projectFileWithNonAnsiSymbols
* add comment
* use GB18030 PUA characters in the project;
fix cproj to proj typo
* small fix
* fix test
Fixes#9467
Context
When building targets we only specify a reason when it has direct control over the flow. So some targets have no built reason at the end of the build and can get very confusing on large builds.
Changes Made
Added options for TargetBuiltReason: Initial target, entry target, default target.
These are added to TargetSpecification so they can be referenced in different points of the build.
Adding a comment about localization in order to cause a merge conflict in the next release branch, when we will be disabling the localization in the previous release branch and the change flows automatically to later releases and main.
See https://github.com/dotnet/msbuild/pull/10269#discussion_r1646558936
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9773561
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9773561
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9777431
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9777431
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9780734
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9780734
Customer requested to have understandable documentation of individual imposed rules.
Let's follow similar practice we introduced in template engine - with adding short hyperlinks to the outputs, that can then include rich information, that can freely evolve off-cycle.
Contributes to #10240.
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.24311.3 -> To Version 8.0.0-beta.24324.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This will help with using these from new code that's nullable-
aware. The biggest helpful bit is the `[NotNull]` ones that let the
compiler know to assume that parameter is non-null in the rest
of the method, which should eliminate the need for some `!`s
after calling `VerifyThrowArgumentNull(whatever)`.
* add BuildCheck.UnitTests to slnf
* add test for replaying binlog of analyzed build
* fixed buf for BuildCheckResultWarning
* changed the test for error case
* fixed bug for BuildCheckResultError
* set RawMessage for BuilCheck results instead of speacial casing in BuildEventArgsWriter
* remove using
* add skip back to the flaky test;
add skip to the new test
These results are uninteresting since drop.app is not something MSBuild ships or
redistributes, and BinSkim is currently breaking the build. Add to the baseline to get the
build working while Arcade is working to update to a new drop.app.
* Add a message for LongPathsEnabled
* refactor LongPathsEnabled logic to a ternary enum
* Elaborate and comment the resource string
* translations
* add state for registry not set
* deduplicate
* Update dependencies from https://github.com/dotnet/roslyn build 20240613.9
Microsoft.Net.Compilers.Toolset
From Version 4.11.0-3.24307.2 -> To Version 4.11.0-3.24313.9
* Update dependencies from https://github.com/nuget/nuget.client build 6.11.0.101
NuGet.Build.Tasks
From Version 6.11.0-rc.87 -> To Version 6.11.0-rc.101
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
From Version 8.0.0-beta.24270.4 -> To Version 8.0.0-beta.24311.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Initially, this delegated thread safety to a `SyncTextWriter`, but the
object graph was hard to understand, so it was replaced with a has-a
`SyncTextWriter` relationship, but this lost the timer-based call to
`Flush()` to send the output to the client.
The docs on `MethodImplOptions.Synchronized` also advise that it can be
risky due to locking on the object itself, so manage the syncronization
with an explicit lock object over the underlying `StringWriter` instead.
Fixes#10013.
These resources were added to the ARM64 subfolder in #10023,
but I don't think they're needed: there's no .NET Framework 3.5
for ARM64 and `MSBuildTaskHost.exe` isn't in the ARM64 folder
itself, so I think we can remove these files.
There was also a build race condition involving the .resources.dll
files, which is how I found this. The `Arm64ProjectReference`
wasn't enough to get them built.
---------
Co-authored-by: Jenny Bai <v-jennybai@microsoft.com>
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9736500
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9736500
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9736500
* move LockCheck to Utilities and make it public, update resources
* add doc comments
* refactor windows condition inside LockCheck
* use LockCheck in other Tasks which delete/modify files
* improve method summary
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
---------
* Update dependencies from https://github.com/dotnet/roslyn build 20240607.2
Microsoft.Net.Compilers.Toolset
From Version 4.11.0-3.24301.1 -> To Version 4.11.0-3.24307.2
* Update dependencies from https://github.com/nuget/nuget.client build 6.11.0.87
NuGet.Build.Tasks
From Version 6.11.0-preview.2.76 -> To Version 6.11.0-rc.87
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Enable CA2000 in tests
* Fix the process ca2000 error
* disabel the warning CA2000 in StartToolProcess
* Refactor the XmlReader create
* Fix new CA2000 after merge
* Fix the typo error
* Fix the indent
---------
Co-authored-by: Gang Wang <v-gaw@microsoft.com>
Fixes#9881
### Context
We believe there is value in flagging cases where the same file is written by more than one task during a build. https://github.com/dotnet/source-build/issues/4390 is an example of a recent hard-to-diagnose build issue that could have been prevented by this analyzer.
### Changes Made
This PR adds a new built-in analyzer and makes a few supporting changes.
### Testing
- Existing and new unit tests.
- Built a few larger repos with the analyzer enabled.
### Notes
The changes contain a fix/workaround for #10176.
Simon Cropp
dotnet-maestro[bot]
Surayya Huseyn Zada
Farhad Alizada
Jan Krivanek
YuliiaKovalova
Mariana Dematte
AR-May
dotnet bot
MichalPavlik
Jenny Bai
Rainer Sigwald
Jan Provazník
David Federman
Jakub Jareš
Roman Konecny
Ladi Prosek