c7ba581efe
Merge remote-tracking branch 'upstream/main' into VSCodeLogging
...
# Conflicts:
# src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorLanguageServerClient.cs
2023-12-22 11:07:07 +11:00
76f7bd3632
Make LanguageServerClient parameters non-nullable now that we're only VS here ( #9691 )
...
(and use primary constructors cos they're ace)
Fixes https://github.com/dotnet/razor/issues/6165
2023-12-22 08:55:24 +11:00
fcbb7ca0f7
Merge remote-tracking branch 'upstream/main' into RazorLanguageServerClient
2023-12-22 08:21:57 +11:00
76e4906e38
Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2340000 ( #9748 )
2023-12-22 06:41:31 +11:00
318d0f922a
Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2340000
2023-12-21 19:59:08 +01:00
bfc9dbb19f
Update Xunit and unify versioning a bit ( #9744 )
2023-12-22 05:42:16 +11:00
25e0a4962d
Dial down the log messages from diagnostics
2023-12-21 17:54:51 +11:00
c16abd1fbb
Make VS Code logging actually honour the setting
2023-12-21 17:54:50 +11:00
d513b8f33c
Use LogLevel for VS Code logging, instead of the custom Trace enum
2023-12-21 17:54:50 +11:00
ef10c5b951
Redo all of the logging in the world ( #9741 )
...
(and hope it compiles)
Given the number of files and lines changed, you may wish to review
commit-at-a-time.
Output Window:
<img width="652" alt="image"
src="https://github.com/dotnet/razor/assets/754264/6aec942e-a7bc-4070-a263-62653713a81d ">
LogHub:
<img width="658" alt="image"
src="https://github.com/dotnet/razor/assets/754264/ef8a5159-befa-4dae-b182-519b8f8cc9d1 ">
Integration tests:
<img width="483" alt="image"
src="https://github.com/dotnet/razor/assets/754264/d5db66e8-1476-4d81-8a30-591eaba521b7 ">
2023-12-21 17:53:39 +11:00
e355426b23
Near as I can tell, a bug in Xunit meant this test didn't previously run
2023-12-21 15:28:24 +11:00
efba61c5c9
Let's put that back
2023-12-21 15:28:08 +11:00
fa6b0946e7
Merge remote-tracking branch 'upstream/main' into UpdateXunit
2023-12-21 15:05:46 +11:00
b26d5eccbe
Case insensitive skipping is now required, apparently.
2023-12-21 13:29:13 +11:00
161f1405cb
Attribution
2023-12-21 12:25:14 +11:00
802d5dd7fa
Update and unify xunit versions
2023-12-21 12:08:59 +11:00
a3f8f1cb5d
Try the Roslyn xunit hook to get the tests to pass
2023-12-21 11:42:13 +11:00
1276dc52e5
Fix hover on html with catchall ( #9635 )
2023-12-20 23:24:03 +00:00
41a43b5b6b
Update after merge
2023-12-21 08:46:50 +11:00
9396afbd72
Merge remote-tracking branch 'upstream/main' into LoggingOverhaul
...
# Conflicts:
# src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/Options/OptionsStorage.cs
2023-12-21 08:46:36 +11:00
a3ef345f0d
PR Feedback
2023-12-21 08:40:54 +11:00
f1da03e863
Fix default
2023-12-21 08:39:14 +11:00
186de226d5
Do not offer snippets when typing inside a start or end tag ( #9739 )
...
Fixes #9726
2023-12-20 13:37:04 -08:00
21a904fe9c
Refresh settings when unified settings change ( #9737 )
...
Finalizes AB#1786418
Unified settins has been in for a while, but we needed to consume the 17.9 preview packages to be able to subscribe to the change events. This adds that, updates the structures we use to help keep it easy to follow, and adds a readme for people adding new options.
2023-12-20 13:02:32 -08:00
beb3531a4c
Random commit to solve AppDomain exception number 1
2023-12-20 22:20:46 +11:00
a62e29d60b
Fix integration test logging
2023-12-20 21:36:36 +11:00
bda5d83118
Move RazorLoggerOutput
...
I wrote most of this code in my cohost branch, which allows MEF exports from the language server. This branch does not, so this has to move.
2023-12-20 21:00:00 +11:00
c65cbce515
Update integration tests
2023-12-20 20:40:32 +11:00
2b60c461e8
Update tests
2023-12-20 20:18:27 +11:00
4f84e570a7
Update everything to take an IRazorLoggerFactory instead of an ILoggerFactory
2023-12-20 19:53:59 +11:00
3c1b088f95
Nicer looking LSP logs
2023-12-20 19:23:01 +11:00
2ea4f0db49
Remove test logging
2023-12-20 19:17:39 +11:00
103f5a1ba7
Add option to control output window logging
2023-12-20 19:17:38 +11:00
82c5663775
Update RZLS logging to the new system
2023-12-20 19:17:38 +11:00
d94df79420
Move MEF exports to use IRazorLoggerFactory
2023-12-20 19:17:34 +11:00
2c421d534e
Wire language server up to the new logging infrastructure
2023-12-20 19:16:02 +11:00
edc2dde987
Move output window logging to the new provider system
2023-12-20 19:15:27 +11:00
285b5d3116
Move LogHub logging to the new provider system
2023-12-20 19:15:27 +11:00
61c666620c
Create RazorLogger infrastructure
2023-12-20 19:15:26 +11:00
524b7656cb
Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2328040 ( #9632 )
...
This is the pull request automatically created by the OneLocBuild task
in the build process to check-in localized files generated based upon
translation source files (.lcl files) handed-back from the downstream
localization pipeline. If there are issues in translations, visit
https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is
https://aka.ms/onelocbuild and the localization process in general is
documented at https://aka.ms/AllAboutLoc .
2023-12-20 15:51:31 +11:00
a54193ca64
Make project removal more efficient ( #9692 )
...
Fixes https://github.com/dotnet/razor/issues/9185
2023-12-20 08:49:47 +11:00
d7b803092d
Offer to fully qualify component name even if case doesn't match ( #9712 )
...
Fixes https://github.com/dotnet/razor/issues/7658 by providing a better
user experience.
Unfortunately we can't be smart and offer to only fix the casing without
some more smarts/APIs from the compiler. But I figure this is better
than nothing.
Before:
<img width="361" alt="image"
src="https://github.com/dotnet/razor/assets/754264/9b34bb9e-4145-4a94-bd81-a2fdbedea964 ">
Before when there is also an `@bind` attribute:
<img width="476" alt="image"
src="https://github.com/dotnet/razor/assets/754264/53a9d66a-0b7d-49f6-8040-325a41e5f995 ">
After:
<img width="524" alt="FixComponentCase"
src="https://github.com/dotnet/razor/assets/754264/b9d1aa5a-6321-4fbd-a951-2598d4d59cb6 ">
The add using code action is also smarter. Full capabilties:
2023-12-19 10:18:38 +11:00
e682600636
Don't show hover info for <Text> components when they're not components ( #9732 )
...
Fixes https://github.com/dotnet/razor/issues/9713
2023-12-19 09:23:46 +11:00
13b0f0ce55
Add more tests
2023-12-19 09:00:26 +11:00
7526a1d5e2
Bump Roslyn and update tests in response to changes in Roslyn semantic tokens results ( #9710 )
...
The Roslyn change in https://github.com/dotnet/roslyn/pull/70595 caused
breaks in our semantic tokens tests. About half of the breaks are only
when precise tokens is turned on, and half whether it's turned on or
not.
After discussing with @maryamariyan it was decided that having
individual baseline files for the feature flag state is no longer
necessary, so this PR merges them, but it also updates the baselines of
a few tests to match what we get back from Roslyn. So lots of baselines
removed, the remaining ones all moved, and then a select few updated.
Review commit-at-a-time shows the full story as it happens, with the
last commit being the interesting one, but it turns out GitHub actually
does a pretty good job of this one if you just look at it as is.
Visually there is no user impact from these changes - TextMate colours
the `*, TestAssembly` portion of the `addTagHelper` the same as the
semantic tokens response used to. Additionally this is just updating
tests, the actual product has already changed and users are already
experiencing it.
2023-12-19 08:48:26 +11:00
8160fc4565
Re-enable compiler tests
2023-12-19 08:27:23 +11:00
f3d9d15e6b
Merge branch 'main' into RespondToRoslynSemanticTokensChanges
2023-12-19 08:25:32 +11:00
7124e7c57c
[main] Update dependencies from dotnet/source-build-reference-packages ( #9733 )
...
This pull request updates the following dependencies
[marker]: <> (Begin:011df26a-fbd1-45b0-94b9-08db3601dcca)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 011df26a-fbd1-45b0-94b9-08db3601dcca
- **Build**: 20231215.3
- **Date Produced**: December 15, 2023 7:04:58 PM UTC
- **Commit**: ad274914920e8e51c5269d215a641e592af8182c
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 9.0.0-alpha.1.23608.1 to 9.0.0-alpha.1.23615.3][1]
[1]:
9e09ace189...ad27491492
2023-12-19 08:02:54 +11:00
a502dd30de
Don't offer to generate a method for a directive attribute that isn't an event callback ( #9731 )
...
Fixes https://github.com/dotnet/razor/issues/9729
2023-12-19 07:43:15 +11:00
9ffbefb3e4
Change Count when resizing the array ( #9727 )
...
Fixes https://github.com/dotnet/razor/issues/9718
2023-12-19 07:35:06 +11:00
David Wengier
dotnet bot
David Wengier
Andrew Hall