razor-tooling/CONTRIBUTING.md

How to contribute

One of the easiest ways to contribute is to participate in discussions on GitHub issues and provide feedback. You can also contribute by submitting pull requests with code changes.

Feedback, bug reports, and feature requests

You can report issues and make suggestions in the dotnet/razor issue tracker.

If you're hitting issues with the Razor tooling in Visual Studio, you can let us know using the Visual Studio "Send Feedback" feature (Help > Send Feedback), which will automatically include helpful logs and diagnostic information for troubleshooting purposes. Most Visual Studio feedback issues will then get migrated to the dotnet/razor GitHub repo for tracking purposes.

If you hit a Razor tooling issue in Visual Studio Code, you can report the issue using the Report a Razor Issue command from the command palette and then follow the instructions.

If someone has already reported your issue or suggestion, be sure to give it a 👍 on the original post so that we know it's important to you! You can also comment on issues with clarifying details on your scenarios and the impact the issue has.

Reporting security issues and bugs

Security issues and bugs should be reported privately, via email, to the Microsoft Security Response Center (MSRC) secure@microsoft.com. You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Further information, including the MSRC PGP key, can be found in the Security TechCenter.

Other issues

For non-Razor tooling related bugs, please log a new issue in the appropriate GitHub repo. Here are some of the most common repos:

• ASP.NET Core (runtime)
• ASP.NET Core Docs
• Entity Framework Core
• .NET Runtime
• Roslyn (C#/VB IDE and compiler)

Or browse the full list of repos in the dotnet and aspnet organizations.

Other discussions

Our team members also monitor several other discussion forums:

• ASP.NET Core Q&A
• Stack Overflow with the asp.net-core, asp.net-core-mvc, or entity-framework-core tags.

Contributing code and content

Identifying the scale

If you would like to contribute to one of our repositories, first identify the scale of what you would like to contribute. If it is small (grammar/spelling or a bug fix) feel free to start working on a fix. If you are submitting a feature or substantial code contribution, please discuss it with the team and ensure it follows the product roadmap. You might also read these two blogs posts on contributing code: Open Source Contribution Etiquette by Miguel de Icaza and Don't "Push" Your Pull Requests by Ilya Grigorik. Note that all code submissions will be rigorously reviewed and tested by the ASP.NET and Entity Framework teams, and only those that meet an extremely high bar for both quality and design/roadmap appropriateness will be merged into the source.

Submitting a pull request

You will need to sign a Contributor License Agreement when submitting your pull request. To complete the Contributor License Agreement (CLA), you will need to follow the instructions provided by the CLA bot when you send the pull request. This needs to only be done once for any .NET Foundation OSS project.

If you don't know what a pull request is read this article: https://help.github.com/articles/using-pull-requests. Make sure the respository can build and all tests pass. Familiarize yourself with the project workflow and our coding conventions. The coding, style, and general engineering guidelines are published on the Engineering guidelines page.

Tests

• Tests need to be provided for every bug/feature that is completed.
• Tests only need to be present for issues that need to be verified by QA (e.g. not tasks)
• If there is a scenario that is far too hard to test there does not need to be a test for it.
  • "Too hard" is determined by the team as a whole.

Feedback

Your pull request will now go through extensive checks by the subject matter experts on our team. Please be patient; we have hundreds of pull requests across all of our repositories. Update your pull request according to feedback until it is approved by one of the ASP.NET team members. After that, one of our team members may adjust the branch you merge into based on the expected release schedule.