* Bump dependency versions of packages that now ship out of maintenance-packages (preview)
- Microsoft.Bcl.HashCode
- System.Buffers
- System.Memory
- System.Threading.Tasks.Extensions
- System.Runtime.CompilerServices.Unsafe
* Workaround name conflict for MathF: See https://github.com/dotnet/roslyn/issues/71442 We refer to MathF from
a comment which hits this bug problem in Roslyn where it thinks it's
ambiguous because visibility is not considered when resolving cref's in
doc comments.
* Permit maintenance-packages prebuilts
* Suppress CS0618 on site in System.Data.Common.Tests - 'Sql*' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
---------
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
The stack overflow coreclr tests started to fail recently. It turns out that
was caused by the size of the helper stack allocated for stack overflow
handling case is no longer sufficient. Moreover, there is a bug in
`Thread::CreateUtilityThread` that calls the `SetThreadName` even when the
thread creation fails.
Close#109499
Now that CSE always inserts into SSA we can update it to make use of the
reaching definition information that it has access to. CSE already spent
effort to track some extra information to try to do this, which we can
remove.
- Remove `optCSECheckedBoundMap`: this was used by CSE to try to update
conservative VNs of ancestor bounds checks. This is unnecessary since
all descendants of the CSE definitions should get the same
conservative VNs automatically now.
- Remove `CSEdsc::defConservNormVN`; this was used to update
conservative VNs in the single-def case, which again is unnecessary
now.
Making this change requires a bit of refactoring to the incremental SSA
builder. Before this PR the builder takes all defs and all uses and then
inserts everything into SSA. After this change the builder is used in a
multi-step process as follows:
1. All definitions are added with `IncrementalSsaBuilder::InsertDef`
2. The definitions are finalized with
`IncrementalSsaBuilder::FinalizeDefs`
3. Uses are inserted (one by one) with
`IncrementalSsaBuilder::InsertUse`. No finalization are necessary;
each use is directly put into SSA as a result of calling this
method.
The refactoring allows CSE to use the incremental SSA builder such that
it can access reaching definition information for each of the uses as
part of making replacements. However, this still requires some
refactoring such that CSE performs replacements of all defs before
performing the replacements of all uses.
Additionally, this PR fixes various incorrect VN updating made by CSE.
VN and CSE still track VNs that are interesting bounds check. However,
VN was sometimes inserting VNs with exception sets into the set, which
is not useful (the consumers always use normal VNs when querying the
set). This PR fixes VN to insert the normal VN instead.
Fix#109745
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 10.0.0-alpha.1.24561.2 -> To Version 10.0.0-alpha.1.24571.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/icu build 20241101.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 10.0.0-alpha.1.24531.1 -> To Version 10.0.0-alpha.1.24551.1
* Update dependencies from https://github.com/dotnet/runtime build 20241103.1
Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json
From Version 10.0.0-alpha.1.24527.3 -> To Version 10.0.0-alpha.1.24553.1
* Update dependencies from https://github.com/dotnet/icu build 20241104.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 10.0.0-alpha.1.24531.1 -> To Version 10.0.0-alpha.1.24554.2
* Update dependencies from https://github.com/dotnet/runtime-assets build 20241104.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 10.0.0-beta.24530.1 -> To Version 10.0.0-beta.24554.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20241104.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 10.0.0-alpha.0.24529.1 -> To Version 10.0.0-alpha.0.24554.1
* Update dependencies from https://github.com/dotnet/cecil build 20241104.3
Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil
From Version 0.11.5-alpha.24521.1 -> To Version 0.11.5-alpha.24554.3
* Update dependencies from https://github.com/dotnet/source-build-externals build 20241104.1
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 10.0.0-alpha.1.24528.1 -> To Version 10.0.0-alpha.1.24554.1
* Update dependencies from https://github.com/dotnet/runtime build 20241110.2
Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json
From Version 10.0.0-alpha.1.24527.3 -> To Version 10.0.0-alpha.1.24560.2
* Update dependencies from https://github.com/dotnet/icu build 20241111.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 10.0.0-alpha.1.24531.1 -> To Version 10.0.0-alpha.1.24561.2
* Update dependencies from https://github.com/dotnet/runtime-assets build 20241111.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 10.0.0-beta.24530.1 -> To Version 10.0.0-beta.24561.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20241111.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 10.0.0-alpha.0.24529.1 -> To Version 10.0.0-alpha.0.24561.1
* Update dependencies from https://github.com/dotnet/cecil build 20241111.1
Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil
From Version 0.11.5-alpha.24521.1 -> To Version 0.11.5-alpha.24561.1
* Update dependencies from https://github.com/dotnet/source-build-externals build 20241111.2
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 10.0.0-alpha.1.24528.1 -> To Version 10.0.0-alpha.1.24561.2
* Update dependencies from https://github.com/dotnet/runtime build 20241114.7
Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json
From Version 10.0.0-alpha.1.24527.3 -> To Version 10.0.0-alpha.1.24564.7
* Update dependencies from https://github.com/dotnet/runtime build 20241115.3
Microsoft.SourceBuild.Intermediate.runtime.linux-x64 , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json
From Version 10.0.0-alpha.1.24527.3 -> To Version 10.0.0-alpha.1.24565.3
* Update dependencies from https://github.com/dotnet/icu build 20241118.3
Microsoft.NETCore.Runtime.ICU.Transport
From Version 10.0.0-alpha.1.24531.1 -> To Version 10.0.0-alpha.1.24568.3
* Update dependencies from https://github.com/dotnet/runtime-assets build 20241118.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 10.0.0-beta.24530.1 -> To Version 10.0.0-beta.24568.1
* Update dependencies from https://github.com/dotnet/hotreload-utils build 20241118.1
Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
From Version 10.0.0-alpha.0.24529.1 -> To Version 10.0.0-alpha.0.24568.1
* Update dependencies from https://github.com/dotnet/cecil build 20241118.1
Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil
From Version 0.11.5-alpha.24521.1 -> To Version 0.11.5-alpha.24568.1
* Update dependencies from https://github.com/dotnet/source-build-externals build 20241118.1
Microsoft.SourceBuild.Intermediate.source-build-externals
From Version 10.0.0-alpha.1.24528.1 -> To Version 10.0.0-alpha.1.24568.1
* Update dependencies from https://github.com/dotnet/cecil build 20241119.4
Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil
From Version 0.11.5-alpha.24521.1 -> To Version 0.11.5-alpha.24569.4
* Update Versions.props
* Update dependencies from https://github.com/dotnet/runtime-assets build 20241118.1
Microsoft.NET.HostModel.TestData
From Version 10.0.0-beta.24522.1 -> To Version 10.0.0-beta.24568.1
* Update dependencies from https://github.com/dotnet/runtime-assets build 20241121.1
Microsoft.DotNet.CilStrip.Sources , Microsoft.NET.HostModel.TestData , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 10.0.0-beta.24530.1 -> To Version 10.0.0-beta.24571.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20241024.1
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.12.0-beta1.24516.1 -> To Version 3.12.0-beta1.24524.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20241027.1
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.12.0-beta1.24516.1 -> To Version 3.12.0-beta1.24527.1
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20241109.1
Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
From Version 3.12.0-beta1.24516.1 -> To Version 3.12.0-beta1.24559.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
When executing a remote iOS build from Windows on macOS, the ILLink task is instantiated on the remote macOS machine using a json deserializer.
This means that the properties will be read and written to before the task has been fully initialized, and this happens:
```
Newtonsoft.Json.JsonSerializationException: Error getting value from 'ILLinkPath' on 'Xamarin.MacDev.Tasks.ILLink'.
---> System.InvalidOperationException: Task attempted to log before it was initialized. Message was: ILLink.Tasks path: ~/Library/Caches/Xamarin/XMA/Agents/Build/net/illink.dll
at Microsoft.Build.Shared.ErrorUtilities.ThrowInvalidOperation(String resourceName, Object[] args)
at Microsoft.Build.Utilities.TaskLoggingHelper.LogMessage(MessageImportance importance, String message, Object[] messageArgs)
at ILLink.Tasks.ILLink.get_ILLinkPath()
at Newtonsoft.Json.Serialization.ExpressionValueProvider.GetValue(Object target)
--- End of inner exception stack trace ---
at Newtonsoft.Json.Serialization.ExpressionValueProvider.GetValue(Object target)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader reader, Type objectType)
at Xamarin.Messaging.Build.Serialization.TaskSerializer.Deserialize(String content, Type taskType) in D:\a\_work\1\s\src\MSBuild\Xamarin.Messaging.Build.Common\Serialization\TaskSerializer.cs:line 25
at Xamarin.Messaging.Build.TaskRunner.Execute(String taskName, String inputs) in [...]xamarin-macios/msbuild/Messaging/Xamarin.Messaging.Build/TaskRunner.cs:line 42
at Xamarin.Messaging.Build.ExecuteTaskMessageHandler.<>c__DisplayClass5_0.<ExecuteAsync>b__0() in [...]xamarin-macios/msbuild/Messaging/Xamarin.Messaging.Build/Handlers/ExecuteTaskMessageHandler.cs:line 40
at System.Threading.Tasks.Task`1.InnerInvoke()
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
--- End of stack trace from previous location ---
at Xamarin.Messaging.Build.ExecuteTaskMessageHandler.ExecuteAsync(ExecuteTaskMessage message) in [...]xamarin-macios/msbuild/Messaging/Xamarin.Messaging.Build/Handlers/ExecuteTaskMessageHandler.cs:line 28
at Xamarin.Messaging.Client.RequestHandler`2.HandleAsync(TMessage message) in D:\a\_work\1\s\src\Xamarin.Messaging.Client\Handlers\RequestHandler.cs:line 68
at Xamarin.Messaging.Client.MessageHandlerManager.<>c__DisplayClass12_1`2.<<RegisterHandlerAsync>b__2>d.MoveNext() in D:\a\_work\1\s\src\Xamarin.Messaging.Client\MessageHandlerManager.cs:line 96
--- End of stack trace from previous location ---
at Xamarin.Messaging.Client.MessagingClient.ReplyAsync[TRequest,TResponse](IRequest`1 request, MessagePriority priority, Func`1 replyFunctionAsync) in D:\a\_work\1\s\src\Xamarin.Messaging.Client\MessagingClient.cs:line 351: 11/18/2024 10:23:11Z
```
So move the logging statement to when it the property in question is used.
- Separate helpers for testing an actual contract descriptor from helpers for mock memory
- Tests/helpers for the contract descriptor are now under the `ContractDescriptor` folder
- Make all contracts tests use the mock target instead of creating a contract descriptor and using the `ContractDescriptorTarget`
- Update root namespaces from `Microsoft.Diagnostics.DataContractReader.UnitTests` -> `Microsoft.Diagnostics.DataContractReader.Tests` to match assembly name
Part of #107749. Prerequisite for #110026.
Use postorder number-based BitVecs in RBO and block layout.
Use bbID-based BitVecs in fgIncorporateProfileData. This runs early enough in the JIT frontend such that I would expect bbIDs and bbNums to be 1:1, so I don't expect any TP impact from this change.
Switch descriptor creation still uses bbNums as a key into a BitVec as a workaround for BB epoch invariants -- I'll try switching this over to bbID in a follow-up to evaluate the TP cost of a sparser bitset.
Move the unboxing helpers to managed code.
Behavior is basically identical except for the Unbox_Nullable paths, which required some investigation to find the fastest implementation. Notably, there interruptibility of managed code makes the copying/zeroing of values more difficult, but with the opportunity/requirement to specialize the codebase came a few micro-optimizations that are somewhat nice. Overall I don't expect anyone to notice the performance changes here, but since my earlier code was about 2X slower than the native implementation, I did feel the need to optimize until everything looked good.
Performance results:
| TestName | With PR | Without PR | % Speedup |
| --- | --- | --- | --- |
| TestJustAPrimitive| 1217.0047| 1221.203| 0.34% |
| TestJustObject| 1212.6415| 1211.6437|-0.08% |
| TestJust5Primitive| 1496.5304| 1522.4968|1.74% |
| TestJust5Object| 1461.0507| 1488.3328|1.87% |
| TestJust10Primitive| 1473.2814| 1493.5238|1.37% |
| TestJust10Object| 3215.6339| 2854.6186|-11.23% |
| TestJustAPrimitiveNullableWithValue| 2727.9085| 5182.2611|89.97% |
| TestJustObjectNullableWithValue| 3148.9484| 5672.2985|80.13% |
| TestJust5PrimitiveNullableWithValue| 5443.9232| 7795.6109|43.20% |
| TestJust5ObjectNullableWithValue| 6492.9071| 8095.1508|24.68% |
| TestJust10PrimitiveNullableWithValue| 6022.6274| 8723.572| 44.85% |
| TestJust10ObjectNullableWithValue| 7728.3239| 9671.1382|25.14% |
| TestJustAPrimitiveNullNullable| 1786.1337| 2230.0932|24.86% |
| TestJustObjectNullNullable| 1675.0683| 2326.0395|38.86% |
| TestJust5PrimitiveNullNullable| 2921.9497| 3298.4642|12.89% |
| TestJust5ObjectNullNullable| 3389.4043| 3615.3131|6.67% |
| TestJust10PrimitiveNullNullable| 3050.809| 4054.9683|32.91% |
| TestJust10ObjectNullNullable| 4658.8316| 5335.0686|14.52% |
Results are very positive, or within the margin of error in this test suite. These results were generated using a small benchmark which mostly targeted measuring the performance of the Unbox_Nullable helper, as it has the most complex and potentially slow code. Generally the impact on that helper is that the performance of the type system portion of the helper is faster, and the performance of code which actually copies the contents of a valuetype is a little better. This isn't quite a fair test of managed vs native performance though, as I took the opportunity to restructure some of the memory on `MethodTable` so that it could more easily be read in managed code, and that happened to make a fair bit of complex code become simpler and thus faster.
* Update dependencies from https://github.com/dotnet/roslyn build 20241104.8
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24554.8
* Update dependencies from https://github.com/dotnet/roslyn build 20241105.1
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24555.1
* Update dependencies from https://github.com/dotnet/roslyn build 20241106.10
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24556.10
* Update dependencies from https://github.com/dotnet/roslyn build 20241107.8
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24557.8
* Update dependencies from https://github.com/dotnet/roslyn build 20241108.12
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24558.12
* Update dependencies from https://github.com/dotnet/roslyn build 20241111.1
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24561.1
* Update dependencies from https://github.com/dotnet/roslyn build 20241113.22
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24563.22
* Update dependencies from https://github.com/dotnet/roslyn build 20241115.1
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24565.1
* Update dependencies from https://github.com/dotnet/roslyn build 20241115.9
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24565.9
* Update dependencies from https://github.com/dotnet/roslyn build 20241117.1
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24567.1
* Update dependencies from https://github.com/dotnet/roslyn build 20241118.2
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24568.2
* Update dependencies from https://github.com/dotnet/roslyn build 20241120.1
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24570.1
* Update dependencies from https://github.com/dotnet/roslyn build 20241120.4
Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
From Version 4.13.0-2.24531.4 -> To Version 4.13.0-2.24570.4
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
I'm looking at places we use .All to see if the new annotations could help. Here we don't need the new annotations, this was always expressible. I can only assume the reason for .All was laziness. This was at a time when we believed .All "just keeps a bit more" and we didn't consider the impact of marking interface methods implemented by the class, or the impact of warnings due to .All capturing things that are not safe to reflection-call.
This is a breaking change in theory, should someone implement `IReflect` or derive from `System.TypeInfo` - they need to update the annotations.
This takes advantage of #109814. This is in theory a breaking change in case someone took advantage
of our annotation and is doing their own reflection on `EventSource` descendants.
Someone else reflecting on EventSource is problematic however. We placed around various suppressions
due to our own annotations like this:
0d62887a30/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs (L414-L424)
It means that if someone else is reflection-accessing these, they would not get a trimming warning.
Hopefully, nobody does that. This PR also assumes that nobody does that (and the PR should therefore
not be breaking in practice).
We annotate the class for our purposes, but someone else could be taking advantage of that in their own code.
* Add CPUID for AVX10.2
* Handle AVX10.2 ISAs in missing places
* Remove APX_X64 since it is unused
* remove log file and change handling for AVX10v2_V512
* resolve merge errors
Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
From Version 10.0.0-alpha.1.24568.1 -> To Version 10.0.0-alpha.1.24569.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Part of #107749. Follow-up to #103450. To facilitate implementing a global variant of 3-opt alongside the greedy variant, this moves some shared components to helper methods. I want to do this as a separate PR to ensure this change is truly no-diff, and has minimal (if any) TP impact.
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20241108.1
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 10.0.0-alpha.1.24555.1 -> To Version 10.0.0-alpha.1.24558.1
* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20241111.2
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 10.0.0-alpha.1.24555.1 -> To Version 10.0.0-alpha.1.24561.2
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* [wasm] Re-enable skiasharp WBT tests
* Disable Debug/AOT combination
That would trigger build error, because we don't support that combination
anymore
* Change order of native libs
Put NativeFileReference files after the runtime libs. This server as
a workaround of #109289
* Update llvm, emsdk and icu deps
* Revert "Change order of native libs"
This reverts commit e320fd67aa.
* Add SseFormatter.
* Update src/libraries/System.Net.ServerSentEvents/src/Resources/Strings.resx
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Document SseItem exceptions.
* Misc improvements and fixes.
* Reinstate ordering of parameters in serialization callback.
* Add SseItem<T>.ReconnectionInterval.
* Address feedback.
* Add parser validation for too small or too large retry intervals.
* Update src/libraries/System.Net.ServerSentEvents/src/System/Net/ServerSentEvents/SseFormatter.cs
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Handle CR line breaks.
* Simplify PooledByteBufferWriter.
---------
Co-authored-by: Stephen Toub <stoub@microsoft.com>
* Use explicit full-path for loading MsQuic.dll on Windows
* Suppress IL3000 in MsQuicApi constructor
A call to `Assembly.Location` was added in a recent fix. It has `IL30000` suppressed via `#pragma warning disable`, but that only applies to the compilation of the library itself. Consumers will hit it when doing something like publishing their app as NativeAOT.
This change adds an `[UnconditionalSuppressMessage]` to the `MsQuicApi` static constructor such that `IL30000` should also be suppressed for apps consuming the runtime.
This was caught in an aspnetcore deps flow PR coming from runtime.
---------
Co-authored-by: Elinor Fung <elfung@microsoft.com>
https://github.com/dotnet/linker/pull/2133 adjusted rooting logic to keep `.All` on all nested types preserved with PublicNestedTypes/NonPublicNestedTypes. The PR resolved the bug and the analysis work that was identified in the review as necessary never happened. So we just uselessly preserve members.
This adds dataflow analysis to propagate this. Since we never had the dataflow analysis, I'm exposing this not as .All, but a subset of .All that doesn't do the worst part - doesn't require reflectability of interface methods.
- Make `TestPlaceholderTarget` (mock target) constructor take type infos and global values
- Handle reading of global values in mock target implementation
- Use Moq for creating a `ContractRegistry` instead of our own explicit implementation
- Remove subclasses of `TestPlaceholderTarget`
Andy Ayers
Mitchell Hwang
Aman Khalid
Carlos Sánchez López
Adeel Mujahid
Steve Harter
Egor Bogatov
Jan Vorlicek
Jakob Botsch Nielsen
dotnet-maestro[bot]
Rolf Bjarne Kvinge
Clinton Ingram
Elinor Fung
Alan Hayward
Alex Rønne Petersen
Sven Boemer
David Wrighton
Brian Chavez
Badre BSAILA
kasperk81
Michal Strehovský
Stephen Toub
Khushal Modi
Jackson Schuster
Marek Fišera
Max Charlamb
Radek Doulik
Eirik Tsarpalis
Radek Zikmund