Keith Cirkel
3d711da0ed
upgrade node runner to 16 LTS
2022-05-19 10:43:22 +01:00
Keith Cirkel
c86d7ff03e
run tests on all branches (not just PRs)
2022-05-19 10:42:49 +01:00
Keith Cirkel
b34abdd9a5
ensure marks default to configurable+enumerable
2022-05-19 09:24:18 +01:00
Keith Cirkel
c12f5b7914
Merge pull request #243 from github/fix-providable-bugs
...
Fix providable bugs
2022-05-18 13:51:30 +01:00
Kristján Oddsson
57c988c1eb
Merge branch 'main' into fix-providable-bugs
2022-05-18 13:49:07 +01:00
Keith Cirkel
9f1fff817f
Merge pull request #245 from github/add-tag-observer
...
add tag observer
2022-05-18 10:37:01 +01:00
Keith Cirkel
e359caa14a
Merge branch 'main' into add-tag-observer
2022-05-18 10:34:40 +01:00
Keith Cirkel
71b8700ee9
Merge pull request #244 from github/fix-ability-retaining-name
...
ability subclasses should retain original class name
2022-05-18 10:24:03 +01:00
Keith Cirkel
3b04a5cc61
add tag observer
2022-05-18 10:00:57 +01:00
Keith Cirkel
0013735899
ability subclasses should retain original class name
...
This fixes a bug where ability subclasses end up being anonymous, which
makes them impossible to register. Ability classes should retain the
original class name.
2022-05-18 08:58:59 +01:00
Keith Cirkel
4e25629f45
fix nested & partial providers
...
If a provider cannot supply a value it should not, and so we need to
check if it has the available `@provide` name.
If a provider _can_ supply a value it should stopPropagation to avoid
letting other providers assign and callback.
2022-05-18 08:49:34 +01:00
Keith Cirkel
e9ed847eb9
fix bug in providable where it should only dispose of older disposers
...
This was causing values to be discarded after the first change which is
a mistake. The disposer should be called only if it recieves a new one
(meaning a different provider has entered the ring).
2022-05-18 08:49:34 +01:00
Keith Cirkel
a570551b02
Merge pull request #242 from github/steves-patch-1
...
Fix typo in providable code sample
2022-05-18 07:52:15 +01:00
Steve S
58def9776e
Fix typo in providable code sample
2022-05-17 17:32:21 -04:00
Keith Cirkel
679c0b96c3
Merge pull request #241 from github/add-providable-ability
...
Add providable ability
2022-05-17 19:47:09 +01:00
Keith Cirkel
d945ecdb2a
Add lib/abilities which exports Providable
2022-05-17 19:03:24 +01:00
Keith Cirkel
a6b678a7eb
add providable implementation
2022-05-17 19:03:24 +01:00
Keith Cirkel
678aac0061
adds docs for abilities and providable
2022-05-17 19:03:23 +01:00
Keith Cirkel
7a4bdff060
Merge pull request #238 from github/split-ability-controllable
...
split out ability & controllable
2022-05-15 20:11:52 +01:00
Keith Cirkel
776c022860
split out ability & controllable
2022-05-15 19:15:45 +01:00
Keith Cirkel
800d7eed1a
Merge pull request #236 from github/add-initializer-to-marks
...
add initializer to marks
2022-05-15 12:08:49 +01:00
Keith Cirkel
02719c9969
Merge branch 'main' into add-initializer-to-marks
2022-05-15 12:06:27 +01:00
Keith Cirkel
dc95eda07b
Merge pull request #235 from github/improve-documentation-around-method-getter-setter-decorators
...
improve documentation around method/getter/setter decorators
2022-05-15 11:27:36 +01:00
Keith Cirkel
6e69a93cea
Accidentally a console.log
2022-05-15 11:26:34 +01:00
Keith Cirkel
772714d81d
add initializer to marks
2022-05-15 11:16:45 +01:00
Keith Cirkel
72da5d3883
improve documentation around method/getter/setter decorators
2022-05-14 22:33:37 +01:00
Keith Cirkel
389bf5559e
Merge pull request #234 from github/rework-tests-for-bind
...
rework tests for bind
2022-05-14 10:23:15 +01:00
Keith Cirkel
b996132245
Update bind.ts
2022-05-14 10:20:51 +01:00
Keith Cirkel
64fe9fc3fc
rework tests for bind
2022-05-14 00:17:31 +01:00
Keith Cirkel
c7b92eacb1
Merge pull request #232 from github/fix-up-types-in-tests
...
Fix up types in tests
2022-05-12 15:14:09 +01:00
Keith Cirkel
5aa70115bd
fix up types in tests
2022-05-12 15:05:55 +01:00
Keith Cirkel
2413c0f54a
fix logic in marks to adhere to types
2022-05-12 15:05:40 +01:00
Keith Cirkel
058516b3d9
add postlint step for tsc checking src and test
2022-05-12 14:37:46 +01:00
Keith Cirkel
b233e701f9
ignore coverage directory
2022-05-12 14:36:28 +01:00
Keith Cirkel
023d3fec75
add tests to tsconfig for checking
2022-05-12 14:36:27 +01:00
Kristján Oddsson
8e9c7dd7e3
Merge pull request #231 from github/fix-ci-cache-action
...
fix reference to lockfile
2022-05-12 00:39:15 +01:00
Kristján Oddsson
dd4f949617
fix reference to lockfile
2022-05-11 22:39:21 +01:00
Keith Cirkel
550896372e
Merge pull request #230 from github/ammend-attr-tests-to-use-two-word-attrs
...
amend attr tests to use two word attrs
2022-05-11 09:06:26 +01:00
Keith Cirkel
b1dc3b8b1b
ammend attr tests to use two word attrs
2022-05-10 16:43:39 +01:00
Kristján Oddsson
bb47eabbea
Merge pull request #229 from github/add-createability
...
add createAbility
2022-05-09 10:34:10 +01:00
Kristján Oddsson
9c86f73f3b
prettier 😭
2022-05-09 10:31:56 +01:00
Kristján Oddsson
85e5f7fc18
Remove unused variables
2022-05-09 10:28:39 +01:00
Keith Cirkel
fb2813229b
add createAbility
2022-05-09 10:24:58 +01:00
Keith Cirkel
a399966d6f
Merge pull request #228 from github/update-attr-tests
...
Cherry-pick attr tests from `use-delegates`.
2022-05-06 20:10:28 +01:00
Kristján Oddsson
6af09352f3
Shrink diff slightly
2022-05-06 20:02:36 +01:00
Kristján Oddsson
baebc13038
Remove tests that don't pass
2022-05-06 20:00:34 +01:00
Kristján Oddsson
8e7d8ab56f
Clean up attr test after cherry-picking
2022-05-06 19:58:55 +01:00
Kristján Oddsson
44a50eb601
Pull in attr test from `use-delegates`
2022-05-06 19:46:44 +01:00
Keith Cirkel
ae48275633
Merge pull request #227 from github/marks
...
add marks feature
2022-05-06 19:38:35 +01:00
Keith Cirkel
9c68a5d4a8
Merge branch 'main' into marks
2022-05-06 19:35:53 +01:00