Граф коммитов

220 Коммитов

Автор SHA1 Сообщение Дата
Joseph Felix f6f1557f47
Removing changes so I can submit a PR 2024-10-14 09:18:57 -07:00
Joseph Felix cbbba2e64b
pvfs-failure-context-update
This commit adds more context to the chatop tests failures by checking for keys in the json_response and raising if they do not exist. This should give users a better idea of why their expectations fail.
2024-10-14 09:15:15 -07:00
Aleksey Levenstein 55b5c7b9cb
Merge pull request #65 from github/time-skew
fix: allow 5 mins time drift
2024-07-02 12:40:05 +03:00
Aleksey Levenstein 76f2338360 fix: allow 5 mins time skew 2024-07-02 12:03:09 +03:00
Roye Tadmor 46655ff362
Merge pull request #63 from github/royetadmor-patch-1
Update docs
2024-03-19 18:00:46 +02:00
Roye Tadmor 46ca18d801
Update README.md 2024-03-19 17:03:52 +02:00
Roye Tadmor 1975bd1461
Update docs 2024-03-19 17:01:56 +02:00
Artem Egorov 25c8c54442
Merge pull request #62 from github/5-2-0-release
Create 5.2.0 release
2024-01-10 14:01:20 +01:00
Artem Egorov 03ea3fef11 Create 5.2.0 release 2024-01-10 12:43:14 +00:00
Artem Egorov 807aeb093f
Merge pull request #61 from github/itoys/multi-base-urls
Allows to set multiple base auth urls
2024-01-10 12:58:37 +01:00
Artem Egorov e60af165ba fix ensure_chatops_authenticated return 2024-01-08 13:01:54 +00:00
Artem Egorov eabf05f972 fix tests 2024-01-08 11:58:38 +00:00
Artem Egorov 508fbb0fe2 revert 2024-01-05 17:40:48 +00:00
Artem Egorov 1c937719f8 install rails 6 for tests only 2024-01-05 16:59:15 +00:00
Artem Egorov f7cd321515 can't stick rails actually 2024-01-05 16:57:04 +00:00
Artem Egorov 9c1c630eb0 stick rails version for tests 2024-01-05 16:52:53 +00:00
Artem Egorov 3e42ea0397 Allows to set multiple base auth urls 2024-01-05 14:45:08 +00:00
Max Wagner 33322579f0
Merge pull request #60 from github/5-1-0-release
Create 5.1.0 release
2022-10-20 11:35:20 -06:00
Max Wagner 07d4dc8e5c
Create 5.1.0 release
This release includes a new permitted parameter `raw_command`.
See #59
2022-10-20 11:10:44 -06:00
Max Wagner 26e93a78fb
Merge pull request #59 from github/permit-raw-command-parameter
Permit raw_command
2022-10-20 11:08:37 -06:00
Max Wagner 4e37bf8787 Permit raw_command
This is to allow implementation of another feature that sends
the raw_command, in addition to the parsed command,
to the chatops server so the server can parse the command itself.
2022-10-20 08:54:25 -06:00
Lee Quarella 82bf43a82d
Merge pull request #57 from github/bump-gem-version-5
Bump gem version to 5
2021-07-15 08:42:19 -04:00
Parker Moore 6cd3b329e5
Merge pull request #56 from github/chatops-thread-style
Define Chatops::THREAD_STYLES
2021-07-12 15:27:59 -04:00
Parker Moore fe0fa0472c
Define Chatops::THREAD_STYLES
ChatopsRPC has been updated to support thread styles, which allows a Chatops RPC call to reply either in the channel, in a thread of the original message, or both.
2021-06-22 12:10:59 -04:00
Lee Quarella 451024eb3d Bump gem major version to 5 2021-06-09 12:25:59 -04:00
Lee Quarella a5eedad7c5
Merge pull request #54 from github/upgrade-ruby-and-rails
Bump to rails 6 and ruby 2.7
2021-04-12 11:26:49 -04:00
Dirkjan Bussink 4406cd2c32 Run against latest Rails 2021-03-25 14:10:13 -04:00
Dirkjan Bussink f8f05de06d Fix action 2021-03-25 11:39:13 -04:00
Dirkjan Bussink ba351da29c Reduce the dependencies of the chatops controller
When looking at options to mitigate
https://github.com/github/github/issues/174690, my initial approach
there failed because we can't drop some Rails components because we use
gems that express all of Rails as a dependency instead of the parts they
need.

The chatops controller is one of those. It looks like though it only
needs ActiveSupport & ActionPack so I reduced the dependencies here to
just those parts.
2021-03-25 11:37:01 -04:00
Lee Quarella 9cb11b7d81 Update cache control conditional for Rails >= 5 2021-03-10 13:35:04 -05:00
Lee Quarella 3fdf53717d Fix `start_with` deprecation 2021-03-10 13:34:03 -05:00
Nina Kaufman 278033696b Update rails dependency in gemspec 2021-02-25 15:25:34 -08:00
Lee Quarella c7ab6e21cd Update syntax to match Rails `content_mime_type` 2021-01-29 12:08:19 -05:00
Lee Quarella 4a60b3d1e0 Bump to rails 6 and ruby 2.7 2021-01-28 10:54:20 -05:00
Raffaele Di Fazio ac72188c38
Merge pull request #51 from github/raffo/fix-ci
Fix build steps
2020-01-20 19:39:36 +01:00
Raffaele Di Fazio e9e51b1f19 changes build steps
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2020-01-20 19:37:32 +01:00
Raffaele Di Fazio db5fb3c173
Adds CI with Actions 2020-01-20 19:33:34 +01:00
Misty De Meo d40bd141f0
Merge pull request #50 from github/add_ruby_version
Commit a ruby-version
2020-01-20 14:28:45 -04:00
Misty De Meo 7b63dc0acc Commit a ruby-version
This is in use just for local development.
2020-01-20 10:17:54 -08:00
Kristján Oddsson 9c56ffb81b
missing comma 2019-11-04 11:55:57 +00:00
Misty De Meo 581957d6ba Revert "add instructions to run against local hubot"
This reverts commit ceb3389620.
2019-02-14 13:01:50 -08:00
Misty De Meo 7b2de6771e
Merge pull request #48 from github/docs_to_include_dev_testing
add instructions to run against local hubot
2019-02-14 13:01:18 -08:00
Georgi Knox ceb3389620 add instructions to run against local hubot 2019-02-14 15:21:33 -05:00
Misty De Meo d25909bfbc v4.1.0 2018-11-13 13:36:18 -08:00
Misty De Meo 083cd61693
Merge pull request #45 from github/add-message-id
Proposal to add an optional message id to the CRPC protocol
2018-11-13 13:35:37 -08:00
Misty De Meo 61336a5afc
Merge pull request #47 from github/new_release
Bump version to 4.0.1
2018-11-08 09:48:21 -08:00
Misty De Meo 23007c321b Bump version to 4.0.1 2018-11-08 09:47:14 -08:00
Misty De Meo 63613bd60b
Merge pull request #46 from github/jaredonline/send-valid-json-errors
Send valid JSON errors
2018-11-08 09:44:39 -08:00
Jared McFarland b7413c53be Send valid JSON errors
In a number of places the controller was sending plaintext responses
back when it encountered an error in a before_action. Those responses
were being "parsed" by Hubot, assuming they were JSON. That parsing
would fail, and return a generic error back to the user.

This sends back valid JSON using the already written jsonrpc_error
method. I followed the pattern I saw, and invented a new set of error
numbers starting at -32800 (there was already -32700 and -32600).
2018-11-08 09:23:40 -08:00
Brian Anglin 7c34327e2c Fixes test helpers to include message_id 2018-10-18 08:24:51 -07:00