Граф коммитов

479 Коммитов

Автор SHA1 Сообщение Дата
Vanessa Yuen a8d54c9af7
Improvements in tools to help merge crowdin PRs (#18409)
- add `script/test-render-translation.js` to render all translated content to catch malformed liquid that would cause render errors
- improve test output for `script/fix-translation-errors.js` and `tests/content/lint-files.js`
- make it so `script/reset-translated-file.js` can handle files that have been renamed
2021-03-26 19:21:45 +00:00
Kevin Heis 938639b2af
Merge branch 'main' into graphql-explorer-query-params 2021-03-25 09:39:06 -07:00
Sarah Schneider db992f7192 lint 2021-03-24 14:01:47 -04:00
Sarah Schneider 2af643eac7 run tests on content 2021-03-24 13:27:27 -04:00
Sarah Schneider df6be79b0f Merge branch 'main' of github.com:github/docs-internal into scheduled-workflow-tests 2021-03-24 13:27:00 -04:00
Matt Pollard 4ce3cb1fb1
Document enterprise policies for GitHub Advanced Security (#18263) 2021-03-22 16:20:27 +00:00
Felicity Chapman 28bec608c7
Group user docs on code security into a new "product" - with more redirects (#18278) 2021-03-22 09:28:35 +00:00
James M. Greene 6e20ed7927
Implement app clustering (#17752)
* Install throng for easy cluster management
* Extract the Express app construction into its own file
* Switch server.js to use app clustering for deployed environments
* Worker count is based on the lesser of process.env.WEB_CONCURRENCY and the count of CPUs
* Reading clustered output is difficult, let's prefix the std{out,err} streams

Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2021-03-19 20:07:46 +00:00
Sarah Schneider d7f78d8238 use regex as a less brittle check for any number of zeros 2021-03-18 13:55:17 -04:00
Sarah Schneider d0a136caee add tests to ensure workflow crons are unique and do not run at top of the hour 2021-03-18 13:39:59 -04:00
Rachael Sewell 02ee72fa25
add topics attribute to search (#18212) 2021-03-17 13:11:29 -07:00
Sarah Schneider 5006cdaff2 add tests 2021-03-17 10:30:16 -04:00
Felicity Chapman 6a7e93f225
Revert "Group user docs on code security into a new "product" (#18196)" (#18277) 2021-03-17 08:07:11 +00:00
Felicity Chapman 024014740b
Group user docs on code security into a new "product" (#18196) 2021-03-16 17:25:29 +00:00
Sarah Schneider 3c1a49e626
Merge branch 'main' into graphql-explorer-query-params 2021-03-12 10:35:13 -05:00
James M. Greene 9e31597ee4
Use promisified fs.readFile instead of fs.promises.readFile (#18204)
* Create a readFileAsync wrapper module

* Use the readFileAsync wrapper module instead of fs.promises.readFile

* Fix require path in test
2021-03-10 17:57:10 +00:00
Emily Gould 052a540cdb
Getting started category landing page (#17841)
* Start building out landing page in index file

* Add articles

* Add a couple more popular articles

* Tweak intro to cover more audiences

* Add TOC back with new organization

* Update content/github/getting-started-with-github/index.md

* Category as product guides section

* Update breadcrumbs.js

* Update server.js

* Update product-landing.html

* Remove TOC listing

* Revert removing TOC

* Update index.md

* Update index.md

* Update content/github/getting-started-with-github/index.md

* Apply suggestions from code review

Co-authored-by: Laura Coursen <lecoursen@github.com>

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
2021-03-09 10:04:45 -06:00
Sarah Schneider 4547221c1a Merge branch 'main' of github.com:github/docs-internal into graphql-explorer-query-params 2021-03-04 13:48:26 -05:00
Sarah Schneider bc5e576e38 Merge branch 'main' of github.com:github/docs-internal into github-ae-release-notes 2021-03-04 13:45:48 -05:00
Sarah Schneider 225bf25220
Merge branch 'main' into ghes-latest-redirect 2021-03-02 09:41:50 -05:00
Sarah Schneider d9d9834194 add basic test 2021-03-01 19:18:39 -05:00
Sarah Schneider 284cfeda4b rename test file 2021-03-01 17:04:27 -05:00
Matt Pollard 2db9da5c8f
[DO NOT MERGE] GitHub AE consumables beta megabranch (#17620)
* Empty commit

* updated beta note for GHAE

* more GHAE update + resolve conflict

* more GHAE updates + prepare for screenshots

* Apply suggestions from code review

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>

* address remaining review comments

* Revise "About GitHub AE" (#17679)

* add screenshots to the Configuring article

* reworked to have a separate GHAE section

* list numbering

* more work on screenshots and conditions

* add GHAE screenshots in article

* review screenshots in article

* added more screenshots and updated more articles

* screenshot madness

* fix liquid versioning

* refactor the ghae script

* [GHAE CB/Feb 22]: Add article about data residency for GitHub AE (#17847)

* add missing GHAE versioning to article

* move screenshots to GHAE asset directory

* forgot to change the path for these two images

* replace CBB screenshot + add better screenshot

* [GHAE CB/Feb 22]: Document upgrades for GitHub AE (#17848)

* Version article for GitHub AE

* Replace unused variable

* Incorporate reviewer feedback

* Update intro

Co-authored-by: Ethan P <56270045+ethanpalm@users.noreply.github.com>

* [GHAE] Enable IP allow list (#17691)

* Notes for CC

* Updat permission leves chart

* Add updated article to further reading

* Update gated feature callout with GitHub AE

* Version "Managing allowed IP addresses for your organization" for AE

* Update images

* Update "Restricting network traffic to your enterprise" with new procedures

* remove todo note

* Update audited actions

* Update info about Premium Runners

* Use reusable for Premium Runners

* Change "Premium Runners" to "AE hosted runners"

* Incorporate reviewer feedback

* Use correct reusable

* Version reusable correctly

* [Feb 22] GHAE: Code scanning beta (#17830)

* Add "github-ae" to all the frontmatter

* GHAE-ify the reusables

* Add some more changes

* Re-use some content

* 🔪 Semmle links

* Revert change re "--external-repository-token" in the CodeQL runner

* Update CodeQL runner token scopes

* Update two screenshots

* Remove mention of GitHub.com from AE + other fixes

* Apply suggestions from code review

Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>

* Use `product_name` variable instead of `product_location`

* Remove confusing phrase

* [Feb 22] GHAE: Code scanning API and webhook docs (#17883)

* Version API and webhook docs

* Actually add versioning for GHAE

* Fix anchor

* [TEMPORARY] Preview for API endpoints

* Revert API previews

* Update procedure step

Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>

* Update docs for AzureAD Group SCIM support in GHAE (#17892)

* [GHAE CB] SMTP bootstrapping flow (#17888)

* draft

* update with AE conntent

* update with tons of versioning

* remove that  lie

* fill out the rest of these steps

* update with correct versioning

* more edits

* add images

* reversion most of ae article

* fix versioning

* format correctlly

* words matter

* last image

* update with permmissions

* update versioning

* add link

* apply feedback ❤️

* update with differrent spacing

* update with feedback

* more feedback

* Temporary GHAE release notes for consumables beta launch (#17859)

* Create release-notes.md

* Add frontmatter

* Add to index file

* Update github-ae-release-notes.md

* Add release notes from Google Doc

* Update finalized docs links that have been reviewed

* OAuth device flow link update

* version for AE

* few fixes

* Update content/admin/overview/github-ae-release-notes.md

* small edits

* whoops

* commit

* update with different links

* used wrong reusable

* fix more brokenness

* Update repository-references.js

* Update repository-references.js

Co-authored-by: Meg Bird <megbird@github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>

* [GHAE] Audit public repos (#17917)

* verifying what we mean by public

* Apply suggestions from code review

* Update content/developers/apps/installing-github-apps.md

Co-authored-by: Laura Coursen <lecoursen@github.com>

* fixing placememnt of liquid conditional

Co-authored-by: Laura Coursen <lecoursen@github.com>

* GHAE packages beta (#17786)

Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com>
Co-authored-by: Martin Lopes <martin389@github.com>

* fix broken links

* [GHAE CB/March 01]: GitHub Actions on GHAE (beta) (#17725)

* Added initial layout for premium runners

* Restructured content

* Added placeholder for removing premium runner

* Added versioning and warning note for self-hosted runners

* Added versioning and beta notice for actions content

* Rephrased beta note

* Added versioning for API docs, fixes

* Added versioning fixes

* Split Github-hosted and premium topics into separate articles

* Added edits

* Restructured some topics

* Revised "Using premium runners in a workflow"

* Some small fixes

* Fixed typo

* Added fixes to reusable

* Added edits

* Made section titles consistent

* Added billing, group mgmt, reusable steps

* Cropped certain screenshots for future-proofing

* Removed superfluous reusable

* Added fixes

* Revert "Cropped certain screenshots for future-proofing"

This reverts commit c7f24f31fa30d4fe3de2b63fc3cd5feba44ef518.

* Added new section for custom images

* Added versioning for enterprise-admin operations

* Added edits

* Added edits

* Update adding-premium-runners.md

* Removed SHR screenshots. Intending to update them when UI is available.

* Update using-labels-with-premium-runners.md

* Added custom labels section

* Added preview of API docs changes

* Added versioning for ip allow list section

* Removed removal article

* Renamed premium runners to AE hosted runners

* Re-added added API preview

* Fixed links, updated software specs

* Revised "Software specifications" based on feedback

* Fixed typos

* Small fixes

* Added new article "Creating custom images"

* Moved "Creating custom images" link

* Apply suggestions from code review

Co-authored-by: ahdbilal <55514721+ahdbilal@users.noreply.github.com>

* Added update from review

* Added updates from tech review

* Apply suggestions from code review

Co-authored-by: ahdbilal <55514721+ahdbilal@users.noreply.github.com>

* Added updates from tech review

* Added updates from tech review

* Added updates from tech review

* Added updates from tech review

* Fixed reusable

* Added fixes

* Added update from tech review

* Removed the dereferenced OpenAPI schema files

* Added fixes

* Fixed links

* Fixed links

* Apply suggestions from code review

Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com>

* Added updates from peer review

* Removed sections that are not in beta

* Update viewing-your-github-actions-usage.md

* Update viewing-job-execution-time.md

* Update index.md

* Update about-github-hosted-runners.md

* Restored versioning to match GHES approach

* Fixed link

* Restored self-hosted runner reference to UI steps.

* Updated screenshots

* Updated screenshots and procedures

* Small edits to screenshots

* Added AE url info for SHR

* Removed superfluous versioning

* Update security-hardening-for-github-actions.md

* Update actions-shared.md

* Small edits

* Update usage-limits-billing-and-administration.md

* Update managing-complex-workflows.md

* Additional versioning

* Additional versioning

* version environments api and checkrun deployments for ghae (#17991)

Co-authored-by: Martin Lopes <martin389@github.com>

* Update reviewing-the-audit-log-for-your-organization.md

* Added versioning for enterprise policy settings

* version configuring artifact retention for AE

* remove AE versioning for connecting to Marketplace

* Apply suggestions from code review

Co-authored-by: Joe Bourne <thejoebourneidentity@github.com>

* Update content/admin/github-actions/getting-started-with-github-actions-for-github-ae.md

Co-authored-by: Joe Bourne <thejoebourneidentity@github.com>

* rewording not public to private

* fixing liquid

* Fixed elseif entries

* Added expectations note

* Revised label management article for AE hosted runners

* Added enterprise-admin note for adding AE hosted runners

* Update enterprise-admin.md

* Update self-hosted-runner-security.md

* Versioned reusable for AE

* Empty commit for CI

Co-authored-by: ahdbilal <55514721+ahdbilal@users.noreply.github.com>
Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com>
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
Co-authored-by: Joe Bourne <thejoebourneidentity@github.com>
Co-authored-by: runleonarun <runleonarun@github.com>

* Update OpenAPI Descriptions for GHAE

* Update content/admin/overview/github-ae-release-notes.md

Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com>
Co-authored-by: mchammer01 <42146119+mchammer01@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: shati-patel <shati-patel@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
Co-authored-by: Felicity Chapman <felicitymay@github.com>
Co-authored-by: Meg Bird <megbird@github.com>
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com>
Co-authored-by: Martin Lopes <martin389@github.com>
Co-authored-by: ahdbilal <55514721+ahdbilal@users.noreply.github.com>
Co-authored-by: Joe Bourne <thejoebourneidentity@github.com>
Co-authored-by: runleonarun <runleonarun@github.com>
Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com>
2021-03-01 16:07:02 -05:00
Sarah Schneider d3617af76a add test 2021-02-26 13:23:55 -05:00
Sarah Schneider 9b33879b4d add browser test for Explorer query param handling 2021-02-26 09:30:30 -05:00
Sarah Schneider a10c2387ca Merge branch 'main' of github.com:github/docs-internal into use-redirects-file-instead-of-stubbed-archived-redirects 2021-02-24 10:35:33 -05:00
Kevin Heis bcd91a04c6
End survey stars AB test (#17907)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-02-22 18:27:57 +00:00
Sarah Schneider a28c7ac2a2 add test 2021-02-22 11:14:01 -05:00
Kevin Heis 46ccfc5d93
Run AB test on survey stars (#17861)
* Run AB test on survey stars

* Update browser.js

* Use text stars instead of primer ones

* Update experiment.js
2021-02-18 16:29:17 +00:00
Rachael Sewell 01e52046f0
migrate away from AWS S3 (#17669) 2021-02-12 10:25:45 -08:00
Kevin Heis 626bfa5918
Move the one performance metric in page to exit to avoid join (#17784) 2021-02-11 16:28:07 +00:00
Jason Etcovitch e68e6a5185
Revert "Revert "Absorb @github-docs/frontmatter (#17783)" (#17793)" (#17799)
* Revert "Revert "Absorb @github-docs/frontmatter (#17783)" (#17793)"

This reverts commit 11baf43eee.

* Move revalidator to depedencies
2021-02-11 11:15:59 -05:00
Jason Etcovitch 11baf43eee
Revert "Absorb @github-docs/frontmatter (#17783)" (#17793)
This reverts commit 1e96c03489.
2021-02-10 20:28:41 +00:00
Jason Etcovitch 1e96c03489
Absorb @github-docs/frontmatter (#17783) 2021-02-10 15:10:46 -05:00
Kevin Heis 1918d2ea14
Inline CSRF token in HTML (#17748)
* Inline CSRF token

* Fix tests
2021-02-09 22:08:24 +00:00
Jason Etcovitch d98bb561c7
Honor Error.status(Code) in handle-errors middleware (#17768)
* Honor error status codes in handle-errors

* Add a test
2021-02-09 14:57:57 -05:00
Kevin Heis 207c536609
Add `page_event_id` to all successive events (#17738)
* Add `page_event_id` to all successive events

* Update events.js

* Break out event inits into functions so they don't break each other

* Update events.js

* Update events.js

* Update events.js
2021-02-09 15:40:27 +00:00
Vanessa Yuen 25ff6b94ff
Translation tools to make our lives easier (#17712)
* create script to fix easy-to-fix frontmatter errors in translation

* improve reset-translated-file.js: allow reverting to the same file from `main` branch

* fix release-notes as well

* also lints liquid in frontmatter
2021-02-09 10:11:12 -05:00
Jason Etcovitch 39e0e0dda1
Use Liquidjs instead of Liquid (#16743)
* Install liquidjs, uninstall liquid

* Comment a bunch of stuff out to get going

* Fix invalid includes

* Fix all includes (path => 'path')

* Get the homepage to render

* Do link-in-list kinda

* Revert "Fix all includes (path => 'path')"

This reverts commit d6fead646353aa5041d9229470a62a1d487456b9.

* Support non-dynamic partials

* Extract getTemplate helper

* Do remaining custom Liquid tags

* Fix some custom tag bugs

* Moar bugs

* Re-add link tag

* Cleaner diff

* Actually fix extended markdown tags

* Fully comment out version matchers

* Smaller diff

* Rely only on Liquid internals for conditionals

* Use new operators option in Liquid engine

* Fix link.js

* Don't need options

* Updoot to the right doot

* Fix some bugs

* Fix another bug

* Pass a test

* Fix the translate bits

* Adjust a test

* Fix another invalid Liquid bug

* Two more borked translations

* Found some more

* Don't need this change

* Revert "Don't need this change"

This reverts commit a916d619747f0492865a69c3e237c97c4d4e7fad.

* This should fix the broken links

* Missed one

* Revert "This should fix the broken links"

This reverts commit e6c2cc0d9055d958706260d57edbe293281c150e.

* Revert "Missed one"

This reverts commit bbe1f23baf16e020f6f7931589decb1afc75dfbd.

* Updoot liquidjs
2021-02-08 12:58:51 -05:00
James M. Greene a40ff31b4b
Cache more assets both in browser + Fastly (#17663)
* Cache archived asset JS/CSS for a day

* Don't waste time with ETag calculations

* Add a comment about the expiration length

* Cache images and fonts for a day

* Cache GraphQL data files for a week

* Set Fastly surrogate-key header on all responses

* Update test to account for new response header
2021-02-03 22:16:54 +00:00
Rachael Sewell fc430896cb
add azure to content security policy (#17649) 2021-02-03 10:49:40 -08:00
James M. Greene 0e729d9a75
Cleanup the testing and old code related to Fastly headers (#17643) 2021-02-03 10:43:00 -06:00
James M. Greene 8f133cbf54
Disallow both Fastly AND the browser from caching HTML pages (#17641) 2021-02-02 21:37:41 +00:00
Jason Etcovitch 53d8e60959
Add a test for non-English rendering (#17593)
* Throw in some code that should fail a test

* Remove read-frontmatter behavior

* Unskip the test that would catch this

* Remove the throw to pass the test
2021-02-02 18:14:39 +00:00
Vanessa Yuen a1d93a7619
Lint translation files (#17561)
### Why:

A lot of content gets mistranslated, some common patterns are: frontmatter date and enums getting translated, liquid tags get translated or go missing during the translation process. These translation errors are tough to catch, especially when they often come in huge PRs. 

### What's being changed:

- Frontmatter is also getting linted against schema as part of `lint-files`
- When an environment variable `TEST_TRANSLATION` is passed,
   - `lint-files` will run its tests against all files that have been newly translated (by git-diffing between `translations` branch and `main` branch), and
   - results are outputted using a custom jest reporter. The output is formatted in a way that makes it easy to exclude the problematic translated files from being merged, and to share the errors with [localization support](https://github.com/github/localization-support/issues/489). 
- Run the implemented translation test as part of the existing `Node.js Tests - Translations` workflow
2021-02-01 17:59:33 +01:00
Jason Etcovitch 8d4f3e65fe
Move test & script utils out of `/lib` (#17517)
* Remove an unused file

* Move authenticate-to-aws to scripts/utils

* Move crowdin-config to tests/utils

* Remove add-frontmatter-to-file

* Move find-unused-assets

* Move git-utils to script/utils

* Move lib/github to script/utils

* Revert "Remove an unused file"

This reverts commit cd93ad846a0354e957359f23124eb0724c9147cf.

* Move find-extraneous-translation-files to script/utils

* We already have tests/helpers

* Rename script/utils => helpers for consistency

* Forgot a path

* Fix path to crowdin-config

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-29 10:30:51 -05:00
Vanessa Yuen 4038e9ca85
Add topic property and filter to guides page (#17328)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-29 12:32:31 +00:00
Jason Etcovitch 4a761418a9
Add a test for the WIP language banner link change (#17480)
* Add a test

* Try adding de

* Let's try all languages
2021-01-26 20:06:58 -05:00
Jason Etcovitch 612ec766aa
Add glossaries to lint-files tests (#17481)
* Add glossariesDir to glob

* Actually make the test work

* Fix the (legitimate) failures
2021-01-26 21:19:27 +00:00
Jason Etcovitch 40d604d3c9
Add test to check content files against `liquid.parse` (#17479)
* Add the test

* Don't forget this require
2021-01-26 20:59:19 +00:00
Jason Etcovitch b4171bf0d5
Use AST parsing for lint file checking (#17471)
* Add markdown parsing dependencies

* Use it for the link test

* Use ast tests for hard-coded language

* Dedupe visiting for links

* Add new mdast utils to check-deps exclusions
2021-01-26 17:45:23 +00:00
Sarah Schneider 35e430c96d
Merge branch 'main' into make-developer-redirects-static 2021-01-26 11:30:16 -05:00
mc 4996deb228
Merge branch 'main' into 3059-remove-send-from-author 2021-01-26 14:14:14 +00:00
Kevin Heis 99a85ff4ef
Push query string when searching (#17417)
* Push query string when searching

* Update search.js

* Fix browser test, remove querystring dependency (new shiny!)

* Remove language and version from visible URL

* Avoid casting event interface

* Update search.js

* Update browser.js
2021-01-25 11:52:55 -08:00
Sarah Schneider 0dbfa96b65 add message to test output 2021-01-25 13:10:08 -05:00
Vanessa Yuen 9bc90cd932
Learning Track navigation banner (#17440)
* add middleware to handle `learn` query param

* add exception to query-less cache key

* add querystring to learning track guides
2021-01-25 16:57:32 +00:00
shati-patel d63f25091a Try a new test article in server.js 2021-01-23 13:56:49 +00:00
shati-patel eb7ce2b47b Merge branch 'main' into 3059-remove-send-from-author 2021-01-23 13:39:49 +00:00
shati-patel ba2f1570f6 change from `main` 2021-01-23 13:37:51 +00:00
shati-patel de0a8e2430 Update server.js 2021-01-23 13:34:05 +00:00
Kevin Heis 6ae96188f2
Move 404 and 500 images to local (#17432) 2021-01-22 21:49:45 +00:00
Sarah Schneider 8dcab4d8c5
Merge branch 'main' into use-linkinator-for-internal-link-check 2021-01-22 10:08:42 -05:00
Sarah Schneider 4be15f7b87
account for paths with or without version (#17443) 2021-01-22 15:07:08 +00:00
Sarah Schneider b0677b2442 use script instead of jest, much faster 2021-01-22 09:28:06 -05:00
Sarah Schneider 0c5b78ee3b use linkinator for internal link checking 2021-01-21 16:36:22 -05:00
Kevin Heis 2fb2e962bc
Move site search to use an endpoint (#17359)
* Move site search to use an endpoint

* Update browser.js

* Update search.js

* Update lib/search/versions.js

Co-authored-by: James M. Greene <JamesMGreene@github.com>

* Fix URLs

Co-authored-by: James M. Greene <JamesMGreene@github.com>
2021-01-20 15:37:42 +00:00
James M. Greene 9724f763f5
Implement discount fingerprinting without webpack (#17337) 2021-01-19 23:00:54 -06:00
Vanessa Yuen b46da8dfc7
Sublanding page all guides section (#16869)
* get link liquid tag to accept variables as param

* new liquid tag `link_as_article_card`

* refactor link liquid tag slightly so we can control what props get rendered

* generalize filterCodeExample to use in all guides section

* pass in `js-filter-card-max` instead of hardcode max

* tweaks and add `data` to CSP for images

* add liquid tag tests

* add some browser tests for card filters

* we still need to rely on `getPathWithLanguage` for hrefs that already have the language code embedded


Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
2021-01-18 12:23:23 +00:00
Sarah Schneider 30f95ce3d2 lint 2021-01-15 11:56:51 -05:00
Sarah Schneider c1bd93f269 Merge branch 'main' of github.com:github/docs-internal into remove-fpt-helper 2021-01-15 11:44:24 -05:00
Laura Coursen 77ee3137ef
Refactor protected branches content (#17277)
* Add new structure to index.md

* Move all conceptual and troubleshooting content

* Add more redirects

* Update links

* Reorganize "About" article

* Tweak some conceptual content

* Rename procedural article

* Fix article title in index.md

* Fix links

* Add more redirects

* Fix more links

* Add redirects for "Managing..." and fix links

* Consolidate procedural information

* Remove duplicate redirect

* Fix indentation

* Add 💅

* Add header

* Add editing and deleting

* 💅 conceptual content

* 💅 conceptual content

* 💅 troubleshooting article

* Clarify default behavior

* 💅 gated feature clarification

* Add 💅

* Add 💅

* update hardcoded links in tests

* Fix gated feature reusable

Co-Authored-By: Matt Pollard <mattpollard@users.noreply.github.com>

* Step out of the way while Matt improves all of the legacy content

Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>

* Tweak gated feature reusable

Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
2021-01-15 16:43:14 +00:00
Sarah Schneider 564628799c Merge branch 'remove-fpt' of github.com:github/docs-internal into remove-fpt-helper 2021-01-15 09:39:12 -05:00
Sarah Schneider ffb4e548a0 Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-15 09:38:15 -05:00
Vanessa Yuen eaacb54422
small liquid link tag cleanup (#17280)
* remove unnecessary `render` methods
* we don't use `link_with_short_title` anymore
* remove `shortTitle` option
* remove ink_with_short_title tag test
2021-01-15 13:24:39 +00:00
Sarah Schneider a394190ad6 Merge branch 'remove-fpt' of github.com:github/docs-internal into remove-fpt-helper 2021-01-14 17:13:06 -05:00
Sarah Schneider ecaec6e78e Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-14 17:12:27 -05:00
Sarah Schneider 9809627129 lint 2021-01-14 17:10:12 -05:00
Sarah Schneider affbc80a3c update tests to remove free-pro-team from expected results 2021-01-14 17:08:30 -05:00
Rachael Sewell 80575a2983
move deprecated site policy content to new directory (#17270) 2021-01-14 11:41:38 -08:00
Sarah Schneider 2b31096312
Merge branch 'main' into remove-fpt 2021-01-14 13:44:02 -05:00
Sarah Schneider ed8b46267c Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-14 12:08:27 -05:00
Sarah Schneider 39fe8cb96c add currentVersion to test context 2021-01-14 12:08:01 -05:00
Sarah Schneider 1dab7c6186
Merge branch 'main' into support-ga-in-deprecated-versions 2021-01-14 11:13:14 -05:00
Jason Etcovitch 0ec47e0246
Only read the frontmatter from files in warm-server (#17222)
* Add read-frontmatter.js

* Use it

* Page static read/init are async now

* Fix some blockers

* I'm confused

* Fix some more bugs

* Use frontmatter schema, ensure end fence exists

* Fix a bug

* Still read full contents for index.md files

* Remove comment

* Only get ToC items for index pages

* Readd frontmatter error and verdadero handling

* Fix some borked tests

* Simplify the code

* Add a comment

* Remove redundant variable

* Re-simplify the Page construction

* End chunk _after_ endline

* Just use Page.init
2021-01-14 10:46:59 -05:00
Sarah Schneider 79a7a7972f Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-13 16:58:05 -05:00
Sarah Schneider e3d0009949 remove no-longer needed tests for removed redirects now that legay /v3 and /v4 links have all been updated 2021-01-13 16:50:54 -05:00
Sarah Schneider e1cb587339 update refs to reinstated findPage() 2021-01-13 16:50:20 -05:00
Sarah Schneider 23170a50e6 lint 2021-01-13 16:50:05 -05:00
Sarah Schneider a8afad4eb9 add test 2021-01-13 14:05:36 -05:00
Vanessa Yuen 641ed02e81
Actions Guides sublanding page (#16740)
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
2021-01-11 18:30:57 +01:00
Sarah Schneider 9d318e0380 Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-08 11:06:27 -05:00
Sarah Schneider 5f42c407f3 add a few redirects to fake context object 2021-01-08 11:05:55 -05:00
Barry McGee adc9954094 Update tests with new expected semantic headings 2021-01-08 00:08:48 +00:00
Barry McGee ffdd3b3d97 Update tests with new expected semantic headings 2021-01-08 00:08:47 +00:00
Abby Vollmer f5a2c56de6
Project Visby site-policy updates (change date + hide from GitHub Docs) (#17139)
and support site policy hidden articles
2021-01-07 22:44:34 +00:00
Sarah Schneider ead1dc202c Merge branch 'main' of github.com:github/docs-internal into remove-fpt 2021-01-07 14:43:50 -05:00
Sarah Schneider 33f93e39c7 remove overloaded helper functions and move code directly where it is used 2021-01-07 13:14:44 -05:00
James M. Greene 068c472084
Cache rendered pages in Redis (#17106)
* Explicitly set the Redis database number used for rate limiting

* Switch to using ioredis as the Redis client for rate limiting

* Install ioredis-mock as a primary dependency

* Create a Redis BasicAccessor class and tests

* Switch rendered page caching to use Redis for storage

* Add support for additional Redis SET options like TTLs

* Remove currently unused methods

* Rename redis-accessors/basic to redis-accessor and remove extra fluff

* Change default behavior for cache setting to throw if an error occurs

Add option allowSetFailures to facilitate graceful failures

* Allow SET failures to fail gracefully for the rendered page cache

* Remove as-yet unneeded serialization options from RedisAccessor

* Move Redis client construction into RedisAccessor constructor, just pass in databaseNumber as option

* Remove rendered-page-cache in favor of direct RedisAccessor use

* Add tests for RedisAccessor constructor param validations

* Eliminate one roundtrip to Redis for the cached HTML existence check

Are we fast yet?

* Set a rendered page cache TTL of 24 hours
2021-01-06 15:30:51 -06:00
Kevin Heis 3582de03da
Parentheticals -> parentheses (#17130) 2021-01-05 17:04:01 +00:00
Kevin Heis 4ffc2a5e2b
Fix a bunch of typos in tests dir (#17132)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-05 11:25:14 -05:00
Kevin Heis d7eb248a10
Fix a bunch of random typos (#17129)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2021-01-05 16:07:27 +00:00
Sarah Schneider 1e76ef7ff2 replace pageWithSwitcher article with one that does not have a default platform set 2020-12-18 18:38:23 -05:00
Chiedo John 4654635962
Merge branch 'main' into default-platform 2020-12-18 10:45:26 -05:00
Kevin Heis c62f49aa0e
Block indexing not crawling (#17044)
* Block indexing instead of crawling

* Lint

* Update deprecated-enterprise-versions.js

* Combine loops
2020-12-17 11:57:18 -08:00
Sarah Schneider 185737342e the new map topic handling now needs context.currentPath 2020-12-17 12:02:28 -05:00
Sarah Schneider 969c8d5110
Merge branch 'main' into revert-16952-revert-16947-optimize-sitetree 2020-12-17 11:10:00 -05:00
Sarah Schneider 78895184a7 updates for clarity 2020-12-17 10:19:44 -05:00
Kevin Heis 59f375ab1d
Merge branch 'main' into default-platform 2020-12-16 14:36:46 -08:00
Sarah Schneider ef9b03a867 Merge branch 'main' of github.com:github/docs-internal into check-links-improvement-redux 2020-12-16 16:32:41 -05:00
Chiedo John 9ab71614fc
Merge branch 'main' into revert-16952-revert-16947-optimize-sitetree 2020-12-16 15:03:20 -05:00
James M. Greene 9d73f5adef
Remove accidentally committed console logging from test (#16813)
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-15 17:40:01 -05:00
Kevin Heis 3dae194793
Merge branch 'main' into revert-16952-revert-16947-optimize-sitetree 2020-12-15 11:01:37 -08:00
Kevin Heis 122da9610c
Move redirect calculation from loadPages to loadRedirects (#16918)
* Move redirect calculation from loadPages to loadRedirects

* Make buildredirects a method for tests

* Update redirects.js

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-15 18:40:50 +00:00
Sarah Schneider 3dfd7a01af add test for unequal versions between category pages and child pages 2020-12-15 11:53:44 -05:00
Sarah Schneider dca55a0257
Revert "Revert "sitetree optimizations"" 2020-12-14 20:25:01 -05:00
Sarah Schneider b38eec9964
Revert "sitetree optimizations" 2020-12-14 16:53:04 -05:00
Sarah Schneider 624245dabe Merge branch 'main' of github.com:github/docs-internal into check-links-improvement-redux 2020-12-14 15:52:46 -05:00
Sarah Schneider c412bd992a
Merge branch 'main' into optimize-sitetree 2020-12-14 15:42:03 -05:00
Sarah Schneider bc01b6c9f5
Merge branch 'main' into update-dates-script 2020-12-14 15:21:45 -05:00
Sarah Schneider f5b050dc5e updates now that siteTree paths include language codes 2020-12-14 14:39:45 -05:00
Jason Etcovitch d891618fcc
Import Enterprise release notes for 2.20, 2.21 and 2.22.5 (#16909)
* Add 2.20

* Add 2.21

* Add 2.22.5

* Lint

* Properly format dates

* Update the tests
2020-12-14 15:16:29 +00:00
Jason Etcovitch 92d5722103
Add 2.22 release notes (#16586)
* Add 2.22.0

* Add 2.22.1

* Add 2.22.2

* Add 2.22.3

* Add 2.22.4

* Lint YAML files

* intro shouldn't be required

* Align all notes

* Full height sidebar

* Make the sidebar full height properly

* Get the real layout going

* Include full name

* Move details > summary around

* Fix sticky sidebar

* Tweak bottom of page

* Add more label colors

* Change heading title

* Don't be <details>, change sticky header

* Include other releases' info

* Show prev/next links

* Change sidenav to show all releases

* Fix ordering of chevron

* Fix link underlines

* Collapsing minor versions

* Moar padding

* Setup schema for sub-sections

* Update a YAML file to match schema

* Redo rendering/sorting logic

* Update layout

* Convert remaining notes

* Improve schema

* Use proper min properties

* Custom bullet points

* Show details control for version picker

* Improve layout on small screens

* One more tiny fix

* Order by semver

* Use proper version in details

* Fix extra arrows showing up

* Change label colors

* Pass the reference check

* Add gradients

* Gradient all the things
2020-12-11 13:43:11 -05:00
Simran Spiller d565a13d8d Fix unit test error 2020-12-11 02:01:14 +01:00
Simran Spiller 4afc7d4035 Merge remote-tracking branch 'upstream/main' into default-platform 2020-12-11 01:13:32 +01:00
Simran Spiller b08584e5be Improve and extend browser tests 2020-12-11 01:05:22 +01:00
Sarah Schneider d4140663c2
Merge branch 'main' into update-dates-script 2020-12-10 13:58:02 -05:00
Sarah Schneider 82ad16c963
Merge branch 'main' into early-access-tweaks 2020-12-09 21:42:55 -05:00
Sarah Schneider 5b82f5e03e
Merge branch 'main' into skip-early-access-tests 2020-12-09 21:32:50 -05:00
Sarah Schneider cfc4f6754d
Merge branch 'main' into early-access-tweaks 2020-12-09 21:13:50 -05:00
Sarah Schneider e0c929c13f add exclusion 2020-12-09 21:13:11 -05:00
Sarah Schneider bc6c0cc6be Merge branch 'main' of github.com:github/docs-internal into yank-outdated-redirect-code 2020-12-09 20:47:40 -05:00
James M. Greene e6518ff9c3
Fix unresolved data lookups on GitHub Glossary page (#16815)
* Support [...] in data tag path

* Use forloop.index0 to get data tag path

* Commit whitespace change to not keep getting it

* Recursively render glossary terms as well

* Add tests to verify Liquid data tag can handle bracketed access

* Remove superfluous 'set' for context in tests

* Avoid the mystery guest anti-pattern... move the test data closer to the test

* Escape the `-` character in the data regex

Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-12-09 18:58:00 -06:00
Kevin Heis e7406b7336
Merge branch 'main' into default-platform 2020-12-09 15:06:30 -08:00
Sarah Schneider 10152fa15a lint 2020-12-09 15:12:39 -05:00
Sarah Schneider c48c02598b Merge branch 'main' of github.com:github/docs-internal into check-links-improvement-redux 2020-12-09 15:12:18 -05:00
Rachael Sewell 6a3d326fcf
add one-off cases for hooks and pre-receive-hooks (#16784)
* add one-off cases for hooks and pre-receive-hooks

* add forum redirect

* update redirect test

* update 2.19-2.22 fixutres

* revert 2.18/2.19 changes

* remove dotcom test

* update dotcom test
2020-12-09 19:50:46 +00:00
Sarah Schneider 9a9b74379a
Merge branch 'main' into check-links-improvement-redux 2020-12-09 14:49:17 -05:00
Kevin Heis 1b424dfdc4
Bring in data-directory, let's go async file reads (#16782)
* Bring in data-directory, let's go async file reads

* Lint fixes

* Update glossary.js
2020-12-09 11:20:24 -08:00
Sarah Schneider cf11e27fc8
Merge branch 'main' into check-links-improvement-redux 2020-12-09 13:13:20 -05:00
Kevin Heis 62889986b6
Revert "Revert "Speed up warmServer by loading pages (and files) asyn… (#16837)
* Revert "Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)"

This reverts commit a14517115f.

* Move async to regular dependencies

* Update package-lock.json
2020-12-09 17:40:58 +00:00
Jason Etcovitch a14517115f
Revert "Speed up warmServer by loading pages (and files) asynchronously (#16752)" (#16835)
This reverts commit 1d5e216404.
2020-12-09 17:12:07 +00:00
Kevin Heis 1d5e216404
Speed up warmServer by loading pages (and files) asynchronously (#16752)
* Async `new Page`

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Update pages.js

* Using mapLimit

* Update pages.js

* Test updates

* Update pages.js

* Move exists to page class

* Test fixes

* Slightly faster localized paths process
2020-12-09 16:57:18 +00:00
Kevin Heis a7cfb88b7a
Use async file reads in categories-for-support-team middleware (#16781)
* Use async file reads in categories-for-support-team middleware

* Update categories-for-support-team.js

* Update categories-for-support-team.js

* Update categories-for-support-team.js

* Update glossary.js
2020-12-09 15:52:33 +00:00
Kevin Heis 98e4b78112
Update tests to use fs.promises when not top-level (#16803)
* Update tests to use fs.promises when not top-level

* Move two to asyncFilter

* Update site-data-references.js

* Update site-data-references.js

* Clear out await fs.exists

* Lint

* A few more fixes

* Can't use async when defining tests
2020-12-09 15:42:02 +00:00
Simran 2a3fdd43ac
Merge branch 'main' into default-platform 2020-12-09 02:06:46 +01:00
Simran Spiller 4dc1ce1322 Lint 2020-12-09 02:01:54 +01:00
Simran Spiller d64a444042 Add unit test for page.defaultPlatform 2020-12-09 01:47:28 +01:00
Simran Spiller de490f62b7 Add browser tests 2020-12-09 01:29:09 +01:00
Sarah Schneider f27002810f req.context.pages is now an object, we need it to be an array 2020-12-08 16:02:15 -05:00
Sarah Schneider fe29938bf7 Merge branch 'main' of github.com:github/docs-internal into check-links-improvement-redux 2020-12-08 15:57:26 -05:00
Melanie Yarbrough 91d3857341
[DO NOT MERGE] Universe 2020 Day 1: December 8, 2020 (#16480)
* Update README

* [Universe] Dark mode (#16545)

* Dark mode updates (#16696)

* [Universe] Corporate sponsors (#16457)

* Dependency review beta (#16563)

* Add placeholder topic file

* Revert change I didn't make

I'm not sure where this change came from or why it's showing up in my PR here but I didn't make this change and it's not part of Dependency Review so I'm reverting it.

* Un-revert previous change

OK I see what happened there. I was comparing the PR to main rather than the Universe megabranch, hence it showed a change I didn't make.
This commit undoes the change I do not want to revert on the megabranch.

* Update image to add the Checks tab

* Finish updating topic to mention DR

* Fix check errors

* Fix another versioning error

* Add a sentence about supported ecosystems

* Add review changes

* Remove Further reading topics in same category

As suggested by James, I've removed the links to topics that are in the same `/collaborating-with-issues-and-pull-requests/` category as this topic.

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

* Updates in the light of Maya's review

* Remove use of "exploit" in description

* Change 'dependency review summary' to 'dependency review'

See PR review comment from Maya.

* Mention that the age of the dependency is given

* Update screenshots to latest GUI

* Add details of dependency ordering within a DR

* Update content/github/collaborating-with-issues-and-pull-requests/reviewing-dependency-changes-in-a-pull-request.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/managing-security-vulnerabilities/about-managing-vulnerable-dependencies.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* Update content/github/visualizing-repository-data-with-graphs/about-the-dependency-graph.md

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>

* [Universe 2020] New audit log REST API endpoint (#16699)

* Minimal updates for preview

*  API previews 

* Update beta note

*  Update API previews 

*  Update previews 

* Add draft section for git events

* Clean API previews

* More fixes + API previews

* Address review comments + update API previews

* Mention cursor-based pagination

* Update content/rest/overview/resources-in-the-rest-api.md

Co-authored-by: Jeff Saracco <jeffsaracco@github.com>

* Temporarily revert API previews

* Small tweaks from review comments + API previews

* revert json schemas

* Updating OpenAPI descriptions (#16776)

* Updating OpenAPI descriptions

* Add decorated OpenAPI schema files

Co-authored-by: Jeff Saracco <jeffsaracco@github.com>
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com>

* [Universe 2020] GitHub Actions: Workflow visualization (#16629)

* initial empty commit

* replace image used only for dotcom

* add new image and version usage

* add new image and version usage

* add new image and version usage

* add new image and version usage, delete unneeded image

* add new image and version usage, fix incorrect image

* add new image and version usage

* add new image and version usage

* add new image and version usage

* add new image and version usage

* update screenshot update

* add new image and version usage

* add new image and version usage

* update text

* update images and fix list numbering

* add step with graph

* Add missing versioning

* add overview of visualization

* fix title to match filename

* add beta note

* update wording

* Restructuring packages (#16731)

* restructuring packages

* moving more content

* moving more content

* fixing the toc for guides

* removing CR from the landing page

* adjusting qs

* updating npm

* enhancing guides

* Update updating-github-insights.md

* fixing link problems

* fixing link problems

* redirecting the redirects

* another change

* fixing the guides landing page

* add packages quickstart

* moving CR content

* adding some descriptive text

* add packages landing page

* adding guide content back

* update popular articles based on data

* fix caps on product name

* try removing product from front matter

* Update content/packages/quickstart.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Update content/packages/quickstart.md

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* add node package instructions to quickstart

* fixing links and adding redirect

* fixing redirects

* renaming to container guides

* renaming to container guides and fixing reusables

* adding context and about section to CR

* removign landign page extra titles and descriptions

* reverting the packages

* updating link

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>

* updating

* update test to reflect redesigned product landing page

* Add private vs public clarification

* Fix borked test

* filter out standalone category files from test

Co-authored-by: Cynthia Rich <crichID@github.com>
Co-authored-by: Cynthia Rich <crichID@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>

* Add discussions video
See https://github.com/github/docs-internal/pull/16759

* Remove typos

* update article name in test

Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: hubwriter <hubwriter@github.com>
Co-authored-by: James Fletcher <42464962+jf205@users.noreply.github.com>
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Co-authored-by: Jeff Saracco <jeffsaracco@github.com>
Co-authored-by: skedwards88 <skedwards88@github.com>
Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com>
Co-authored-by: Meg Bird <megbird@github.com>
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
Co-authored-by: Cynthia Rich <crichID@github.com>
Co-authored-by: Cynthia Rich <crichID@users.noreply.github.com>
Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2020-12-08 12:20:02 -05:00
Sarah Schneider a161a5923b lint 2020-12-08 11:40:52 -05:00
Sarah Schneider 117bd5fcb8 add new conditional test runs helper 2020-12-08 11:36:53 -05:00
Sarah Schneider 373a1ddd44 lint 2020-12-08 11:30:21 -05:00
Sarah Schneider e51842b586
Merge branch 'main' into early-access-tweaks 2020-12-08 11:10:42 -05:00
Sarah Schneider 4b1988d8a8
Merge branch 'main' into skip-early-access-tests 2020-12-08 11:10:33 -05:00
Sarah Schneider b75f18f2d2 yank outdated tests 2020-12-08 09:30:32 -05:00
Meg Bird 754ceda517
[Universe] Discussions Public Beta (#16547)
* Update README

* create structure for discussions landing page

* is everything broken

* [Universe] Dark mode (#16545)

* Fix title

* Add Discussions product

* Correct title

* Correct title

* Move quickstart article

* Move quickstart back out into article

* Add and incorporate reusables

* Move information about search

* Draft conceptual information

* Draft best practices

* Draft further reading

* Draft product introduction

* Draft introduction

* Add author metadata

* Pluralize

* Fix typos

* Add introduction

* Bump Octicons

* Add some reusables

* Add images

* Revise article

* Draft article

* Change word

* 🔪 the gerund

* Add reusable

* Revise introduction

* Revise list

* Simplify

* Revise reusable

* Fix reusable; add context

* Rename reusable

* Deduplicate conceptual information

* 🔪 gerund

* Add link to further reading

* Move link and dispose of tip

* Delete space

* Add images

* Add conceptual section

* Add word

* Delete newline

* Revert package.json to state on main

* Tweak images

* Draft article

* Add product name

* Remove beta note

* Use product name for future-proofing

* Begin adding search information

* Fix copypasta

* little edits

* build out a bit more of the guides content

* Don't mention integrations for now

* Escape quote

* Remove authorship information for new defaults

* Finish drafting article

* Replace encoded character to match description

* Revise away inline link

* Accommodate 'for more information' in reusable

* Fix links

* Fix one last bit of copypasta

* Update indices

* Temporarily remove heading

* Update introduction

* Add new article 💀

* Remove commits from universe-2020-megabranch

* Add article 💀

* update with a very rough draft

* Add content about collaboration options to "About repositories"

* Add content about discussions to "About issues"

* Reorder content

* Add is:discussion query

* update with a few mmore fleshed out sections

* update with more structure

* Add reusable

* Add screenshots

* Clear way for actual procedural

* Discussions landing page "Communities" section (#16692)

* Make button Overview-able

* Make card filtering more extensible

* Guard for missing attributes

* Use arbitrary dataset attributes

* Add section with discussions-community-card

* Tweak show more button behavior

* Conditionally show "Show more"

* Add beta_product frontmatter/label

* Remove beta callout note

* Hide changelog with no items

* Finish importing community info

* Fix borked markup

* Omit search abr

* Two columns should actually be two columns

* Use org image, change card layout

* Add two more examples

* Fix title

* Escape quote

* Escape another quote

* Draft article

* Lower case

* Relocate conceptual information

* Update qualifier name

* Draft article

* Add conceptual information and links

* Remove duplicative section

* Fix copypasta

* Revise reusable

* Update link

* Add content on categories

* Lint the discussions YAML file

* Update introduction and permissions

* 

* Reusablize; fix link

* more planning content stuff

* Escape quotes

* Align prerequisites

* Soften

* Clean up prerequisites

* Fix titles; version; add screenshot

* Fix links

* Actually fix links

* Use better variable

* Mention pinning

* Update screenshots

* Add screenshot

* forgot to committ

* update with reusable

* add that screenshot

* beef up landing page a bit

* remove extra space

* messed that up

* fix hardcoded linkks weirdo

* fix tests

* update with permissions content

* update with placeholder

* filter out standalone category files from test

* update

* update @becca's  feedback

* update with more feedback

* so many updates

* fix links

* fix some more tests

* flesh some more things out

* update with further reading blah blah

* fix some things

* remove the gate-features label for beta ship only

* Add discussions video to product landing page (#16759)

* Add discussions video placeholder

* This might work maybe

* fix tests

* apply all of @becca's and @lecoursen's  feedback ❤️

* rename to fix test

* Revert "Add discussions video to product landing page (#16759)"

This reverts commit 2247e5d0881ca6b36cee421218e8341a7cc12ac7.

* update with test fix

Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
Co-authored-by: Laura Coursen <lecoursen@github.com>
Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com>
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
2020-12-07 15:00:35 -07:00
Sarah Schneider 2e8b8d3802 test Early Access breadcrumbs 2020-12-07 16:18:11 -05:00
Sarah Schneider 59c0b8f9b8 Merge branch 'check-links-improvement-redux' of github.com:github/docs-internal into check-links-improvement-redux 2020-12-07 11:56:34 -05:00
Sarah Schneider ef82435371 check repo 2020-12-07 09:55:24 -05:00
Rachael Sewell 0244ff4ad5
add openapi test from rest-api-operations (#16630) 2020-12-03 15:36:58 -08:00
James M. Greene fb30a0766f
Unravel pages (the array + map object) (#16708)
* Revise the 'pages' module to export two methods: 'loadPages' and 'loadPageMap'

Update all existing references to use 'loadPages' for now

* Remove explicit Promise resolutions on loadPage* methods

* Condense reduction method into its now-singular usage spot

* Opt for for-of instead of forEach

* Make require of pages in warm-server more explicit

* Be more explicit about find-page using a pageMap

* Be more explicit about find-page-in-version using a pageMap

* Be more explicit about site-tree using a pageMap

* Extract the map creation from loadPageMap

* Be more explicit about using a pageMap

* Update redirects precompile to take two arguments: pageList, pageMap

* Rename internal loadPages method to loadPageList

* Clarify pageMap is what is stored in context.pages

* Use loadPageMap in tests and stuff
2020-12-03 22:31:10 +00:00
Sarah Schneider c0b7195057
Fix Early Access tests (#16749)
* fix early access tests

* Update lint-files.js

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2020-12-03 21:07:22 +00:00
Sarah Schneider e469cf25b4
Merge branch 'main' into check-links-improvement-redux 2020-12-03 15:54:18 -05:00
James M. Greene c7870f44b7
Skip EA articles test temporarily (#16748) 2020-12-03 20:52:38 +00:00
Kevin Heis 30cdb3173b
Allow repo sync in public repo (#16746)
* Allow repo sync in public repo

* Update repository-references.js

* Update lint-files.js
2020-12-03 19:19:23 +00:00
Sarah Schneider ca39999daf update hidden page expectations 2020-12-03 12:55:57 -05:00
Sarah Schneider 82644efc7c Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-03 12:06:18 -05:00
Kevin Heis 11d8e415da
Check repository references (#16680)
* Check repository references

* Remove "foundRepoNames" that I used to find all the unique names

* A little speed up with Set

* Ignore a few files

* Remove remaining references

* Update README.md
2020-12-03 16:41:03 +00:00
Sarah Schneider 2f10991ea5 Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-03 10:29:46 -05:00
James M. Greene 4e1d62b91a
Remove free-pro-team support from Spanish translation of Insights doc (#16730)
* Remove free-pro-team support from Spanish translation of Insights doc

* Throw errors for mismatched products in non-English content pages as well
2020-12-02 22:07:56 +00:00
Sarah Schneider 1b051afa18 Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-02 15:13:43 -05:00
Kevin Heis e3cfacd8df
Fix robots.txt from being self repeating (#16705)
* Fix robots.txt from being self repeating

* Add test to make sure robots doesnt have duplicate lines
2020-12-02 19:45:22 +00:00
Sarah Schneider 1258092a41 Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-02 14:22:10 -05:00
Robert Mosolgo a7d042a898
Merge branch 'main' into build-changelog 2020-12-02 13:56:50 -05:00
Sarah Schneider 7628caa417 Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-02 12:47:54 -05:00
Kevin Heis 685e7a3655
Remove unsafe eval (#16704)
* Remove unsafe eval

* Actually, we're not using this anyways

* Reset package-lock, I have no idea why this keeps changing

* Update csp.js

* Update server.js
2020-12-02 16:19:14 +00:00
James M. Greene 684a72077f
Fix the browser tests by using a newer version of Puppeteer (#16707)
Improve 2 async-callback-based tests by counting their assertions
2020-12-01 19:17:05 -06:00
Sarah Schneider 6304c863fe lint 2020-12-01 13:07:00 -05:00
Sarah Schneider b244d447dd Merge branch 'main' of github.com:github/docs-internal into hidden-docs-alt 2020-12-01 12:38:48 -05:00
Sarah Schneider 432d13fd32 Add more detail in comment 2020-12-01 10:25:23 -05:00
Sarah Schneider 74fe86d91e clarify what is happening with the context objects 2020-12-01 10:16:05 -05:00
Sarah Schneider da1427f812 Merge branch 'main' of github.com:github/docs-internal into build-changelog 2020-12-01 09:40:04 -05:00
Sarah Schneider a8e12608fa
Update tests/helpers/links-checker.js
Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
2020-11-30 13:26:41 -05:00
Sarah Schneider f483874687 lint 2020-11-25 20:12:45 -05:00
Sarah Schneider 7ee7d1ef26 delete no longer needed link checking code 2020-11-25 20:04:30 -05:00
Sarah Schneider 08d548a978 add new link checking code 2020-11-25 20:04:04 -05:00
Sarah Schneider 23ca5270b7 add test 2020-11-25 19:22:32 -05:00
Robert Mosolgo 9e5d72eb42 Merge branch 'main' into build-changelog 2020-11-25 16:32:10 -05:00
Robert Mosolgo fc54b4d43c Fix lint errors 2020-11-25 16:30:37 -05:00
Jason Etcovitch 4484068e01
Move render-content code to this repo (#16544)
* Move render-content files in here

* Replace existing file with nested index.js

* Copy in tests and jest-ify

* Update docs

* Uninstall @github-docs/render-content

* Bring over README

* Add missing dependencies

* Fix require paths
2020-11-25 11:20:23 -05:00
Robert Mosolgo aeedfac37e Add graphql tests to CI, move snapshots to fixures, use mockdate 2020-11-25 11:12:13 -05:00
Jason Etcovitch 1ec8c35e34
Refactor indented_data_reference to use Liquid internals (#16623)
* Refactor indented-data-reference

* Add spacing around referenced reusables

* Update expected test output

* Fail silently with empty valuer
2020-11-24 16:50:20 -05:00
Sarah Schneider 18d25f6129 update references to old helpers.js 2020-11-24 15:42:11 -05:00
Sarah Schneider 3121eae634 move tests/helpers.js into subdir and rename 2020-11-24 15:41:38 -05:00
Sarah Schneider 6662e027b0 let, not const and one more regex tweak 2020-11-23 13:04:11 -05:00
Sarah Schneider 10c7ba7855 include full content including frontmatter, and tweak some regexes 2020-11-23 12:51:15 -05:00
Robert Mosolgo b87ca3b3e3 Fix lint errors 2020-11-23 08:55:05 -05:00
Robert Mosolgo 2400be9528
Merge branch 'main' into build-changelog 2020-11-23 08:44:32 -05:00
Robert Mosolgo ab06aadf82 Add changelog creation to update-files.js 2020-11-23 08:42:12 -05:00
Robert Mosolgo f2119bc619 Add a test for updating the changelog file on disk 2020-11-23 08:17:57 -05:00
Robert Mosolgo 360c517a7d Add upcoming changes to build-changelog 2020-11-23 08:08:00 -05:00
Robert Mosolgo 9d5af1f98d Create preview changes entries 2020-11-23 07:15:22 -05:00
Robert Mosolgo 96e4ea9499 Set up tests, start formatting messages 2020-11-20 17:02:21 -05:00
Kevin Heis 912ac50034
End AB test on moving helpfulness prompt to bottom (#16552)
* End AB test on moving helpfulness prompt to bottom

* Move helpfulness to bottom of page only

* Update helpfulness.js

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
2020-11-20 12:24:33 -08:00
Jason Etcovitch cc719ffb6f
Render Enterprise release notes on docs.github.com (#16367)
* Create basic layout

* Create stubbed out release note YAML

* Get a real implementation going

* Simplify using site-data

* Add a real page to send from render-page.js

* Use array of patches

* Render patches

* Add sidebar and breadcrumbs

* Reverse order

* Add date

* Tweak labels

* Redirect to entweb for missing versions

* Render patch.intro

* Move to separate files for patches

* Show support for RC versions

* Improve some comments

* Sticky headers!

* Remove a console log

* Improve example formatting

* Add a link on /admin

* Add a schema and test

* Move to /index.md, add version_num filter

* Improve layout

* Use <details>

* Placeholder more realistic notes

* Don't require links in index pages

* Remove admin/index link for now

* Remove unused frontmatter field

* Add a test for middleware

* Fix remaining YAML file to test CI

* Update 2-rc.yml

* Don't call it RC

* Just push

* Make a main a div

* Fix a borked class

* Lint YAML files

* Improve Download link

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Improve check order

* Move to contextualizers

* Use alternative version thing

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Move back to `release-notes.md`

* Use version for anchor IDs

* Undo category-pages test change

* Fix borked details layout in Chrome

* Improve mobile setup

* Render markdown in note tags

* Use allVersions[currentVersion] again

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Undo change to extended-markdown

* Add whitespace so it renders markdown bits

* Remove 2-22 files

* Add check for any release notes

* Fix the failing tests

Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-11-20 13:33:11 -05:00
Jason Etcovitch 52dbd92144
Rewrite links in Page.intro with language (#16550)
* Add defaultLanguage behavior

* Add a million logs because I'm confused

* Rewrite intro links

* Undo changes to detect-language

* Add a test
2020-11-19 15:53:35 -05:00
Sarah Schneider 0c3a46f205 update asset path for <2.13 CSS files 2020-11-18 12:53:39 -05:00
Sarah Schneider 84f0aac8f6 Merge branch 'main' of github.com:github/docs-internal into deprecate-2.19 2020-11-17 21:20:38 -05:00
James M. Greene d402a60833
Merge branch 'main' into hidden-docs-alt 2020-11-17 17:56:25 -06:00
Jason Etcovitch 8f2b4eb450
Merge branch 'main' into repo-sync 2020-11-17 18:02:58 -05:00
James M. Greene 72d1265ebc Fix lint-files tests for Early Access to use newly established pattern 2020-11-17 16:30:08 -06:00
James M. Greene b04f01d890 Ignore early-access as a product for the category-pages tests? 2020-11-17 16:22:44 -06:00
James M. Greene 1280f6f06c Fix rendering tests for /early-access 2020-11-17 16:18:54 -06:00
Sarah Schneider a3559e12bd remove test that should have been removed in #16490 2020-11-17 16:34:20 -05:00
Nick Schonning b6de7c6887
chore: Convert Standard to eslint-config-standard (#1328)
* chore: Move standard to ESLint config

* fix: auto-fix ESLint indent issues

* fix: ESLint prefer-regex-literals

* fix: ESLint array-callback-return

- .filter must return a boolean value
- .map replaced with forEach when the value isn't used

* fix: ESLint no-extra-semi
2020-11-17 16:18:18 -05:00
Kevin Heis 890e86cc46
Merge branch 'main' into hidden-docs-alt 2020-11-17 09:58:45 -08:00
James M. Greene 04dff854c2 Include other actions-only EA-cloning tests now 2020-11-17 11:50:18 -06:00
Sarah Schneider 8bb7120185 lint 2020-11-17 11:45:18 -05:00
Sarah Schneider bed7ecc890
Update tests/routing/deprecated-enterprise-versions.js
Co-authored-by: Jason Etcovitch <jasonetco@github.com>
2020-11-17 11:37:54 -05:00
James M. Greene a53255c8c9 Add tests for site-data-references within article metadata 2020-11-17 09:56:21 -06:00
James M. Greene 5c6f5bb351 Fix site-data-references tests by using uniqWith instead of uniqBy 2020-11-17 09:55:34 -06:00
Sarah Schneider a895ef68ba update tests 2020-11-16 20:07:04 -05:00
Sarah Schneider a8f16c63f7
Do not include feedback links in deprecated GHES versions (#16485)
* do not render if this is the oldest supported GHES release

* add tests
2020-11-16 17:09:19 -05:00
Kevin Heis dd02bfa007 Merge main 2020-11-16 10:07:53 -08:00
Kevin Heis 714ca0263b
Add `hostname` to events (#16419)
...so that its easier to filter out localhost and herokuapp domains
2020-11-16 09:49:12 -08:00
James M. Greene 510a0e3871 Add test to verify Early Access does not show up as a product in the sidebar 2020-11-13 15:48:10 -06:00
James M. Greene 272c4722d2 Add new content-linting tests for Early Access 2020-11-13 13:40:25 -06:00
jmarlena 45398e709c
Password authentication and OAuth Authorizations API deprecation (#16375)
* Version password examples for GHES only

* Remove unnecessary note

* Versioned deprecation reusable for GHES only?

* Update troubleshooting article

* Version OAuthorizations REST API page for enterprise-only

* Remove deprecations reusable

* Add tentative note

* Rework two-factor authentication sections

* Fix double redirect reference

* versioning tweak

* Versioning tweaks

* adding back the endifs

* random link reformatting

* OAuth Authorization API versioned for 2.22

* /

* Fix internal docs links

* remove static redirect for dotcom

* Try deleting redirect

* Apply @martin389's suggested changes

Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>

* Remove best practice assumptions

* Apply suggestions from code review

Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>

* Add note

* restore redirects in content file and remove free-pro-team expected path from test fixture

* change note position

* handle path that was available on dotcom in developer site but is now GHES only

Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@github.com>
2020-11-13 11:01:17 -08:00
Sarah Schneider 5705d334ca
Header notification updates (#16425)
* remove middleware that sets notification flags

* move all notification handling into includes/header-notification.html

* update tests
2020-11-12 16:27:29 -05:00
Jason Etcovitch 9e38a854b9
Filterable code examples on Actions landing page (#16276)
* Add custom hover shadows

* Support avatars

* Add guide-card include

* Use it in product-landing

* Add gradient styles

* Add guides frontmatter

* Use guideArticles instead of full objects

* Add support for authors

* Add support for category header

* Just pass the whole page

* Use it

* guide.url => guide.href

* Use `*.githubusercontent.com`

* Fix mobile card width

* Remove showDescription check

* Use featureLinks.guideCards

* Forgot an if

* Add contextualizers/actions-code-examples

* Use code-example-card include

* Tweak sizing/shadows

* Add a basic filterer

* Some visual tweaks

* labels => tags

* Cleanup some code

* Improve spacing on mobile

* Add "No results!" blurb

* Fix a boog

* Tweak spacing

* Remove support banner

* Improve "No results" state

* Just use login instead of name/avatarUrl

* Change card spacing

* Use circular avatars

* Add "Show more" button

* Add margin beneath "Guides"

* Use smaller font

* Assume github.com for code examples

* Show two columns at small screen

* Make "Show more" a btn

* Use the "repo" octicon

* Link to contributing guide

* Use a YAML file instead of a middleware

* Link straight to the file

* Fix some wonky markuip

* Fix a broken link

* Fix the borked test

* Allow variables that aren't strings

* Fix remaining tests
2020-11-12 11:35:43 -05:00
James M. Greene b75cb104c2 Make Early Access tests only run on the docs-internal repo 2020-11-10 15:25:18 -06:00
James M. Greene 3e0d94ec91 Fix pathing on CrowdIn config tests 2020-11-09 23:05:42 -06:00
James M. Greene 4fac3decec Comment out premature tests 2020-11-09 23:04:24 -06:00
James M. Greene e1f3f6457e
Merge branch 'main' into hidden-docs-alt 2020-11-09 13:09:52 -06:00
James M. Greene f410fd175c Mostly reverting github/docs-internal#15313 2020-11-09 13:07:04 -06:00
Sarah Schneider dfb29cfb59
Remove no longer needed middleware (#16384)
* remove no longer needed middleware

* remove accompanying test
2020-11-06 14:14:28 -05:00
Nick Schonning 87e8d1b4b0
chore: Remove locales from docs.microsoft.com urls (#1011) 2020-11-04 14:43:27 -08:00
Sarah Schneider c4b50183a2 update docs path in newly added robots test 2020-11-03 17:17:43 -05:00
Sarah Schneider 0cf94f26b7 Merge branch 'main' of https://github.com/github/docs-internal into hidden-docs-alt 2020-11-03 17:09:22 -05:00
Sarah Schneider ba310bf991
Support GHAE in Algolia (#16315)
* add frontend search support for GHAE version

* add support for GHAE version to Algolia sync

* add browser tests for frontend search

* if a version can be derived from a path, but it is not a real version (like from a path that 404s), fall back to dotcom

* Update javascripts/search.js

* Update lib/algolia/sync.js
2020-11-03 15:35:56 -05:00
Kevin Heis 8b8d6d24d3
Merge branch 'main' into hidden-docs-alt 2020-11-03 10:19:14 -08:00
Jason Etcovitch 5d09adb106
Add/use small-footer for Actions landing page (#16265)
* Add/use small-footer

* Fix borked HTML

* Extract scripts to new include

* Add spacing

* Fix some padding

* Fix a test that uses /actions

* Fix old links

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Update /developers in general footer

* Don't hard code free-pro-team

* Use the small-footer everywhere

* Tweak border

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-11-03 13:12:25 -05:00
Chiedo John 7924aea2f8
Instruct search engines to not crawl archived versions (#16292)
* Instruct search engines to not crawl archived versions

* Update middleware/robots.js

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Add test

* Fix spooky bug

Co-authored-by: Chiedo <chiedo@users.noreply.github.com>
Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-11-03 08:23:22 -05:00
Matt Pollard 2484cd3f16
Add external GitHub CLI product (#16277) 2020-11-03 08:11:49 +01:00
James M. Greene 521d11b6a4
Merge branch 'main' into hidden-docs-alt 2020-11-02 18:03:48 -06:00
Laura Coursen a3e1733aa1
GitHub AE (GHAE) (#16090) 2020-11-02 15:12:44 -06:00
Sarah Schneider 63e3f917c6 Merge branch 'main' of https://github.com/github/docs-internal into hidden-docs-alt 2020-11-02 14:21:19 -05:00
Jason Etcovitch 174d8539c6
Support arbitrary keys in new featuredLinks frontmatter (#16239)
* Add featuredLinks to frontmatter

* Parse them in featured-links.js

* Remove old raw setup

* Use them

* Missed a couple

* Update translation files

* Fix frontmatter schema

* Loop over the right object

* Also update translations' usage

* Update docs and tests

* Better README comment

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>

* Return next()

Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
2020-10-27 13:53:10 -04:00