067611679d
fix build script exit code and fix typo in README ( #1472 )
2024-11-20 10:41:47 -08:00
42c0f0823a
Tweak the testcontainers setup ( #1460 )
...
* Allow skipping port validation in tests.
* Add more test coverage.
* Fix linter.
* Fix DSN string generation.
* Add a `Migrator` test.
* Add a tmp folder.
* Make the linter happy.
* Add tests for `Streamer`.
* Close the `Streamer`.
* Fix linter issue.
* ignore contextcheck linter
---------
Co-authored-by: meiji163 <meiji163@github.com>
2024-11-18 14:00:58 -08:00
a6ccd3feaf
fix: onSuccess hook to run after INSTANT ( #1463 )
...
previously, no hooks would run after a successful INSTANT DDL,
which is an unexpected behavior.
2024-10-31 10:51:27 -07:00
7c30fb083a
Merge pull request #1462 from github/meiji163/multi-stmt
...
Use multiStatement to apply DML
2024-10-25 12:03:18 +02:00
2e62f2a839
set session outside of transaction
2024-10-24 14:07:20 -07:00
c1b600085c
add arthurscreiber's review suggestions
2024-10-24 12:03:26 -07:00
1bd2b0be49
Fix named value building.
2024-10-24 07:34:47 +00:00
2a3318c8b6
conn.Raw not working
2024-10-23 18:55:55 -07:00
90d6148dc4
fix test
2024-10-23 16:08:57 -07:00
a7e4601a69
use multiStatements to apply DML
2024-10-23 15:56:33 -07:00
a834c00f0a
Merge pull request #1459 from github/danieljoos-dml-query-builders
...
Improve query building routines of DML event queries, reducing time and allocations
2024-10-23 16:54:14 +02:00
5c0829a9c5
Merge branch 'master' into danieljoos-dml-query-builders
2024-10-23 16:40:11 +02:00
30f28c24ce
Merge pull request #1455 from github/arthur/dont-lock-rows
...
Avoid causing deadlocks when copying rows on busy tables
2024-10-23 16:39:24 +02:00
5ddeb21d22
Only use `NOWAIT` on MySQL 8.
2024-10-23 12:40:40 +00:00
ab74e9927c
Add doc comments and remove old DML query builder functions
2024-10-23 11:38:32 +00:00
4608dcbcab
Temporarily moving one check on column lists to `DMLUpdateQueryBuilder.BuildQuery()`
2024-10-23 08:43:04 +00:00
a91c386f5c
Only specify `for share nowait` on transactional tables.
2024-10-22 21:39:22 +00:00
095fb267f2
Fix linter issues.
2024-10-22 21:07:00 +00:00
16a88d8425
Add `for share nowait` option.
2024-10-22 18:56:26 +00:00
590f875360
Merge branch 'master' of https://github.com/github/gh-ost into arthur/dont-lock-rows
2024-10-22 17:56:24 +00:00
412346ea78
Use query builders for DML event queries
2024-10-22 14:30:06 +00:00
9af3a077e0
Merge pull request #1458 from github/arthur/use-testcontainers
...
Use testcontainers to spawn MySQL server container in unit tests. #1457
2024-10-21 22:04:55 +02:00
b34b86df79
Make linter happy,
2024-10-21 15:58:53 +00:00
00f450d874
Merge pull request #1456 from github/arthur/use-stretchr-testify
...
Switch all unit tests to use `stretchr/testify` for assertions.
2024-10-21 17:47:13 +02:00
db9c69ab0f
Use testcontainers to spawn MySQL server container in unit tests.
2024-10-21 13:49:46 +00:00
96f841ad91
Switch all unit tests to use `stretchr/testify` for assertions.
2024-10-21 13:34:56 +00:00
0a0d1f4848
Do not lock rows when copying.
2024-10-20 10:14:15 +00:00
48cb9ab7c7
Refine `wait_timeout` override to be at cut-over only ( #1406 )
...
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
2024-08-15 20:29:52 +02:00
1e1fbcbd43
Ensure `-attempt-instant-ddl` respects `-execute` flag ( #1440 )
2024-08-14 11:23:00 +02:00
59db6fab40
chore: fix some function names ( #1417 )
...
Signed-off-by: overallteach <cricis@foxmail.com>
2024-06-03 01:21:08 +02:00
e87e2abd99
Bump golangci/golangci-lint-action from 4 to 6 ( #1414 )
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 4 to 6.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v4...v6 )
---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-08 00:32:40 +02:00
8d99e46c3e
chore: fix function names in comment ( #1405 )
...
Signed-off-by: mountcount <cuimoman@outlook.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
2024-04-15 01:39:30 +02:00
e6c198c940
Update to go1.22, update core deps to latest-stable ( #1404 )
...
* Update to go1.22, update core deps to latest-stable
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* update script/ensure-go-installed
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* git add vendor --all
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* go 1.22.0
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
---------
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: meiji163 <meiji163@github.com>
2024-04-10 08:26:21 -07:00
329b13dc6b
Add doc for PR #1401 ( #1403 )
...
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
2024-04-09 03:33:46 +02:00
c681f6163d
Add `--mysql-wait-timeout` flag ( #1401 )
2024-04-08 19:04:38 +02:00
bc6cd55ea5
Update the description of the max-lag-millis in docs ( #1388 )
...
* Update description for max-lag-millis in command-line-flags.md
* Update command-line-flags.md
---------
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
2024-03-13 00:58:57 +01:00
48b34bcbfd
Fix binlog end log pos over lost data ( #1367 )
...
* fix(fix binlog end-log-pos over 4g lost data): fix binlog end-log-pos over 4g lost data
* fix(fix-binlog-end-log-pos-over-lost-data): fix-binlog-end-log-pos-over-lost-data
Calculate whether the binlog log_pos overflows beyond 4G using end_log_pos and event_size.
* fix(x): x
x
* test(fix-binlog-end-log-pos-over-lost-data): add unit test
* fix(fix-binlog-end-log-pos-over-lost-data): x
x
* Update binlog.go
change IsLogPosOverflowBeyond4Bytes comment.
* Update binlog.go
x
* fix(fix-binlog-end-log-pos-over-lost-data): fix doc
x
---------
Co-authored-by: shaohoukun <shaohoukun@meituan.com>
Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: meiji163 <meiji163@github.com>
2024-03-12 16:10:08 -07:00
9ca2499075
Update pinned deps ( #1355 )
...
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: meiji163 <meiji163@github.com>
2024-03-12 16:26:19 +01:00
27a672d8b7
Bump golangci/golangci-lint-action from 3 to 4 ( #1392 )
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](https://github.com/golangci/golangci-lint-action/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-11 22:31:29 -07:00
6b3c6ba472
Bump actions/setup-go from 4 to 5 ( #1395 )
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](https://github.com/actions/setup-go/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: actions/setup-go
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: meiji163 <meiji163@github.com>
2024-03-11 22:21:42 -07:00
a05f32fa64
Bump CodeQL actions ( #1391 )
...
* Bump actions/upload-artifact from 1 to 4
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 1 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v1...v4 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* update codeQL action
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: meiji163 <meiji163@github.com>
2024-03-11 22:11:45 -07:00
17149b99ed
Add Dependabot config file ( #1213 )
...
Co-authored-by: meiji163 <meiji163@github.com>
2024-03-11 21:42:49 -07:00
aa010a0488
Support to config charset and collation ( #1368 )
...
* feat(feat-config-connection-charset): support config connection charset
* feat(feat-config-connection-charset): feat-config-connection-charset
The ability to specify character set and collation is supported.
---------
Co-authored-by: shaohoukun <shaohoukun@meituan.com>
2024-03-11 19:23:05 -07:00
b1aae87c26
Add `cpu-profile` interactive command ( #1358 )
...
* Add cpu-profile interactive command
* better doc markdown
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* set block profile after isProfiling=1
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* improve test
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* check isCPUProfiling later
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* Cleanup
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* Fix discrepancy
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* move base64 to .applyServerCommand(...)
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
---------
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Co-authored-by: meiji163 <meiji163@github.com>
2024-01-31 22:34:01 +01:00
3aa69124d4
Merge pull request #1375 from github/update-codeowners
...
Update CODEOWNERS
2024-01-31 17:02:48 +00:00
6f09ee0abe
Merge branch 'master' into update-codeowners
2024-01-31 16:44:27 +00:00
a6cddf9b53
Print status to migration context logging after escaping % character ( #1374 )
2024-01-31 08:41:09 -08:00
51c1a214fc
Update CODEOWNERS
...
Remove `@dm-2` as I am no longer a maintainer for gh-ost.
2024-01-31 14:32:11 +00:00
11d66d8dc4
Fix successive failures error in streamer ( #1371 )
2024-01-23 19:46:19 +01:00
59fd18dc90
Add `CODEOWNERS` file to auto-request reviews ( #1350 )
...
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
2023-12-12 02:35:17 +01:00
He Wang
Arthur Schreiber
Artem Vovk
meiji163
Daniel Joos
Tim Vaillancourt
overallteach
dependabot[bot]
mountcount
dontstopbelieveing
Shao Hou Kun
Sentinel Reviewer
dm-2
Siddharth Kannan