Mislav Marohnić
0ada3c473e
Fix normalization of commit summary in pull request test
...
https://travis-ci.org/github/hub/builds/38441514
2014-10-19 23:58:49 +02:00
Mislav Marohnić
44aefe7728
Fix git commit summary in pull request message template
...
Use "origin/<base>" and "origin/<head>" for git commit comparison and
summary in the pull request template instead of the local branch
equivalents, since the local branches could be out of date with the
remote tracking branches.
2014-10-19 23:41:45 +02:00
Mislav Marohnić
69f66e0556
Grammar tweak in pull request message template
...
"The first block of the text"
becomes:
"The first block of text"
The definite article was not needed here.
2014-10-19 23:41:45 +02:00
Jingwen Owen Ou
12445c14fe
Merge pull request #643 from github/fix_version
...
[gh] Print hub version instead of gh
2014-10-19 12:40:10 -07:00
Jingwen Owen Ou
89ef033c75
Print hub version instead of gh
2014-10-19 12:36:02 -07:00
Jingwen Owen Ou
c78fe8b4a4
Merge pull request #641 from github/gh
...
[gh] Go powered Hub 2.0
2014-10-19 12:23:29 -07:00
Jingwen Owen Ou
cc2b958e89
Merge pull request #640 from github/show_git_help
...
[gh] Show git’s own help when running `hub help <command>` for git commands
2014-10-19 09:59:32 -07:00
Jingwen Owen Ou
1b0d45420c
Show git’s own help when running `hub help <command>` for git commands
...
This is to fix https://github.com/github/hub/issues/635
2014-10-19 09:56:46 -07:00
Jingwen Owen Ou
ca7c0f8450
Merge pull request #639 from github/merge_master
...
[gh] Fix cuke failure due to missing port for original request
2014-10-19 09:13:53 -07:00
Owen Ou
7fada87cf5
Fix cuke failure due to missing port for original request
2014-10-17 16:23:33 -07:00
Owen Ou
11f0eb39d6
Merge remote-tracking branch 'origin/master' into gh
2014-10-17 16:02:37 -07:00
Jingwen Owen Ou
a39ce5428c
Merge pull request #637 from github/fix_cherry_pick_empty_args
...
[gh] Fix exception when having no args for cherry-pick
2014-10-17 08:50:25 -07:00
Jingwen Owen Ou
2914ff1f29
Merge pull request #638 from github/fix_crash_report_repo
...
[gh] Point crash report repo to github/hub
2014-10-17 08:49:18 -07:00
Owen Ou
81df5e3134
Point crash report repo to github/hub
2014-10-16 12:03:03 -07:00
Owen Ou
8e340bd0eb
Fix exception when having no args for cherry-pick
...
https://github.com/jingweno/gh/issues/223
2014-10-16 11:55:08 -07:00
Jingwen Owen Ou
9694397a1d
Merge pull request #634 from github/release_script
...
Clean up package script
2014-10-16 08:33:30 -07:00
Jingwen Owen Ou
5b4e7f462f
Bump to Go 1.3.3 for Linux Vagrant build box
2014-10-16 08:15:18 -07:00
Owen Ou
c8ffd06ec3
Build Hub in a temporary dir for cukes
...
We need to run the packaging script for every platform using a Vagrant box. During the packaging step, cukes are run. However, the workspace is shared between host and the Vagrant box. Instead of cleaning up the built binary for each platform, build it into a temporary dir.
2014-10-15 16:18:28 -07:00
Owen Ou
43e1abcb72
Use `IO.popen` to execute command
2014-10-15 15:33:14 -07:00
Owen Ou
9fc5f2ad72
Check Process.exitstatus since Process.existed? is always true
2014-10-15 13:05:22 -07:00
Owen Ou
9e88c9c377
Run bootstrap script before test
2014-10-14 08:56:57 -07:00
Owen Ou
e61fb24970
Run tests as part of the packaging process
2014-10-14 08:39:04 -07:00
Owen Ou
df0c90f3c7
Add version to build artifact
2014-10-14 08:32:06 -07:00
Jingwen Owen Ou
69660ca452
Clean up package script
...
* Prefer Ruby script to `gotask` script for packaging task
* Clean up Vagrant file
* Prefer `gox` to `goxc`
2014-10-13 23:58:52 -07:00
Mislav Marohnić
3fad589b6e
Merge pull request #626 from github/fix-uri-port
...
Tweak URI implementation for compatibility with stdlib
2014-09-22 22:59:04 -07:00
Mislav Marohnić
b311b7b343
Ensure tests use URI from speedy_stdlib even if Bundler loaded URI
...
When running through `bundle exec`, Bundler will have loaded URI already
which will make our speedy_stdlib skip redefining it.
Aggressively undefine URI if loaded through Bundler so that our tests
perform against our implementation, not the stdlib one.
2014-09-22 22:52:44 -07:00
Mislav Marohnić
38dbd312f7
Tweak URI implementation for compatibility with stdlib
...
When `url.scheme` is changed from "https" to "http" when someone
configured their Enterprise instance to be used over insecure protocol,
the "speedy" implementation changed the port as well, but the stdlib
implementation doesn't. Things would break if someone used hub in an
environment where stdlib URI was already loaded, like for instance from
RubyGems.
2014-09-22 16:40:35 -07:00
Mislav Marohnić
3294fe5560
Merge pull request #601 from github/no-curl
...
gh: Move away from using curl for patches and to GitHub API
2014-09-22 08:22:04 -07:00
Jingwen Owen Ou
5603206826
Add Go test for overriding URL
2014-09-21 14:07:08 -07:00
Mislav Marohnić
144df2d3cd
Use io.Copy to write an io into the tempfile
2014-09-21 09:38:30 -07:00
Mislav Marohnić
8813153bf9
TempFile already uses TempDir by default
2014-09-21 09:37:55 -07:00
Jingwen Owen Ou
93ee3123ee
Merge branch 'no_update' into gh
2014-09-21 08:53:20 -07:00
Mislav Marohnić
cac0abae06
Have `am/apply` use API for getting patches instead of curl
...
This enables fetching patches from private repos that you have access to.
2014-09-21 00:30:10 -07:00
Mislav Marohnić
b04869756d
Expect encoding declaration in "Accept" HTTP header
2014-09-21 00:30:10 -07:00
Mislav Marohnić
28add6545e
Reimplement HUB_TEST_HOST support using a custom http.Transport
...
In testing, we want to redirect all requests to a local test server
pretending to be GitHub API, but we want them to preserve their original
"Host" header. A good place to do that transparently is the `RoundTrip`
method that handles every request for this http.Client instance.
2014-09-21 00:30:10 -07:00
Jingwen Owen Ou
cc816c9df8
Provide option to build `hub` without autoupdate
2014-09-20 10:15:42 -07:00
Jingwen Owen Ou
361793368a
Merge branch 'gh_yaml_fix' into gh
2014-09-16 09:59:45 -07:00
Jingwen Owen Ou
e08ecd2a5b
Remove toml related code in cukes
2014-09-16 09:59:43 -07:00
Jingwen Owen Ou
13a84381d5
Turns out Host is an array for the YAML format
2014-09-16 09:59:43 -07:00
Jingwen Owen Ou
0f60c59615
Load yaml config
2014-09-16 09:59:43 -07:00
Jingwen Owen Ou
0a7ee90c51
Add `go-yaml`
2014-09-16 09:59:43 -07:00
Jingwen Owen Ou
ae77e64ff8
Add `yamlConfigEncoder` and `yamlConfigDecoder`
2014-09-16 09:59:42 -07:00
Jingwen Owen Ou
72d8220279
Revert cukes to test yaml config
2014-09-16 09:59:42 -07:00
Jingwen Owen Ou
254bf7c7e7
Merge pull request #620 from github/gh_yaml
...
Refactor to `configService` to read & write `Config`
2014-09-16 09:58:10 -07:00
Jingwen Owen Ou
26255a0566
Merge branch 'bump_deps' into gh
2014-09-14 17:49:06 -07:00
Jingwen Owen Ou
b3d5be4d93
Refactor to `configService` to read & write `Config`
...
`configService` can save and load `Config` using a strategy of `configEncoder` and `configDecoder`. This pave the path for swapping out `tomlConfigEncoder` and `tomlConfigDecoder` with `yamlConfigEncoder` and `yamlConfigDecoder`.
`Configs` also has been renamed to `Config`.
2014-09-14 17:46:13 -07:00
Jingwen Owen Ou
3fdfbad997
Bump Dependencies
...
It includes the latest changes from `go-octokit`
2014-09-14 15:12:16 -07:00
Jingwen Owen Ou
5f996ae980
Merge pull request #617 from yasuoza/gh-fix_merge-message
...
gh: Fix merge PR title to be followed with proper new line
2014-09-11 08:29:18 -07:00
Yasuharu Ozaki
c4b45abef5
Fix merge PR title to be followed with proper new line
...
Now, merge pull-request makes a commit like:
Merge pull request #8 from yasuoza/blahblah\n\nOriginal Pull Request Title
This commit fixes it to:
Merge pull request #8 from yasuoza/blahblah
Original Pull Request Title
2014-09-11 21:18:50 +09:00
Mislav Marohnić
d044e078a3
Merge pull request #605 from github/rubyless-docs
...
Remove Ruby-specific parts of docs in prep for move to Go
2014-09-09 19:52:37 -07:00