зеркало из https://github.com/github/ruby.git
[rubygems/rubygems] Remove very old TODO note
It was added 10 years ago on a "146 additions, 170 deletions" commit named "Deprecation removals and minor cleanup." that didn't explain much other than that. This TODO doesn't necessarily apply nowadays. I don't see how anyways. TODO notes, if useful at all, should include a clear explanation of what should be done either via the note itself or the commit message. This note doens't meet any of these. So I want to remove it because it distracts me every time I go through it. https://github.com/rubygems/rubygems/commit/58d81e8a32
This commit is contained in:
Родитель
76722c4928
Коммит
d5b5a7ab31
|
@ -1006,7 +1006,6 @@ class Gem::Specification < Gem::BasicSpecification
|
|||
# Return currently unresolved specs that contain the file matching +path+.
|
||||
|
||||
def self.find_in_unresolved(path)
|
||||
# TODO: do we need these?? Kill it
|
||||
specs = unresolved_deps.values.map {|dep| dep.to_specs }.flatten
|
||||
|
||||
specs.find_all {|spec| spec.contains_requirable_file? path }
|
||||
|
|
Загрузка…
Ссылка в новой задаче