73bce05b02
Before this change, any deeply nested strcuture would result in a regular Hash
being returned and ptoentially leaving an application open to mass assignment
issues.
hash = {'a' => 1, 'b' => [{'c' => [{'d' => 2, 'e' => 3}]}]}
tainted = TaintedHash.new hash
class_type = tainted[:b][0][:c][0].class
In the above, class_type would be `Hash` instead of `TaintedHash`. So, we now
support deep tainting/untainting to prevent this.
|
||
|---|---|---|
| lib | ||
| test | ||
| .gitignore | ||
| LICENSE.md | ||
| README.md | ||
| Rakefile | ||
| tainted_hash.gemspec | ||
README.md
Tainted Hash
A TaintedHash is a wrapper around a normal Hash that only exposes the keys that have been approved. This is useful in cases where a Hash is built from user input from an external service (such as Rails or Sinatra). By forcing the developer to approve keys, no unexpected keys are passed to data stores. Because of this specific use case, it is assumed all keys are strings.
By default, no keys have been approved.
hash = {'a' => 1, 'b' => 2, 'c' => 3}
tainted = TaintedHash.new hash
You can access keys manually to get the value and approve them:
Use #expose to expose keys.
tainted.include?(:a) # false
tainted['a'] # Returns 1
tainted[:a] # Symbols are OK too.
tainted.include?(:a) # false, not exposed
tainted.expose :a
tainted.include?(:a) # true
tainted.keys # ['a']
If using Rails 2.3, require tainted_hash/rails to setup the necessary hooks.
It amounts to little more than this:
def wrap_params_with_tainted_hash
@_params = TaintedHash.new(@_params.to_hash)
end
Set this up as a before_filter early in the stack. However, it should run
after filters like #filter_parameter_logging that needs to filter any
key.
Note on Patches/Pull Requests
- Fork the project on GitHub.
- Make your feature addition or bug fix.
- Add tests for it. This is important so I don't break it in a future version unintentionally.
- Commit, do not mess with rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
- Send me a pull request. Bonus points for topic branches.