Andrew Eisenberg
88d0bda049
Move source-map-support to dependencies
2022-04-04 12:15:57 -07:00
edoardopirovano
4559c5a38d
Bump version to v1.6.3
2022-04-04 15:28:36 +00:00
Edoardo Pirovano
16bd106abc
v1.6.2
2022-04-04 08:25:23 -07:00
Charis Kyriakou
e5dcec8d8e
Move repository selection code to own module ( #1269 )
2022-04-04 11:03:53 +01:00
Charis Kyriakou
ad3565d3ad
Use the repos defined in the query result instead of the query ( #1268 )
2022-04-04 11:03:05 +01:00
dependabot[bot]
978a82dd1a
Bump ts-node from 8.10.2 to 10.7.0 in /extensions/ql-vscode
...
Bumps [ts-node](https://github.com/TypeStrong/ts-node ) from 8.10.2 to 10.7.0.
- [Release notes](https://github.com/TypeStrong/ts-node/releases )
- [Commits](https://github.com/TypeStrong/ts-node/compare/v8.10.2...v10.7.0 )
---
updated-dependencies:
- dependency-name: ts-node
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-31 18:51:38 +00:00
Andrew Eisenberg
04f72a7da9
Merge pull request #1260 from github/aeisenberg/source-map-support
...
Add source map support and clean test dependencies
2022-03-31 11:42:22 -07:00
Angela P Wen
cc1bf74370
Print end-of-query summary logs to Query Server Console ( #1264 )
...
* Log new end summary file to query server console
* Change supported CLI version to 2.9.0
2022-03-31 16:26:13 +00:00
Andrew Eisenberg
2f7908773a
Merge pull request #1253 from github/aeisenberg/codeSnippet-handling
2022-03-31 07:19:44 -07:00
Andrew Eisenberg
0efd02979e
Merge pull request #1242 from github/aeisenberg/analysis-results-on-restart
2022-03-31 07:19:02 -07:00
shati-patel
bd9776c4b7
Variant analysis: Remove handling of invalid repos
...
This is now done automatically on the API side
2022-03-31 15:15:16 +01:00
Andrew Eisenberg
35e9da83ec
Add source map support and clean test dependencies
...
1. Source map support means that stack traces will point to the *.ts
file instead of the generated *.js file
2. Cleaning test dependencies means moving all mocha and chai
registration into the respective index files and removing unnecessary
imports.
2022-03-30 12:30:18 -07:00
Andrew Eisenberg
43f314b2b5
Change missing code snippet handling in UI
...
Also, simplify sarif tests.
2022-03-30 12:02:19 -07:00
Andrew Eisenberg
4bdf579ce2
Merge branch 'aeisenberg/analysis-results-on-restart' into aeisenberg/codeSnippet-handling
2022-03-30 11:57:24 -07:00
Andrew Eisenberg
aba3039eef
Merge pull request #1257 from github/dependabot/npm_and_yarn/extensions/ql-vscode/sinon-13.0.1
...
Bump sinon from 9.0.2 to 13.0.1 in /extensions/ql-vscode
2022-03-30 11:48:11 -07:00
Andrew Eisenberg
bbff791c65
Merge pull request #1258 from github/dependabot/npm_and_yarn/extensions/ql-vscode/gulp-sourcemaps-3.0.0
...
Bump gulp-sourcemaps from 2.6.5 to 3.0.0 in /extensions/ql-vscode
2022-03-30 11:47:20 -07:00
Andrew Eisenberg
67336a24e7
Simplify checking for downloaded analyses
...
And some renaming.
2022-03-30 11:30:10 -07:00
Andrew Eisenberg
48174c327d
Merge pull request #1246 from github/aeisenberg/repo-filter
...
Add repositories search box
2022-03-30 11:14:27 -07:00
Andrew Eisenberg
43f2539b42
Remove unused css class
2022-03-30 10:54:14 -07:00
dependabot[bot]
462a7a722a
Bump gulp-sourcemaps from 2.6.5 to 3.0.0 in /extensions/ql-vscode
...
Bumps [gulp-sourcemaps](https://github.com/gulp-sourcemaps/gulp-sourcemaps ) from 2.6.5 to 3.0.0.
- [Release notes](https://github.com/gulp-sourcemaps/gulp-sourcemaps/releases )
- [Commits](https://github.com/gulp-sourcemaps/gulp-sourcemaps/compare/v2.6.5...v3.0.0 )
---
updated-dependencies:
- dependency-name: gulp-sourcemaps
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-30 13:04:47 +00:00
dependabot[bot]
4101bb252e
Bump sinon from 9.0.2 to 13.0.1 in /extensions/ql-vscode
...
Bumps [sinon](https://github.com/sinonjs/sinon ) from 9.0.2 to 13.0.1.
- [Release notes](https://github.com/sinonjs/sinon/releases )
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md )
- [Commits](https://github.com/sinonjs/sinon/compare/v9.0.2...v13.0.1 )
---
updated-dependencies:
- dependency-name: sinon
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-30 13:04:31 +00:00
Shati Patel
4ff4e4827e
Bump CLI version in integration tests
2022-03-30 12:03:16 +01:00
Andrew Eisenberg
8daa92ad49
Merge branch 'main' into aeisenberg/analysis-results-on-restart
2022-03-29 16:04:35 -07:00
Andrew Eisenberg
6fa0227a1e
Merge branch 'main' into aeisenberg/codeSnippet-handling
2022-03-29 15:08:17 -07:00
Andrew Eisenberg
c38e4ce265
Merge pull request #1252 from github/aeisenberg/settings
...
Prevent cli path from being synced across remote instances
2022-03-29 14:23:51 -07:00
Andrew Eisenberg
21bcd62ba8
Merge pull request #1239 from github/dependabot/npm_and_yarn/extensions/ql-vscode/types/gulp-replace-1.1.0
...
Bump @types/gulp-replace from 0.0.31 to 1.1.0 in /extensions/ql-vscode
2022-03-29 14:21:06 -07:00
Andrew Eisenberg
76c034f79a
Merge branch 'main' into aeisenberg/repo-filter
2022-03-29 14:15:31 -07:00
Andrew Eisenberg
d8d394ce40
Use new version of gulp-replace
2022-03-29 14:09:01 -07:00
Andrew Eisenberg
213f4ce92f
Merge branch 'main' into aeisenberg/settings
2022-03-29 13:54:41 -07:00
Andrew Eisenberg
abfd9b3cbd
Fix duplication import
2022-03-29 13:21:08 -07:00
Andrew Eisenberg
6114f6a7fd
Merge branch 'main' into aeisenberg/analysis-results-on-restart
2022-03-29 13:18:13 -07:00
Andrew Eisenberg
61e674e9f6
Allow for undefined codeSnippets
...
This reverts commit 006cc8c52a
.
2022-03-29 13:10:28 -07:00
Andrew Eisenberg
006cc8c52a
Undo sarif-processing change
...
Will move to a different PR.
2022-03-29 13:07:56 -07:00
Andrew Eisenberg
ffe7fdcb46
Rename methods and address comments
2022-03-29 13:04:00 -07:00
Andrew Eisenberg
49cceffe1b
Merge pull request #1235 from github/aeisenberg/history-sort
...
Add query history sorting for remote queries
2022-03-29 11:13:35 -07:00
Andrew Eisenberg
558009543f
Update changelog
2022-03-29 11:11:44 -07:00
Andrew Eisenberg
aaef5bde2c
Prevent cli path from being synced across remote instances
...
This will fix a problem where settings sync will cause the cli not
to be found on codespaces.
2022-03-29 11:08:31 -07:00
Andrew Eisenberg
f52f595d56
Add max-width for remote queries results page
2022-03-29 11:05:22 -07:00
dependabot[bot]
50196d8430
Bump @types/webpack from 4.41.21 to 5.28.0 in /extensions/ql-vscode
...
Bumps [@types/webpack](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/webpack ) from 4.41.21 to 5.28.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/webpack )
---
updated-dependencies:
- dependency-name: "@types/webpack"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-29 17:17:18 +00:00
Andrew Eisenberg
2ecfbfbb42
Merge pull request #1244 from github/aeisenberg/webpack-watch
...
Add webpack watch gulp task
2022-03-29 10:16:18 -07:00
Andrew Eisenberg
9508dffe6d
Merge pull request #1236 from github/dependabot/npm_and_yarn/extensions/ql-vscode/fs-extra-10.0.1
...
Bump fs-extra from 9.0.1 to 10.0.1 in /extensions/ql-vscode
2022-03-29 10:15:13 -07:00
Andrew Eisenberg
b4a72bbcab
Merge pull request #1238 from github/dependabot/npm_and_yarn/extensions/ql-vscode/through2-4.0.2
...
Bump through2 from 3.0.2 to 4.0.2 in /extensions/ql-vscode
2022-03-29 10:08:32 -07:00
Andrew Eisenberg
4ceaaf92cc
Merge pull request #1237 from github/dependabot/npm_and_yarn/extensions/ql-vscode/vsce-2.7.0
...
Bump vsce from 1.88.0 to 2.7.0 in /extensions/ql-vscode
2022-03-29 10:07:04 -07:00
Andrew Eisenberg
ef28c9531b
Update extensions/ql-vscode/gulpfile.ts/webpack.ts
2022-03-29 08:50:42 -07:00
Shati Patel
c86c602e39
Allow GitHub URL as well as NWO ( #1241 )
2022-03-29 12:45:46 +01:00
Angela P Wen
3bee2905e5
Gate show eval log and summary commands behind CLI v2.8.4 ( #1243 )
2022-03-29 05:30:31 -04:00
Edoardo Pirovano
9ac8a15cd5
Address review comments from `@aeisenberg`
2022-03-29 05:30:31 -04:00
Edoardo Pirovano
81b8104064
Expose per-query structured evaluator logs
2022-03-29 05:30:31 -04:00
Andrew Eisenberg
65f58b1f98
Add repositories search box
...
A simple, webview-only search box for filtering repositories from
the remote queries results view.
2022-03-28 17:01:11 -07:00
Andrew Eisenberg
7e872aa6d6
Add webpack watch gulp task
...
Now, when running `npm run watch`, both the regular tsc command
and the webpack command will be run in watch mode.
The raw gulp tasks are now:
- `gulp watchView` to watch webpack compilation.
- `gulp watchCss` to watch for css changes.
- `gulp compileView` to compile the webpack once and exit.
However, stats are no longer being printed out. Not sure why.
2022-03-28 15:43:35 -07:00
Andrew Eisenberg
0383a91a68
Display proper download state in remote results view
...
Before displaying any results for a remote query, ensure that all
downloaded results are in memory. This ensures the proper download icon
is displayed alongside each NWO.
2022-03-28 12:38:13 -07:00
Andrew Eisenberg
bb6ebe5750
Handle query directory not existing
...
Also, fix some changelog notes.
2022-03-28 10:55:02 -07:00
Andrew Eisenberg
71aa3d145f
Update changelog
2022-03-25 14:30:01 -07:00
dependabot[bot]
2f1f80029b
Bump @types/gulp-replace from 0.0.31 to 1.1.0 in /extensions/ql-vscode
...
Bumps [@types/gulp-replace](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/gulp-replace ) from 0.0.31 to 1.1.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases )
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/gulp-replace )
---
updated-dependencies:
- dependency-name: "@types/gulp-replace"
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-25 21:28:00 +00:00
dependabot[bot]
ad18cfa284
Bump through2 from 3.0.2 to 4.0.2 in /extensions/ql-vscode
...
Bumps [through2](https://github.com/rvagg/through2 ) from 3.0.2 to 4.0.2.
- [Release notes](https://github.com/rvagg/through2/releases )
- [Commits](https://github.com/rvagg/through2/compare/v3.0.2...v4.0.2 )
---
updated-dependencies:
- dependency-name: through2
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-25 21:27:45 +00:00
dependabot[bot]
92ed1c6ac9
Bump vsce from 1.88.0 to 2.7.0 in /extensions/ql-vscode
...
Bumps [vsce](https://github.com/Microsoft/vsce ) from 1.88.0 to 2.7.0.
- [Release notes](https://github.com/Microsoft/vsce/releases )
- [Commits](https://github.com/Microsoft/vsce/compare/v1.88.0...v2.7.0 )
---
updated-dependencies:
- dependency-name: vsce
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-25 21:27:25 +00:00
dependabot[bot]
e71e04a8f1
Bump fs-extra from 9.0.1 to 10.0.1 in /extensions/ql-vscode
...
Bumps [fs-extra](https://github.com/jprichardson/node-fs-extra ) from 9.0.1 to 10.0.1.
- [Release notes](https://github.com/jprichardson/node-fs-extra/releases )
- [Changelog](https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jprichardson/node-fs-extra/compare/9.0.1...10.0.1 )
---
updated-dependencies:
- dependency-name: fs-extra
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-25 21:27:03 +00:00
Andrew Eisenberg
4afac5fa4d
Add query history sorting for remote queries
...
Also, fix two smaller issues:
- Ensure the `Open Query Directory` command opens inside the specified
directory.
- Ensure label changes are saved across restarts.
2022-03-25 14:25:07 -07:00
dependabot[bot]
689db3713b
Bump minimist from 1.2.5 to 1.2.6 in /extensions/ql-vscode
...
Bumps [minimist](https://github.com/substack/minimist ) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases )
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6 )
---
updated-dependencies:
- dependency-name: minimist
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-03-25 18:48:40 +00:00
Andrew Eisenberg
23e29a1fdc
Update tsc to 4.5.5
...
The default version of tsc in vscode is now 4.5.4. This version
has changed the type of the variable in the catch block.
Previously, it was `any`. Now it is `unknown`.
This change updates vscode so that it can build with 4.5.4.
Previously, this had been a bit of a pain since sometimes running
a compile task in vscode will use the global default version of
tsc.
2022-03-25 09:48:51 -07:00
Shati Patel
90d636a026
Download databases from GitHub ( #1229 )
2022-03-25 15:24:09 +00:00
Andrew Eisenberg
421f5d23ec
Update changelog
2022-03-24 12:39:11 -07:00
Andrew Eisenberg
0fa91f32cb
Fix invalid file comparison for changing ast viewer location
...
This fixes a bug where the ast viewer was not updating its source
location when a user clicks on different parts of a file.
The problem was that the file name of the AST viewer was being stored as
a base name, which was getting compared with the full URI string of the
current file.
This fixes the comparison to ensure that the full URI strings are always
being compared.
2022-03-24 12:36:17 -07:00
shati-patel
3d21b203be
Make "promptForLanguage" more general
...
(so we can use it for downloading a GH database as well)
2022-03-21 16:37:51 +00:00
shati-patel
3972b8f4c1
Rename LGTM-specific function
2022-03-21 16:37:51 +00:00
Tobias Speicher
2d1707db00
refactor: replace deprecated String.prototype.substr()
...
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-03-21 14:16:54 +00:00
Robert
fd57cc95e9
Remove unnnecessary function
2022-03-21 10:38:00 +00:00
Robert
04c392be7e
Allow a custom branch name in settings file
2022-03-18 16:26:06 +00:00
github-actions[bot]
38da598214
Bump version to v1.6.2 ( #1221 )
...
Co-authored-by: charisk <charisk@users.noreply.github.com>
2022-03-17 12:47:33 +00:00
Charis Kyriakou
3f2c9b647c
v1.6.1 ( #1220 )
2022-03-17 12:04:37 +00:00
Shati Patel
7d5b4369c1
Fix highlighting issues ( #1219 )
2022-03-17 11:45:31 +00:00
Shati Patel
aade33fa88
Minor webview fixes ( #1217 )
2022-03-17 11:12:50 +00:00
Shati Patel
2a8a90bdfc
Change public occurrences of "remote queries" ( #1215 )
2022-03-17 10:14:32 +00:00
Shati Patel
f36048cc95
Use variable for highlighting code ( #1216 )
2022-03-17 10:08:42 +00:00
Charis Kyriakou
517feeca21
Remove SARIF viewer support ( #1213 )
2022-03-16 14:39:52 +00:00
Charis Kyriakou
9436a49118
Remove helper command for working on the Remote Query results view ( #1214 )
2022-03-16 14:19:19 +00:00
Charis Kyriakou
0e02cb08fd
Enable viewing of analyses results ( #1212 )
2022-03-16 14:15:43 +00:00
Shati Patel
26244efc50
Create remote file links to GitHub URL ( #1209 )
...
Co-authored-by: Charis Kyriakou <charisk@github.com>
2022-03-16 14:11:17 +00:00
Charis Kyriakou
6339eeffe5
Minor styling fix for raw results ( #1211 )
2022-03-16 11:44:51 +00:00
Charis Kyriakou
8cc2f598eb
Fix highlight region end column calculation ( #1210 )
2022-03-16 09:47:09 +00:00
Charis Kyriakou
46a1dd57f4
Minor style fixes around result rendering ( #1208 )
2022-03-15 14:43:24 +00:00
shati-patel
9d99fc521e
Get database sha from result index
2022-03-15 10:30:01 +00:00
Shati Patel
bcf79354ee
Bump CLI version in integration tests
2022-03-15 10:22:18 +00:00
Charis Kyriakou
27a8636bac
Deal with non-printable characters when rendering raw results ( #1203 )
2022-03-14 11:25:33 +00:00
Charis Kyriakou
92a99938c9
Add support for remote queries raw results ( #1198 )
2022-03-14 08:18:43 +00:00
Charis Kyriakou
ed61eb0a95
Deal with analysis messages that have links to locations ( #1195 )
2022-03-14 08:14:09 +00:00
Charis Kyriakou
1720f9201e
Update Primer React to v35 ( #1199 )
2022-03-10 20:24:12 +00:00
Charis Kyriakou
d052ddb742
Rename analysis alert results ( #1197 )
2022-03-10 07:56:05 +00:00
Charis Kyriakou
8e2d18da8c
Rename ColumnValue to CellValue ( #1196 )
2022-03-09 16:44:15 +00:00
Charis Kyriakou
2c5004387d
Add support for showing code flows ( #1187 )
2022-03-09 09:15:45 +00:00
Charis Kyriakou
3fc3b259ba
Add pre-push hook check to block leftover .only()s ( #1189 )
2022-03-08 09:32:18 +00:00
aeisenberg
fa85865fe5
Bump version to v1.6.1
2022-03-07 18:04:29 +00:00
Andrew Eisenberg
ae6263a07f
v1.6.0
...
Note that the change to `run-remote-query.ts` is being coordinated
with the rest of the remote-queries team.
2022-03-07 09:46:56 -08:00
Charis Kyriakou
9af75634fa
Remove .only from mocha test ( #1188 )
2022-03-07 10:04:29 +00:00
Andrew Eisenberg
04b8681272
Merge pull request #1184 from github/aeisenberg/open-remote
...
Add command to open remote query on github
2022-03-04 10:46:55 -08:00
Andrew Eisenberg
d5549f2894
Add command to open remote query on github
...
Command is available for remote queries that are in progress or
completed.
2022-03-04 10:36:41 -08:00
Charis Kyriakou
b510b85ca0
Extract code snippet into stand alone component ( #1181 )
2022-03-04 08:06:19 +00:00
Andrew Eisenberg
5ad754a3a2
Merge pull request #1178 from github/aeisenberg/log-history
...
Save log files to the query history directory
2022-03-03 08:14:25 -08:00
Andrew Eisenberg
025a1a1383
Add new command to open the query history directory
...
Allows users to explore the contents and all artifacts of the query
that was just run.
2022-03-03 07:57:56 -08:00
Andrew Eisenberg
f28c1f91d9
Ensure structured logging file exists before running a query
2022-03-03 07:57:23 -08:00
Charis Kyriakou
c609377a9c
Add SARIF processing and basic alert rendering ( #1171 )
2022-03-03 09:03:27 +00:00
Andrew Eisenberg
2579d12f24
Save log files to the query history directory
...
This commit deprecates the the cutsom log directory option by saving
all log files with query history.
There is a simplification of the `OutputChannelLogger` since it no
longer needs to manage deleting log files on exit.
Also, the `codeQL.runningQueries.customLogDirectory` is marked as
deprecated. If this value is being used, a warning message is popped
up after the query completes.
2022-03-02 12:21:15 -08:00
Andrew Eisenberg
c18f7953e7
Merge pull request #1111 from github/aeisenberg/graph-viewer
...
More work on the graph viewer
2022-03-02 07:52:49 -08:00
Andrew Eisenberg
3a292b02b6
Simplify `walkDirectory`
...
The check for `seenFiles` is not necessary since we do not need to
handle symbolic links.
2022-03-01 14:02:21 -08:00
Andrew Eisenberg
7baf2d0a2a
Small formatting changes for graphes
2022-03-01 11:50:55 -08:00
Andrew Eisenberg
328289eb1c
Ensure graph view loads when result is clicked
...
Without these changes, a race condition was sometimes hit when viewing
a graph. There are two, related issues that are fixed. These problems
did not appear in the past since rendering a normal results view is
much faster and the message handler is always already set up by the
time the interface first sends a message over to the web view.
1. `vscode.postMessage({ t: 'resultViewLoaded' });` was being called
before the component is completely mounted. Ie- `componentDidMount`
is not called. So, the interface is notified that the web view is
ready to receive messages _before_ it is actually ready to receive
messages.
The change ensures the interface only sends messages when the web
view is ready.
2. `this._panelLoaded` is never set to false if the panel is unloaded.
This means that if a panel is re-opened, the interface assumes that
the view is nearly _immediately_ ready to receive messages.
The change ensures that the interface waits for the webview to really
be loaded before sending messages.
In both of these cases, if the interface sends the `setState` message
too early, then the message is ignored since no handlers have been added
to the web view.
2022-03-01 11:46:26 -08:00
Andrew Eisenberg
95d93eeb61
Merge pull request #1176 from github/bump-cli
...
Bump CLI version in integration tests
2022-03-01 08:15:05 -08:00
Charis Kyriakou
b54cc27cab
Update ECMAScript version to be the same across the codebase ( #1177 )
2022-03-01 16:01:29 +00:00
shati-patel
c9ca1ee7b3
Bump CLI version in integration tests
2022-03-01 12:14:30 +01:00
Charis Kyriakou
649d6d94a3
Expose Remote Query language ( #1173 )
2022-02-28 13:12:01 +00:00
Charis Kyriakou
bf68d21830
Some UI fixes for collapsible items ( #1172 )
2022-02-28 10:53:02 +00:00
Andrew Eisenberg
64b33b76cb
Update node version in CI
2022-02-26 19:48:55 -08:00
Andrew Eisenberg
c189df3fd6
Ensure Graph results can only be seen if in canary mode
2022-02-25 18:04:21 -08:00
Andrew Eisenberg
277869ebca
Ensure graph queries with ids that have slashes work
...
Do this by actually walking the interpretation directory.
Move the directory walker from tests to prod and make it async. Also
add tests for it.
And add a warning on graph views to let users know that it is not
production quality.
Finally, change the interpreted directory to be `graphResults` instead
of `interpretedResults.sarif`.
2022-02-25 18:03:14 -08:00
shati-patel
303513a566
Make icon part of clickable link
...
Plus fix the associated styling/CSS
2022-02-25 21:08:16 +00:00
shati-patel
8712106b3d
Add link to workflow run logs from results view
2022-02-25 21:08:16 +00:00
Andrew Eisenberg
cdb9506583
Merge branch 'main' into aeisenberg/graph-viewer
2022-02-25 10:38:19 -08:00
Andrew Eisenberg
94a311a550
Merge pull request #1166 from github/aeisenberg/remote-queries-unit-tests
...
Add unit tests for query history and remote queries
2022-02-25 10:07:56 -08:00
Andrew Eisenberg
791e7e9c4d
Small cleanups around remote-queries tests
...
- More explicit test helper module names
- Fix unit test names
- Better sanitization of repo names in tests
2022-02-25 09:57:15 -08:00
Angela P Wen
6cfa7e2cd3
Integrate evaluator structured logging per query server instance ( #1151 )
...
Adds structured evaluator logging on a per-query instance to CLI v 2.8.2+. The newline-delimited JSON logs are emitted to `structured-evaluator-log.json` in the directory with other query artifacts, but not consumed by the extension.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
2022-02-25 09:22:56 -08:00
Andrew Eisenberg
7196c26181
Merge pull request #1168 from github/aeisenberg/query-history-version
...
Preemptively add a version number to the query history json file
2022-02-25 08:11:14 -08:00
Charis Kyriakou
735f177283
Use webview CSP source for style-src ( #1170 )
2022-02-25 16:03:58 +00:00
Andrew Eisenberg
f857e5ec6c
Ensure all tests are run
...
Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com>
2022-02-25 08:00:03 -08:00
Charis Kyriakou
a5e02950c2
Fixed unique key warning ( #1169 )
2022-02-25 10:58:24 +00:00
Andrew Eisenberg
4a928f1298
Add unit tests for query history and remote queries
...
Adds some tests for reading in the history and manipulating.
There are some more tests to come later. Maybe in another PR, maybe in
this one.
Note that this PR uses a new node 16 API String.prototype.replaceAll.
I think this is ok since vscode ships with node 16. If this causes
problems, I can separate to a different PR and we can discuss there.
2022-02-24 23:09:55 -08:00
Andrew Eisenberg
f59012862e
Preemptively add a version number to the query history json file
...
Since we are now storing query history on disk, we will need to handle
situations where versions change. For now, there is only version 1. In
the future, we may need to make breaking changes to this format and we
need the flexibility to detect and possibly handle different versions.
In this case, users don't often downgrade their vscode versions, so
most likely, we only need to be forward compatible. Ie- we need to
handle moving from v1 to v2, but not the other way around.
2022-02-24 11:42:46 -08:00
Andrew Eisenberg
548a216b56
Avoid downloading a result if it already exists
...
This commit adds a check if a results artifact already exists before
trying to download it again.
This is not a complete solution since the page icon will still have a
download button even if the artifact already exists. In this case,
clicking on it will avoid downloading it a second time.
The next step is to read in the downloaded artifacts and display them
appropriately.
2022-02-23 11:16:39 -08:00
Andrew Eisenberg
1ed8b225db
Small cleanup and comment
2022-02-23 09:52:46 -08:00
Andrew Eisenberg
f0354c87f4
Allow multiple analyses for same repo to be downloaded
...
Removes the limitation specified in #1089 where analyses for the same
repo and different queries will overwrite each other.
2022-02-22 14:16:54 -08:00
Andrew Eisenberg
5e06a615cd
Remember remote queries across restarts
...
Remote query items will be stored in query history and will remain
available across restarts.
When the extension is restarted, any `InProgress` remote queries will
be monitored until they complete.
When clicked on, a remote query is opened and its results can be
downloaded. The query text and the query file can be opened from the
history menu. A remote query can be deleted as well, which will purge
all results from global storage.
Limitations:
1. Labels are not editable
2. Running multiple queries that each run on the same repository
will have conflicting results and there will be errors when trying
to view the results of the second query. This limitation is not new,
but it is easier to hit now. See #1089 .
Both of these limitations will be addressed in future PRs.
2022-02-22 11:42:52 -08:00
Andrew Eisenberg
e11aa7af18
Merge branch 'main' into aeisenberg/remote-query-save
2022-02-22 10:13:16 -08:00
Andrew Eisenberg
f4ddc17851
Merge pull request #1158 from github/aeisenberg/open-query-logger
...
Open query server logger for query errors
2022-02-22 09:55:19 -08:00
Andrew Eisenberg
ebce2826cb
Merge pull request #1143 from github/aeisenberg/refactor-query-history-info
...
Refactor query history to handle remote and local
2022-02-22 09:51:13 -08:00
Andrew Eisenberg
4c411acef4
Merge branch 'main' into aeisenberg/open-query-logger
2022-02-22 09:44:41 -08:00
Andrew Eisenberg
ddc941f464
Merge pull request #1157 from github/aeisenerg/empty-additional-packs
...
Ensure `--addtional-packs` arg not used for empty workspace
2022-02-22 09:44:10 -08:00
shati-patel
c5ff2c6f76
Fix styling for light mode
2022-02-22 17:14:15 +00:00
shati-patel
85ac16bb22
Change shape of result index
2022-02-22 17:14:15 +00:00
shati-patel
e7ee4a33c7
Add new component for displaying analysis failures
2022-02-22 17:14:15 +00:00
shati-patel
ac0da04542
Read analysis failures from index file
2022-02-22 17:14:15 +00:00
shati-patel
3337117970
Use more accurate primer icon
2022-02-22 12:04:21 +00:00
Charis Kyriakou
9b61ff5714
Use Primer octicons where possible ( #1156 )
2022-02-21 11:28:13 +00:00
Andrew Eisenberg
d25db48452
Open query server logger for query errors
...
Because errors when running queries tend to have better explanations
in the query server log instead of the extension log, by default open
the query server log for query errors.
2022-02-18 12:55:32 -08:00
Andrew Eisenberg
251f354076
Ensure `--addtional-packs` arg not used for empty workspace
2022-02-18 10:16:42 -08:00
Andrew Eisenberg
9c6ae226fb
Merge branch 'aeisenberg/refactor-query-history-info' into aeisenberg/remote-query-save
2022-02-17 14:11:44 -08:00
Andrew Eisenberg
a502ee85d1
Fix unit test and add comments/todos
2022-02-17 13:07:10 -08:00
Andrew Eisenberg
eec72e0cbd
Merge pull request #1142 from github/aeisenberg/remote-queries-history
...
Store remote query artifacts in global storage
2022-02-17 12:35:09 -08:00
Andrew Eisenberg
7a1acce133
Merge pull request #1150 from github/aeisenberg/clear-cache
...
Fix race condition where packs with no name errored during remote query
2022-02-17 10:04:53 -08:00
Andrew Eisenberg
16df990183
Add remote query items to history view
...
This is another incremental step on the way to saving history.
This commit adds remote items to the history view. It adds in progress
and completed icons. Users can explicitly remove items.
Here is what is _not_ working:
1. Any other query history commands like open results or open query.
2. Seeing items after a restart.
2022-02-16 18:43:00 -08:00
Andrew Eisenberg
969dd26041
Use `QueryHistoryInfo` instead of `LocalQueryInfo`
...
Also, rename RemoteQueryInfo -> RemoteQueryHistoryItem
2022-02-16 13:52:17 -08:00
Andrew Eisenberg
9df1f91318
Fix race condition where packs with no name errored during remote query
...
Uses the internal `clear-cache` CLI server command.
2022-02-16 12:46:38 -08:00