These builders have reached a point where they're considered added.
Fixesgolang/go#63599.
Fixesgolang/go#63601.
Change-Id: I37bcd2905b0b39b639828c3e3de9f2d0ebdbc994
Reviewed-on: https://go-review.googlesource.com/c/build/+/608155
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: David du Colombier <0intro@gmail.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Richard Miller <millerresearch@gmail.com>
Backporting the patches necessary to make these builders pass seem not
worth the effort. The main problem is the patches touch many parts of
std, which results in a lot of conflicts.
Just disable them for now.
For golang/go#70054.
Change-Id: I5a304dbe71b4887d0a59ec2dbc7b1cc6e9129804
Reviewed-on: https://go-review.googlesource.com/c/build/+/627536
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Two reasons: to buy more time to work on the result_adapter/ResultDB
side (beyond just the bare minimum behavior of not regressing beyond
what we had before), and to test that using a GODEBUG for this works
as we expect. It already uncovered the need to merge multiple GODEBUG
settings that we hadn't run into earlier.
For golang/go#70402.
Change-Id: I9b86f6a5462637eef84f3efca9fc31d11657d756
Reviewed-on: https://go-review.googlesource.com/c/build/+/629375
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
This adds new builders that target the new c4a instances in our fleet
for performance testing.
For golang/go#70231.
Change-Id: I924859344f72cfa331bce296f1d646bccb3589e7
Reviewed-on: https://go-review.googlesource.com/c/build/+/625976
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Try setting GOMAXPROCS. We'll start with 2 to confirm a
clear effect, then may raise it to 4.
For golang/go#70213
Change-Id: Ic5f5e0b99c5e9ead896a465e39286ab161f431c7
Reviewed-on: https://go-review.googlesource.com/c/build/+/625317
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Now that GOEXPERIMENT=swissmap is enabled by default, switch to a
-noswissmap builder to ensure the old maps continue to work until the
GOEXPERIMENT is deleted.
For golang/go#54766.
Change-Id: I47cd081cd144740ccb95352b78d3a292b3e2a418
Reviewed-on: https://go-review.googlesource.com/c/build/+/625517
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Part of golang/go#63698.
Change-Id: Ib1c5722aba24095d27c23cb69065a80d4c127dd4
Reviewed-on: https://go-review.googlesource.com/c/build/+/624995
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
As mentioned in https://go.dev/issue/63698#issuecomment-2450448780,
this might be a good starting point. Can be adjusted later as needed.
For golang/go#63698.
Change-Id: I851852981527e1dcdae18f535f16a37117791ce6
Reviewed-on: https://go-review.googlesource.com/c/build/+/624075
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Auto-Submit: Benny Siegert <bsiegert@gmail.com>
These builders do not run regularly. Their sole purpose is to help look
at performance over longer timeframes, ~1 year, so manually triggering
them is good enough.
Also, fix up the sorting of RUN_MODS.
Change-Id: Ibf49260037dbe4d8316700457f5dbaef8d468499
Reviewed-on: https://go-review.googlesource.com/c/build/+/623297
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
It was updated to target GOARM=7 because it can't work with GOARM=6.
For golang/go#63698.
Change-Id: I164a49d4a2bf6f680e4a980e90f6e2968f1906a7
Reviewed-on: https://go-review.googlesource.com/c/build/+/623015
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This change adds two new builder types. It depends on
https://chromium-review.googlesource.com/c/infra/infra/+/5967115 to
function.
The goal of this change is to test ASAN and MSAN at a baseline, to make
sure the Go parts work. We recently broke ASAN but didn't notice until
we got feedback from someone else; our internal tests are too
simplistic.
While we're here, sort the RUN_MODS list in the source code.
For golang/go#70054.
Change-Id: Ib515a2c908fbfdc58abf6e9d4c9c7a170bec0499
Reviewed-on: https://go-review.googlesource.com/c/build/+/622322
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
I tested this with led by picking all the test_only builds for a recent
commit for the regular builder and longtest. All of the builds
succeeded. Also, the clang15 builder's make.bash step now completes.
Yay!
There may still be unexpected breakage since I didn't test every
possible configuration, so I'll keep an eye out.
Change-Id: I7902273594098b027b35fac4c47a51ea70ed07b9
Reviewed-on: https://go-review.googlesource.com/c/build/+/622318
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Wazero 1.8.1 includes a fix for a bug
(https://github.com/tetratelabs/wazero/issues/2318)
which will cause failures for a pending os package CL.
Change-Id: I5c05cd5344ffd10168fc5e5688c452a22f84bee9
Reviewed-on: https://go-review.googlesource.com/c/build/+/619215
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
I uploaded the toolchain to CIPD already, so assuming the tests pass it
should just work out of the box.
For golang/go#69763.
Change-Id: I3e4bbbfbb3f674475a0c3f6ec0ad45870e0cc960
Reviewed-on: https://go-review.googlesource.com/c/build/+/617577
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
But, don't remove the known issue just yet. Things definitely still
might be broken.
Also, exclude known-issue builders from presubmit always.
For go.dev/issue/61095.
Change-Id: Iedff5ce9df88dc763dd2a6b3010376cc39d4ad47
Reviewed-on: https://go-review.googlesource.com/c/build/+/617576
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Looking at the history of the x_tools-go1.21-linux-amd64 post-submit
at https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-go1.21-linux-amd64
makes it apparent that there are two gitiles triggers for it:
gitiles {
repo: "https://go.googlesource.com/go"
refs: "regexp:refs/heads/master"
}
gitiles {
repo: "https://go.googlesource.com/tools"
refs: "regexp:refs/heads/master"
}
The later is expected. The former has the wrong branch: it should be
release-branch.go1.21 and not the main branch - it doesn't make sense
to re-run the x_tools-go1.21-linux-amd64 builder whenever there's a
new Go tip commit.
It ended up being automatically populated because we don't have a
release-branch.go1.21 branch trigger, and because I didn't think to
set postsubmit_builders_by_project_and_branch to True in CL 524175.
Since there aren't expected to be new commits on release-branch.go1.21
by now, it should be fine not to have a trigger for that - the x/tools
repo trigger is enough - but do remove triggering from Go tip commits.
Change-Id: Id2c5ff8f52eab507459f1dd7815c80f5bf099417
Reviewed-on: https://go-review.googlesource.com/c/build/+/611944
Reviewed-by: Tim King <taking@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
As described in https://go.dev/issue/69322#issuecomment-2338994506,
the intent is to only run a gopls perf builder using the latest Go
release branch, not the second latest.
Fixesgolang/go#69322.
Change-Id: I8a94344a1ba4fe8aaae7f353c208397c9643be40
Reviewed-on: https://go-review.googlesource.com/c/build/+/611942
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Tim King <taking@google.com>
I considered refactoring INTERNAL_GO_BRANCHES to be generated from
GO_BRANCHES since there's so much overlap between them, but it seems
to also work well to define moving targets for the two supported major
Go release, and use them in both places.
Generated files are unchanged. The next CL will use LATEST_GO to refer
to only the latest Go release, not the second latest one.
For golang/go#69322.
Change-Id: I4c1850fed49a5552d6aa7afda622f849522389ed
Reviewed-on: https://go-review.googlesource.com/c/build/+/611941
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Tim King <taking@google.com>
Delete code that became dead as of CL 605295. Generated files unchanged.
Change-Id: I8a64311650371c82cd0510c25d91302aba85cb77
Reviewed-on: https://go-review.googlesource.com/c/build/+/609895
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Tim King <taking@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The Go 1.23.0 release is out. This drops many of the special cased
extra branches for x/tools per plan in go.dev/issue/65917, keeping
only go1.21 as a special case for the needs of gopls v0.17.0.
For golang/go#65917.
Change-Id: I2af34126099b58f6445a5198f2b06c654df0ae6d
Reviewed-on: https://go-review.googlesource.com/c/build/+/605000
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
For golang/go#69121
Change-Id: Ia47ba04ed86cf1785edaddd689c53065f4a83d87
Reviewed-on: https://go-review.googlesource.com/c/build/+/609735
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
We still want to be able to trigger them in the very immediate future,
but they don't need to be included by default and block submission.
For golang/go#65917.
Change-Id: I2d8d0602c631bd7335488c4c473081812fc07dde
Reviewed-on: https://go-review.googlesource.com/c/build/+/610395
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Owners of x/pkgsite are setting the go directive to 1.23, so signal
from go1.22 builders is no longer applicable. See CL 609142. Remove
those builders.
Change-Id: I87ee28583fc0412f2aea7d1109f5e01f8e612cda
Reviewed-on: https://go-review.googlesource.com/c/build/+/609279
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
For golang/go#69121
Change-Id: Ia3183c1037384ee36b1afe174f70fa9cfda12f86
Reviewed-on: https://go-review.googlesource.com/c/build/+/609375
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
These previously had presubmit, so add them back with presubmit. To
retain the uniformity of our existing policy, we also let them get added
as postsubmit.
We add them as PT.TOOL so that they only run on a small subset of
platforms, but they're probably tested with *way* more configurations
than they need to be. This is generally harmless, though if it becomes a
problem we can prune the builders more aggressively.
Change-Id: I9a8317dd8473e4efa7c917b9b7aa25a089034bb2
Reviewed-on: https://go-review.googlesource.com/c/build/+/608495
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
This change defines shadow buckets for security-try so that we can
create and test builds in the security-try pools. Creating builds
requires being part of luci-bot-access, since these pools are
particularly security sensitive.
Change-Id: I0c94148ad6920e5f16927720fcd726bc7d46bba3
Reviewed-on: https://go-review.googlesource.com/c/build/+/607575
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
For golang/go#64751.
Change-Id: I68b42b295f48a57f7016e8d70f068c7cb3548df8
Reviewed-on: https://go-review.googlesource.com/c/build/+/605978
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
The Go 1.23.0 release is out, so 1.22 is the oldest supported release.¹
The previous infrastructure (cmd/coordinator) does this automatically,²
whereas here I authored this CL manually. We'll explore automating it
later on³, possibly with relui generating the CL.
This also prepares to drop the special cased extra branches for x/tools
per plan in go.dev/issue/65917, but does so in the follow up CL so that
it can be submitted slightly later, separately.
¹ https://go.dev/doc/devel/release#policy
² It too used to be manual, until we automated it in go.dev/issue/34097
in 2019.
³ I said the same thing 6 months ago in CL 562395. That said, we need
to do a bit more one-off changes here since x/tools is dropping its
extended Go testing.
For golang/go#65917.
Change-Id: Id5228b484995ded1094aaeb6b747f2f507ed241d
Reviewed-on: https://go-review.googlesource.com/c/build/+/605295
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
There is a minor but non-zero diff when generating with
a newer lucicfg. Check it in so that TestValidate passes.
[git-generate]
go generate
Change-Id: Ia6fb390f789b848944967f6ca29b5890e2d36d25
Reviewed-on: https://go-review.googlesource.com/c/build/+/605297
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This is separated out in a separate CL for a more gradual rollout.
Fixesgolang/go#68798.
Change-Id: I6a4c2f1e89ab7c6426a9b5d19e429b68ca61bee4
Reviewed-on: https://go-review.googlesource.com/c/build/+/604336
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
New information in go.dev/issue/68798 shows that having this builder
available for 1.23 and at tip will be helpful, at least in the short
term. Also run it in postsubmit (for 1.23/tip only, where it's meant
to pass), and also in presubmit as of the next CL.
For golang/go#68798.
Change-Id: I72183cc8703b65ecb265e01b18288651a7e64cfb
Reviewed-on: https://go-review.googlesource.com/c/build/+/604335
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Tim King <taking@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
This is a longtest so we get more thorough testing, and is post-submit
only.
For golang/go#54766.
Change-Id: Icc948ce7fe8e60e4f4988db07e10a209bc46bff2
Reviewed-on: https://go-review.googlesource.com/c/build/+/602555
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The builder has reached a point where it's considered added.
Fixesgolang/go#63480.
Change-Id: I82985686fa1ac0f00d46c2b49fd8e2fc187fc5fa
Reviewed-on: https://go-review.googlesource.com/c/build/+/596817
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Eric Grosse <grosse@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
As of a recent builder change related to its security, this host has
started to take longer to run tests and runs into timeouts. Examples:
- https://ci.chromium.org/b/8740874888365769313
- https://ci.chromium.org/b/8740872183618140241
Mark it as slower to give it more time.
Change-Id: Ib4765683c5102b8d093ae7f7e62610eb1e8732c5
Reviewed-on: https://go-review.googlesource.com/c/build/+/602235
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Copying the test to the main Go repository requires vendoring x/net/html
as a test-only dependency, which works (prototype in go.dev/cl/600816)
but adds size and requires a copy of the test to be maintained in an
extra place.
Instead, reuse x/website's test by invoking it as a trybot. This is
viable because x/website tests pick up main Go tree content from the
runtime.GOROOT() directory, which is what the trybot ends up using as
its Go version. (Checked in go.dev/cl/601039.)
For golang/go#37047.
Fixesgolang/go#68633.
Change-Id: I69cc638c489cbb847e7b46e4af90e0197ddd6695
Reviewed-on: https://go-review.googlesource.com/c/build/+/601656
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
We're aware of an issue where the current darwin-amd64 hosts are slower
than we expect, primarily in the context of the darwin-amd64-longtest
builders. Various cmd/go tests often end up failing with a timeout.
As a step in investigating this, mark it as slow so that the longtest
builders have a longer timeout and we can get more information out of
these builders.
For golang/go#65040.
Change-Id: I18fa6fc2ef944d40ad4ad1a96e572d674023f279
Reviewed-on: https://go-review.googlesource.com/c/build/+/600998
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
In Go 1.23 onwards, the GODEBUG gotypealias defaults to a value of 1,
so setting gotypesalias=1 in the environment is a no-op.
So constrain the builder to exist only for 1.22 and older.
Change-Id: Ia21995ae3feefe63115c2e7770c5e6e2d918dc98
Reviewed-on: https://go-review.googlesource.com/c/build/+/601177
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
CL 597335 intended to disable the misccompile builder for x/oscar repo.
It did so successfully, stopping the misccompile builder from running
both in pre-submit (by default) and in post-submit in that repository.
That change was unintentionally applied for all other repositories too,
because the second and third booleans in define_for_projects_except set
to False unconditionally.
Undo that, and improve the documentation of make_run_mod to make it
more readable.
Change-Id: I97d91c8056f34f0b1d42f29d98e85a04ca46e00a
Reviewed-on: https://go-review.googlesource.com/c/build/+/601176
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
For golang/go#67299.
Change-Id: I76f511338617f6b431c396f048200d25e09dd275
Reviewed-on: https://go-review.googlesource.com/c/build/+/600995
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This reverts the temporary change applied in CL 596815.
By now golangbuild has a workaround added to it in crrev.com/c/5730108.
Tested with:
$ led get-build -real-build 8741505627666329441 \
| sed 's/git_revision:3827b7d23334361675d082c87b226aa09f74f855/latest/' \
| led launch
[I 2024-07-24 19:17:28] getting build definition
[I 2024-07-24 19:17:29] Launching the led job as a real build
[I 2024-07-24 19:17:29] LUCI UI: https://ci.chromium.org/b/8741489447033761169Fixesgolang/go#68310.
Change-Id: I1464fa6fcdaaf9a34a8ddc3100a7bd8654529921
Reviewed-on: https://go-review.googlesource.com/c/build/+/600996
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Change-Id: I161a668381be642cd59ef9c46c0447984da70890
Reviewed-on: https://go-review.googlesource.com/c/build/+/600496
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
It's already annoying to have to ask for longtest builders to run the
end-to-end test for sweet, but the fact that we also forget to run the
Go 1.22 end-to-end test means we get real breakages like
golang/go#68555.
Resolve this once and for all by enabling longtest in presubmit if any
Go file is touched by a CL in the x/benchmarks repository.
Change-Id: Ia76258edf9bc93b88501cd64755beddd39186f06
Reviewed-on: https://go-review.googlesource.com/c/build/+/600495
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This way issue references should get tagged correctly.
Change-Id: I1d225101d4e0760e34e6094dd74ad8e38350fa19
Reviewed-on: https://go-review.googlesource.com/c/build/+/598175
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This builder has been migrated and appears to be running stably.
Updates golang/go#67105
Change-Id: Iaafaf669a290b5fc1fda2deea1ed06b2faf7ec60
Reviewed-on: https://go-review.googlesource.com/c/build/+/598155
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Change-Id: I2b457f0503ee08e95f59ae836ff289f581d4a561
Reviewed-on: https://go-review.googlesource.com/c/build/+/597277
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Bypass: Carlos Amedee <carlos@golang.org>
Commit-Queue: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The misccompile builders should not run for the oscar project. Oscar
will not compile for various misccompile platforms.
Change-Id: I2f59302004a32b1c1f8451292e427177febdb7ca
Reviewed-on: https://go-review.googlesource.com/c/build/+/597335
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Bypass: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
This change sets the version of go to 1.23 and above for the oscar
project. The repo makes extensive use of range-over-func.
Change-Id: I62c6516604685f34397ccae61f928ef5c7c4dce1
Reviewed-on: https://go-review.googlesource.com/c/build/+/597175
TryBot-Bypass: Carlos Amedee <carlos@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Add x/oscar as a 'TOOLS' repository.
Change-Id: Ie35d9b63706bc9fcdab3a85cfffd384c613fa2b4
Reviewed-on: https://go-review.googlesource.com/c/build/+/596675
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Than McIntosh <thanm@google.com>
Dmitri Shuralyov
Michael Anthony Knyszek
Eric Grosse
Michael Pratt
Benny Siegert
Damien Neil
Tim King
Joel Sing
Carlos Amedee
Than McIntosh