Граф коммитов

278 Коммитов

Автор SHA1 Сообщение Дата
Hana (Hyang-Ah) Kim e72031dac4 devapp/owners: create oscarTeam
Note: CLs won't be assigned to anyone automatically
because oscarTeam is not a gerrit account.

Change-Id: Ie20c419b3caf310fcc0da373fe9f63415629abec
Reviewed-on: https://go-review.googlesource.com/c/build/+/623639
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-10-31 14:09:03 +00:00
Zxilly 25b5b847e6 all: add support for lib/wasm folder
Updates golang/go#68024

Change-Id: If33d8641114a2b0c0e6d70b3dd4e8683ed24b359
GitHub-Last-Rev: b6415001a5
GitHub-Pull-Request: golang/build#101
Reviewed-on: https://go-review.googlesource.com/c/build/+/604835
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2024-10-02 16:57:28 +00:00
Dmitri Shuralyov 7e4b4ea2c0 all: update Dockerfile to build with Go 1.23
Otherwise deploying runs into:

Step 5/15 : RUN go mod download
 ---> Running in 2cb572f3515a
go: go.mod requires go >= 1.22.0 (running go 1.21.13; GOTOOLCHAIN=local)

Change-Id: I70e4df2a3f9db92cb144351d4b67a40cfc7fa482
Reviewed-on: https://go-review.googlesource.com/c/build/+/612557
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Tim King <taking@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
2024-09-12 18:00:55 +00:00
Michael Pratt 6f08d2ff3b devapp: handle internal/runtime moves
There have been several moves recently.

Updates golang/go#65355.

Change-Id: Ie00f2e540bc7e51d1f833dffb587b3ce9954601f
Reviewed-on: https://go-review.googlesource.com/c/build/+/595295
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-07-29 18:05:14 +00:00
Dmitri Shuralyov b9910f3203 cmd/relui, devapp: remove rand.Seed call
It's not needed as of Go 1.20, the generator
is seeded randomly at program startup anyway.

Change-Id: Ic1f5cd84df333a73c8bd39be70f88df03c690e81
Reviewed-on: https://go-review.googlesource.com/c/build/+/599736
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-07-22 20:07:05 +00:00
Russ Cox 93f3e4f28b devapp/owners: remove r from os owners
By Rob's request.

Change-Id: Ic8bcb7aeb95606dbe4f93b65a564808552ab838c
Reviewed-on: https://go-review.googlesource.com/c/build/+/598475
Reviewed-by: Rob Pike <r@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
2024-07-16 00:43:41 +00:00
Suzy Mueller 59576ec10c devapp/owners: remove/replace suzmue
Change-Id: I4ce564f9dbb4bd48bcb1e962eed93b518ff615f5
Reviewed-on: https://go-review.googlesource.com/c/build/+/596375
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-07-09 17:21:53 +00:00
Than McIntosh 7bd85afa0c devapp/owners: add rsc as owner of x/oscar
Change-Id: I205ec67c50a303b60220c709e3c5f9687b7fa491
Reviewed-on: https://go-review.googlesource.com/c/build/+/596477
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Than McIntosh <thanm@google.com>
2024-07-03 21:44:39 +00:00
Bryan C. Mills 7c2d52f723 devapp/owners: remove/replace bcmills as an owner
My last day at Google will be March 15,
so I will no longer be on the Go team at that point.

Change-Id: Ic851359719850ffe1799da30b7394ea021998dc0
Reviewed-on: https://go-review.googlesource.com/c/build/+/570235
Reviewed-by: Damien Neil <dneil@google.com>
Commit-Queue: Bryan Mills <bcmills@google.com>
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
2024-03-11 18:47:10 +00:00
Ian Lance Taylor 727bcae879 devapp: replace sort.Slice with slices.SortFunc
The new slices.SortFunc function is clearer and faster.

Change-Id: Id1194dc7fb64cdcbe53ad7faa57f7dfb40e533c3
Reviewed-on: https://go-review.googlesource.com/c/build/+/565575
Commit-Queue: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
2024-02-21 02:13:02 +00:00
Ian Lance Taylor 4fe3df3f59 devapp: drop owners form field
The only use was removed in CL 163218 (the removed href for
.Owner.Name in reviews.tmpl).

It's unlikely that anybody is using the field manually as you have to
match the owner name, not e-mail address.

Change-Id: I1209680a7f729fa743050872c89beb52a4fe19ac
Reviewed-on: https://go-review.googlesource.com/c/build/+/565555
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
2024-02-21 02:12:25 +00:00
Rob Findley b6d280a2fb devapp/owners: update telemetry owners to telemetryTeam
Use a team rather than individuals, so we can more easily CC folks who
are currently working on telemetry.

Change-Id: I91a58404f11a350e4b84bd433e03186eade7772e
Reviewed-on: https://go-review.googlesource.com/c/build/+/562247
Reviewed-by: Peter Weinberger <pjw@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
2024-02-08 16:25:27 +00:00
Dmitri Shuralyov 2e1eb85ccb all: use Go 1.21 for building services
Use a newer supported version.

For golang/go#64169.

Change-Id: Ice8fea55951bf1615a04aca24a870556c281877a
Reviewed-on: https://go-review.googlesource.com/c/build/+/556359
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
2024-01-17 23:47:09 +00:00
Hana (Hyang-Ah) Kim 5535e35557 devapp/owners: remove hyangah from x/debug
and clean up unused names

Change-Id: If9b7645024903f3cbb78f66b672e00513d7b2fb5
Reviewed-on: https://go-review.googlesource.com/c/build/+/554015
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
2024-01-04 15:12:45 +00:00
Mauri de Souza Meneguzzo bad0ec2117 devapp/owners: add mauri870 as owner for the atomic packages
Given my contributions to the atomic apis, I would like to volunteer as
a secondary maintainer for the sync/atomic and runtime/internal/atomic
packages.

Change-Id: Id47b71d04a2e91d38e3c1aabbb33ad743e17b608
GitHub-Last-Rev: cab3ed7cd3
GitHub-Pull-Request: golang/build#82
Reviewed-on: https://go-review.googlesource.com/c/build/+/548376
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
2023-12-14 17:21:12 +00:00
Heschi Kreinick f85f669a36 devapp/owners: remove Heschi
I assume nobody wants to individually volunteer for goimports and such,
even though they do occasionally get CLs :)

Change-Id: Id50f265be13f0dd96924ccad34a282718528c6dd
Reviewed-on: https://go-review.googlesource.com/c/build/+/544635
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
2023-11-27 19:47:51 +00:00
Carlos Amedee ea2ff87af5 devapp/owners: add the tools team as owners of the playground.
Change-Id: Ifd64354fdb095db337825ab4c56165f7ea3d1c4d
Reviewed-on: https://go-review.googlesource.com/c/build/+/539455
Auto-Submit: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
2023-11-02 20:01:45 +00:00
M Hickford fedccefa5a devapp/owners: explain how reviews are assigned
Change-Id: Idfc323bffd56bc729aec40e46b0199c2f98d0c5a
GitHub-Last-Rev: f1361d1bb6
GitHub-Pull-Request: golang/build#75
Reviewed-on: https://go-review.googlesource.com/c/build/+/532197
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2023-10-25 10:18:15 +00:00
M Hickford a3af2980cc devapp/owners: link paths to Gerrit
This is helpful to see activity by path, and discover which paths could benefit from additional owners.

Change-Id: Ic7682b68f13e60155587d52f043d0594ab2b4e50
GitHub-Last-Rev: a06f6634ab
GitHub-Pull-Request: golang/build#52
Reviewed-on: https://go-review.googlesource.com/c/build/+/460117
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2023-10-06 19:55:36 +00:00
M Hickford 7f88539780 owners: remove inactive oauth2 owners
Reviews are automatically assigned to owners, so inactive owners cause confusion.

Fixes golang/oauth2#669

Change-Id: I1c81b462fb68b2d17ae1ad5b9d42584506ec4b02
GitHub-Last-Rev: 13ba3ca5bd
GitHub-Pull-Request: golang/build#74
Reviewed-on: https://go-review.googlesource.com/c/build/+/530695
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cody Oss <codyoss@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Matt Hickford <matt.hickford@gmail.com>
2023-09-28 19:51:59 +00:00
Filippo Valsorda d5438a6b1f devapp/owners: assign x/crypto/ssh to Nicola
Change-Id: I414e3b57d57de1e4d55c2b6809a8a06ebba606ae
Reviewed-on: https://go-review.googlesource.com/c/build/+/529955
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
2023-09-22 10:29:52 +00:00
Hana (Hyang-Ah) Kim 11c460a65c devapp/owners: adjust x/telemetry owners
Change-Id: Id23d54d01ef2e6eb5dc83f4a453be82eb13d5945
Reviewed-on: https://go-review.googlesource.com/c/build/+/528178
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
2023-09-14 15:03:09 +00:00
Dmitri Shuralyov 049da809c1 devapp: account {,de}milestoned events in issue burndown chart
Previously the calculation of open issues over previous days only took
into account when the issue was created and closed, but not that issues
may have been added to or removed from the current development milestone
over their lifetime.

This was especially noticeable when relui moved 100 open issues from
Go1.21 to Go1.22, yet the burndown graph made it seem like there had
always been around 225 issues in it, pretty misleading. :( maintner
already tracks milestoned and demilestoned events along with event
creation time, so take them into account to de-gaslight the graph.

Change-Id: Iba3f3f68e4ddc140d5612317c02bdfefe4693d8d
Reviewed-on: https://go-review.googlesource.com/c/build/+/517716
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2023-08-11 19:50:19 +00:00
Heschi Kreinick fe5bbc764a cmd/gopherbot,devapp,maintner: update to 1.20 and Bookworm
Update some random stuff that hasn't been deployed for a while.

Change-Id: Ib8b7059e770d1176b8b8885c479019e404fa97d0
Reviewed-on: https://go-review.googlesource.com/c/build/+/509896
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
2023-07-14 19:58:49 +00:00
Ian Lance Taylor e764d3a5a2 devapp/owners: add owners for new Go 1.21 packages
Change-Id: I975306ddf1a22db5c96f5588075abdae27ddf662
Reviewed-on: https://go-review.googlesource.com/c/build/+/507296
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Eli Bendersky <eliben@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2023-07-06 01:31:51 +00:00
Hana (Hyang-Ah) Kim e0a88d0833 devapp/owners: add telemetry owners
Change-Id: Ib0865f4ba154707662503cd106afe490745f085f
Reviewed-on: https://go-review.googlesource.com/c/build/+/499375
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
2023-05-31 14:01:02 +00:00
Michael Anthony Knyszek 763985093e devapp/owners: make golang/runtime the primary owner of net/http/pprof
This package has more to do with runtime/pprof than net/http.

Change-Id: I69ecfedc1d425c9c7f144d45d14c4b69674d1d5f
Reviewed-on: https://go-review.googlesource.com/c/build/+/482338
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
2023-04-05 17:49:06 +00:00
Michael Pratt fff540fe60 devapp/owners: add js and wasip1 owners
For golang/go#58141.

Change-Id: I64473f26a693b982b891b4e11dae11a28901fca4
Reviewed-on: https://go-review.googlesource.com/c/build/+/479735
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2023-03-27 23:01:20 +00:00
Dmitri Shuralyov 7bf60f09df all: make copyright headers consistent
Replace "Go Authors" with "The Go Authors." to be consistent with the
standard copyright header at https://go.dev/doc/contribute#copyright.
There were also a couple instances of a double space and double "the".

Change-Id: Ife7a80dd40f1a760ba85cbfee270356d46cfc53f
Reviewed-on: https://go-review.googlesource.com/c/build/+/472376
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
2023-03-01 01:31:01 +00:00
cui fliter 459bd2670d all: fix some comments
Change-Id: I15769c4302e8dd1d649e0eaa9b16099f0eda603b
Reviewed-on: https://go-review.googlesource.com/c/build/+/464239
Run-TryBot: Ian Lance Taylor <iant@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
2023-01-31 14:57:29 +00:00
Roberto Clapis faadd2fe3f devapp/owners: change ownership of html/template to security team
Change-Id: Ie3ff5334f011c861e929a1369cb0a70e35222654
GitHub-Last-Rev: a2b83c487a
GitHub-Pull-Request: golang/build#54
Reviewed-on: https://go-review.googlesource.com/c/build/+/463019
Run-TryBot: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2023-01-25 23:05:49 +00:00
Dmitri Shuralyov f233f745bd devapp/owners: add teams to more top-level golang.org/x repos
We know which teams generally own some of these golang.org/x repos,
so document that here for better visibility. Similarly, add relevant
teams to the embed, hash, html, and unicode directories in the main
Go repo.

Also remove out-of-date branch and domain entries.

Change-Id: Id9c564a7b365972f3630b2ac77448eb64b48ef7b
Reviewed-on: https://go-review.googlesource.com/c/build/+/457340
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-12-15 14:56:07 +00:00
Dmitri Shuralyov 7cdfffaab1 devapp/owners: remove unhelpful dmitshur entries
Remove some of my no-longer-relevant entries, since their presence is
causing more confusion than benefit.

x/tools/go/vcs is hopefully heading towards deprecation (see proposal
go.dev/issue/57051) and in general it's outside of scope of what I own
by now.

Similarly, x/tools/cmd/godoc is already deprecated and I hope to see it
carved out+tagged+deleted. I was primary on godoc while on the OSP team
and while working on pkgsite that replaced it, but that is long since
complete.

Continue to de-emphasize my x/website involvement as started in
CL 335209 since my team isn't the primary owner of x/website by now.

Change-Id: Idb97d2d3a6486468809522d329e46bf1872da347
Reviewed-on: https://go-review.googlesource.com/c/build/+/457339
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
2022-12-13 22:08:29 +00:00
Dmitri Shuralyov 12ea671701 devapp/owners: update x/build owners
Brad told me he's okay with being removed here. Thanks for all the work!

Change-Id: I3e101a2b612166761e5ef478bb94373513c6cc32
Reviewed-on: https://go-review.googlesource.com/c/build/+/457338
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-12-13 22:07:23 +00:00
Dmitri Shuralyov 171dd47f30 devapp: update Dockerfile
Start using the latest stable version of Go.

While here, show 8080 as an example local development port in the README
since that's more common in x/build.

Change-Id: Ib2fa17cde2ee4c658dc844c779d308656fdc10cb
Reviewed-on: https://go-review.googlesource.com/c/build/+/457337
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2022-12-13 22:07:02 +00:00
Heschi Kreinick 826bc42c71 internal/https: add health checking support and use it
CL 454935 broke the Kubernetes ingress by requiring IAP on health
checks. Move /healthz handling into internal/https, where it
automatically bypasses authentication and removes some duplicate trivial
implementations.

Unfortunately, GKE is not capable of inferring health check parameters
from a multi-container pod like relui, so we have to change our
BackendConfig. That sets off a yak shave -- I made the questionable
decision to use the same backend for all our IAP services, and the
coordinator doesn't currently support /healthz. Split all them up and
delete the devapp configuration I was using for testing way back in the
day.

Change-Id: I45e866d30508a07e9a805de70af731dd64c22d7f
Reviewed-on: https://go-review.googlesource.com/c/build/+/455215
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-12-05 19:20:45 +00:00
Roland Shoemaker 07d0737649 devapp/owners: fix crypto owners, remove agl
Previously for all packages that had {filippo, securityTeam}, only
filippo would get added as a reviewer, because github teams are not
considered when assigning reviewers. In all those cases switch to
{filippo, roland, securityTeam}, so that at least one person on the
Security team is at least assigned as a reviewer.

Additionally remove agl from secondary on various packages, as he hasn't
worked on the project actively in quite a while.

Change-Id: I96fc27b81b7fe54b990948854a4c7140b9c66d32
Reviewed-on: https://go-review.googlesource.com/c/build/+/444055
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
2022-10-19 22:18:33 +00:00
David Chase b37645b19f devapp: add entries for architecture and OS-specific owners/teams
If I need to find someone to ping to triage a bug, I look here.
So, I added the OS (and architecture) teams.

Updates #28596.

Change-Id: I32a8eff23d68d6d9219ec71a509a6693963c8f05
Reviewed-on: https://go-review.googlesource.com/c/build/+/443435
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
2022-10-18 19:22:22 +00:00
Hana (Hyang-Ah) Kim d0ca5194ff devapp/owners: remove individuals from tools, vscode-go secondary
We will move the code review responsibility to persons on rotation.

And update adonovan's gh handle

Change-Id: Idc4ba5eea82cd1616d4c7054ea0d92138082f61a
Reviewed-on: https://go-review.googlesource.com/c/build/+/440335
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
2022-10-13 19:39:59 +00:00
Than McIntosh 67c445dddb devapp/owners: update owners table for coverage-related packages
Add entries for various new code-coverage related packages, and update
some existing packages (ex: cmd/cover) with revised owner info.

Updates golang/go#51430.

Change-Id: Ibf9e040c8a018b04974c78deb8c8e3355f8bec91
Reviewed-on: https://go-review.googlesource.com/c/build/+/436784
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-10-04 17:53:39 +00:00
Tim King 6d81d672f5 devapp/owners: remove guodongli
Change-Id: Ia485cd4fa132baa140434d83e5060cea9539eba3
Reviewed-on: https://go-review.googlesource.com/c/build/+/429715
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Tim King <taking@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
2022-09-30 21:21:51 +00:00
Heschi Kreinick 97ac8cdb8a all: re-disable container native routing
This reverts CL 422594. Apparently we were misinformed.

Change-Id: I199ca3780ba3b8a7003490534609255ae15861e9
Reviewed-on: https://go-review.googlesource.com/c/build/+/423341
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2022-08-12 18:07:47 +00:00
Heschi Kreinick f59fccde49 all: re-enable container native routing
The bug we were working around is fixed in Kubernetes 1.22, which we
have finally upgraded to.

Change-Id: Ic51a80521d72cb81ceb125586632e1101da795aa
Reviewed-on: https://go-review.googlesource.com/c/build/+/422594
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-08-10 21:07:16 +00:00
Michael Anthony Knyszek 22bcd23136 devapp/owners: add compiler team and shift primary ownership
This change will cause a number of compiler-related issues to
automatically gain the compiler/runtime label on GitHub, and helps
distribute the responsibility of ownership.

It also adds a ton of previously unlisted packages now that we can
assign group ownership.

Change-Id: I6ac932b0950cc386326eb3e1b979d5cbdc8a98a0
Reviewed-on: https://go-review.googlesource.com/c/build/+/416416
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
2022-07-13 16:44:23 +00:00
Michael Anthony Knyszek 83302b2ec4 all: clean up and consolidate deployment documentation
This change moves the devapp deployment documentation into the doc
directory because it's common to all services that run in the GKE
cluster.

It also restructures that documentation just a little to alleviate some
confusion (i.e. make push-prod is not necessary if using make
deploy-prod).

Then, it updates all the relevant services' documentation to refer to
that shared document.

Also, it touch up a couple of the services' READMEs, like gopherbot and
pubsubhelper.

Change-Id: I3774385f1d0ba9e9886ece8462294c1f28e8bd17
Reviewed-on: https://go-review.googlesource.com/c/build/+/416220
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2022-07-07 18:00:38 +00:00
Dmitri Shuralyov a9dc5f043d cmd/coordinator: update local dev command in README
The README suggests a command to run coordinator locally in dev mode.
Update it to take into account that coordinator uses internal/https for
HTTP(S) serving now and no longer always serves https://localhost:8119.

While here, document that the -env flag isn't needed when -mode=dev is
being used. Fix and simplify the /try-dev page: it was using dev build
constraint, so not tested via CI and broke. (I considered just deleting
it, but it was simple enough to keep and it adds value to dev mode.)

Change-Id: I4ffaecd07e5f1321f55bc18f42281d48f2433f30
Reviewed-on: https://go-review.googlesource.com/c/build/+/416215
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Alex Rakoczy <jenny@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
2022-07-06 18:27:47 +00:00
Dmitri Shuralyov f0d6776e9d maintner/maintnerd: set ingress backend timeout to 60 seconds
As mentioned in GKE docs¹, the default is 30 seconds, which is too short
for the /logs endpoint to serve a 304 while long-polling during periods
of low corpus activity. Use a minute, since that worked okay before.

While here, update other YAML files to use the non-beta annotation for
the backend config, since we're using a new enough Kubernetes by now.

¹ https://cloud.google.com/kubernetes-engine/docs/how-to/ingress-features#timeout

Fixes golang/go#53569.

Change-Id: If35ac2b30a8fcb1740d0597afd3e4cda4fe0cea1
Reviewed-on: https://go-review.googlesource.com/c/build/+/415354
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
2022-07-06 18:27:44 +00:00
Michael Anthony Knyszek 5bcae3837a cmd/gopherbot: add task to label compiler/runtime issues
This change adds a task to gopherbot to automatically label
compiler/runtime issues based on the owners list. This task will aid in
finding compiler/runtime issues for further triaging, prioritization,
and assigning ownership.

This change also adds a JSON field to the code owners API to allow for
obtaining all ownership information. The reason why an explicit field
was chosen over alternatives like an empty path set meaning 'all' is
because it's backwards compatible.

Finally, it exports the translation that the owners page does for
package names so that gopherbot can translate the paths the owners
page returns into the names used for packages in GitHub issues.

Change-Id: Idb81a2ab53d16f8bec71450899ea33a5e1c30abe
Reviewed-on: https://go-review.googlesource.com/c/build/+/413579
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
2022-07-06 17:58:58 +00:00
Carlos Amedee e8c8ca12ab all: add license headers
This change adds license headers to files which are missing them.
A modified version of the addlicense tool was used to add these headers:
https://github.com/google/addlicense

The command issued was:
addlicense -c "Go Authors" -l bsd *

Change-Id: Id6fd17c587f99b3ff0ef5f5f35befcfe5aaeef72
Reviewed-on: https://go-review.googlesource.com/c/build/+/409614
Run-TryBot: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
2022-06-01 18:19:15 +00:00
Dmitri Shuralyov fb495b9aac devapp: propagate updateReviewsData error from ForeachProjectUnsorted
CL 407394 added a detailed error in case of a rare, unexpected problem.
Propagate it in one more place so we benefit from the new information
if this happens again.

Updates golang/go#47695.
Updates golang/go#50474.

Change-Id: Iddb9a8d8de320d535fd15842c60bf0274391f8f2
Reviewed-on: https://go-review.googlesource.com/c/build/+/408194
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
2022-05-24 17:32:19 +00:00