Tasks added by expansions, in contrast to all other tasks, didn't handle
the sub-workflow prefix. A while back I looked into it briefly, and saw
that shallowClone didn't clone that one field, so figured CL 546235
would fix it.
It didn't, and now it's apparent to me why not. The expansion always
gets a copy of the top-level workflow definition, even if it was made
by a task with some prefix. Modify addExpansion to record not just that
a given task is an expansion, but also the workflow prefix at that time.
We also have a test that makes it easy to verify this works now.
Keep shallowClone as is, to match the behavior implied by its name,
even though by now the namePrefix it clones gets overwritten anyway.
For golang/go#70249.
Change-Id: Ib1cb34ef121baf946fe6f2500c4bf1611aaa6db7
Reviewed-on: https://go-review.googlesource.com/c/build/+/626336
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
We've inadvertently been running expansions concurrently during minor
releases. For better or worse, it happened to be seemingly fine, and
problems started to be noticeable only when needing to restart or
approve tasks, which failed with puzzling "unknown task" errors.
It's useful to be able to plan builders for the two Go releases in
parallel, and it's completely fine for it not to happen concurrently.
Instead of getting the workflow to arrange for that, it seems we can
do it in the workflow package itself.
The new TestManualRetryMultipleExpansions test fails before the change,
and passes after.
Fixesgolang/go#70249.
Change-Id: Id87323f77f573d9ac364010dfc0b8581e57ce9b8
Reviewed-on: https://go-review.googlesource.com/c/build/+/626335
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Change-Id: Ie188af4920fd9a3033bd90959940f61bda19bdd6
Reviewed-on: https://go-review.googlesource.com/c/build/+/628878
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
This change does a few things:
- Start emitting geomean/<builder details> as a separate time series.
- Add the option to mix benchmarks of all platforms on the same page.
- Set up the front page to show the geomean for each builder we run.
Change-Id: I50bfe0a2f7c92bb7405cf0d799f95c4ec3226a8d
Reviewed-on: https://go-review.googlesource.com/c/build/+/627555
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
benchseries seems to fall over on some of our benchmarks and it's
difficult to say why. But, benchstat works just fine.
This CL forks the internals of benchstat and rewrites benchCompare to
use them.
The comparison made by benchstat is slightly different than the one
made by benchseries, but it's not clear to me how. It might make sense
to try and flush InfluxDB and refill it with the new comparison, but I
suspect it's probably not worth it.
This is a reapplication of go.dev/cl/623275 to correctly propagate
bootstrapped ratio data instead of just a summary of the direct
benchmark data.
Change-Id: I24d161130934e59aee4082629e8d0698fef3fde5
Reviewed-on: https://go-review.googlesource.com/c/build/+/626640
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This adds an extra click to get to the previous dashboard page, but a
follow-up CL will start tracking geomean values and put that on the
homepage.
Change-Id: I178cad30722006629cc1b69917fda650e09cbcb4
Reviewed-on: https://go-review.googlesource.com/c/build/+/626639
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
And update the rule checker to recognize the oscar issue tracker
Change-Id: Ic57e711ef503040f27e0b59590b63eeaf44cefe2
Reviewed-on: https://go-review.googlesource.com/c/build/+/628475
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Relui currently adds steps to a map based on their names. This can
cause issues when multiple steps within the same definition share a
name, as later steps overwrite earlier ones. This overwriting behavior results in relui crashlooping when attempting to access a step that
has been overwritten.
This commit addresses the issue by ensuring that all step names within a
relui definition are unique.
Change-Id: Ib0dbefaa95d9d12367caabc73ab893cb3ccc3872
Reviewed-on: https://go-review.googlesource.com/c/build/+/628195
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
As discussed offline, the gopls pre-release version lasts short
and becomes obsolete by stable version. The pre-release version
related fields are never read.
The vscode-go behavior was changed in CL 618935.
Change-Id: I080a9a984d9c71835d932aedd32f425d9bc1a651
Reviewed-on: https://go-review.googlesource.com/c/build/+/627236
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Commit-Queue: Hongxiang Jiang <hxjiang@golang.org>
Everything is already wired up and I can manually select data for
linux/arm64 by modifying the query params, so all that's left is adding
a dropdown option to make it easier to find.
Fixesgolang/go#70231.
Change-Id: Ide7427f45a042e1ceca75763b440347daf5dabad
Reviewed-on: https://go-review.googlesource.com/c/build/+/627275
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Make it possible to see any scheduled workflows that couldn't be
resumed due to their parameters changing, including their original
parameter values, and the original cron schedule (if any).
This also makes it possible to use the same UI to delete obsolete
schedules after new ones are re-created.
Fixesgolang/go#70145.
Change-Id: Ic6c2ee5794e500bf4a1e8ac5d81fdc6fb68a64e9
Reviewed-on: https://go-review.googlesource.com/c/build/+/624077
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This is to support pushing to gomotes that haven't been ported to LUCI
yet. The alternative, using the ListDirectory RPC in gomote, is actually
more complicated than just implementing the streaming RPC, since the
callsites get very complicated and intertwined with regular code. Here,
it's just duplicate code nicely separated in a separate file.
Change-Id: Icec3514682f6429393df581ccd2e5488098b7e7d
Reviewed-on: https://go-review.googlesource.com/c/build/+/626001
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This is a minor point of friction. Simply accept the optional prefix to
make repro a little easier to use, especially for passing builds.
Change-Id: Id20ec9e13d65ed7f2f6541ecd1c9aae871206d56
Reviewed-on: https://go-review.googlesource.com/c/build/+/623636
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Change-Id: Ie478a5afb1faae767b21b81c16a98fc6169955c4
Reviewed-on: https://go-review.googlesource.com/c/build/+/625695
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Relui is expected to serve 404 when a workflow that doesn't exist is
requested. Its tests, ones that run only when a database is available,
also expect that. Update a few places after CL 593915 accordingly to
serve 404 instead of 500, and update TestServerStopWorkflow to create
a workflow in the DB, since stopWorkflowHandler now fetches it as part
of checking ACLs.
For golang/go#68114.
Change-Id: I90f12a431b1f97d8be33d6404eb7e2064e50f688
Reviewed-on: https://go-review.googlesource.com/c/build/+/624076
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This type is expected to be embedded by value in order to have the
intended effect. Caught by a newer version of generated code which
panics at startup when an unimplemented server type is embedded as
a pointer.
Change-Id: I5074b8b009a5ff6c86695f727b061dffb9c53065
Reviewed-on: https://go-review.googlesource.com/c/build/+/625055
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
On non-Linux, non-Windows OSes, gomotes use the value of the SHELL
environment variable. If the variable is unset, starting gomote fails.
Instead, set /bin/sh as a safe default.
Fixesgolang/go#70163.
Change-Id: I88bdb2d83fa6d81eeccaffd1562fc8512bc0c4c5
Reviewed-on: https://go-review.googlesource.com/c/build/+/624796
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
These are LUCI now. The buildlets won't come back.
Part of golang/go#63698.
Change-Id: I7e8fb2f1892d2f9e81e69a101e26072c4dd08788
Reviewed-on: https://go-review.googlesource.com/c/build/+/624875
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The buildlet on the machine is now turned down.
Part of #63698.
Change-Id: Idf78fed5e56bf91b671629229eb5c9535355eebe
Reviewed-on: https://go-review.googlesource.com/c/build/+/624795
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Cloud Scheduler calls /cron/syncinflux hourly. If there are several days
of results (because we deleted data and want to re-sync), then this can
take several minutes to complete. Allow longer connections.
Change-Id: I334b86b91e6e0ebe640a7a05afd04f1193c092f6
Reviewed-on: https://go-review.googlesource.com/c/build/+/623999
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This reverts commit 0d31c9b6e4.
Reason for revert: This is broken (it send raw measurements, not
a ratio) but even if that's fixed, we're not sure how to compute the
95% confidence bounds for the ratio from the information produced by benchtab.
Change-Id: I9b182668e5f68771bb2c1992e9e1c0a30f8af9c0
Reviewed-on: https://go-review.googlesource.com/c/build/+/623996
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
When watchflakes encountered a build with a mismatch between
a builder definition and the input revision it would log the error and
exit. This change changes the behavior to log that the mismatch exists
and skip the build. This was causing watchflakes to continuously exit
and never process builds past the point of the encountered mismatch.
Fixesgolang/go#70091
Change-Id: Ic3e2957a8e501f6dfa8bbbc458db40f925a0877d
Reviewed-on: https://go-review.googlesource.com/c/build/+/623995
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
The current experience sends non-Googlers down a bunch of scary
authentication prompts asking them to give LUCI access to their GCP
information. This is completely unnecessary.
Add a flag, -public, set to true by default, which causes an
unauthenticated client to be used. The purpose of authentication is
primarily for reproducing non-public builds, though... it turns out
those aren't even supported yet by gomote. Whoops.
Change-Id: I73fb245df8b45917a405312970faf92e825ac3ba
Reviewed-on: https://go-review.googlesource.com/c/build/+/623635
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change removes Matthew's Google address as the primary address
and sets his personal account as the primary address. It keeps his
Google address so that existing CLs will still match with his account.
Change-Id: I0f63146942cd9e5d12e97ff1132768faa8237d02
Reviewed-on: https://go-review.googlesource.com/c/build/+/623955
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Note: CLs won't be assigned to anyone automatically
because oscarTeam is not a gerrit account.
Change-Id: Ie20c419b3caf310fcc0da373fe9f63415629abec
Reviewed-on: https://go-review.googlesource.com/c/build/+/623639
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
benchseries seems to fall over on some of our benchmarks and it's
difficult to say why. But, benchstat works just fine.
This CL forks the internals of benchstat and rewrites benchCompare to
use them.
The comparison made by benchstat is slightly different than the one
made by benchseries, but it's not clear to me how. It might make sense
to try and flush InfluxDB and refill it with the new comparison, but I
suspect it's probably not worth it.
Change-Id: I7e1ea887106e6d7bd9bb310b6ee34cef47efde19
Reviewed-on: https://go-review.googlesource.com/c/build/+/623275
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The upload command doesn't need to track these anymore since they're
no longer used.
Change-Id: I0d96f0cf3572b9f157617ff07e9f3d1496dc4d47
Reviewed-on: https://go-review.googlesource.com/c/build/+/622456
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
As of the last change, it becomes easy to read the nested module's own
go.mod file and determine whether it had a toolchain directive. Before,
it was reusing the top-level go.mod file's decision for nested modules.
I didn't realize earlier there is a way to use the lower-level 'go mod
edit' command to drop a toolchain directive, but it turns out there is.
Switch to it now - it's equivalent but fits slightly better in context.
Fixesgolang/go#68873.
Change-Id: I1ea4bfd9e5deb4e72843887d7f8d68a4b2a67f3e
Reviewed-on: https://go-review.googlesource.com/c/build/+/622396
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fetch the git tree where go.mod is being updated, walk over its content
to find nested modules to tidy. This way even if new nested modules are
added, they'll be handled without needing additional attention here.
The existing test cases continue to pass (i.e., the x/tools/gopls module
is still being tidied). It required adding a minimal HTTP(S) git server
to FakeGerrit, to act like the real Gerrit server, or rather just enough
for gitfs to be able to successfully clone from it.
For golang/go#68873.
Change-Id: Ic571f2edc6345d25558591e531d58ecce70f1851
Reviewed-on: https://go-review.googlesource.com/c/build/+/617778
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
It's generated rather than copied manually, so that it is clear its
canonical source still lives at golang.org/x/website/internal/gitfs.
For golang/go#68873.
Change-Id: I2ec03384666d5c230e59c36db118e7f3969a8e11
Reviewed-on: https://go-review.googlesource.com/c/build/+/617777
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
A fourth nested module was added to x/oscar in CL 615155. The rest of
the CL stack makes manually maintaining this list no longer necessary.
For golang/go#68873.
Change-Id: Ib775a2c84d269b5d9bbd85ba12ded1b78b711706
Reviewed-on: https://go-review.googlesource.com/c/build/+/617776
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
This is an attempt to upgrade the Debian image for linux-arm64.
For golang/go#69763.
Change-Id: I73e579bcd5599e4eb4461d81cd79ed45d8239dad
Reviewed-on: https://go-review.googlesource.com/c/build/+/622039
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
OpenBSD 7.6 has been released, meaning that the only two supported
versions are 7.5 and 7.6. Update the image build script for 7.6.
Additionally, bump the maxproc limit for the swarming user, which
will hopefully reduce the number of failures due to fork/exec
returning EAGAIN.
Updates golang/go#66474
Updates golang/go#69823
Change-Id: Ie2667de2defefbb6a56adca3dec92d7663c615e4
Reviewed-on: https://go-review.googlesource.com/c/build/+/618895
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Change-Id: I130e0ea017fac790ef49a2dda1b7003a7132f061
Reviewed-on: https://go-review.googlesource.com/c/build/+/619635
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
For golang/vscode-go#3500
Change-Id: I923c5e6b25af2f08a2d55401bba032ebdfa82dd5
Reviewed-on: https://go-review.googlesource.com/c/build/+/618396
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
There are two places we need to update the "package.json":
- Insider Release (from master branch) update the "package.json" in the
master branch to reference the next stable version with a "-dex"
suffix.
- Stable Prerelease (from release branch) update the "package.json" in
the release branch to reference the corresponding release version
withou any suffix.
"npx vsce package" generate "package.json" with offending new line. Trim
the "package.json" before creating the CL.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2386625293
For golang/vscode-go#3500
Change-Id: I59476917f960e0dbc0903ee2cf128ba6fb8b96a1
Reviewed-on: https://go-review.googlesource.com/c/build/+/617157
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
- Add a check for release coordinators parameter making sure the
all coordinators have gerrit user name and github user name.
- The first user of the release coordinators will be assigned to the
release tracking issues.
- All the release coordinators will be added as reviewers for the
auto-generated CLs.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2377704665
For golang/vscode-go#3500
For golang/go#57643
Change-Id: If528ab3c5bbc2d589c7198cffa0211f4e5db478f
Reviewed-on: https://go-review.googlesource.com/c/build/+/616195
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This change upgrades perfdata to Go 1.22, explicitly enables the legacy
appengine APIs, and switches to the v2 SDK. This results in a bunch of
logging-related failures from disappearing in the latest deployment.
Change-Id: I44a12ecb4bfee3aeef40a7ce09c84ec89be0f2c8
Reviewed-on: https://go-review.googlesource.com/c/build/+/617578
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Port to LUCI includes:
- Install Python.
- Install bootstrapswarm.
- Use bootstrapswarm instead of buildlet.
For golang/go#61095.
Change-Id: Ie787f6d098186259398ad135b60758e1ce8b489c
Reviewed-on: https://go-review.googlesource.com/c/build/+/616836
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Switch from the older github.com/golang/protobuf module
to the newer google.golang.org/protobuf one.
Mostly a no-op, but this will change the formatting of
text protos a bit.
Change-Id: I2ac90ad5f882c6429ab7c81d55496adbb1008542
Reviewed-on: https://go-review.googlesource.com/c/build/+/617275
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Use the streaming directory listing RPC to avoid
overflowing the maximum RPC response size.
For golang/go#69732
Change-Id: I2529d3788843844e3ccdde79c12c5c453b09bb25
Reviewed-on: https://go-review.googlesource.com/c/build/+/617161
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
For golang/go#69732
Change-Id: I72ef0672cfffa7d33afd44f886c67933242801fb
Reviewed-on: https://go-review.googlesource.com/c/build/+/617515
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
ListDirectory responses can overflow the maximum RPC message size.
Add a streaming version which returns its results in chunks.
For golang/go#69732
Change-Id: I3f7d50a3899f0cbc9954da89a26906f1f5850a93
Reviewed-on: https://go-review.googlesource.com/c/build/+/617160
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Dmitri Shuralyov
Matthew Dempsky
Michael Anthony Knyszek
Hana (Hyang-Ah) Kim
Hongxiang Jiang
Gopher Robot
Ian Lance Taylor
Benny Siegert
Michael Pratt
Carlos Amedee
Joel Sing
cuishuang
Damien Neil
Zxilly