All of these fmt.Sprintf calls aren't needed.
For golang/go#69267.
Change-Id: Ie8e2719e1e94bac3810d4975a349614316e6e0d2
Reviewed-on: https://go-review.googlesource.com/c/build/+/610816
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Funda Secgin <fundasecgin38@gmail.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Fix a bug where inputVersion and versionBumpStrategy arguments were
switched in the determineReleaseVersion step.
Also, add a step to wait for explicit user approval for the gopls release.
A local relui screenshot is at https://go.dev/issue/57643#issuecomment-2329523260
For golang/go#57643
Change-Id: I2201e046970cea4e14fa12e040020dcd54e20940
Reviewed-on: https://go-review.googlesource.com/c/build/+/610536
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
We enabled post-submit builders for x/playground in golang/go#24823.
Stop marking it as "hidden from the dashboard".
Fixesgolang/go#66001.
Change-Id: I96f581aa93ec76748e888c1ad5c50f260beffa59
Reviewed-on: https://go-review.googlesource.com/c/build/+/609140
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
It's no longer used, and not expected to be needed in the future.
As of Go 1.21, the go directive is a more direct way of stating the
minimum Go version to stay compatible with.
For golang/go#48523.
Change-Id: I3932a103982a6843194195c99304bf265217b8d1
Reviewed-on: https://go-review.googlesource.com/c/build/+/609397
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
The golang.org/x repo tagging/updating workflow will inadvertently add
a 'toolchain go1.23.0' directive in a few modules in its next upcoming
run. This is because we use the latest Go toolchain to generate go.mod
file changes, and default behavior of the go command:
> For repeatability, any command that updates the go line also updates
> the toolchain line to record its own toolchain name.
However, right now we want to keep the toolchain directive at go1.22.0
or so, to avoid module authors from needing to remove it if trying to
use an older (but still supported) version of the Go toolchain. Also
see the rationale at https://go.dev/design/69095-x-repo-continuous-go#why-not-bump-the-toolchain-lines-too.
Modify the tagging/updating workflow to check if a toolchain directive
wasn't already there (the common case at this time), and drop it at the
end if so.
For golang/go#48523.
Change-Id: I9f2fb5b02e61fcdeed0ba43bbcc9fb69a1f1efb9
Reviewed-on: https://go-review.googlesource.com/c/build/+/609396
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
The release issue will be referenced by all CLs generated by the gopls
release process.
For golang/go#57643
Change-Id: Icc44aeab84a7a1fc3c624267cb398729371db068
Reviewed-on: https://go-review.googlesource.com/c/build/+/610236
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Tweak the gopls prerelease announcement as follows:
- Gopls->gopls, unless it is at the start of a sentence
- use URLs rather than golang/go#12345 references for issues
- minor tweaks to phrasing
Also, add a test case for TestAnnouncementMail, and consolidate
TestMailAnnouncement into the end to end flow test. TestAnnouncementMail
makes it easy to iterate on emails and update golden testdata.
Change-Id: Ib9ab73208b557b56467a0badaf15127baa09d4f2
Reviewed-on: https://go-review.googlesource.com/c/build/+/609616
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Make it possible to read about its behavior without needing
to deduce it from the source code.
Change-Id: Ica367060d839150699b0e4bf59e4c58f702536fe
Reviewed-on: https://go-review.googlesource.com/c/build/+/609775
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
For gopls pre-release, the flow only need to update gopls version in
vscode-go master branch.
For gopls release, the flow will need to update gopls version in
vscode-go master and current active release branch. (Next cl)
To make the function resusable in future, the branch varaiable will be
taken out and determined by the caller.
For golang/vscode-go#3500
Change-Id: I4778f3ce5ae133b1e495b2660fe41fccfa59c2e6
Reviewed-on: https://go-review.googlesource.com/c/build/+/609376
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
1. Add new method ListBranches in gerrit client interface returns all
the branches in a project.
a. implement the real gerrit client follow rest api doc.
b. implement the fake gerrit client using git for-each-ref.
2. Add util function returns the current active release branch from
vscode-go.
3. Add step at the end of gopls pre-release process to update gopls
version info in vscode-go project.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2311084528
For golang/vscode-go#3500
Change-Id: Ib88b950df729a2f28133809f5a54311c420b447b
Reviewed-on: https://go-review.googlesource.com/c/build/+/608416
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Coordinator have three options to run the pre-release flow:
* next minor or next patch, the flow will interpret the user intention.
* use explicit version, the user must input the version explicitly.
A local relui screenshot is at https://go.dev/issue/57643#issuecomment-2310730081
For golang/go#57643
Change-Id: I9621da87f248c79597641162682fb2d108bc19f9
Reviewed-on: https://go-review.googlesource.com/c/build/+/608415
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
For golang/go#68873.
Change-Id: Ibcd81ec99314819dd5e2faf0c23ae8c33f8a02a7
Reviewed-on: https://go-review.googlesource.com/c/build/+/605316
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
1. Add an input selection parameter allowing the coordinator to choose
between targeting the next minor or patch version.
2. Add a step to automatically determine the appropriate version number
based on the coordinator's selection and prompt for release approval.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2307330808
For golang/vscode-go#3500
Change-Id: I38fcd861ff864dc3683fc571e9a39bccf4e9cb63
Reviewed-on: https://go-review.googlesource.com/c/build/+/607176
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
All of the legacy builders are defaulting to the newer "-7" suffix,
which is what the cross-compiled archives on go.dev/dl/ default to
for GOARCH=arm (ignoring the special case of GOOS=linux). The URL
just needs be fixed to leave out the "-7".
Fixesgolang/go#69038.
Change-Id: I080c26ae9407b286475eaff82f1864b71de8e5be
Reviewed-on: https://go-review.googlesource.com/c/build/+/608076
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
A local relui screenshot is at https://go.dev/issue/57643#issuecomment-2305572494
For golang/go#57643
Change-Id: Iab10d6b4adbb04cfa8381d4e4776c3166ae40f41
Reviewed-on: https://go-review.googlesource.com/c/build/+/607896
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Commit-Queue: Hongxiang Jiang <hxjiang@golang.org>
Keeping one struct gopls release task which can create both gopls
release workflow and pre-release workflow using different method.
For golang/go#57643
Change-Id: I8880684ab1cc0068b1a02f8bc3d791f3ad98bcfe
Reviewed-on: https://go-review.googlesource.com/c/build/+/607497
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Update cmd/relui to accept gopls announcement receiver and sender.
For golang/go#57643
Change-Id: I8271a778a77ea01a51314128b21b7d6b26a273b9
Reviewed-on: https://go-review.googlesource.com/c/build/+/606876
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
We use our policy group for Go release workflows.
For golang/go#68114.
Change-Id: I2cb31682c1072e0b2f2908d05054831ca6987bd0
Reviewed-on: https://go-review.googlesource.com/c/build/+/607795
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Fixesgolang/go#68997
Change-Id: Ifbb0f9deec52f57833f2fdf40952d1c4e69d4f3f
Reviewed-on: https://go-review.googlesource.com/c/build/+/607655
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
1. Extract the awaitSubmission method so that it can be shared by
multiple workflows.
2. Add an executeAndMonitorChange helper, to run a script and return
any change to the file list provided.
3. Add a task to the gopls release flow to upgrade dependency for
x/tools' gopls submodule in master branch. (only for minor version
release)
4. Update the gopls release flow to accept CL reviewers as a parameter.
A local relui screenshot is at https://go.dev/issue/57643#issuecomment-2294232653
For golang/go#57643
Change-Id: I9cb6495956409ce9a3712584278ba0e031e48cfc
Reviewed-on: https://go-review.googlesource.com/c/build/+/606336
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
For golang/go#64751.
Change-Id: Ib8ba94bafc661bd4142dc2f180254d484ce3efa6
Reviewed-on: https://go-review.googlesource.com/c/build/+/605980
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The genbootstrap-generated bootstrap tarballs placed all files at the
root of the tarball, while the go.dev/dl/ tarballs place them in 'go'.
So when using a tarball from go.dev/dl/ as the bootstrap toolchain, the
previously working GOROOT_BOOTSTRAP=$WORKDIR/go1.4 now ends up needing
a slight change to GOROOT_BOOTSTRAP=$WORKDIR/go1.4/go.
This was missed in CL 520901. Fix it now, so that it's possible to
switch to using the go.dev/dl/ tarballs as originally intended there.
Balance out this new complexity slightly by removing a condition for
leaving out the -force flag. The Go 1.20 release branch has aged out.
Change-Id: I6e598e66020e46cc11d40b21663ddb6bd6792fb2
Reviewed-on: https://go-review.googlesource.com/c/build/+/606835
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Allow workflows to define required group membership in order to interact
with them. Currently this implements a flat role model, where all users
can view workflows, and users with specified group memberships can
create, schedule, stop, and delete workflows.
In the future we may want to introduce role-specific group requirements.
Fixesgolang/go#68114
Change-Id: Ic63601b1928e51878805e0c9a7437f65e23ca02e
Reviewed-on: https://go-review.googlesource.com/c/build/+/593915
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Implement CrIA auth database replication. This fetches the database
containing group memberships from a cloud storage bucket and then
updates it every 30 seconds with +/- 10 seconds of jitter. This
duplicates the logic that is used in the LUCI server implementation and
is the solution recommended by their team.
For golang/go#68114
Change-Id: I6f120aa6180822854049e5d9b4d370cd0faa8633
Reviewed-on: https://go-review.googlesource.com/c/build/+/593895
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Gitmirror uses mirror (bare) local repositories as part of its work.
Its tests use one non-bare test repository, so that they can commit
to it and check that mirroring works.
Explicitly track and specify GIT_DIR for all git operations for the
same reasons as in CL 489915 and CL 605937 - it makes them slightly
faster and able to run in safe.bareRepository=explicit environments.
Fixesgolang/go#66202.
Change-Id: I9a08938777e9108f940a791bab65180f8297d0a8
Reviewed-on: https://go-review.googlesource.com/c/build/+/605976
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
The github package API already provides helpers for creating pointers.
Use them as is instead of creating more helpers.
Change-Id: Ie4d5031d6c30dec116e5c1ffd2f457fb731c2067
Reviewed-on: https://go-review.googlesource.com/c/build/+/606315
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Commit-Queue: Hongxiang Jiang <hxjiang@golang.org>
A local relui screenshot is at https://go.dev/issue/57643#issuecomment-2293754679
For golang/go#57643
Change-Id: Ifca27ffc1e333dc65f876083dc0b2496427d4424
Reviewed-on: https://go-review.googlesource.com/c/build/+/605979
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The E2E test will test the following behavior:
- the flow will return the expected pre-release version.
- the flow will create the release branch for minor version.
- the flow will write expected content to three files under
gopls/go.mod, gopls/go.sum and codereview.cfg.
- the flow will verify the number of commits added to release branch is
expected.
- the flow will add a new pre-release tag that point to the head of
release branch.
Fix the issue where the commit and pre-release version string passed in
to the step in wrong order.
Add the pre-release version to the workflow's output.
For golang/go#57643
Change-Id: Ic25cf971a249b555b6d8a5f173c0b4c85f21dd00
Reviewed-on: https://go-review.googlesource.com/c/build/+/605656
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
The gopls release flow will find the commit have the tag
gopls/vX.Y.Z-pre.V and add the release tag in form of gopls/vX.Y.Z.
A local relui screenshot is at https://go.dev/issue/57643#issuecomment-2287244918
For golang/go#57643
Change-Id: I1c3a8ac4b67304cc79a05e9aebd48a8cb57f2f35
Reviewed-on: https://go-review.googlesource.com/c/build/+/604999
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Currently the timeout also applies to the interactive login, which is a
pain. It's also not obvious that someone should just run a different
command.
Fixesgolang/go#68875.
Change-Id: I1f4d10dc8b09df0d928a4fd3429a4eb2b5ccf184
Reviewed-on: https://go-review.googlesource.com/c/build/+/605317
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The gopls release flow takes a full semantic version string
(vX.Y.Z-pre.V) from the coordinator.
The gopls release flow validates this version before proceeding with
any other release steps.
A local relui screenshot is at https://go.dev/issue/57643#issuecomment-2284487734
For golang/go#57643
Change-Id: Ideb799bce8d493f13e2da6ec54d9d24621afba23
Reviewed-on: https://go-review.googlesource.com/c/build/+/604895
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
The gopls release process contains four parts:
1. (Auto) pre-release gopls workflow: coordinator provide a release
version (in form of vX.Y.Z), the pre-release gopls flow create &
submit CLs and tag a release candidate (create a gopls/vX.Y.Z-pre.V
tag in tools repo).
2. (Manual) coordinator cherry pick commits from master branch to
release branch. Once cherry-picks are merged, re-run the first step.
3. (Auto) release gopls workflow: coordinator provide a pre-release
version (in form of v.X.Y.Z-pre.V) produced by the pre-release gopls
workflow, the release gopls workflow create an official release tag
gopls/vX.Y.Z in tools repo.
4. (Manual) coordinator draft the release notes and publish it.
For golang/go#57643
Change-Id: Ib46641acec5b8573a60b9fcfd236b9a34670d1a7
Reviewed-on: https://go-review.googlesource.com/c/build/+/604117
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
1. The gopls release coordinator is responsible for creating the release
milestone. The release automation will fail if the milestone is
either missing or closed.
2. The gopls will re-use existing open releasing issue or create a new
issue.
3. All CL created by the release automation will reference the release
issue.
4. Implement FakeGitHub client which can be used to run unit tests.
A local relui screenshot is at https://github.com/golang/go/issues/57643#issuecomment-2274316296
For golang/go#57643
Change-Id: I5a7a5e07b3cfa1c9155bd6439b737c1baac75138
Reviewed-on: https://go-review.googlesource.com/c/build/+/603876
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
1. Install gopls using the commit from the previous CL or using the head
of the release branch.
2. Print gopls version as informational log.
3. Run smoke test using gopls references.
A local relui screenshot is at https://github.com/golang/go/issues/57643#issuecomment-2269305120
For golang/go#57643
Change-Id: I2a79a0ac35c78c8277a7b5e8a32af82edb9d0573
Reviewed-on: https://go-review.googlesource.com/c/build/+/603036
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds a gomote login subcommand. There is currently an
issue where gomote users have their authentication token invalidated.
They are unable to log into the gomote service. The only way to
create a new authentication token is to manually delete the
authentication token from the file system and attempt another command.
This change adds a login subcommand which removes any existing
authentication token and initiates the authentication workflow.
Investigation into why we can't detect invalid tokens will continue
after this CL has been submitted. The login command also authenticates
with the LUCI service.
For golang/go#68612
Change-Id: Ib0c14546e919648ffd76a1021154134184bc18e3
Reviewed-on: https://go-review.googlesource.com/c/build/+/601796
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Currently, watchflakes skips consistent failures, including ones
at the top, i.e. failing the latest a few commits. Consistently
failing at tip means builds are broken recently on this builder.
Currently we rely on human watching the dashboard to report such
failures. This CL lets watchflakes to do so. If a new issue is
opened for such failures, the title includes "[consistent failure]"
to increase awareness.
Fixesgolang/go#58819.
Change-Id: I2ea89a5d8edee0b9087f03b58e4ff834c03e826d
Reviewed-on: https://go-review.googlesource.com/c/build/+/601439
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Builders with a known issue are in development and are not fully
functioning. They may encounter a lot of failures. Skip them.
Change-Id: Ia89c86975165a05a1f2a0a382d09c86c0ba6d356
Reviewed-on: https://go-review.googlesource.com/c/build/+/602576
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
updateXToolsDependency will drop the replace directive in gopls sub
module and pin the x/tools version to the head of the current gopls
release branch.
A local relui screenshot is at https://go.dev/issue/57643#issuecomment-2263725465
For golang/go#57643
Change-Id: I0d9f4462b71b394ff432bc65142cf35e70977e6a
Reviewed-on: https://go-review.googlesource.com/c/build/+/602516
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
1. Add optional parameter reviewers to gopls release flow.
2. Add a Task to update code review configuration in release branch.
3. Add a Action to wait for CL to be submitted.
A local relui screenshot is at https://go.dev/issue/57643#issuecomment-2259049777
For golang/go#57643
Change-Id: Iae3ebd5dd7bc9040979185aa353e2a4afed8cb54
Reviewed-on: https://go-review.googlesource.com/c/build/+/601241
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Hongxiang Jiang
Dragan Mladjenovic
Dmitri Shuralyov
Rob Findley
Russ Cox
Ian Lance Taylor
Roland Shoemaker
Michael Anthony Knyszek
Gopher Robot
Carlos Amedee
Cherry Mui