Add a internal/cmd/update-protos command which regenerates all
protobuf files within the repo, using the versions of the
code generators listed in the go.mod file.
Replace the per-directory //go:generate commands with a single
top-level one.
Regenerate all .pb.go files.
For golang/go#69732
Change-Id: I337badfb49fc29f638d71eee609d5995262ccd75
Reviewed-on: https://go-review.googlesource.com/c/build/+/617057
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Direct comparison of proto messages (*a == *b) is not supported.
Use proto.Equal instead.
For golang/go#69732
Change-Id: I14db4806e37519a1b988db99ed6c5f5c0284c52b
Reviewed-on: https://go-review.googlesource.com/c/build/+/617056
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
A following CL regenerates the gomote protobuf files,
so update to the most recent gRPC/protobuf modules
while we're at it.
For golang/go#69732
Change-Id: I5de0a5c536ee027556e7bd66d485e6c7658d8a73
Reviewed-on: https://go-review.googlesource.com/c/build/+/617155
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Also fix the Makefile by upgrading to the newest minor version for the
oldest supported major version.
Change-Id: Ic9ab0456a02dd3629b323e649f2cd1729b16e9d3
Reviewed-on: https://go-review.googlesource.com/c/build/+/617215
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Currently, the workdir passed to the buildlet is a relative path, but
this breaks an assumption in the buildlet about the --workdir flag
always being absolute or empty (if empty, it is set to an absolute
path). This results in a bunch of things breaking because a bunch of
codepaths in handleExec in the buildlet expect an absolute path.
At least, that's my current theory. If this doesn't work, then I'll
revert the change to set --workdir and dig deeper.
Change-Id: I3a484e336f997804c0aaaaae02d0af0f00cb6e9b
Reviewed-on: https://go-review.googlesource.com/c/build/+/616917
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Also, throw in some details about the environment the user will be
dropped into.
Change-Id: I58f0f6b188d2bffd615b87c001496592d6a82d75
Reviewed-on: https://go-review.googlesource.com/c/build/+/615957
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Austin Clements <austin@google.com>
golangbuild already assumes it's running in the workdir, but buildlet
creates another workdir in golangbuild's workdir's tmp directory. This
means the checkout of x/ repos ends up in a different directory than
expected, not the work directory buildlet assumes.
Set the workdir for buildlet explicitly in the golangbuild case to match
golangbuild's expectations. This means users will be dropped into a
directory with a whole bunch of stuff, like the tools they need (already
in PATH, but sometimes useful) and whatever repo they wanted checked
out for them.
Change-Id: I7ee3ba9f08cb23b3abc571b7a60b534112c5cca9
Reviewed-on: https://go-review.googlesource.com/c/build/+/615956
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Right now the benchseries comparison performed on benchmark data and the
influx upload code is deeply intertwined. This makes it hard to test the
benchseries comparison code, and also makes it hard to just try out
one-off comparisons for debugging.
This change splits the logic of these two using a Go 1.23 iterator
(though they're not available in this repository yet).
For #69594.
Change-Id: Ibc104a7abf711b89e5f3a2dced91f6cd7dc9e882
Reviewed-on: https://go-review.googlesource.com/c/build/+/615137
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Change-Id: I5e1452eacc01b859c7843ab3af34ae225f9ad225
Reviewed-on: https://go-review.googlesource.com/c/build/+/616156
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
The package.json and package-lock.json in vscode-go master branch should
point to the next stable release with special suffix "-dev".
The vscode-go insider release will first make sure the package.json is
up-to-date before start executing the release related flow.
If update to the package.json is needed, an automatic CL will be created
and wait for it to merge. The insider flow will read the head of master
branch after the CL is merged.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2375280245
For golang/vscode-go#3500
Change-Id: I6067660e8675b299fb68bbb91bbe4df4152ff015
Reviewed-on: https://go-review.googlesource.com/c/build/+/615975
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
This extends the maximum amount of time a gomote instance can run. It
was previously 24 hours. It has now been set to approximately a week.
Fixesgolang/go#69658
Change-Id: I01d7f10a5ba96b3213dbb5fdfeff66cbc7aa688b
Reviewed-on: https://go-review.googlesource.com/c/build/+/616062
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
As of crrev.com/c/5875121, golangbuild switched to the new default
behavior of using 'proto' field naming (such as "gitiles_commit")
instead of using protobuf default names (such as "gitilesCommit").
The previous behavior can still be achieved by explicitly using the
https://pkg.go.dev/go.chromium.org/luci/luciexe/build/properties#OptProtoUseJSONNames
option, but we choose to accept the new default behavior since it's
fine for our needs.
So, update a few places in lucipoll for the new field naming pattern
as was also recently done for watchflakes in CL 615515. Not handling
the old pattern here since lucipoll only needs to handle new builds.
Also drop the unused "omitempty" option from BuilderConfigProperties
while here - it's never used for marshaling, only unmarshaling.
For golang/go#69609.
For golang/go#65913.
Change-Id: Icf2f942fa9821f8781c9a2ecaddd2a3e10496ba2
Reviewed-on: https://go-review.googlesource.com/c/build/+/615976
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: David Chase <drchase@google.com>
- The go run release.go package command is not being executed in the
publish execution step so the log is empty.
- For insider release, the github release will now mention the insider
release is a prerelease version of the next stable version.
For golang/vscode-go#3500
Change-Id: I20f3aa9bea53fd25b06129fb702a907f62b6bffe
Reviewed-on: https://go-review.googlesource.com/c/build/+/615977
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
gomote repro currently doesn't account for no-network builders, making
it harder to reproduce certain failures. On no-network builders, tests
are wrapped with a command to disable the network _and to run as root_.
These are subtleties that probably should be captured in a test runner
or something more visible, but at the very least we can now cover this
specific gap. #69599 tracks capturing this logic in a shared test
runner (possibly golangbuild?) to avoid duplicating it in gomote repro.
While we're here let's also fix an issue with test command generation
for gomote repro (the instance name would appear in the wrong location
in the argument list, before all flags were enumerated).
For #69561.
Updates #69599.
Change-Id: Iff140144f3642ae209974c1f68ec4ea9ee429441
Reviewed-on: https://go-review.googlesource.com/c/build/+/615455
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The test step can be skipped as it was already executed in the
prerelease flow.
For golang/vscode-go#3500
Change-Id: Ieea664ec28657208a93d4dbd9a6fe04ffd9da576
Reviewed-on: https://go-review.googlesource.com/c/build/+/615215
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
- The flow accepts one parameter "verison bump strategy".
- The flow uses that version bump strategy to interpret the version
coordinator want to release. (from "next patch" -> vX.Y.Z)
- The flow finds the latest prerelease of the interpreted release
version. (from vX.Y.Z -> vX.Y.Z-rc.V)
- The flow waits for coorindator's approval before moving forward to
next step.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2364530790
For golang/vscode-go#3500
Change-Id: Ia8573451db5d84b126d95c5c9c2821e5221fa6be
Reviewed-on: https://go-review.googlesource.com/c/build/+/614299
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
The JSON describing a build changed, slightly.
Old convention was camel case, new convention is snake case.
I don't know for sure, but allegedly
Fixesgolang/go#69609.
Change-Id: Ic998e0aa3922749f36528d1f7c4fe4cbe6fc690f
Reviewed-on: https://go-review.googlesource.com/c/build/+/615515
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
When a gomote client attempts oauth authentication via GCP
Identity-Aware Proxy and fails it will log an authentication error. It
will also ask the user to issue the gomote login command. This should
clarify any confusion around when a user is expected to
re-authenticate and how to do so.
Fixesgolang/go#68612
Change-Id: I1afe501829f0bba4d3bf7c369115520243bc892f
Reviewed-on: https://go-review.googlesource.com/c/build/+/615435
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
- Rename mailPrereleaseAnnouncement to mailAnnouncement which handles
all kind of vscode-go releases.
- Create announcement template for insider release, stable release.
For golang/vscode-go#3500
Change-Id: I74ec0a658dcad4c21f7a6d9f7f7c562cf60e012f
Reviewed-on: https://go-review.googlesource.com/c/build/+/614718
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The Cloud Build service account has access to the Secret Manager secret
containing the "vscode-go" extension publish token. This token is
exported as the environment variable "VSCE_PAT" only during the extension
publishing step.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2361818536
For golang/vscode-go#3500
Change-Id: Iede31c019ddd1e37398903f815a0e8ca72aa268f
Reviewed-on: https://go-review.googlesource.com/c/build/+/614455
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
The added steps include:
- Verify the commit in the master branch.
- Generate package extension based on the commit.
- Add the insider tag to the commit.
- Create GitHub release with the tag, diff and body.
Enhence createGitHubRelease method to handle more than prerelease flow.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2359278554
For golang/vscode-go#3500
Change-Id: Ia946a1544b35e29de97c64d0f3cadd48f0f3e366
Reviewed-on: https://go-review.googlesource.com/c/build/+/614216
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
This change also makes use of a log.Logger more consistent in the
various Usage functions for each subcommand.
Change-Id: I22e26156f9dbf5e8042b487db6b66f74ab5c322b
Reviewed-on: https://go-review.googlesource.com/c/build/+/614238
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Make the test commands easier to just use directly:
- Fix std packages having the wrong directory.
- Add GOMOTE_GROUP prefix if the instances were created in a group.
- Add the instance name (just the first) to the command if not created
in a group.
Change-Id: I1dffde676a51e69100a1ea8a902c4a67cbde6fce
Reviewed-on: https://go-review.googlesource.com/c/build/+/614161
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Remove the -login flag as well, which is no longer needed.
Change-Id: I1da04c830b3ae6e218c209a7034f75e131ee8359
Reviewed-on: https://go-review.googlesource.com/c/build/+/614160
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
This was requested by the tools folks because it allows creating stable
links without knowing the magic query parameter.
Change-Id: I29570f70cf89957a54a09d9eb94c45ca1fb8a283
Reviewed-on: https://go-review.googlesource.com/c/build/+/613916
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Currently the dashboard's influx queries hard-code linux/amd64. Remove
the hard-coding by adding a "platform" dropdown to the page and passing
that as a query parameter.
Change-Id: I18c19b95da9aae73b26d93ee850c3181de45b999
Reviewed-on: https://go-review.googlesource.com/c/build/+/613719
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
The relui will accept two input parameters specifying the announcement
sender and the receiver.
As mentioned previously, the email announcement is not locally testable.
For golang/vscode-go#3500
Change-Id: I8b22bc8a4bf5f62b42b22bc34f081c914bc0d7fd
Reviewed-on: https://go-review.googlesource.com/c/build/+/613599
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Currently the "table"/"unit" page has its commit links broken because
the repository value is loaded from the drop-down UI element.
Unfortunately, that doesn't work because the callbacks for fetching
formfields.js won't run until the top-level code is done, so the UI
elements won't be properly prefilled.
Instead of relying on that, access the source-of-truth to get the
repository: the query parameters. This fixes the bug.
Change-Id: I91d3c81036e3722951d5353cdf4b5cff5c7c61a3
Reviewed-on: https://go-review.googlesource.com/c/build/+/613915
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Only the stable version (Y is even) have release candidate, when
releasing a stable minor version (vX.EVEN.0), the release note should
show the diff between current version (vX.EVEN.0) and the latest patch
of the last stable version(vX.EVEN-2.LATEST).
For golang/vscode-go#3500
Change-Id: Ia1ed84d2b2da0789a3e3410f96ad7b6db007174b
Reviewed-on: https://go-review.googlesource.com/c/build/+/613598
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Add a new method UploadReleaseAsset to GitHubClient interface. The
method can upload a file in form of fs.File to a GitHub release as a
release asset.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2354426300
For golang/vscode-go#3500
Change-Id: I16f48573fbb2e3c76d8c5c91bc80ab09c7653e25
Reviewed-on: https://go-review.googlesource.com/c/build/+/613596
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
This step will accept release, prerelease and cloud build as input
parameter.
The first two parameter is being use to determine the release version.
The CloudBuild will be used in the next CL to upload generated package
extension.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2353739346
For golang/vscode-go#3500
Change-Id: Ia9b7fdf2869ceae2baecfbb0179c9985e7a9e1ad
Reviewed-on: https://go-review.googlesource.com/c/build/+/613595
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
For golang/vscode-go#3500
Change-Id: Ic55a53fd5797322bc18d52ae910f60dd70641ec9
Reviewed-on: https://go-review.googlesource.com/c/build/+/613597
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Use RunCustomSteps method to trigger a few steps to build vscode-go
release artifacts:
- download go binary.
- clone vscode-go repo and checkout specific commit.
- execute npm ci and go run to build artifacts.
- copy generated package extension and logs to gcs.
The steps after this will use the returned CloudBuild struct (containing
cloud build ID, project, gcs url) to fetch the artifacts and upload as
github release assets.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2347320416
For golang/vscode-go#3500
Change-Id: Ia2987e1367cd6d76e019b4e576b6cc3e878ac751
Reviewed-on: https://go-review.googlesource.com/c/build/+/611945
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Add new method to interface CloudBuildClient:
- RunCustomSteps accept a function as input parameter.
- The input function should return a slice of cloud steps which will be
eventually executed by the method.
- The input function should accept an input parameter "resultURL" and
can assume this will be valid so the caller can write output to it.
- The method will generate a random result url and pass that to the
input function to generate the cloud steps.
A local relui screenshot is at https://github.com/golang/vscode-go/issues/3500#issuecomment-2341760224
For golang/vscode-go#3500
Change-Id: Icdc6411ab8274b71783c15a0ccf7ecae0d61b3a5
Reviewed-on: https://go-review.googlesource.com/c/build/+/610375
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
All EC2 builders have been migrated to LUCI and stopped in coordinator.
Stop the pool as well. Its permissions have been revoked and it prints
errors continuously. Also drop an unhelpful printf.
For golang/go#67761.
Change-Id: I6ce48e222a2dc88f7d5a7386f8cc9d5b1e8bac71
Reviewed-on: https://go-review.googlesource.com/c/build/+/612559
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
This backports CL 609279 to coordinator. It's not strictly needed since
legacy builders don't take the extra step of setting GOTOOLCHAIN=local
in order to catch instances where the toolchain selected by the builder
ends up upgrading itself to a different toolchain (which is also tested
via another builder, producing little signal other than that toolchain
switching works at the cost of significant builder resources), so the
few remaining legacy builders are passing.
But I have the change ready, so might as well stop a few more builders
from running needlessly.
Change-Id: I8ee686494d1116c93961b08842eb02173224f7cc
Reviewed-on: https://go-review.googlesource.com/c/build/+/612558
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Tim King <taking@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Otherwise deploying runs into:
Step 5/15 : RUN go mod download
---> Running in 2cb572f3515a
go: go.mod requires go >= 1.22.0 (running go 1.21.13; GOTOOLCHAIN=local)
Change-Id: I70e4df2a3f9db92cb144351d4b67a40cfc7fa482
Reviewed-on: https://go-review.googlesource.com/c/build/+/612557
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Tim King <taking@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
A minor clean-up to leave it in a more readable state.
Change-Id: Ia0811df0c9da569be2d08ae1b57da81fdc520056
Reviewed-on: https://go-review.googlesource.com/c/build/+/612556
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The Go 1.21 entries are no longer needed now that go1.23.0 is out.
The list for tip is the same as for Go 1.23, except that the windows/arm
port is not included because it's currently marked broken (CL 601777).
I considered renaming allReleases to something more appropriate since
it tracks only first class ports now, but leaving that to a future CL.
For golang/go#40561.
For golang/go#68552.
Change-Id: Ic61e797a125aef5b9cc2782b87ea558e7c88035c
Reviewed-on: https://go-review.googlesource.com/c/build/+/612555
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Tim King <taking@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
For golang/vscode-go#3500
Change-Id: I257a974f06387a8888e96e645b3dd692e6ab6287
Reviewed-on: https://go-review.googlesource.com/c/build/+/612115
Auto-Submit: Hongxiang Jiang <hxjiang@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
1. Remove prerelease field from semver and rename it to releaseVersion.
2. parseSemver rename to parseVersion returns a releaseVersion and
the corresponding prerelease string.
3. Refactor vscode go release process follow the same pattern as gopls.
Move some code change from CL 612115.
Change-Id: Ic02f26c02db519e475118e80e09748c0c63d1521
Reviewed-on: https://go-review.googlesource.com/c/build/+/611975
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
We can use go/version directly from the standard library now that it
exists there, and because Go 1.22 or newer is always used in x/build.
Change-Id: I5fc65eefa552c9b457691fe0cea6a1cffc2ac871
Reviewed-on: https://go-review.googlesource.com/c/build/+/611976
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
For golang/go#57643
Change-Id: I2f95f961648c9aa9a8c126982cace1a7814ae9a1
Reviewed-on: https://go-review.googlesource.com/c/build/+/611475
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Change-Id: Ife18300373ea73af34f80a3d161794f50737cde5
Reviewed-on: https://go-review.googlesource.com/c/build/+/611555
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Damien Neil
Michael Anthony Knyszek
Hongxiang Jiang
Carlos Amedee
Dmitri Shuralyov
David Chase
Tatiana Bradley
Gopher Robot