Currently, if -post is set, when we encounter a new issue, it
immediately creates an issue on GitHub. This CL changes it to post
at end. This gives us a chance to modify the new issue before
posting. This also makes posting actions together.
Change-Id: I8252b0fde0373134378e61c440b5b62c3cdc514d
Reviewed-on: https://go-review.googlesource.com/c/build/+/602375
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The LUCI RPC call sometimes hangs. Set a deadline so we can
restart.
For golang/go#66687.
Change-Id: Ia61d5d91ac78915cfc18cf37e85550b4c4fbb146
Reviewed-on: https://go-review.googlesource.com/c/build/+/601797
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
1. Add new method CreateBranch to interface GerritClient.
a. Implement CreateBranch real gerrit client follow gerrit
documentation.
b. Implement CreateBranch using git branch for fake client.
2. Change fake gerrit client implementation of ReadBranchHead to
return empty string if encounter error to align return value with
the real client.
3. Change return type of isValidVersion to semantic version to avoid
future code duplication.
4. Add a new action CreateBranchIfMinor to gopls release after
converting the input version string to semantic version struct.
A local relui screenshot is at https://go.dev/issue/57643#issuecomment-2258617146.
For golang/go#57643
Change-Id: I36eb88625ed6036eb322c39b345aee3f1ffa3f5c
Reviewed-on: https://go-review.googlesource.com/c/build/+/601655
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Currently the test commands emitted by the repro subcommand set CWD to
the repo's top-level directory and specify a relative package path for
the package to test. This has a problem in that the test command is
incorrect for reproducing tests from nested Go modules. Since the CWD is
very likely in a parent module, any attempt to run a test in a nested
module from the parent module's directory will fail.
Fix this with a simple trick: set CWD to the package we want to test.
Then, we're always guaranteed to be executing the test from the right
location, within the submodule.
Thanks to dmitshur@golang.org for pointing this out to me!
Change-Id: I121a39f04d8c0e874a339f88d43c01237118bc40
Reviewed-on: https://go-review.googlesource.com/c/build/+/601795
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
As of the previous CL, some messages now have a duplicate "# " prefix.
Remove it.
[git-generate]
cd cmd/gomote
sed -i 's/log.Printf("# /log.Printf("/g' *.go
sed -i 's/log.Println("# /log.Println("/g' *.go
sed -i 's/log.Print("# /log.Print("/g' *.go
gofmt -w -s *.go
goimports -w *.go
Change-Id: Iba9dbf88570310bb11b6b03f6dbab57785867d56
Reviewed-on: https://go-review.googlesource.com/c/build/+/601738
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Some log messages have this prefix so mixing stdout+stderr is still
relatively easy to parse and detangle for most commands. Let's apply it
to everything. A follow-up CL will clean up the places where it now
appears twice in a row.
Change-Id: I02e66eb72215ac883deb283f9a5b2b6d7c51528a
Reviewed-on: https://go-review.googlesource.com/c/build/+/601737
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change switches all explicitly, verbose writes to os.Stderr to
happen through the log package instead. The refactoring is performed
automatically by the program below.
[git-generate]
cd cmd/gomote
sed -i 's/fmt\.Fprintf(os\.Stderr, /log.Printf(/g' *.go
sed -i 's/fmt\.Fprintln(os\.Stderr, /log.Print(/g' *.go
gofmt -w -s *.go
goimports -w *.go
Change-Id: If0c8652d98a465b3569258b4e6593e2821512dee
Reviewed-on: https://go-review.googlesource.com/c/build/+/601736
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change moves the setup for the log package flags to main in
anticipation of a follow-up CL to use the log package everywhere in the
command.
Change-Id: Ib663aa8dc9ad82f6c78ec3cdc93c32b21c7c08d8
Reviewed-on: https://go-review.googlesource.com/c/build/+/601735
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
CL 601438 expands the list of valid gomote builder types, and the
expansion is multiplicative. The help text quickly gets lost when making
an error with the create CLI.
This change moves the list of valid builder types behind the -list flag
which short-circuits execution of the CLI to dump valid builder types.
-list is also a minor usability improvement compared to the old builder
type list: builder types are now printed without decoration to stdout,
so they can processed more easily by tools list grep, awk, and the like.
That is, this change makes gomote a little bit more 'scriptable'.
For golang/go#68006.
Change-Id: Ibb22b4bad383efeef5eb913ba385c0a2746baff3
Reviewed-on: https://go-review.googlesource.com/c/build/+/601440
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Currently the gomote server excludes subrepo builder types from its list
of valid builder types. IIRC, the main reason for this is that since
gomotes did no extra work, these builder types would be redundant.
However, now that we have GOMOTE_REPRO mode and GOMOTE_SETUP mode
installs subrepos at HEAD if possible, there is now a good reason to
expose these as valid builder types.
For golang/go#68006.
Change-Id: Ib80dcaf80c8f2676a63bd489d4136688ef053c47
Reviewed-on: https://go-review.googlesource.com/c/build/+/601438
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
This change adds the repro subcommand which allows one to pass a LUCI
build ID for the Go project and reproduce the build's environment in a
gomote. It also prints out how to run failed tests.
To make this easier, this change also refactors the create subcommand so
that the repro command can reuse the instance creation code and flags
more easily.
Lastly, this change also changes the create subcommand to consistently
use log. Although there's no buffering on stderr, making writes
concurrent-safe, I'm still paranoid that there will be some tearing when
writing from multiple goroutines. Using the log package guarantees
safety. This change also uses the log package for logging the repro
command as well.
For golang/go#68006.
Change-Id: I32b54e0b8cac9fc9cbbdbdad241c0194241dd50d
Reviewed-on: https://go-review.googlesource.com/c/build/+/601437
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
1. Param: coordinator need to provide the version string that will be
released.
2. Task: validate the input version a valid version.
3. Output: returns whether the input version is valid.
For golang/go#57643
Change-Id: Ib6d3f10c9a46ad2f24b0a1fc053265456d152f41
Reviewed-on: https://go-review.googlesource.com/c/build/+/601236
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Recently we added reporting package-level failures (that is not
associated to a specific test) to LUCI. In some cases, e.g. a test
timeout could also cause a package-level failure. E.g.
https://ci.chromium.org/b/8745232168515795905 . Currently
watchflakes reports them as two issues. But they are the same
cause. This CL changes it to combine them, when there is a
package-level failure and also a test failure in the same package.
Also update splitTestID to handle package-level failure. If it
cannot split, treat the whole TestID as package, not the test.
Fixesgolang/go#68597.
Change-Id: I0679a0345194589e84b351ea7519b2d4da2731e3
Reviewed-on: https://go-review.googlesource.com/c/build/+/601436
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
There have been several moves recently.
Updates golang/go#65355.
Change-Id: Ie00f2e540bc7e51d1f833dffb587b3ce9954601f
Reviewed-on: https://go-review.googlesource.com/c/build/+/595295
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
When debugging, it is often useful to let it analyze a single
build, instead of reading the full dashboard, which takes quite
some time. Add a -build flag to specify a build ID or URL.
Change-Id: I488769b788af2c6328065873aafc699e62fd7ba2
Reviewed-on: https://go-review.googlesource.com/c/build/+/601435
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The gradual shutdown has gone smoothly and can be applied
to a couple more remaining builders that have been ported.
Fixesgolang/go#67761.
Change-Id: I0d772073ade99a0a55d4020432d56d9bd41aef12
Reviewed-on: https://go-review.googlesource.com/c/build/+/601237
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
We want to migrate from Global DNS for VMs to Zonal DNS, which is more
resilient. The only known use of Global DNS in the x/build GCP project
is the internal module proxy.
This was previously needed to try and catch tests that accidentally
use the internet while testing.Short() is true, something they're not
expected to do, but without also breaking the ability to download any
module dependencies when testing golang.org/x repos. All that is now
done by LUCI and the coordinator can just use the Go module mirror to
simplify things and help migrate.
Change-Id: Ifbb60804948af160dfcbfe5397a8278c87106505
Reviewed-on: https://go-review.googlesource.com/c/build/+/601175
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
I anticipated that the commit link would need to be absolute, since
commits to the luci-config branch get mirrored to a different GitHub
repo than where the issue is being closed, but accidentally pointed it
to the wrong repository. It should be where the repo where the commit
is, not where the referenced issue is.
Change-Id: Ieba4c3146355b4f6c66ef648091905168603cd8d
Reviewed-on: https://go-review.googlesource.com/c/build/+/601155
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
The need for this setup has been made obsolete via wiki move to Gerrit,
proposal golang/go#61940. Thanks for serving us well, as well as being
quite a nice, simple setup that involved little follow-up maintenance.
Fixesgolang/go#64730.
Fixesgolang/go#55263.
Fixesgolang/go#33187 (obsolete).
Change-Id: I2f6161ec8bf7f9604826e7f803d1084fe9be32aa
Reviewed-on: https://go-review.googlesource.com/c/build/+/600997
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This change rewrites retrybuilds from the ground up to support LUCI. It
works in a similar way to the old command but eschews some of its
functionality so we can iterate more quickly.
The general structure of the tool is to query buildbucket for builds
based on some predicate and then retrigger them as closely as possbile
to how they were triggered in the first place.
The tool supports several convenience flags for influencing the
predicate (builder ID and build ID) as well as an ability to iterate
over commit ranges (which requires making several queries). Where we're
missing functionality there's also a -predicate flag for directly
modifying the BuildPredicate proto as JSON to allow for full control
over the queries made.
This tool works on all repositories, not just the main Go repository. It
does not guarantee "wiping" the dashboard in the same way, but golang/ci
bucket builds will always replace older builds for the same commit on
the LUCI dashboards (and our dashboard too).
Fixesgolang/go#36131.
Fixesgolang/go#27055 by making it obsolete.
Change-Id: I5646982d285145622d9951a7bebbcd9025caf47f
Reviewed-on: https://go-review.googlesource.com/c/build/+/600855
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The internal runtime package sys moved in CL 600436. Update the list of
dist-generated files accordingly.
runtime/internal/sys/zversion.go is left behind for the same reason as
written in the commit message of CL 595116: in case someone works with
an older toolchain before the rename.
Fixesgolang/go#68574.
Change-Id: Ifaf115bd2244670ed1677980b346e75f1b19c7cd
Reviewed-on: https://go-review.googlesource.com/c/build/+/600735
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
It's not needed as of Go 1.20, the generator
is seeded randomly at program startup anyway.
Change-Id: Ic1f5cd84df333a73c8bd39be70f88df03c690e81
Reviewed-on: https://go-review.googlesource.com/c/build/+/599736
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The relui README says it should be possible to run it for development
by providing a Postgres database and by setting a single -listen-http
flag to some value. This has regressed.
Fix it by making some of the newer task dependencies initialize their
clients only when requested. This will still be the case in production,
but it becomes optional when running relui locally.
Change-Id: Ib3d3b20d4c0c9686febeab0a6eab8182f0d08e42
Reviewed-on: https://go-review.googlesource.com/c/build/+/599735
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Very minor tweaks:
- Remove (c) pseudosymbol.
- Remove "All Rights Reserved."
- Change "Google Inc." (no longer exists) to "Google LLC".
[git-generate]
echo '
,s/\(c\) //
,s/ All rights reserved.//
,s/Google Inc./Google LLC/
w
q
' | sam -d LICENSE
Change-Id: Ia0dc8354e00efb3fc98a0cf7508ee25a6372aa56
Reviewed-on: https://go-review.googlesource.com/c/build/+/598519
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
By Rob's request.
Change-Id: Ic8bcb7aeb95606dbe4f93b65a564808552ab838c
Reviewed-on: https://go-review.googlesource.com/c/build/+/598475
Reviewed-by: Rob Pike <r@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
The "close luci-config issues" task is based on the "close cherry pick
issues" task and exists for the same reason. For example, the Go issue
go.dev/issue/63482 should've been closed when https://go.dev/cl/586036
was submitted (since it had a "Fixes golang/go#63482." line), but that
didn't happen because it was submitted to the luci-config branch.
While here, update the "close cherry pick issues" task message to note
the CL number in its closing message too. Also access the scratch repo
directly in abandonScratchReviews without using a loop (for simplicity
and consistency).
Tested with go run . -dry-run -only-run="close luci-config issues" but
with the 'monthAgo' optimization temporarily left out.
Change-Id: I363842e97ab8867afb1933ab97a4e64e0aceeb17
Reviewed-on: https://go-review.googlesource.com/c/build/+/597435
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Change-Id: I205ec67c50a303b60220c709e3c5f9687b7fa491
Reviewed-on: https://go-review.googlesource.com/c/build/+/596477
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Than McIntosh <thanm@google.com>
Change-Id: Ia32e5dd4934537b9b8a91f7f3145c363a7795703
Reviewed-on: https://go-review.googlesource.com/c/build/+/596655
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
For golang/go#68276.
Change-Id: I2169a573c9c64415cd4d524cf378e5a313784e32
Reviewed-on: https://go-review.googlesource.com/c/build/+/595616
Reviewed-by: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The performance testing builders have been migrated to LUCI.
For golang/go#67761.
Change-Id: Ib6816c5f58f7cfd59b340827f07d2a87830b42bb
Reviewed-on: https://go-review.googlesource.com/c/build/+/596155
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Now that gopls@v0.16.0 is released, users do not need special
instructions to install the gopls prerelease.
Updates golang/go#67618
Change-Id: I18dae3f3f2eaf99efda9d555d7e227ef10b5a98c
Reviewed-on: https://go-review.googlesource.com/c/build/+/593679
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Robert Findley <rfindley@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
As of writing, it looks like we may not have gopls@v0.16.0 released
prior to go1.23rc1. Therefore, we should inform users that they must
install the gopls prerelease in order to test Go 1.23.
Also simplify instructions by using the go1.23rc1 command from the
command line. In the future, we should revert to the prior wording, and
remove mention of go1.23rc1, just suggesting "at least Go 1.23".
Also, use fenced code blocks for the command line instructions, as
without these the installation line for gopls@v is linkified as a
mailto: address. For consistency, do the same for other announcement
emails.
Fixesgolang/go#67618
Change-Id: I64ac4fd9b0622683fc35ecddd9147d270e49471d
Reviewed-on: https://go-review.googlesource.com/c/build/+/593055
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
With the CockroachDB benchmark, we now have some new units where higher
is better that don't get matched in the current heuristic. Change the
heuristic to look at unit suffixes to identify some common patterns for
describing throughput.
Change-Id: Ifebf661e2ed0dd104f211e54b9463c571ac8d008
Reviewed-on: https://go-review.googlesource.com/c/build/+/593095
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The Markdown parser used here emits separate AST nodes for regular and
fenced code blocks. Despite that partial support for the former was
started in the initial CL 411575, it appears incomplete. Code blocks
weren't exercised by the existing announcement templates, and there
wasn't coverage for them in the TestMarkdownToText sample input either,
which is why things stayed as they were for this long.
They're about to be used more actively, so unify their handling, and
render them as plain text without additional indentation. This seems
to work out better in this context.
For golang/go#67618.
Change-Id: Ia1b3cfeb56716624916535c51b45c49bb078101e
Co-authored-by: Robert Findley <rfindley@google.com>
Reviewed-on: https://go-review.googlesource.com/c/build/+/593057
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The "label proposals" task adds the "Proposal" label and sets the
"Proposal" milestone, whichever is missing, to proposal issues.
It got stuck processing a no-longer-existing proposal issue 67913:
milestone-Proposal
https://go.dev/issue/67913 proposal: exp/xerrors: add try and handle
2024/06/17 15:24:10 label proposals: PATCH https://api.github.com/repos/golang/go/issues/67913: 404 Not Found []
2024/06/17 15:24:10 gopherbot ran in 33.445731908s
2024/06/17 15:24:10 sleeping 30s after previous error.
Because it happens to set the milestone first, and setting the milestone
was missing the path to add to deletedIssues to work around for maintner
not reflecting deleted issues in its corpus (see go.dev/issue/30184).
Add that path to setMilestone. Also make the task add label first,
set milestone second, for consistency with the task's description.
While here, also mark a few issues that are known to be gone.
Tested in -dry-run mode.
For golang/go#28320.
Updates golang/go#30184.
Change-Id: I5878c944c8e8f52ab375cd433032953fb8a58d54
Reviewed-on: https://go-review.googlesource.com/c/build/+/593056
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Due to several factors as an old pkg version in the ISO, or the amount
of changes that have gone to the binary packages since 6.4.0 was
released, a bit of a workaround is needed in phase2.sh
For golang/go#64684.
Change-Id: I233fcfb77c3cc2f0b04331ad7bfee5892193622a
GitHub-Last-Rev: 76b78fd935
GitHub-Pull-Request: golang/build#88
Reviewed-on: https://go-review.googlesource.com/c/build/+/568315
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change configures the working directory used when a Windows
gomote SSH session is created. When a user starts an SSH session they
will no longer need to change into the windows working directory. In
order to enable this, the conpty package version has been updated to a
version that supports this option.
Updates golang/go#65826
Change-Id: I89654adb229d81c2d07b8632ae18459696ff62c5
Reviewed-on: https://go-review.googlesource.com/c/build/+/592497
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Change-Id: I31e3c67df1e790f5218b7aabf2b56ea0c3af79f5
Reviewed-on: https://go-review.googlesource.com/c/build/+/592516
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This change adds the formfields.json endpoint which the web client hits
to figure out what the valid form options should be. For now, it only
returns the full list of latest Go release branches as well as the
single latest release branch. This information is then used to
dynamically populate the branch dropdown. This means we no longer have
to manually update the list of supported releases.
While we're here, let's also add support for "latest-release" as a
pseudo-branch that picks the latest release. This allows subrepositories
which do not benchmark against Go at master to generate evergreen static
links to their benchmarks.
Fixesgolang/go#67530.
Change-Id: I8b1060686be86f5d1ecc55ae92e632873e60a445
Reviewed-on: https://go-review.googlesource.com/c/build/+/590656
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
An easy way for users to help validate release candidates is by opting
in to telemetry. Suggest this in RC release announcements.
For golang/go#67618
Change-Id: I2eace20a18addbb32566de07155c1f4cd0bc309a
Reviewed-on: https://go-review.googlesource.com/c/build/+/592199
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Robert Findley <rfindley@google.com>
As of the switch to LUCI, we test releases on all trusted and available
builders and require any failures to be manually inspected and approved.
There's no special handling of longtest builders. Remove an old brittle
test that confirmed the fix in CL 503757 worked. That code is no more.
For golang/go#29252.
Change-Id: I30246c7266d463ab0c935f187106d1c8101f8a43
Reviewed-on: https://go-review.googlesource.com/c/build/+/592315
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This change is intended to avoid reporting suggestions that are
intended for development branches, like:
The commit title should start with the primary affected package
name followed by a colon, like "net/http: improve [...]"
On backport CLs on release and internal branches, such as:
"[release-branch.go1.22] os/exec: on Windows look for [...]"
Since their possible mistakes don't quite follow the same rules.
For golang/go#61573.
Change-Id: I36c2317a999768eb9cfce6412278d0ed1c82da72
GitHub-Last-Rev: d4f6ba349d
GitHub-Pull-Request: golang/build#97
Reviewed-on: https://go-review.googlesource.com/c/build/+/591455
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Upgrade a few remaining uses of the very old v17.0.0+incompatible major
version of go-github to the newer v48.1.0 that's already used elsewhere.
Change-Id: I79316b1b32574b11e87828ae9ac1a8ab952154f2
Reviewed-on: https://go-review.googlesource.com/c/build/+/591735
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Make the output of 'relnote todo' more useful:
- consider the existence of a *-stdlib/*-minor/.../nnn.md file to
be equivalent to an explicit mention of an issue nnn; this way
there's no need to enforce that a file like 12345.md must also
have a comment like <!-- go.dev/issue/12345 -->
- improve the TODO wording of legacy RELNOTE= Gerrit comments when
the release note isn't specified (beyond just "y" or "yes")
- track CLs that are mentioned (e.g., "CL nnn") and consider such
mentions to mark legacy RELNOTE= Gerrit comments as handled
- sort provenances to remove a remaining source of non-deterministic
output
With these changes, relnote todo | wc -l goes from 52 lines down to 8,
removing many mentions of proposals that are mentioned in nnn.md files
without an explicit comment, and a few legacy RELNOTE= Gerrit comments
that were reviewed as well.
For golang/go#64169.
Change-Id: If285c431854d279dd7dba6c145ba696ec003b351
Reviewed-on: https://go-review.googlesource.com/c/build/+/591317
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
These coordinator-specific reverse builders have stopped doing work
as CL 589659 and CL 589660. They're being stopped and so they're no
longer expected to connect to the coordinator.
For golang/go#67761.
Change-Id: Id3a4ab94e24a57bd5dc3db900dd486e348857682
Reviewed-on: https://go-review.googlesource.com/c/build/+/591156
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Hongxiang Jiang
Cherry Mui
Michael Anthony Knyszek
Michael Pratt
Dmitri Shuralyov
Russ Cox
Suzy Mueller
Gopher Robot
Than McIntosh
Rob Findley
Antonio Huete Jimenez
Carlos Amedee
Ian Lance Taylor
qiulaidongfeng