Adds fields for the 'draft' flag, patch set number, and revision uploader.
Change-Id: I3780e2df046d9fe1065a6dc1b39400b4ea049d3a
Reviewed-on: https://go-review.googlesource.com/13936
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This adds revision creation date, git ref, and fetch info to the Gerrit
RevisionInfo type. In particular, adding fetch info allows the caller
to include "DOWNLOAD_COMMANDS" as a field to return in queries; this can
be useful in automation.
Change-Id: I407024b2d50278f7179bc589cbe29fa279d5ab78
Reviewed-on: https://go-review.googlesource.com/13896
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Fixes crash on current Gerrit data.
Change-Id: I2097fa66afcbf938f880c89891d7d9ed65d843ac
Reviewed-on: https://go-review.googlesource.com/12555
Reviewed-by: Andrew Gerrand <adg@golang.org>
This will allow tests to identify that they are running on the
continuous build infrastructure and run extra and/or different tests.
Fixesgolang/go#11346
Change-Id: Iafe25babc764b7e012c05f0b62331b11690bf194
Reviewed-on: https://go-review.googlesource.com/13120
Reviewed-by: Russ Cox <rsc@golang.org>
This allows the release command to be run from any directory.
Change-Id: Ia0cac8ad32fb5a232bdf429ec2d8901ffd773d57
Reviewed-on: https://go-review.googlesource.com/12915
Reviewed-by: Andrew Gerrand <adg@golang.org>
This ensures that each release actually passes the tests.
Fixesgolang/go#11943
Change-Id: Ia7bb34a611389fe0d529bdb76ff4d0cd68d3d7cd
Reviewed-on: https://go-review.googlesource.com/12914
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The coordinator doesn't know how to fetch dependencies outside
golang.org/x/... so we should allow it to use Go 1.5's new vendoring
support.
Change-Id: I5e9a8a7e574a1dc728b2b0a8a35616001ff6bc46
Reviewed-on: https://go-review.googlesource.com/12783
Reviewed-by: Nigel Tao <nigeltao@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
We solved the mentioned issue when we got cmd/release working.
Fixesgolang/go#11812.
Change-Id: I163f6757c5e930629fb8b840701e9e3ce7edf3cf
Reviewed-on: https://go-review.googlesource.com/12754
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
If there are multiple +2s, give preference to the person named in an R= line.
If there is a -2 and an R=close, record that as closed.
Change-Id: I9910c0a322688e1f4fa91118c2297158110ddadb
Reviewed-on: https://go-review.googlesource.com/11670
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
remote.go has its own timeout tracking. Don't have the GCE VM cleanup
loop also cleaning them up based on VM's "delete-in" metadata.
The GCE VM cleanup loop will still delete unknown VMs if the
coordinator is restarted.
Change-Id: I5803f3c9431d05df8a31758820e082f60a4878fc
Reviewed-on: https://go-review.googlesource.com/12156
Reviewed-by: Austin Clements <austin@google.com>
This creates a mechanism for clients (such as cmd/release and
cmd/gomote) to obtain buildlets via the coordinator. Previously
cmd/release and cmd/gomote could only create GCE VMs themselves, and
required the GCE project's credentials. In addition to the awkwardness
of needing to hand out the GCE credentials, it also meant ARM and
Darwin buildlets (which use the reverse buildlet pool) weren't usable.
Instead, this creates a new auth mechanism where the coordinator is
contacted over TLS with key pinning (the CA system isn't used) in the
same way that the reverse builders already dialed into the
coordinator, and then a "user build type" and hash are sent as the
username and password. The same master key is used to sign user
builder keys, and they always start with "user-". (which isn't a GOOS).
Then the coordinator provides an API to create and list buildlets.
They auto-expire after a duration and are auto-renewed upon use.
The buildlet library (as used by cmd/release etc) then proxies HTTP
requests via the coordinator to the backend buildlet.
See doc/remote-buildlet.txt for protocol details.
Change-Id: I12e27eae788fdd91927cb182b950893dc759f8e9
Reviewed-on: https://go-review.googlesource.com/11901
Reviewed-by: Andrew Gerrand <adg@golang.org>
I made it static in GCE's web UI but as always, I forgot you can't
rename IP addresses in GCE, so we get another special case here since
our auto-detect logic below wouldn't work. Oh well.
Change-Id: Iae2a435576e9b03959f2e634929da94f0e9275c2
Reviewed-on: https://go-review.googlesource.com/11902
Reviewed-by: Andrew Gerrand <adg@golang.org>
Also link commits to github (nicer diff view).
Also remove some old Mercurial cruft.
Change-Id: I717900cd9cac9c6b5d08b0594d5adf29ed56eeb7
Reviewed-on: https://go-review.googlesource.com/11327
Reviewed-by: Chris Broadfoot <cbro@google.com>
Reviewed-by: Andrew Gerrand <adg@golang.org>
Add closed flag so people can ask for them.
Change-Id: Ifc69f318f54b0c644d2356381e39a757855cd619
Reviewed-on: https://go-review.googlesource.com/11171
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Now you have to fail 3 in a row before you're killed.
This helped Plan 9 a bunch for a few days, before the change was
reverted (and then it started failing consistently again).
We still don't know why Plan 9 sucks at replying to heartbeats.
Change-Id: Ic64d2e8fb75f544c7c3e9a62c28ab9e20ff8392d
Reviewed-on: https://go-review.googlesource.com/11132
Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: David du Colombier <0intro@gmail.com>
The coordinator will automatically start building sub-repos against
the stable releases once this dashboard is rolled out.
Fixesgolang/go#11197
Change-Id: I6f0735f842431a1c072d748f9073120812a03309
Reviewed-on: https://go-review.googlesource.com/11112
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
David Crawshaw
Andrew Gerrand
Rob Earhart
David du Colombier
Russ Cox
Hyang-Ah (Hana) Kim
Brad Fitzpatrick
Alex Brainman