The actual spelling of DoNotReview that has meaning
to the dashboard includes spaces, but I can't put that
string in the commit message because it makes the
CL uncommitable. :-)
Add dnr flag so people can ask for them.
If people do ask, show DoNotReview as the reviewer.
Similarly, show Closed as the reviewer for closed CLs.
Change-Id: Ibe758bbb5f5f03fcb5035e7cb068c6d8d0b6baa4
Reviewed-on: https://go-review.googlesource.com/11260
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
This is stuff needed for my Github->Gerrit bot.
Change-Id: Ie072d7b66be2b219ba48245305a8187446238c9e
Reviewed-on: https://go-review.googlesource.com/19380
Reviewed-by: Andrew Gerrand <adg@golang.org>
Revise Makefile in linux-x86-std-kube and linux-x86-nacl:
- Support a target named `dev` that allows specifying a non-default
Docker repository name.
- Replace hard-coded image names with the directory name that Makefile
resides in. This uses the existing convention of naming directories
according to image name.
- When Dockerfile inherits from a custom image (i.e., linux-x86-nacl
inherits FROM linux-x86-std-kube), use sed to dynamically set the
repository prefix in the Dockerfile.
Change-Id: I372c834175a38bb34d80a18f2f0e23c5a1d007af
Reviewed-on: https://go-review.googlesource.com/19021
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
OS X uses $HOME/Library/Caches instead of $HOME/.cache.
Also make the copyright notice not a doc comment,
which is the real reason I opened this file.
Change-Id: I3af75465a3831aed4d38e2c667c813440e20d0e1
Reviewed-on: https://go-review.googlesource.com/19000
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Otherwise it doesn't work.
Maybe it worked for Evan because he was on a GCE VM with the
right scopes itself. I am not.
Change-Id: Id29a3256a71c732cd9d63055c51b80a9f77b4211
Reviewed-on: https://go-review.googlesource.com/18982
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
OpenBSD 5.8 is the current release and OpenBSD 5.6 is no longer supported.
Revise build script:
- Use the auto installer and disklabel templates built into later versions of
OpenBSD, rather than entirely using expect.
- Rather than duplicating the entire script for openbsd-386, provide an ARCH
environment variable that switches between openbsd/amd64 and openbsd/i386.
Have the openbsd-386 script invoke the openbsd-amd64 script with the
appropriate environment.
- Remove the 'ignore classless-static-routes' option for dhclient, as it is
no longer needed for OpenBSD 5.7 and later.
- Clean up after ourselves, rather than leaving a bunch of temporary files
lying around.
Updates issue golang/go#13029.
Change-Id: Ic1b11dd5eded317b7be32b8f1c2485617ac02b78
Reviewed-on: https://go-review.googlesource.com/18358
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* Buildlets cluster can be created using buildongce program
* Deployment Manager builds cluster and autoscaler
* Describe the environments a build system can be deployed to
* Merges https://golang.org/cl/17827
Updates golang/go#12546
Change-Id: Icac4efab2e9e72932c66f56da319e4d51326455a
Reviewed-on: https://go-review.googlesource.com/17334
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This bit me a few weeks ago when I had some local unsubmitted
oauth2/google changes which failed, but the coordinator kept trying
to run with a nil token source.
Change-Id: I351e626e5c28fb8982786fbb1ba7a8a09d9bb86d
Reviewed-on: https://go-review.googlesource.com/18800
Reviewed-by: Andrew Gerrand <adg@golang.org>
The freebsd 386 builder is run on a FreeBSD amd64 host - without
GOHOSTARCH=386 this is generating a 64-bit tool chain with a 32-bit
runtime and disabling cgo. The previous issue with this configuration
is fixed with https://golang.org/cl/18420.
Fixes#13873.
Change-Id: I3ceef59055c5409773eab06f3980277854c61e89
Reviewed-on: https://go-review.googlesource.com/18421
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Fixes#13769
When copying source files for the OSX pkgbuilder (and others) make
sure the atime/mtime of the source is respected.
Change-Id: I75d463d6a3a350f95c5ab4d8b943b60c8cbf2715
Reviewed-on: https://go-review.googlesource.com/18355
Reviewed-by: Andrew Gerrand <adg@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The Google Container Engine API began returning InstanceGroup
rather than InstanceGroupManager URLs, breaking the code
that downsizes the cluster. Resize code is being removed for
now, to be replaced by the autoscaler API soon.
Change-Id: I5baedcc09627f3443e93f931cd0993ac45430c35
Reviewed-on: https://go-review.googlesource.com/18305
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Previously the Go repo would be in /tmp/watcher1234 and each sub repo in
/tmp/watcher1234/subrepo. This change puts the Go repo inside
/tmp/watcher1234/go.
Change-Id: I4dc3d9fad8cc41647f6a821273565b815fc0f968
Reviewed-on: https://go-review.googlesource.com/18240
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
On Windows, the ProductCode must be different¹ for different versions of
the same product while the UpgradeCode must remain the same².
By setting the Id-field in the Product-tag in installer.wxs file to "*"
(instead of the static GUID), a new ProductCode will be generated by the
WiX-Toolkit on each run of the building process. This allows to upgrade
from previously installed versions of Go without uninstalling them
manually.
Quotes from MSDN
¹) https://msdn.microsoft.com/en-us/library/aa370854(v=vs.85).aspx:
" The ProductCode property is a unique identifier for the particular
product release, [...]. This ID must vary for different versions and
languages. "
²) https://msdn.microsoft.com/en-us/library/aa372375(v=vs.85).aspx:
" The UpgradeCode property is a GUID representing a related set of
products. The UpgradeCode is used in the Upgrade Table to search for
related versions of the product that are already installed. "
Fixesgolang/go#12213
Change-Id: I5d04eef7786107d0d7d4a913e8799838e8788a4f
Reviewed-on: https://go-review.googlesource.com/18071
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Bryan Chan
Brad Fitzpatrick
Andrew Gerrand
Shenghou Ma
Russ Cox
Evan Brown
Joel Sing
Dave Cheney
Özgür Kesim
Chris Broadfoot
Burcu Dogan