Also remove dead nacl-arm. It hasn't run in ages.
And update netbsd comment about why 386 doesn't run. And correct its
VM image name.
Updates golang/go#31705
Updates golang/go#31726
Change-Id: I9de4605f34a052d0a84684fca098388d75602a82
Reviewed-on: https://go-review.googlesource.com/c/build/+/174637
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Revert CL 173517 and replace with a similar but different mechanism.
Now that the new revdial is out, only penalize the old revdial users
(a few stragglers who haven't updated). In practice the limit of 10 at
once won't be a problem but will protect the coordinator during submit
floods.
Fixesgolang/go#31639
Change-Id: I6b6c3567205fdd98e0b80def96d75827e986fe4f
Reviewed-on: https://go-review.googlesource.com/c/build/+/174325
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The old revdial has a simple multiplexing protocol that was like
HTTP/2 but without flow control, etc. But it was too simple (no flow
control) and too complex. Instead, just use one TCP connection per
reverse dialed connection. For now, the NAT'ed machine needs to go
re-connect for each incoming connection, but in practice that's just
once.
The old implementation is retained for now until all the buildlets are
updated.
Updates golang/go#31639
Change-Id: Id94c98d2949e695b677531b1221a827573543085
Reviewed-on: https://go-review.googlesource.com/c/build/+/174082
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Otherwise, the resulting binary refuses to run on a multicore machine,
stating that the use of atomic synchronization instructions is needed.
Change-Id: Ie1a626e064a77c4fd80abbdc597ddbc62e3ffb95
Reviewed-on: https://go-review.googlesource.com/c/build/+/174141
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
To mitigate bug in revdial that's retaining way too much memory and
causing coordinator evictions.
Also double memory limit for now.
Updates golang/go#31639
Change-Id: I19b6df92df9905b087c29884140096946037fa38
Reviewed-on: https://go-review.googlesource.com/c/build/+/173517
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
This is a re-apply of CL 171360, but this time with support for gradual
migration for existing clients. Use redirect with status 308, so that
POST requests to /owners/ preserve POST method after being redirected
to /owners.
This should make it possible to make this change without breaking
current clients (see CL 171460).
After all clients have been updated to use the new /owners URL,
deployed, and enough time passes, the old redirect can be removed.
Update ./devapp/owners tests to use the new URL, and drop the trailing
slash from an unrelated go.googlesource.com link, for consistency.
Change-Id: Idd5615987392c2bdb612f719ace08db895b7cf3a
Reviewed-on: https://go-review.googlesource.com/c/build/+/172668
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This will allow long tests to use/test delve.
Delve is built in its own stage with go1.12, then copied out.
Updates golang/go#18144
Change-Id: I346729c945a95d5e34616500913a43bbe03b524c
Reviewed-on: https://go-review.googlesource.com/c/build/+/172959
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The HTTP response object contains an indication of how much (or until
when) to wait before the next successful API call.
This makes the code use this information to obey the rate limit
constraints.
Change-Id: I22cf851220db6f361f8663be28d49179f52dd623
Reviewed-on: https://go-review.googlesource.com/c/build/+/170959
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This change configures gopherbot to automatically label issues with
"gopls" or "lsp" in the title as "gopls".
Change-Id: I1b6639558551a29f22375732592cb13819748115
Reviewed-on: https://go-review.googlesource.com/c/build/+/172097
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
These components have had recent activity in the issue tracker, so
it's helpful to add explicit owners, even if their primary role as
such is to dispatch issues to more-specific owners who are not yet
listed.
Updates golang/go#27586
Change-Id: Ib77b6d1d02b49b9709f1f58797acf2b64ce95e48
Reviewed-on: https://go-review.googlesource.com/c/build/+/172278
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This reverts commit 6265160dde.
Reason for revert: this incorrectly mirrors to the golang/protobuf repo, which is not intended.
Change-Id: Id75c3f9c82f98a0da0e6d33e3f617dae11354dea
Reviewed-on: https://go-review.googlesource.com/c/build/+/172279
Reviewed-by: Andrew Bonventre <andybons@golang.org>
The runtime package contains multitudes.
I only care about a few of them.
The signal to noise ratio on changes is currently too low.
I hope that we will someday resume work on golang/go#11647,
and/or implement some devapp filters. (Keyword-based? File-based?)
Until then, I'm tapping out.
Change-Id: Ib3baabb44f3a9ee48d78dcb8234c3752e0e42278
Reviewed-on: https://go-review.googlesource.com/c/build/+/171702
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
None of the other handlers for this server require trailing slashes,
so the requirement for this one is surprising.
Change-Id: If4ad2958b3549a849a5af9ee47490a4c47295abe
Reviewed-on: https://go-review.googlesource.com/c/build/+/171360
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Without this step, 'make push-staging' fails for me.
Change-Id: I4563775762671e39dc6a2cb2c5def403e908dfc7
Reviewed-on: https://go-review.googlesource.com/c/build/+/171359
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The owners table is consumed by gopherbot to assign reviewers and
escalate triaged issues.
Gopherbot has its own fallback behavior for unowned paths, which
should generally be to escalate to whichever member of the Go team is
on triage duty (or to escalate to the Go Open Source Project subteam
in general to update the owners table).
Due to the explicit entry for the root of the 'go' repository, when
gopherbot encounters an issue or CL for any standard-library package
without an owner, it will instead escalate to rsc, ianlancetaylor, and
bradfitz. That doesn't seem like a great use of their time, and also
masks the missing entry in the owners table.
This CL removes that top-level entry, so that unknown paths within the
Go repo will appear to gopherbot as such.
Updates golang/go#27586
Change-Id: I469028f7ec5f4b357ae33bca125da2323fc3e0d2
Reviewed-on: https://go-review.googlesource.com/c/build/+/171358
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Remove trailing slashes uniformly from table entries.
Previously, we used string prefixes, which could over-match if two
packages' final elements share a prefix, and used trailing slashes to
compensate, but it's remarkably easy to omit a trailing slash and end
up with a pattern that usually-but-not-always works.
Updates golang/go#27586
Change-Id: Id029a706653e2ba42e83d68f789b65fca34be623
Reviewed-on: https://go-review.googlesource.com/c/build/+/171242
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Move rsc and iant to secondary for cmd/go (to reduce CC and
review-spam for them).
Updates golang/go#27586
Change-Id: I0601d4b50202708726a666d774413d90452c02cd
Reviewed-on: https://go-review.googlesource.com/c/build/+/171036
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Drop linux-amd64-stretch (which is redundant with linux-amd64, which
is now Stretch since CL 170282) and add linux-amd64-jessie, and use
Jessie in cmd/release for Linux releases)
Updates golang/go#31293
Change-Id: I21b7a43a24385d5976296d0e5f1c6009cbc18b05
Reviewed-on: https://go-review.googlesource.com/c/build/+/171121
Reviewed-by: Andrew Bonventre <andybons@golang.org>
• The /auth subdirectory wasn't downloading content from GCS.
• The zip extraction logic was failing for zip files that do not
contain explicit directory entries.
• The invocation of http.FileServer wasn't trimming the /auth prefix,
so rejections would work correctly but successful authentication
would return 404s instead of serving the file.
Updates golang/go#26232
Change-Id: I3a72d7dfca62435c53f4bc7efaebae3900f2c175
Reviewed-on: https://go-review.googlesource.com/c/build/+/170880
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Make exp off by default, as it barely passes anywhere. Lock in the
places where it does pass.
Also disable x/net master combined with Go 1.11 on FreeBSD 32-bit. It
doesn't work on our builders and it'll never be fixed (we're not going
to make changes to Go 1.11) and there's resistance to skipping those
tests (my CL 170777), so I'm just turning off the builder. That's not
ideal, but it's better than people getting used to red on the
dashboard.
Fixesgolang/go#31221
Change-Id: Id0228e4b0ee73715a0c2da84f68dcfc989a48aaf
Reviewed-on: https://go-review.googlesource.com/c/build/+/170782
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
It was previously master, Go 1.11, then Go 1.12, which puts Go 1.11 in
the middle of two things that came after it.
Change-Id: I5c67bff7f0ab4269f1db3d4c7e8197df36dc12cb
Reviewed-on: https://go-review.googlesource.com/c/build/+/170779
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This endpoint will be used for integration testing golang/go#26232.
Updates golang/go#26232
Change-Id: I70cab336b885b82abfe8b77839bc9163600f15b0
Reviewed-on: https://go-review.googlesource.com/c/build/+/170581
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Ignore whitespace before/after buildkeys in ~/.gobuildkey. It worked
in the past because this was only sent in HTTP headers where net/http
cleaned it. But once we also started sending it in HTTP Basic Auth
headers (where it's base64'ed), the newlines then made it to the
server where it didn't match.
So also clean it in the server for old clients.
Fixesgolang/go#30749
Change-Id: I2d9b56909a0f616da670f4e41e63701a0872dff2
Reviewed-on: https://go-review.googlesource.com/c/build/+/170621
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The plan9 port doesn't need to be tested against older Go releases.
Its userbase runs at master.
Change-Id: I710d98560b234c7555c7be526aa2efdb6473c439
Reviewed-on: https://go-review.googlesource.com/c/build/+/170519
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Exp is experimental. It's hard enough keeping it passing on master.
We're not going to fight release branches as well. If somebody wants
to see test coverage against three versions of Go, they can graduate
their code out of experimental.
Change-Id: I4695ce479c47bd56a4a58dba05d367d3de020c58
Reviewed-on: https://go-review.googlesource.com/c/build/+/170518
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Apparently Josh's intuition in CL 170339 was correct. We do need sudo.
Sometimes. It's weird. It works without sudo with gomote, but not
during start-up. The environment is slightly different.
In any case, sudo works. Verified on macOS 10.10, 10.11, 10.12, and 10.14.
Updates golang/go#31123
Change-Id: Idc4ace816a5d8e19bbb124663ca186fdf74b188c
Reviewed-on: https://go-review.googlesource.com/c/build/+/170438
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds support to generate amd64 Plan 9
image. Consequently the "plan9-386" directory was
renamed "plan9". The script handles either the
"386" or the "amd64" parameter to build the image.
This change also adds the possibility to chose to
build the image for QEMU or GCE by passing either
the "qemu" or the "gce" parameter.
Change-Id: Ic5aced903e0d1e7baa4ae7df2167c4d54cd6a66b
Reviewed-on: https://go-review.googlesource.com/c/build/+/4904
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Elias Naur
Brad Fitzpatrick
Damien Neil
Benny Siegert
Dmitri Shuralyov
David Chase
Nikhil Benesch
Rebecca Stambler
Bryan C. Mills
Andrew Bonventre
Josh Bleecher Snyder
David du Colombier