This change adds support for user-invoked TryBots through the new TRY=
syntax. If the user comments TRY=x/foo on a CL to the Go repository, the
linux-amd64 builder will run at head for that repository.
Updates golang/go#34348
Change-Id: I0e7f470329866969586057501034385596e5caa0
Reviewed-on: https://go-review.googlesource.com/c/build/+/203677
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
This will allow the openbsd-arm builder to be migrated to a buildlet.
Change-Id: If38788daf2d1e7f237ebdcce384a098e08bffb0b
Reviewed-on: https://go-review.googlesource.com/c/build/+/192598
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Maybe this will solve the golang/go#28365 problems. But at least it
gets us into codepaths that are known & trusted, and removes use of
deprecated API.
Also, add more logging to help debug golang/go#28365.
Updates golang/go#28365
Change-Id: Ibff2b03fd82573cbeedbbc22d12c30ae1a3c3aa0
Reviewed-on: https://go-review.googlesource.com/c/build/+/203217
Reviewed-by: Bryan C. Mills <bcmills@google.com>
I'm hoping the V8 bump gets us past some tests that were too slow
before.
Updates golang/go#31282 (slow x/text/unicode/norm)
Change-Id: I80bdded59c0148c4d3f277acc82c5cac7a339666
Reviewed-on: https://go-review.googlesource.com/c/build/+/202641
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The Repo.fetch method tries to execute "git fetch" up to 3 times with
linear back-off. We don't expect the git fetch process to take more
than a few minutes unless something is very wrong. At that point,
it's better to abort and try again. So, add a 10 minute timeout.
This should help prevent fetch from being stuck and never retrying.
Fixesgolang/go#35124
Change-Id: Ic06a552378f8bff1bea314288a3637548663a3ef
Reviewed-on: https://go-review.googlesource.com/c/build/+/203057
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
There have been a few instances of people reporting cmd/go issues with
gopls as an example binary that they tried to install. This leads to
issues being labeled as gopls issues, even if they are not.
Change-Id: Iead43281c4b12bebc8748057d4af7131d61d1681
Reviewed-on: https://go-review.googlesource.com/c/build/+/202297
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
From https://github.com/golang/go/issues/34958#issuecomment-543852995 :
> Go's DragonFly support policy is that we support the latest stable
> release primarily, but also try to keep DragonFly master passing, in
> prep for it to become the latest stable release.
>
> But that does mean we need one more builder at the moment.
Updates golang/go#34958
Updates golang/go#23060
Change-Id: I84be7c64eac593dee2252c397f9529deea13605a
Reviewed-on: https://go-review.googlesource.com/c/build/+/202478
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
The earlier fix to remove IN_KUBERNETES in buildlet/stage0/stage0.go
in CL 201739 caused Kubernetes-based cross compilation builds on fail
to start up because I forgot to rebuild & push those container images.
But when I went to re-push them, I found they're too old (Debian
Jessie) and don't build anymore. So update them to Debian Buster.
While I'm here, remove the Debian release name from their image name,
as this won't be the last time we need to upgrade them. Unlike real
builders, the OS release isn't the point of these containers, as they
don't run tests. They exist only to do builds, so the OS isn't
interesting or worth calling out.
Updates golang/go#34956
Change-Id: Iee4691a821421b161a9333b4441f83ff45d1ffec
Reviewed-on: https://go-review.googlesource.com/c/build/+/202021
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The dashboard package has been gradually absorbing all configuration,
keeping cmd/coordinator only about mechanics. But we'd missed this
cross compilation bit in earlier cleanups.
Move it, and add some tests & docs while I'm at it.
Also, disable the linux-arm-nativemake builder by default. It's
redundant with linux-arm. They used to be more different when we
always cross compiled for linux-arm, but I guess that got disabled at
some point. At this poin it serves no purpose except as an opt-in
slowbot if the user really wants to run make.bash on scaleway.
Change-Id: Iac683ccf4d30214330480f9db39f131263b1bf8a
Reviewed-on: https://go-review.googlesource.com/c/build/+/202020
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This parses TRY= comments to opt-in to slower/difference trybots.
This needs some docs/UI work yet.
Updates golang/go#34501
Change-Id: I13a835520d7ac341bc86139b0a2118235bc83e60
Reviewed-on: https://go-review.googlesource.com/c/build/+/201338
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
While the work to make illumos a first class GCE guest is completed, use
this interim zone provided by an illumos community member to run illumos
builds.
Updates golang/go#15581
Change-Id: I1784847e5407894d01ce0aadf489b38d7e5c1924
Reviewed-on: https://go-review.googlesource.com/c/build/+/201597
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This change prevents GopherBot from adding a helpful comment on bugs
opened by known contributors.
Change-Id: Ibda3523d5a90e05f1eaf1be61ce555645f14e26f
Reviewed-on: https://go-review.googlesource.com/c/build/+/200762
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The /etc/services file used to be elsewhere in Jessie. When we
upgraded to Buster we lost it and now need the netbase package.
We've had to do this for other builders we upgraded from Jessie but
I forgot.
Updates golang/go#34905
Change-Id: I24c4271839cc2c4a9556f88d7347b031bd3a29bb
Reviewed-on: https://go-review.googlesource.com/c/build/+/201459
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Go 1.11 added ReverseProxy.ErrorHandler; use it to make the
httputil.ReverseProxy failures print the underlying error back to the
(trusted) client. (Normally the client isn't necessarily trusted
enough to get the full info)
Also, log more to stderr where we can search for it.
Updates golang/go#28365
Change-Id: Iac2d863b159f24fda2e0e6e1f7374ed05434d3e4
Reviewed-on: https://go-review.googlesource.com/c/build/+/200738
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
To do historical analysis, it is helpful to have a corpus of
events data from GitHub. Store all GitHub events in a GCS
bucket until golang/go#29396 is fixed.
Updates golang/go#29396
Change-Id: Ia0172db93e019a8d6ab4ccf6e195f3a3e15583bd
Reviewed-on: https://go-review.googlesource.com/c/build/+/199638
Run-TryBot: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
They were removed to make the build faster but they've let a few
bugs slip by now.
Re-enable.
The 10 test shards adds 812 seconds of test time. Over 5 machines,
that's 162.4 seconds each. Add another test shard to bring it down
more.
js-wasm trybots are currently at ~350 seconds, so we have some budget
to get a bit slower and still be under 5 minutes.
Updates golang/go#34768
Change-Id: Ic40c226d26e873227510e644756b0cc969151186
Reviewed-on: https://go-review.googlesource.com/c/build/+/200477
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Joyent.com is shutting down their public cloud, so we no longer
have our GOOS=solaris or GOOS=illumos builders there.
Maybe somebody will find a new place to run them. Or maybe the ports
will be abandoned. We'll see.
Updates golang/go#15581
Change-Id: I0590227ce61b6b298b6aa4554e5e3bc9e4c464b5
Reviewed-on: https://go-review.googlesource.com/c/build/+/200219
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Adds tags for trybot results, release milestones of issues the CL
is referencing, and Code-Review: -1.
Fixesgolang/go#30576
Change-Id: Idcfe31a3953619218a2e1c9b75f80813dd4158ef
Reviewed-on: https://go-review.googlesource.com/c/build/+/199646
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
+ Adds a stats page that shows open CLs over time
+ Adds a command-line flag to reload templates on each request
+ Breaks some repeated code into some shared logic
+ Some minor cleanup to adhere to best practices
Change-Id: I2d84a1e5c77c7e9131c758d69e4a9bf9a9d815f4
Reviewed-on: https://go-review.googlesource.com/c/build/+/199637
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This is a follow-up to CL 199800. That change started to consider more
builders as active to allow release-branch-only builders to run.
However, it also made those builders show up as new empty columns when
viewing builds for the master branch. There are quite a few old FreeBSD
builders that only run on release-branch.go1.12, and it's too disruptive
to have them appear everywhere. So, hide them when viewing the master
branch of Go repo in the UI.
There can be more UI improvements to be made, and this can become too
much of a whack-a-mole to address them one by one. The scope of this CL
is to fix the most disruptive high priority problem for now. Further
improvements will happen later, with merging of app/appengine and
cmd/coordinator codebases in mind.
Updates golang/go#34738
Updates golang/go#34744
Change-Id: I3df75f8b2bbd5f6fe8097c181ee8a1b1b4354dc9
Reviewed-on: https://go-review.googlesource.com/c/build/+/199878
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Previously, it was possible to accidentally try to specify the
branch name for the Go repository by writing something like:
{b("nacl-386", "go@go1.13"), none},
That looks like it would test the right thing,
but in reality it would be equivalent to:
{b("nacl-386@master", "go"), none},
Because the branch of the builder always overwrites the branch
of the "go" repository.
This is not intuitive and easy to miss when reviewing or reading
the code.
Add a check that detects and panics on this b() API pitfall,
so that it is not accidentally introduced in the future, and
so that code readers don't need to spend time verifying that
none of the existing test cases have fallen victim to it.
Updates golang/go#34738
Change-Id: Id2986e88c0e3585eaa7b45f33de97e1902847305
Reviewed-on: https://go-review.googlesource.com/c/build/+/199817
Reviewed-by: Bryan C. Mills <bcmills@google.com>
The filtering of builders in commitBuilders was too strict,
causing post-submit builders that are configured to run on
release-branches only to not get included in the list of
builders.
This change makes the following builders no longer skipped:
darwin-amd64-10_10
freebsd-386-10_3
freebsd-386-10_4
freebsd-386-11_1
freebsd-amd64-10_3
freebsd-amd64-10_4
freebsd-amd64-11_1
nacl-386
nacl-amd64p32
We may need to adjust the build.golang.org UI after to avoid
including unhelpful columns, but this is a first step to get
nacl builders to run on release branches again.
Updates golang/go#34738
Updates golang/go#34744
Change-Id: Iaf2b93aedd5f44b48b9a63b57f12549fe50b1637
Reviewed-on: https://go-review.googlesource.com/c/build/+/199800
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Now use gl.bucketName as opposed to the passed "bucketName".
Change-Id: Idb405798e90d7a3815b542642e8d6e248c9890be
Reviewed-on: https://go-review.googlesource.com/c/build/+/199237
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Brad Fitzpatrick
Rebecca Stambler
Joel Sing
Tobias Klauser
Dmitri Shuralyov
Dmitri Goutnik
Joshua M. Clulow
Meng Zhuo
Quinten Yearsley
Emmanuel T Odeke
Andrew Bonventre
Carlos Eduardo Seo
Colin Nelson
Gergely Brautigam