This extends the amount of time we spend waiting for a gomote instance
to be created.
Change-Id: Ica872dceff7ec19226022b1e83646ccdfb9c304e
Reviewed-on: https://go-review.googlesource.com/c/build/+/566955
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This adds a workflow to relui which takes a patch from the private
internal gerrit instance for one of the golang.org/x/ repos and sends it
to the public gerrit, waits for it to be submitted, tags the repo, and
emails an announcement message to the various lists.
Requires a minor change to the HTML workflow template to allow for
non-slice textareas.
Updates golang/go#65756
Change-Id: Ica1ec5982545ddd7fff1e71bd33eb3281572017d
Reviewed-on: https://go-review.googlesource.com/c/build/+/559295
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
In most x/tools tests, freebsd-amd64-race can be about as slow as
windows-amd64-race, and much slower on tests that do a lot of I/O,
like some of the gopls tests.
x/tools had actually skipped freebsd-amd64-race previously, and
inadvertently lost the skip when test packages were refactored. Bumping
the timeout seems like a simpler workaround than trying to find all the
tests to skip again.
Fixesgolang/go#64473.
Fixesgolang/go#65863.
Change-Id: I5fee3cb9fb79d2d28cc0051d11966a3e80e90ced
Reviewed-on: https://go-review.googlesource.com/c/build/+/566055
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
This change modifies the Python script used to bootstrap the gomote
instance. It fixes the paths to files on Windows instances. The time
we wait for an instance to be fully bootstrapped has been increased to
10 minutes from 5 mintes because of the time needed to bootstrap macOS
instances.
Change-Id: I257e9c392b717d690b1ba3bd847fa987ead485e6
Reviewed-on: https://go-review.googlesource.com/c/build/+/565855
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This change adds an experimental flag to the gomote service which
enables bootstrapping with through the use of golangbuild.
Change-Id: Ieb6045edd23bc04bf3a253c2d19ec6d03de0a0a5
Reviewed-on: https://go-review.googlesource.com/c/build/+/565418
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The new slices.SortFunc function is clearer and faster.
Change-Id: Id1194dc7fb64cdcbe53ad7faa57f7dfb40e533c3
Reviewed-on: https://go-review.googlesource.com/c/build/+/565575
Commit-Queue: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
The only use was removed in CL 163218 (the removed href for
.Owner.Name in reviews.tmpl).
It's unlikely that anybody is using the field manually as you have to
match the owner name, not e-mail address.
Change-Id: I1209680a7f729fa743050872c89beb52a4fe19ac
Reviewed-on: https://go-review.googlesource.com/c/build/+/565555
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
This adds the ability to pass an experimental option to the gomote server.
Change-Id: I86dd35c6e16212f18d91bea58d36c06109c7ab11
Reviewed-on: https://go-review.googlesource.com/c/build/+/565417
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This moves setting environmental variables in gomote instances from
the SSH session creation to the swarming task configuration. This also
adds setting the GOROOT_BOOTSTRAP variable to the bootstrap version of
Go installed by CIPD.
Change-Id: I8d9a0f146f2316cec7cef7a2b58e81e56cbdf6f4
Reviewed-on: https://go-review.googlesource.com/c/build/+/565416
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The Target struct fields Builder, LongTestBuilder, and BuildOnly were
applicable to releases prior to distpacks (i.e., Go 1.20 and older).
By now, all releases are built on a secured Linux machine (and verified
by rebuilding on another secured Windows machine), installers are built
by the same pipeline that's responsible for performing signing, and the
tests are run via the "advisory builder" loop. These fields have become
meaningless and confusing, so drop them.
Print whether a port is primary or not in releases.txt, so that if a map
entry like "linux-amd64": &Target{} that only has implicit effects left
by now is accidentally removed from allReleases, it'll be easy to spot
the effect via the releases.txt diff.
There's a bit more to do before the entire package becomes obsolete.
For golang/go#40561.
Change-Id: Ib66ca6958db695db0093556edc822dcdfbfdde0d
Reviewed-on: https://go-review.googlesource.com/c/build/+/564255
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Change-Id: Ia38576f3a146dfdc3c5e6013ccdc423aa327573a
Reviewed-on: https://go-review.googlesource.com/c/build/+/564876
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
If a Cq-Include-Trybot footer appears in the GitHub PR message,
include it in the footer section of the Gerrit commit message.
This footer controls the LUCI SlowBots that run on a CL, and has no
effect if it isn't in the footer block, so it is important that we place
it in the footer specifically.
Most GitHub PR users won't add these initially, but reviewers may
request that they add them to add important SlowBots.
Though LUCI requires this be a footer, gerritbot is intentionally more
lenient and allows it anywhere in the message to try to catch simple
mistakes.
Change-Id: Ib31762765aad69e9229501fe3fe3d8f8b6b97eda
Reviewed-on: https://go-review.googlesource.com/c/build/+/564837
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Delete everything that runs on release-branch.go1.20 and older.
This is dead code since only Go 1.21 and higher are supported now.
Change-Id: Id5740c6a775e0eba4957348c0ee0531775a2277d
Reviewed-on: https://go-review.googlesource.com/c/build/+/564220
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
For golang/go#40561.
Fixesgolang/go#64207.
Change-Id: I1bbd60d0c2bcae28856c7f7c8293cb2f5a2397f5
Reviewed-on: https://go-review.googlesource.com/c/build/+/564217
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Delete the old before starting to update for the new.
"Targets for release 1.21" and newer in releases.txt
doesn't change.
For golang/go#40561.
Change-Id: I40abd20bbee165a641e2a22a6e791cfbdf950058
Reviewed-on: https://go-review.googlesource.com/c/build/+/564216
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The coordinator was used for Go 1.20 non-distpack-based releases.
Those are gone. Remove all of the code path that will be unused.
The new advisory builders that run on LUCI run for all first-class
ports and non-first-class ports. The previous testing strategy tried
to select a single hard-coded builder (or two hard-coded builders,
one for short tests and another for long test) per first-class port,
and considered remaining Google-owned builders as advisory. There were
separate code paths for running these. With LUCI we have one code
path that covers both. Release coordinators always review advisory
failures and will make an appropriate decision whenever something
needs to be manually approved.
With this, relui no longer has a coordinator client and should keep
working after the coordinator is shut down as part of the migration
to LUCI.
Fixesgolang/go#63147.
Change-Id: Icb75be762238e0ebef64da2eb58b33ac39fafb2f
Reviewed-on: https://go-review.googlesource.com/c/build/+/564219
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The process for adding a bootstrap version of Go on gomote instances
has changed. It no longer places it in a go1.4 directory. It also
places the bootstrap version of go in a directory inside of the
working directory even though the bootstrap version of go is already
installed by CIPD for the instance. This is an intermediary step to
clarify the logging and remove non-functioning logic.
Change-Id: I46f18837b63483e8b9593865c3df8e090252a358
Reviewed-on: https://go-review.googlesource.com/c/build/+/564836
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Port watchflakes to LUCI. Query LUCI build results instead of
build.golang.org.
Partly based on Russ's CL 432403 (old watchflakes).
Change-Id: I8191e92858349f0d8310d31dc31ccb9cc578bf7f
Reviewed-on: https://go-review.googlesource.com/c/build/+/557115
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This change adds a conversion from the armv6l CIPD platform dimension
to the arm GOARCH value.
Change-Id: I3a0b1e0ad1fda05e3fe1db72d4a0f9cce7a77231
Reviewed-on: https://go-review.googlesource.com/c/build/+/564875
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Most lines in api/next/NNN.txt files look like
pkg PACKAGE, FEATURE #ISSUE
but there can also be build information, like
pkg PACKAGE (windows-386), FEATURE #ISSUE
Fix the parser to account for that.
For golang/go#64169.
Change-Id: I7b82084f1a9589d162aa7f4fc8abbe5b0199b4d4
Reviewed-on: https://go-review.googlesource.com/c/build/+/564396
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Go 1.20 has become unsupported, so relui will always take the distpack
code path for all future Go releases. Delete the non-distpack code.
For golang/go#63147.
Change-Id: If2c38cbe6aee21d7a8f5077162e48c180c6b7db0
Reviewed-on: https://go-review.googlesource.com/c/build/+/564218
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
CL 558197 updated LUCI builders to take into account
that Go 1.23 will require macOS 11 Big Sur or later.
We haven't fully migrated away from the old dashboard,
so apply the same change here for now.
For golang/go#64207.
Change-Id: If0baa35d6f595d33911eaef43a467ad71c0a4c15
Reviewed-on: https://go-review.googlesource.com/c/build/+/564215
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
CL 556455 incurred some complexity to opt x/build out of testing with
Go 1.20 sooner than it would've happened automatically. This complexity
is no longer needed since Go 1.20 is fully unsupported now. Remove it.
Updates golang/go#64169.
Change-Id: I99128b9294c50439ed95a91b968a65f18d8fec03
Reviewed-on: https://go-review.googlesource.com/c/build/+/564134
Commit-Queue: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
- Change links to point at the LUCI build dashboard.
- Call the branch input "Go branch" and tweak the help text to match.
- Add some helpful text if no data could be fetched for charts.
- Update the release branch list to include new releases and drop old
ones.
Change-Id: If821a9919d5ae3e07ddc7e394c8887db0bb1d146
Reviewed-on: https://go-review.googlesource.com/c/build/+/563875
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
For whatever reason, Git on macOS (both Xcode-provided and Google-provided)
does not respect GIT_FLUSH=1. Stop using git check-ignore
interactively.
based on Russ's CL 557755.
Fixesgolang/go#65683
Change-Id: Ie46294f8392ca7b65eabb360a7d504b809c45b08
Reviewed-on: https://go-review.googlesource.com/c/build/+/563515
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Otherwise no one will ever find it.
Change-Id: Ibcaf2df7d7b4a190dc7fa17f1bed92502830b6af
Reviewed-on: https://go-review.googlesource.com/c/build/+/563403
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
When it comes to planning advisory builders during the release process,
as well as determining commit greenness as part of the tagging process,
we want to skip custom builders (e.g., the new perf builder which does
benchmarking) and builders with known issues (e.g., the linux/arm port
builder which is undergoing the turn-up process).
This change implements that behavior in the two places. Log the causes
of these skips, but default to skipping for custom modes that might be
added in the future. We want that to be possible without incurring any
disruption to these workflows.
Fixesgolang/go#65589.
Change-Id: I6bcac92e1c2f298f5a748581ae333402a90d39ef
Reviewed-on: https://go-review.googlesource.com/c/build/+/563395
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Currently there's no way to identify a baseline change or a change in
the benchmarks as the source of a regression or improvement. This change
adds this information to the per-unit page, which at least allows for
*some* way to check it in the UI.
Change-Id: I28bfe7eca1dfb2792a1f7adc94b3ac7b4aa8911e
Reviewed-on: https://go-review.googlesource.com/c/build/+/563400
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Currently perf.golang.org ingests only benchmark results produced by the
coordinator service account. Now that the LUCI perf builders are up, we
should target those instead. This change makes the switch.
Although it might seem prudent to support the old and new infrastructure
simultaneously, the old infra's perf builder has been broken since the
Go 1.22 release, since it's running out of disk space. (The LUCI
machines have plenty of disk space, so this shouldn't be a problem going
forward.) This presents an opportunity to do a clean switch and not fix
the old builder at all.
Change-Id: I7005f9d0996d20da0c4e01d36088ecd2e9e14021
Reviewed-on: https://go-review.googlesource.com/c/build/+/563399
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Currently makemac is extremely minimal, all it does is renew existing
leases. It does not attempt to detect broken leases or create new
leases. Over time as leases disappear for various reasons, the pool
slowly dwindles, and a human must come along and add new leases.
Extend makemac to perform complete lifecycle management. config.go
specifies the desired count of each image type, and makemac attempts
to maintain that many healthy leases.
There are several different ways that a lease may be unhealthy:
It may fail initial boot. If it fails to connect to the hypervisor,
MacService will automatically remove it eventually. If it connects to
the hypervisor, but not to LUCI, then it will appear healthy in
MacService but be missing from swarming.
It may succeed initial boot and successfully connect to LUCI, but
eventually freeze, crash, etc. This case will appears as a "dead" bot
on LUCI, and may or may not be automatically removed from MacService
depending on the nature of the freeze/crash.
makemac attempts to detect and handle all of these cases. For example,
if LUCI reports a bot as "dead", but MacService still reports it as
alive, makemac will destroy the lease.
Since makemac can now perform destructive actions, we need to add a
bit more safety. Leases created by makemac will set the MacService
lease "project name" to "makemac". The "project name" is effectively
just a tag on the lease. makemac will only operate on leases with the
"makemac" project. All other leases (such as those manually created by
a human) will be left alone.
Image updates can be performed by changing the image SHA in config.go.
handleObsoleteLeases will automatically destroy old leases using the
old image on the next run.
Change-Id: I9bc53cb5812784adbb5cacf9fb224d64d063c089
Reviewed-on: https://go-review.googlesource.com/c/build/+/562399
Auto-Submit: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Change-Id: I0d948377ff84430a53471ba577b717b3881aa221
Reviewed-on: https://go-review.googlesource.com/c/build/+/562398
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Use a team rather than individuals, so we can more easily CC folks who
are currently working on telemetry.
Change-Id: I91a58404f11a350e4b84bd433e03186eade7772e
Reviewed-on: https://go-review.googlesource.com/c/build/+/562247
Reviewed-by: Peter Weinberger <pjw@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
The generate command should take the Go repo root, not the directory
where the doc files reside.
Change-Id: I313a0f795f97dde32af7efd3171d98567557b39a
Reviewed-on: https://go-review.googlesource.com/c/build/+/562242
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Add DumpMarkdown, which prints the blocks of a document to aid
debugging.
For golang/go#64169.
Change-Id: I371bb0123fda941bc47f5b197aa6e711e4d60406
Reviewed-on: https://go-review.googlesource.com/c/build/+/562241
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Convert text in markdown like "[bytes.Buffer]" to links to
Go symbols, like the go/doc/comment package does.
For golang/go#64169.
Change-Id: I6518e422877991e61cdbd4137d90faf082235eb7
Reviewed-on: https://go-review.googlesource.com/c/build/+/562240
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This changes the error message when the expected hostname does not
match the hostname used to generate the certificate signing request.
Change-Id: I06669e74255b72b4e92a42b5f3045830557777a8
Reviewed-on: https://go-review.googlesource.com/c/build/+/562016
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Just happened to notice this by accident.
Change-Id: Ib3f318e682c567806475de5dec8fd5c08c187392
Reviewed-on: https://go-review.googlesource.com/c/build/+/562136
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This dependency is required for clang's llvm-symbolizer to decompress
DWARF debug information in the binaries we (and clang) produce. This is
already accounted for indirectly with the debian package manually
included for linux-x86-clang, but in the LUCI world, I chose to add
clang to CIPD so it's easier to update.
Fixesgolang/go#65469.
Change-Id: Id58fb754f959c1a3b6da1b7505003697685a3b45
Reviewed-on: https://go-review.googlesource.com/c/build/+/561595
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Have CheckAPIFile look for corresponding release note files in the
directory doc/next/*stdlib/*minor.
Previously, it was looking in doc/next.
For golang/go#64169.
Change-Id: I40fa31f0e95885648536ce74aa070f9f7fdf692b
Reviewed-on: https://go-review.googlesource.com/c/build/+/560295
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
In the error messages for CheckAPIFile, display the full pathname of
the problematic file and refer to the documentation for API release
notes.
For golang/go#64169.
Change-Id: I2e8c6d3952d9e234ffc5e7aec9d55dacaca15828
Reviewed-on: https://go-review.googlesource.com/c/build/+/559695
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
After the rc for the new go version has been tagged, there is a
tagged version > current major version, so the heuristics to choose
when to run the task do not apply. Instead, read the current go
version in the go.mod to find the old version and compare.
Change-Id: I2feefd9f4cb1e45e4e1d27f26b4416c392963955
Reviewed-on: https://go-review.googlesource.com/c/build/+/555675
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This port is successfully passing tests.
Change-Id: I27a17f67fc2b03a43261c5286e784d27527f6e28
Reviewed-on: https://go-review.googlesource.com/c/build/+/558496
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
This change sets the gomote client to use LUCI as the default
gomote instance provider. A fallback option has been added.
Set the GOMOTEDISABLELUCI environmental variables equal to
true to force the client to fallback to the legacy build environment.
Fixesgolang/go#64747
Change-Id: I43e91b5ccd6396317695798cfe03cece4eb2151e
Reviewed-on: https://go-review.googlesource.com/c/build/+/554055
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Add a subcommand to display unfinished release notes.
For golang/go#64169.
Change-Id: Ie378a53cf89fe0cbf8425fdad5bdd0b415f33e55
Reviewed-on: https://go-review.googlesource.com/c/build/+/557035
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Very much a copy of the code for Twitter, except that it uses
a 3rd party package to handle posting. Some of the common code
was moved into a new function.
Also includes an end-to-end test for by-hand use that will send a
Mastodon DM to a specified account. This test requires access
to the cloud secrets and will skip if it lacks either those
secrets or the command line flag.
Fixesgolang/go#65046.
Change-Id: Ie7606242766f36fecd5b15acc3c995c046098079
Reviewed-on: https://go-review.googlesource.com/c/build/+/554375
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Carlos Amedee
Roland Shoemaker
Michael Pratt
Michael Anthony Knyszek
Russell Hancox
Ian Lance Taylor
Dmitri Shuralyov
Cherry Mui
Jonathan Amsterdam
Gopher Robot
Rob Findley
Suzy Mueller
Joel Sing
David Chase