This seems to be the last builder still using the old builder
binary and not buildlet. It needs an entry in here to switch
to buildlet and stage0.
Change-Id: If2fdd2298ab88d56b6850061050caf27ca7c8983
Reviewed-on: https://go-review.googlesource.com/c/build/+/168061
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
By now, there's no more need to be able to serve requests over http
instead of https, so start always redirecting to https instead.
Fixesgolang/go#27870
Change-Id: I257ce732597839dc511c3e9ce440340494c62191
Reviewed-on: https://go-review.googlesource.com/c/build/+/168138
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It's convenient to be able to build and run tests for cmd/coordinator
on macOS, in addition to Linux. Add the build tags and make appropriate
changes to the README to document the level of support.
I've tested running locally on macOS and the limited basic functionality
seems to work okay. If there's something specific that doesn't work on
macOS but works on Linux, we can update the README accordingly.
Start using go run instead of go install to combine two commands into
one. If someone prefers to use go install and run the installed binary,
they can infer the instructions to do so from the go run command.
Change-Id: I823b21a8c790c77045638b53c204ce10b60f40b2
Reviewed-on: https://go-review.googlesource.com/c/build/+/168137
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It's not important to run the new "reboot" bootstrapping test on all
builders; a few is fine. Skip it on plan9-arm, etc, and on trybots that aren't
super widely sharded.
Change-Id: I35d5408eb5e034f42df5976f2b9b7f7d478d580a
Reviewed-on: https://go-review.googlesource.com/c/build/+/167998
Reviewed-by: David du Colombier <0intro@gmail.com>
The NetBSD builders apparently have a tiny filesystem.
And this test doesn't need to be run everywhere. A few builders is enough.
Fixesgolang/go#30839
Change-Id: I60df10173112ef9957c0e4cd6d414a4c5efaa940
Reviewed-on: https://go-review.googlesource.com/c/build/+/167637
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Version v1.16.0 of the grpc module is known to be bad (because it
doesn't include the fix from grpc/grpc-go#2393), so we don't want
to require it, even indirectly.
Commands run:
go mod edit -droprequire=google.golang.org/grpc
go mod tidy
go test ./...
Updates golang/go#30833
Change-Id: I549dd5276ae19aa89c18cf2e9c981e81b8ffdd11
Reviewed-on: https://go-review.googlesource.com/c/build/+/167597
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Now that a pseudo-version of golang.org/x/build module with maintserve
carved out exists, the module golang.org/x/build/maintner/cmd/maintserve
can depend on it. Do so now.
This is analogous to CL 166857.
Updates golang/go#29935
Change-Id: I661f32336ede26fde5581527959d31d164a00b63
Reviewed-on: https://go-review.googlesource.com/c/build/+/167463
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This change creates a new module with the module path
golang.org/x/build/maintner/cmd/maintserve, and moves the maintserve
command into it. This is done by adding a go.mod file in the
maintner/cmd/maintserve directory. As a result, the maintserve command
and its dependencies are removed from this and later pseudo-versions of
the golang.org/x/build module.
This is similar to how the h2demo command was carved out into a separate
module in CL 162822.
The motivation for doing this is that the maintserve command requires a
large number of dependencies for its own use, that no other package in
x/build needs. Even though authors of library modules should not be
requiring x/build, it still happens (see golang/go#29935). So, improve
the situation by moving maintserve into a module separate from x/build,
which in turn significantly reduces the dependencies in x/build.
Updates golang/go#29935
Change-Id: Ic64da32be142fedf6475a11fea787cdfe245e0ce
Reviewed-on: https://go-review.googlesource.com/c/build/+/167461
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
No tests because this part of the coordinator hasn't been refactored
for testability yet. (Working builders for the x/build repo are new
and this code hasn't been historically unit tested.) We're getting
there, but not in this CL.
Fixesgolang/go#28891
Change-Id: Iad718a98e42fec7de09f5d77e6c957dca97fc0a3
Reviewed-on: https://go-review.googlesource.com/c/build/+/167382
Reviewed-by: Bryan C. Mills <bcmills@google.com>
* add support for longtest builders for subrepos.
* fix race builders for subrepos (they weren't passing the -race flag).
* adjust the policy for the js-wasm builders to build fewer subrepos
where it'll never work or isn't worth it.
* fix the android emu builders which disappeared because an empty
string was being passed to buildsRepoAtAll. In some places in the
code an empty string for goBranch for the "go" repo meant the same
as branch, but I forgot that in the new code, so an old caller was
confusing the new config hooks. Rather than make all policy funcs be
aware of both ways, the new code in this CL now maps an empty string
to the same as the repo's branch when the repo == "go". Adds a test
too.
* fix some outdated comments.
Change-Id: Icf3fb85e5542a4d314443b59d02517b306ef46b7
Reviewed-on: https://go-review.googlesource.com/c/build/+/166897
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This README was an accident. I had an early prototype of maintner on
my local disk as slurpgit.go (before it was named maintner). Because
it was on my disk, when I ran x/build/update-readmes.go, it created
this directory.
Fixesgolang/go#30744
Change-Id: I8a7807a8c7c0faaf31124cba1401d7c96b0bdbdc
Reviewed-on: https://go-review.googlesource.com/c/build/+/166878
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The x/website repository uses go.mod to specify precise versions of
its dependencies, and therefore requires the use of GO111MODULE=on
to build correctly. So set GO111MODULE=on when running its tests.
Change-Id: I4acc80fd207e257aa77dc0e296b1039c83fa3d2a
Reviewed-on: https://go-review.googlesource.com/c/build/+/165743
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Mostly some regressions (building too much) from the massive refactoring
in CL 166218, but also some minor changes. See test updates.
Change-Id: Ie30f51b425367f18a49764ac971e262131959bc8
Reviewed-on: https://go-review.googlesource.com/c/build/+/166557
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Remove the old compressed Darwin one that's no longer used and add
windows-arm.
Change-Id: I342d3132888090b80a9332d17307f1c6e7ef57c8
Reviewed-on: https://go-review.googlesource.com/c/build/+/166378
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This removes a bunch of TODOs about scattered policy and moves it all
into builders.go.
While here,
* add a bunch of tests
* unexport some things
* rename some things
* document some things
* adjust FreeBSD policy as function of branch (per Go 1.12 being
last to support FreeBSD 10.x, and to unblock CL 165801)
* set GO_BUILDER_SET_GOPROXY=coordinator for reverse buildlets,
which is necessary to remove the oauth2 & build special cases
in the config
* change Elias Naur's mobile builder to how I think he wants it
(he was fighting the old system)
* add $HOME on the Solaris smartos builder, which was missing &
causing tests to fail lately
* make the (currently failing) longtest builder have GOPROXY set
* remove an allocation in version.ParseReleaseBranch
Fixesgolang/go#9603
Updates golang/go#14594
Change-Id: I50a23ad7cdf478c95b14bee9b3931ba361baacfa
Reviewed-on: https://go-review.googlesource.com/c/build/+/166218
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Now that farmer.golang.org is an authenticated GOPROXY server (CL 165779),
this adds the unauthenticated localhost server on the buildlet that
adds the auth headers to farmer.golang.org.
The buildlet only does this if the build includes env
GO_BUILDER_SET_GOPROXY=coordinator, in which case it listens on an
emphemeral localhost port per exec and sets GOPROXY to an HTTP server
running on that port. This way we don't need to deal with any port
management or conflicts.
Updates golang/go#14594
Change-Id: Iae6d2deda9d5e88ab659d94aaccc43e01fcf4a7c
Reviewed-on: https://go-review.googlesource.com/c/build/+/165782
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
They've been decomissioned for some months now. Our arm64 builders are
on packet.net these days.
Change-Id: Iaede189157e0298812b2971cdd63599f6096d73d
Reviewed-on: https://go-review.googlesource.com/c/build/+/165781
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Broken by CL 165779 where I forgot we have trybots in x/build again.
Change-Id: I92df000cbeefe9ec11375cf22e260692ac188848
Reviewed-on: https://go-review.googlesource.com/c/build/+/166077
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
To ease Robert's load and help out with a first pass review.
Change-Id: I3e0aa1fe7211429de4352358073870c4c8be7f8e
Reviewed-on: https://go-review.googlesource.com/c/build/+/166057
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Buildlets have regular builder tokens, not "user-" prefixed ones. So
don't use the auth helper function. Just inline what we need in the
proxy handler.
Fix from testing CL 165779.
Updates golang/go#14594
Change-Id: Ie2d8d7a21f5660d24e929c932571b8df61895374
Reviewed-on: https://go-review.googlesource.com/c/build/+/165780
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
So builders outside of GCE (Macs, etc) can use a module proxy. It will
be exposed to them via an unauthenticated localhost:3000 server that
adds the necessary authentication to this server.
This is a follow-up of work started in CL 157438.
Updates golang/go#14594
Change-Id: Id824b0ad3a0274048023cc72f8adad23d5f0ea29
Reviewed-on: https://go-review.googlesource.com/c/build/+/165779
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Also allow individual builders to override GOPROXY explicitly.
The vetall builder expects to build golang.org/x/tools from a specific
revision, and in module mode that implies that it needs access to all
of the module dependencies of that revision.
The individual subrepo builders may need a GOPROXY to resolve
dependencies when the default value of GO111MODULE changes to "on",
since they will enter module mode automatically even though they are
running within GOPATH.
Updates golang/go#30228
Change-Id: I40f6f2ea3c5ed05eaaaf3503ba97e6ccd3f20e1f
Reviewed-on: https://go-review.googlesource.com/c/build/+/165738
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
When running GOOS=android go test <pkg>, the go tool will build the test(s)
for Android and run it through the exec wrapper. The exec wrappers takes care
of pushing the binary to the device and running it. That's how the normal
builder with an Android device attached works: setting GOOS=android.
Some x/mobile tests uses the Android SDK and then use an Android specific way
to run integration tests with Java. Those tests don't run on GOOS=android.
To solve that dilemma, define a special builder without GOOS=android set
and use it (only) for x/mobile.
Then, disable the GOOS=android builder for x/mobile to avoid wasting
device time better spent on the main repository.
Similar to CL 164740.
While here, correct two GOHOSTOS values and rename the existing
android builders to match the GOOS-GOARCH-suffix form.
Updates golang/go#30482
Change-Id: I3712584c62c3765d5605cccb642aa6f119826ae8
Reviewed-on: https://go-review.googlesource.com/c/build/+/164660
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
By adding gradle and Android build tools to PATH, setting ANDROID_HOME,
and adding the OpenAL headers to CGO_CFLAGS.
Change-Id: Ifeaa1b82f4108afc3787eee4449b3317185bbaec
Reviewed-on: https://go-review.googlesource.com/c/build/+/164658
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The "close cherry pick issues" task has been working to close
cherry-pick issues when CLs are merged to release branches,
but only for issues with milestones like like 1.12.1, 1.12.2,
1.12.3, etc., not ones like 1.12. This change fixes that.
Output from a -dry-run run after this change:
$ go run . -dry-run -only-run="close cherry pick issues"
close-cherry-pick [dry-run]
https://golang.org/issue/30314 x/tools/cmd/godoc: url flag's response recorder ignores body [1.12 backport]
2019/02/21 14:00:43 [dry-run] would add comment to github.com/golang/go/issues/30314: Closed by merging 49d818b07734fb3230f2d00bc5d4453348348d24 to release-branch.go1.12.
2019/02/21 14:00:43 [dry-run] would close golang.org/issue/30314
2019/02/21 14:00:43 gopherbot ran in 217.391921ms
Fixesgolang/go#30342
Change-Id: I93528e6cf724aba1894a7c640fbb75ec42bb2006
Reviewed-on: https://go-review.googlesource.com/c/163205
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Yuval Pavel Zholkover
Brad Fitzpatrick
Benny Siegert
Dmitri Shuralyov
Bryan C. Mills
Tobias Klauser
Agniva De Sarker
Elias Naur
Katie Hockman