This change adds builders for amd64 FreeBSD 11.4 and 12.2. These
builders are labeled with a known issue until they have been tested.
They will not be used in trybots until the known issue label has been removed.
Updates golang/go#44431
Change-Id: I902f2f6bd887135bf247feb1be0e0fd49f732614
Reviewed-on: https://go-review.googlesource.com/c/build/+/311869
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Update the expect script to work with with the SeaBIOS built-in VGA
serial console emulation instead of sgabios.
Tested on Ubuntu 20.4.
Updates golang/go#44431
Change-Id: I4f7f1972092416f1d6d54ec7e16d100aeeeaf25f
Reviewed-on: https://go-review.googlesource.com/c/build/+/279392
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Unresolved false was being omitted because false is the zero value.
Change-Id: I4b164b27e28d10d10fc192ec86c9d41046a00dfc
Reviewed-on: https://go-review.googlesource.com/c/build/+/311469
Trust: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
It's nice to have a thread for the results because it starts unresolved,
it gets marked resolved automatically if TryBots are happy, and it can
be used to discuss the failure.
Dropped the duplicate check on the beginning message because it's useful
to know the TryBots have started again when dropping TryBotResult.
Updates golang/go#39828
Change-Id: I66e8edec6dee10e8e1df2d2a6b501774ef373496
Reviewed-on: https://go-review.googlesource.com/c/build/+/310015
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Trust: Filippo Valsorda <filippo@golang.org>
This will only show the latest one in the web UI unless "Show all
entries" is checked.
Also added the status link to the in progress failure notification, as
the previous one won't be as accessible.
Fixesgolang/go#39828
Change-Id: I9d81006ac3822a9dc0201637bbb0ce1bae860cc7
Reviewed-on: https://go-review.googlesource.com/c/build/+/310011
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Trust: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Transferred issues are getting categorized as part of this set and
returning errors when the milestone is applied, causing GitHub to rate
limit Gopherbot. Only try to milestone newly created issues as a result.
And re-enable that task now that the number of transferred issues should
be lower.
For golang/go#40640
Change-Id: I7e772d1bcda46e982f0f375481108ff10c064ae9
Reviewed-on: https://go-review.googlesource.com/c/build/+/309069
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
plan9LogWriter was added to truncate log writes
to 128 bytes to work around an issue with
GCE serial port.
This change enables plan9LogWriter only on GCE,
so the log writes aren't truncated when running
in other environments.
Change-Id: I4c5dcb27e5daa8e68f2a1e1abfce96d709d50a0f
Reviewed-on: https://go-review.googlesource.com/c/build/+/225697
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: David du Colombier <0intro@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
A good amount of time has passed since the deletedIssues map was last
updated, and the "freeze old issues" task was needlessly making 34 API
calls to freeze issues that are gone. After this change, that task is
making 0 API calls (whenever there aren't existing issues to freeze).
Some gardening tasks were converted to be more general and run on more
issue trackers in CL 233377, so update the deletedIssues map to track
the repo ID in addition to the issue number.
For golang/go#28320.
Updates golang/go#22635.
Updates golang/go#44406.
Updates golang/go#39008.
Change-Id: I3b477bf717f7d97676e9ef950214a3598ec3abd2
Reviewed-on: https://go-review.googlesource.com/c/build/+/308790
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The maintner data model doesn't expose when an issue gets transferred
from one repo to another (that's golang.org/issue/37370), so GopherBot
currently doesn't skip transferred issues when processing them.
There turns out to be many transferred issues in the vscode-go repo,
causing gopherbot to take too many repetitive actions as reported in
golang.org/issue/45461. Skip the task by default until this is handled
better to avoid depleting the GitHub quota way too quickly.
For golang/go#45461.
Change-Id: I404c94b342f9a870f159d3cadef6cfa2a9979d2d
Reviewed-on: https://go-review.googlesource.com/c/build/+/308789
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
For the purposes of improving issue triage, it's helpful to add all of
the new issues in the vscode-go repo to Untriaged. Add a gopherbot task
that does this.
Change-Id: I9484c6fd4cc8388cba5f9bf629b77b3a5dda29cf
Reviewed-on: https://go-review.googlesource.com/c/build/+/308350
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change was initiated by the need to migrate the darwin cluster
hosted on MacStadium over to an entirely new cluster. The changes
contained in this change are:
- Configure makemac to work with new cluster configurations.
- Enable the use of the new versioning used by macOS as of version
11.0.
- Begin enabling the addition of arm64 macOS instances into the VMWare
cluster. While the feature has not been released it seemed prudent
to make these changes along with the other changes being made.
Fixesgolang/go#45088
Change-Id: I1f46871c16046ccc289059f96dc69c0fd66a5175
Reviewed-on: https://go-review.googlesource.com/c/build/+/308489
Trust: Carlos Amedee <carlos@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The builder name was misleading, because plan9-amd64-9front
hasn't been running 9front anymore since 2016, but is running
the 9k kernel from Bell Labs.
Change-Id: I6929583b784d076a86b818649c64b821a538ed1c
Reviewed-on: https://go-review.googlesource.com/c/build/+/307409
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
Trust: David du Colombier <0intro@gmail.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
This change removes the known issue from the darwin-amd64-11_0 builder.
Fixesgolang/go#40762
Change-Id: I9914c8153abf3b9078579e8829374ee09f84e6e3
Reviewed-on: https://go-review.googlesource.com/c/build/+/307822
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change updates the desired host counts for darwin amd64 hosts.
The numbers require changing because:
- Migration to the new cluster with diffrent counts for amd64
machines.
- The addition of macOS 11.0 builders.
Updates golang/go#40762
Change-Id: I4a0dfcc8bd812ede38acbb98c0b317e03059b525
Reviewed-on: https://go-review.googlesource.com/c/build/+/307474
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change updates the number of Mac hosts that are expected to
connect to the coordinator. There is now a distinction between there
being a amd64 and arm64 Mac hosts. We have reduced the count of amd64
hosts to 8 and have been adding arm64 Macs.
Updates golang/go#45088
Change-Id: I97de966c8398ceb0e5cb31d6bbe688de69efc4a5
Reviewed-on: https://go-review.googlesource.com/c/build/+/307731
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
With the release of macOS 11.0 (Big Sur), the hostname for hosts need
to accomodate multiple architectures. The operating system version is
now noted in the major portion instead of the minor portion of the
version. This change creates the appropriate hostname in the buildlet.
Updates golang/go#40762
Updates golang/go#45088
Change-Id: I943f0c481442a892bb5793283c527b8400a5be9c
Reviewed-on: https://go-review.googlesource.com/c/build/+/293829
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Change-Id: I05b5f1e93548295d3e465d999922563fa99e682d
Reviewed-on: https://go-review.googlesource.com/c/build/+/304969
Run-TryBot: Tim King <taking@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
This change adds linux-arm64-aws to the set of trybots. It also
removes linux-arm and linux-arm64 from the list of builds attempted in
the misc-compile-linuxarm builder.
Updates golang/go#36170Fixesgolang/go#45065
Change-Id: If25fed08e35b2a91c9c9dbbf31701ff5464dc913
Reviewed-on: https://go-review.googlesource.com/c/build/+/303232
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds linux-arm-aws to the set of trybots. The related
changes include:
- Renaming the linux-arm builder to linux-arm-scaleway.
- Adding slowbot aliases which use linux-arm-aws as the default
builder for linux-arm builds.
Fixesgolang/go#35628Fixesgolang/go#40872
Updates golang/go#45064
Change-Id: Ib49f50e03fc4f766015fdd78080b804c2784a398
Reviewed-on: https://go-review.googlesource.com/c/build/+/303230
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Make the health dashboard more useful by displaying
the status of the darwin/arm64 reverse builders.
For golang/go#39782.
For golang/go#45336.
Change-Id: I3536d5716b048722fe36e905b182a0a4972b9bc3
Reviewed-on: https://go-review.googlesource.com/c/build/+/306649
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This adds a builder for the GOEXPERIMENT=regabi configuration of the
compiler. We'll want this builder until we enable regabi by default.
Update comments and buildsRepo test, since it's now merged with master.
Updates golang/go#40724.
Change-Id: I424ca7bf6243e6b4660f4ec54c248a1813b3a83d
Reviewed-on: https://go-review.googlesource.com/c/build/+/305849
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Add support for a linux-386-longtest test-only target. This is the
third longtest builder that we have.
Both linux-{386,amd64}-longtest targets are passing on master
for future Go 1.17 releases, as well as release-branch.go1.16
and release-branch.go1.15 now that CL 288818 is cherry-picked
(see backport issues golang/go#45240 and golang/go#45239).
Start including them in the release process by default, so that we
have more automated test coverage and more information available
during the upcoming releases, and in turn can use it to improve
the releases and the release process further.
Fixesgolang/go#29252.
Change-Id: I9740c9ce5cae73a3ed9fe320219f1044f5fdcc9a
Reviewed-on: https://go-review.googlesource.com/c/build/+/304949
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Change-Id: I1989a6cb1ec2a9c848077e5f7352d7cb07d5d183
Reviewed-on: https://go-review.googlesource.com/c/build/+/304809
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
In recent times, it has been observed that the GitHub API rate limit
quota of 5000 requests per hour is being occasionally exceeded.
It should be very helpful to have a graph that tracks remaining rate
limit over time to better understand the current state and how much
effect future code changes have on improving it.
Also add a health check to coordinator's health section that prints
a warning when the GitHub rate limit is known to be exceeded. This
can help when observing GopherBot or GerritBot problems: we'll be
able to tell if they're likely caused by GitHub rate limit issues
or if the cause must be something else.
For golang/go#44406.
Change-Id: Id75d70129a75292a6d3f9c722636a8b740ca05a1
Reviewed-on: https://go-review.googlesource.com/c/build/+/303670
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Replace low-level Stackdriver monitoring API usage for OpenCensus
with a Stackdriver exporter. To benefit local development, expose
metrics at an /metrics endpoint (to be picked up with Prometheus).
This makes it much easier to add new metrics, to test them locally,
and brings our metrics solution in sync with what's currently in
use in x/playground (see CL 302769). It's expected to be preferable
to migrate to OpenTelemetry in the future when a good migration path
becomes available, and both x/build and x/playground can be updated
at that time.
This CL is based on work in CL 229679 and CL 138522.
For golang/go#26779.
For golang/go#44406.
For golang/go#17104.
Co-authored-by: Alexander Rakoczy <alex@golang.org>
Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com>
Change-Id: Iad45730feace471db1668e828b7c9775377be8a9
Reviewed-on: https://go-review.googlesource.com/c/build/+/303669
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
When gitmirror recovers from a recent failure, its status message
begins with "ok; " followed by additional helpful context, instead
of being just "ok".
Start classifying such messages as warnings (yellow) rather than
errors (bright red) to reduce false positives that are reported
at https://farmer.golang.org/#health.
Change-Id: I6fec7330daaec95c6d4b78849100ca54f2a3f34b
Reviewed-on: https://go-review.googlesource.com/c/build/+/302650
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The toolchain is under go/src.
Change-Id: If2567d7deea63876ab86fde4b7c3316b638e8855
Reviewed-on: https://go-review.googlesource.com/c/build/+/303310
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
Prior to CL 230637, this cloud function was targeting the Go 1.11
runtime, which implicitly¹ set the GCP_PROJECT environment variable.
That no longer happens with the newer Go runtime², so set the same
variable explicitly, otherwise publishing to the topic fails.
Remove a defer r.Body.Close() line; the http.Request body is closed
by the http.Server, http.Handler does not need to.
Also update the version of pubsub package to the latest. It isn't
needed to fix the problem, but it has already been tested during
debugging, so it's inexpensive to include.
A future enhancement is to factor out the pubsub client creation
to happen once per function instance rather than per invocation³,
and use metadata.ProjectID instead of needing an explicit env var.
¹ https://cloud.google.com/functions/docs/env-var#nodejs_8_python_37_and_go_111
² https://cloud.google.com/functions/docs/env-var#newer_runtimes
³ https://cloud.google.com/functions/docs/concepts/go-runtime#one-time_initializationFixesgolang/go#44948.
Change-Id: I03fd66c7fb784cef24c5759b45cb7c10ed17ee6a
Reviewed-on: https://go-review.googlesource.com/c/build/+/302549
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This makes the deploy into something that can be executed without
the need to seek external context on where the secrets are kept.
It's especially helpful since we deploy cloud functions less
frequently than many other services.
A future change can explore removing secrets from the environment,
preferring to have the cloud function access secrets directly from
Secret Manager.
Updates golang/go#37171.
Change-Id: I1b1468c6f02d45b764f65396027d9bdca69ac5e4
Reviewed-on: https://go-review.googlesource.com/c/build/+/300230
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This sets the GO_TEST_TIMEOUT_SCALE=2 for ppc64 builders. The
runtime tests have been timing out intermittently on ppc64le
power8; it has happened on ppc64 and ppc64le power9 but
very rarely.
Updates golang/go#44422
Change-Id: I663f3f211a368a59e38fbff9ce43c925c6c7a209
Reviewed-on: https://go-review.googlesource.com/c/build/+/300870
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
We are hitting resource limit during the API tests which is causing
consistent failures.
These VM's claim to have 20G ram allocated and run to up to 5 builders.
This will potentially overcommit them, but I suspect some amount of that
usage is shared.
Likewise, remove specific number from ppc64 builders in the
event we need change this number again.
Fixesgolang/go#44541
Change-Id: Ifad1aeb9f461d59151d569d878d94d93cb426351
Reviewed-on: https://go-review.googlesource.com/c/build/+/296669
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
This improves the selection of slowbot aliases for ppc64.
Updates golang/go#42067
Change-Id: I180fe2f49a1e44c422e64c311e601dd93b07f7a7
Reviewed-on: https://go-review.googlesource.com/c/build/+/301769
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
Some of README.md files were initially generated by update-readmes.go,
but later had some additional information appended. Re-running update-
readmes.go blasts away those changes, and requires manually reverting
the deletions. This makes it expensive to re-run update-readmes.go to
add new READMEs or update existing ones.
Solve this problem by adding support for a special "<!-- End of auto-
generated section -->" comment and making update-readmes.go preserve
any content after it.
After this change, re-running update-readmes.go produces a zero diff.
Also set the working directory when using build.Import so that packages
inside nested modules work okay.
Add the missing first word 'Package' to ./internal/datastore/fake doc.
Change-Id: If7ba92a297eebeec8029d48d760acb1daa7f263e
Reviewed-on: https://go-review.googlesource.com/c/build/+/300229
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Use gob encoding for the datastore fake, avoiding issues with using
shared memory. Also, add a lock around access to in-memory store.
Moves datastore fake package to internal, as it is not cmd/relui
specific and will be useful elsewhere.
For golang/go#40279
Change-Id: I5ed3211a0899133d7d534cae8d4643ab8d40f75e
Reviewed-on: https://go-review.googlesource.com/c/build/+/291193
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Change-Id: I28df5ed9a2a013b87a6d5c03ee12869d95ea9d07
Reviewed-on: https://go-review.googlesource.com/c/build/+/295191
Run-TryBot: Dan Peterson <danp@danp.net>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Jeremy Faller <jeremy@golang.org>
pprof: cherryyz will be the primary owner
trace: mknyszek&prattmic will be the primary owner
The functionality depends on the runtime internal greatly
so it makes more sense that runtime team owns them.
This CL adds go/src/internal/{trace, profile} packages to
the list.
Currently rsc is the primary owner of
"go/src/net/http/pprof". I propose to add cherryyz to the
primary owner because this is the user-facing package
of pprof.
Change-Id: Ib5bcbfddf3b290943569c63e75e3ba57c40e3098
Reviewed-on: https://go-review.googlesource.com/c/build/+/297510
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
When github.Client.Do returns a non-nil error, the *github.Response
may be nil if a request wasn't even made. Check for that to avoid a
panic.
Fixesgolang/go#44438.
Change-Id: I199048213160eb08892ca0c830af09959c5a4ffc
Reviewed-on: https://go-review.googlesource.com/c/build/+/294412
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Make all our package sources use Go 1.17 gofmt format
(adding //go:build lines).
Not strictly necessary but will avoid spurious changes
as files are edited.
Part of //go:build change (#41184).
See https://golang.org/design/draft-gobuild
Change-Id: I8020e066756b0cfa99ed1cb804b17e127e4151b9
Reviewed-on: https://go-review.googlesource.com/c/build/+/294417
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
We can drop the 32-bit and 10.11 macOS builders, they're unused.
Remove FreeBSD 11.1 builder, it's unused.
Update freebsd-amd64-race to use the latest available FreeBSD builder.
Simplify build policy and comments, removing anything that mentioned
Go version 1.14 or older, since they're not relevant anymore.
Drop Go 1.14 support from minSupportedMacOSVersion, and add support
for the future Go 1.17 release, which will increase minimum macOS
version requirement to macOS 10.13.
Fixesgolang/go#40562.
Change-Id: I7beeec0952a516afe99a5154b22c7f25ceeb3da1
Reviewed-on: https://go-review.googlesource.com/c/build/+/293771
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The release process now documents the step of creating the first minor
release milestone when issuing a major Go release. That happens before
the 'releasebot -mode=prepare' step.
Add an automated check for this so that we don't need to manually
verify whether it was done or not.
(Future release process improvements may include automatically making
the milestone. That is better suited to be in scope of golang/go#40279.)
Fixesgolang/go#44404.
Change-Id: I0ee5ff270ceb66d4dea219aad3c49f77b9d21e2f
Reviewed-on: https://go-review.googlesource.com/c/build/+/294249
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The Go 1.17 tree has started adding the windows/arm64 port.
Change-Id: Id9557160704688feea3667d5b18b0a37371aa0cd
Reviewed-on: https://go-review.googlesource.com/c/build/+/293772
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
CloseNotify has been deprecated in favor of Request.Context.
Start using the newer API to avoid the panic when CloseNotify
gets called too late.
Fixesgolang/go#44244.
Change-Id: I1f01c2d42cf6735d1161b977b62a7d982e8a61ea
Reviewed-on: https://go-review.googlesource.com/c/build/+/291769
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change adds macOS 11.0 Big Sur builder to the dashboard. It will
not spawn an instance on the older MacStadium cluster which we are
migrating away from. It will be marked with a known issue until until
we have migrated away from the old cluster and makemac has been
updated to process the new macOS versioning convention.
Updates golang/go#40762
Updates golang/go#40757
Updates golang/go#40761
Change-Id: I24ce615a2c0c55dd75beed4f821119d4058ad8af
Reviewed-on: https://go-review.googlesource.com/c/build/+/288192
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change replaces the file storage layer with Google Cloud Datastore.
It adds a fake implementation of the datastore client, supporting only
the features we use so far.
Slightly simplifies Workflow configuration.
Updates golang/go#40279
Change-Id: I55228f6540fbcdf5f803203ff7309232cebf6a20
Reviewed-on: https://go-review.googlesource.com/c/build/+/275237
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The tip server is primarily about serving tip.golang.org, and it does
today. There was also a time it was used to serve talks.golang.org
with an auto-deploy feature, but that ability has degraded over time
and is currently unused.
After some investigation of our options, we made a decision in issue
golang.org/issue/36825 to remove this broken and unused functionality
in favor of x/talks' own simpler App Engine deployment. If needed,
this can all be brought back and restored as part of future work,
but it's better to delete code and a misleading README until then.
Fixesgolang/go#36825.
Updates golang/go#38120.
Change-Id: I5fbca48dea13e871cd04e23b36c8d3acd2f8fef5
Reviewed-on: https://go-review.googlesource.com/c/build/+/290529
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
UsePkgGoDev was added in CL 234677 to aid with a gradual migration
on golang.org. That redirection has been completed as of CL 275195,
and UsePkgGoDev is no longer meaningful nor used. Remove it, since
it's allowed per x/build's compatibilty policy, to keep things tidy.
Updates golang/go#36106.
Updates golang/go#39150.
Change-Id: If3f9bed7f215a7c572a2d7a9f25b3184a1e5362a
Reviewed-on: https://go-review.googlesource.com/c/build/+/289700
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The github.com/golang/gddo repository was archived on GitHub as part
of redirecting godoc.org requests to pkg.go.dev¹, to make it more
visible that it doesn't accept new contributions. Mirroring to an
archived repository on GitHub fails with an error, so don't try to.
¹ https://blog.golang.org/godoc.org-redirect
Change-Id: I648bccf8edc6f034eaa2ea3b2ced6c505473c22c
Reviewed-on: https://go-review.googlesource.com/c/build/+/289699
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Carlos Amedee
Yuval Pavel Zholkover
Roland Shoemaker
Filippo Valsorda
Filippo Valsorda
Rebecca Stambler
David du Colombier
Dmitri Shuralyov
Tim King
David Chase
Damien Neil
Cherry Zhang
Lynn Boger
Sean Liao
Paul E. Murphy
Alexander Rakoczy
Dan Peterson
Hana
Russ Cox