The x/blog and x/tour repositories have been merged into x/website.
Stop displaying x/blog on the build dashboard, especially because
there are 0 Go packages in it, which the build dashboard shows in
red. (Keep TryBots enabled in case a CL is sent with new Go code.)
Remove their descriptions since neither is worth including in the
list at https://golang.org/pkg/#subrepo. Show x/website instead.
Change-Id: Idc2bcec17b6bed9929c3a37f2c45ae524559d37f
Reviewed-on: https://go-review.googlesource.com/c/build/+/324609
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Add the windows-arm64 builder to the dashboard and coordinator with a
known issue until we can verify builds are succeeding regularly.
Also, tweak the logic around validating ec2 configurations. The arm64
buildlet sets VMImage but not ContainerImage, unlike other ec2
buildlets. This should work for both.
For golang/go#42604
Change-Id: I7176b8f6bba837830a0565e7713c9e9a0eb76e90
Reviewed-on: https://go-review.googlesource.com/c/build/+/322656
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
a1.metal instances have 32Gb of ram, and 16 cores. We should try to use
as much as possible.
We run into CLOCK_WATCHDOG_TIMEOUT when using more than 4 of the 16
cores. The VM can also fail to boot. We have a thread discussing how to
resolve this.
A new AMI will need to be created and configured after any changes to
this script.
For golang/go#42604
Change-Id: If49b89718fca6dc5cee30e609a8ded9f99bf1f05
Reviewed-on: https://go-review.googlesource.com/c/build/+/322655
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change allows the ledger to track how many a1.metal instances
have either been created or are in the process of being created. A
hard limit of 1 has been set for a1.metal limits while testing is
being performed.
For golang/go#42604
Change-Id: I5bcb3a65407af07d225caf2884877ce040ee011b
Reviewed-on: https://go-review.googlesource.com/c/build/+/322855
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The a1.metal instances take about four minutes to become available
before beginning to boot the Windows ARM64 VM. This means we need
somewhere between five and ten minutes before we can first connect to
the buildlet.
It's possible that other instances are faster to boot, but this is
currently the most economical choice.
For golang/go#42604
Change-Id: Ib76944307c9ad28fd1adca0dc54f3fbeaabfffa0
Reviewed-on: https://go-review.googlesource.com/c/build/+/322654
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The Windows ARM builders on EC2 run on qemu via KVM. We use a userspace
network device for simplicity, which also conveniently restricts which
ports are exposed. In order to make a request to the metatadata service,
which is routed in a different way than the public internet, we
explicitly forward the port to the guest VM on a special ip/port.
This introduces a hard-coded value for Windows ARM64 buildlets. We
should be able to improve this code to detect it, but this will get the
buildlet unblocked.
The buildlet image also includes llvm-arm64 mingw rather than a gcc
based distribution. This change also adds the correct directory to the
path.
For golang/go#42604
Change-Id: Ife2ebb900a08034d6e0dfa0982a24b312ee6d70a
Reviewed-on: https://go-review.googlesource.com/c/build/+/322653
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change translates the entries tables' keys before serving the
owners index page such that the names that appear in the UI align better
with the names we use in the issue tracker.
Specifically, the translation removes the go/src prefix from any
standard library package and adds an x/ prefix to any package that
resides in a repository with a golang.org/x/ import path.
Change-Id: I3e0dd7de081818a667ba4416a75cd1a81e17b3dd
Reviewed-on: https://go-review.googlesource.com/c/build/+/322710
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change changes the sorting of the owners key for easier editing,
indicating which paths refer to x/ repos and which refer to the standard
library. It then groups together other categories, like other
repositories and domains.
This change should make it a little clearer what should change when
editing the owners table.
Change-Id: I64bd04abaea67ece5bf8fce0332911e96d93acad
Reviewed-on: https://go-review.googlesource.com/c/build/+/322709
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds {index,sum,proxy}.golang.org to the list of Go
resources the Go team owns since we occasionally see issues related to
these domains appear on the issue tracker.
This change adds heschi, hyangah, and katie as primary owners and
findleyr as a secondary owner.
Change-Id: I375e6b9ec6d627a7b9c2a1687d6d1ab7097194d0
Reviewed-on: https://go-review.googlesource.com/c/build/+/322552
Trust: Michael Knyszek <mknyszek@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Katie Hockman <katie@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
This change adds neild as the owner if net/http-adjacent packages as
well as context.
This change also removes bradfitz as an owner of these packages.
Change-Id: I1d35c3f540d42d7df6da778e1a192ebeb638bba8
Reviewed-on: https://go-review.googlesource.com/c/build/+/322550
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
The x/website repository is getting bigger as x/blog is being
merged into it. The 50 MB size limit has lasted many years.
Hopefully doubling it will too.
Make the error message more detailed so it's easier to tell
that the limit is in x/build code rather than elsewhere.
Fixesgolang/go#46379.
Change-Id: I4c89fb0ae3d706a13537e2f6c898aed2efd959b7
Reviewed-on: https://go-review.googlesource.com/c/build/+/322658
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
This change introduces a Windows ARM64 builder image for Go, running on
Ubuntu on an a1.metal instance on AWS.
The AMI image successfully boots, and automatically starts a Windows
ARM64 VM, exposing port 443. The buildlet still needs to be updated for
the appropriate mingw path. Additionally, the qemu script does not
yet automatically halt the instance on termination, which makes
debugging easier.
- Ubuntu was chosen over Debian, as the official Debian AMI would not
boot on a1.metal instances.
- a1.metal is the most affordable AWS instance to support KVM on ARM64.
- A prepared qemu image exists in the Go AWS account, under
s3://go-builder-data.
- Only 4 processors are currently supported in order to avoid a
CLOCK_WATCHDOG_TIMEOUT. We're working on investigating how to increase
this.
- The EC2 metadata service is proxied to the guest OS via qemu.
For golang/go#42604
Change-Id: I2a505a8218c2a818f0e52d179c02e6d264d2e422
Reviewed-on: https://go-review.googlesource.com/c/build/+/321959
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
We continue to use 10.15 for 1.16 and 1.15.
Fixesgolang/go#46161.
Change-Id: I84b597c6cf99f1d212ff1bba271bec8ef1c0557c
Reviewed-on: https://go-review.googlesource.com/c/build/+/321011
Trust: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Previously, we were using the branch of golang.org/x repo as the
GoBranch, which is inaccurate. It made little difference because
few builder policies filter by GoBranch at this time.
Fixesgolang/go#38303.
Change-Id: Iaeff8ca7ceeb81eb57073d3bc5533db3c9e30504
Reviewed-on: https://go-review.googlesource.com/c/build/+/319791
Reviewed-by: Carlos Amedee <carlos@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
This change reverts the coordinator side to be much simpler, as it was
before CL 167382, and consolidates all the version selection in maintapi.
This direction is chosen because at this time¹ maintapi is best suited
to perform version selection.
This is a refactor CL that leaves current behavior unmodified, and test
cases provide improved coverage. The following smaller CL will make the
desired changes to behavior.
Remove TestNewTrySetBuildRepoGo110 because it's no longer needed. It was
added when x/build started requiring module mode to build successfully,
given that Go 1.10 didn't have module mode support.
Background
At this time¹ coordinator makes use of maintapi to find TryBot work,
and it is a collaborate effort between the two components that results
in determining what builds will happen. Coordinator is ultimately
responsible for starting and running the builds, but it doesn't have
information about the branches in the Go project (the Go revision at
refs/heads/master, refs/heads/release-branch.go1.16, etc.). Maintapi
has that information via the maintner corpus. So it makes the version
information available to coordinator by populating relevant fields in
apipb.GoFindTryWorkResponse.
Issue golang/go#28891 was about wanting to test golang.org/x repo CLs
on release-branch.go1.n with the corresponding Go 1.n version, rather
than Go tip. Unfortunately, it was implemented on the coordinator side,
resulting in the logic for version selection to be more spread between
the coordinator and maintapi components. There were followup issues
like golang/go#42127 and golang/go#37512, whose fixes built on top of
the coordinator side, and increased complexity there. As a consequence,
making and testing further changes became more difficult than it needs
to be.
¹ After golang/go#34744 is done, I'd like to move all the TryBot version
selection logic into coordinator, the component responsible for TryBots.
But not today.
For golang/go#46154.
Change-Id: I93986acefd4bf66b27ccf0323439966122b7989a
Reviewed-on: https://go-review.googlesource.com/c/build/+/319789
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
We already log about storing unknown JSON (on the server) and can look
up occurrences there. Most clients don't care, so only log if they are
in verbose mode.
Fixesgolang/go#46180.
Change-Id: I665511e3d69827108bf59ddcd5e44359cacbaaa2
Reviewed-on: https://go-review.googlesource.com/c/build/+/320290
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
"lock_reason" is a field that was added to GitHub API v3 after maintner
was created. It's present in GitHub issue "locked" events and indicates
the reason the issue was locked, such as "off-topic", "too heated",
"resolved", etc.
Since maintner didn't have explicit handling for it, it got the default
treatment of being saved in OtherJSON just in case.
It's a non-goal for maintner to track all available data, only what is
deemed to be worth including. This field hasn't been used all this time
and seems fine to exclude until something changes.
Also fix a bug where OtherJSON wasn't even set in GitHubIssueEvent,
and improve various internal comments and log messages.
For golang/go#46180.
Change-Id: I9ebb3bf4183f78e413dfb032c94cb736a8b07e02
Reviewed-on: https://go-review.googlesource.com/c/build/+/320289
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
For golang/go#45998
Change-Id: I411e0ae3bdc9d0537ccc9115f7169e39dd279157
Reviewed-on: https://go-review.googlesource.com/c/build/+/319352
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
There are only 3 possible configurations for a builder: a TryBot
and a post-submit builder, a post-submit only builder, or neither.
Make all test cases in TestBuilderConfig more precise by selecting
one of those available combinations to reduce the chance of future
refactors making an unintentional configuration change.
Change-Id: I6deafa19f2a48a7b5bc576ecd20d16463f46fa93
Reviewed-on: https://go-review.googlesource.com/c/build/+/317976
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change splits the release log into parts that are equal to or
smaller than the maximum GitHub comment character limit. It attempts
to break the parts up by the last new line found per part.
Fixesgolang/go#45998
Change-Id: Ica35ceff961e7c02a1e37fc1f928705c32007853
Reviewed-on: https://go-review.googlesource.com/c/build/+/318070
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
For golang/go#38968.
Change-Id: Ib99c3facbd87776d89279e05d33805ba78a8f72b
Reviewed-on: https://go-review.googlesource.com/c/build/+/318190
Trust: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
In Go 1.16 we added darwin/arm64 (macOS) port, along with race
detector support. At that time we didn't have a builder, so the
syso file was built manually. Now that we have a builder, this CL
adds darwin/arm64 support to racebuild, so the syso file can be
built with it.
Verified that it successfully builds the syso and it passes the
tests.
Change-Id: I0bac1345a0b5f1df74dcb47cec13b6856a647094
Reviewed-on: https://go-review.googlesource.com/c/build/+/318110
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Change-Id: I9377abf5c77063d6abdca6ca4767e57353e78c0d
Reviewed-on: https://go-review.googlesource.com/c/build/+/318109
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Also, respond to the most recent thread even if there are multiple ones
for the same commit.
This was way harder than it should be.
Change-Id: Id6868b267c019cd70e504310ecf9c79dac29a17b
Reviewed-on: https://go-review.googlesource.com/c/build/+/317971
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Filippo Valsorda <filippo@golang.org>
Trust: Katie Hockman <katie@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
This change removes the explicit setting of files uploaded during the
release process. The bucket where the files are being uploaded to now
use uniform bucket-level access which defines an ACL for all objects
in the bucket. Any attempt to set an ACL will end with a failure.
Fixesgolang/go#46028
Change-Id: If2b291a4b5ee94b75cf73113f3afe8b65a002cf5
Reviewed-on: https://go-review.googlesource.com/c/build/+/317809
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
My current workload does not allow me to work on it.
Change-Id: I0cd003dd968136d0365c881b0fee66868e31cfec
Reviewed-on: https://go-review.googlesource.com/c/build/+/317629
Trust: Roberto Clapis <roberto@golang.org>
Run-TryBot: Roberto Clapis <roberto@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
Build log truncation is currently silent and can easily go unnoticed
unless you notice missing expected output (such as a filename line
following a function name in a stack trace).
Adjust livelog to explicitly annotate truncation at the end of a log so
that it is very clear to readers.
Fixesgolang/go#45972
Change-Id: I5ad555232ba670bfb37d2eb3d2260307468c28a9
Reviewed-on: https://go-review.googlesource.com/c/build/+/317209
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
There are two tasks we regularly do when reopening the tree for the
next major Go version development: remove "wait-release" hashtags
from CLs, and ping issues with "early-in-cycle" label.
The former was automated in CL 129817. The latter is automated here.
Maintner is used to find issues, and a GitHub API client is used to
post comments.
The Go 1.17 cycle was used as an opportunity to test this approach.
It worked as expected; no unexpected problems were found.
Like the unwait-release task, this is run manually via -only-run flag.
In the future we may want to factor both of these tasks out of
gopherbot and into a place that can be used by release automation.
But this seems like the most sensible place to add it initially.
Add a brief sleep in the hot loop for tasks that are invoked
manually. This is to appease humans and can modified at will.
It's unlikely to remain needed when these tasks are automated further.
For golang/go#40279.
Change-Id: I70c4eb7e98551d610f1518d1599661db21e2f271
Reviewed-on: https://go-review.googlesource.com/c/build/+/300570
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
It's helpful to check that required credentials exist before starting
the upload operation. That way, if the gomote token is missing, the
user will be told right away, rather than the operation failing midway.
For golang/go#45893.
Change-Id: I70aec0a9021a714032f2d0a9a8e51465cefd262e
Reviewed-on: https://go-review.googlesource.com/c/build/+/315929
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
I changed my GitHub username to 'heschi' a while back. Also add myself
as an owner of x/build/.
Change-Id: I1b4e53ff8d55311602d987dd887638a82712ba12
Reviewed-on: https://go-review.googlesource.com/c/build/+/316589
Trust: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Change-Id: I42c24f2d6f3020791ce1c3ec15799e202ce583a0
Reviewed-on: https://go-review.googlesource.com/c/build/+/308629
Trust: Tim King <taking@google.com>
Run-TryBot: Tim King <taking@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
This change uses the latest patch release of the oldest major release
of FreeBSD for packaging Go 1.17 and beyond.
Updates golang/go#40561Fixesgolang/go#45727
Change-Id: I1adc77560affa0db0e001388884431248e3a20ec
Reviewed-on: https://go-review.googlesource.com/c/build/+/315889
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This sets the GO_TEST_TIMEOUT_SCALE=2 for dragonfly builders in order
to try to solve intermittent test failures.
For golang/go#45215.
For golang/go#34034.
Fixesgolang/go#45216.
Change-Id: I81dae533c137ff1903bf6b1a52cf9752e8921b7c
GitHub-Last-Rev: 9b4fb8017b
GitHub-Pull-Request: golang/build#35
Reviewed-on: https://go-review.googlesource.com/c/build/+/315329
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
The macOS cluster hosted at MacStadium has been migrated to a new set
of machines. With that migration, several configuration options
changed along with the migration. This change updates the
documentation to reflect the changes which have been made.
For golang/go#45088
Change-Id: I076f482865f3a1ce57addd8495ab18588c2d87e2
Reviewed-on: https://go-review.googlesource.com/c/build/+/313710
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The windows/arm64 port has been completed in golang.org/issue/36439
recently. Add pre-submit compile-only coverage via a misc-compile
TryBot for the new port. It can be upgraded to a normal TryBot that
also executes tests after a windows/arm64 builder becomes available.
Tested locally by running 'buildall.bash windows-arm64' on a recent
Go tip commit (CL 313849), which passed.
For golang/go#36439.
Updates golang/go#42604.
Change-Id: Ie4988a876aa18392a583eb407c6c3621eb30a4f8
Reviewed-on: https://go-review.googlesource.com/c/build/+/314430
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Change-Id: I77cb092d5facff6b0dd27cf9b6ff55a60a2e0f84
Reviewed-on: https://go-review.googlesource.com/c/build/+/313729
Trust: Tim King <taking@google.com>
Run-TryBot: Tim King <taking@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Between Go 1.15, 1.16 and tip, the following 29 ports don't have
a real TryBot and instead rely on misc-compile TryBots for their
pre-submit coverage:
• aix/ppc64
• darwin/amd64
• darwin/arm64
• dragonfly/amd64
• freebsd/386
• freebsd/arm
• freebsd/arm64
• illumos/amd64
• linux/mips
• linux/mips64
• linux/mipsle
• linux/mips64le
• linux/ppc64
• linux/ppc64le
• linux/riscv64
• linux/s390x
• netbsd/386
• netbsd/amd64
• netbsd/arm
• netbsd/arm64
• openbsd/386
• openbsd/arm
• openbsd/arm64
• openbsd/mips64
• plan9/386
• plan9/amd64
• plan9/arm
• solaris/amd64
• windows/arm
The previous approach for misc-compile target selection was to break
them up primarily by GOOS value. However, as new architectures were
added over time, some misc-compile TryBots got to a point where they
were testing upwards of 5 ports (for example, misc-compile-openbsd
was testing 386, amd64, arm, arm64, and mips64 architectures).
Since each port is tested sequentially, allocating too many to one
misc-compile TryBot can cause it to become the bottleneck of an
entire TryBot run, exceeding the 10 minute completion time goal.
Arrange it so misc-compile TryBot target selection is done explicitly
in x/build, and pick 3 as max number of targets per TryBot for now.
Based on recent timing observations, that should strike a decent balance
between resource use (spinning up a builder) vs chance of a misc-compile
TryBot becoming a bottleneck. It will also give us an opportunity to
compare timing of 1, 2 and 3 targets per misc-compile in the future.
(When we start tracking timing for TryBot completion time holistically,
we'll be in a better position to refine this strategy further.)
Making misc-compile target selection explicit in x/build also enables
removing unnecessary duplicate misc-compile coverage from ports that
already have a real TryBot (for example, openbsd/amd64 was previously
tested via both the openbsd-amd64-68 TryBot and misc-compile-openbsd).
This shouldn't be needed, so it's no longer done.
For golang/go#17104.
Fixesgolang/go#32632.
Change-Id: Iac918377b91af3e48780b38ffdf3153e213eeba2
Reviewed-on: https://go-review.googlesource.com/c/build/+/313210
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Some TryBot builders are disabled or configured with a custom
try policy that doesn't test the master branch of the main Go
repository. For example, openbsd-386-68 is configured with:
tryBot: explicitTrySet("sys"),
So it's only a TryBot for the x/sys repo, not the main one.
Modify TestTryBotsCompileAllPorts to not consider such TryBots
when determining whether a port has sufficient pre-submit test
coverage.
This will help in the next change which re-arranges target
selection between misc-compile TryBots.
For golang/go#32632.
Change-Id: If393610d11b04b75133a4f10f89cfdfff9dbaece
Reviewed-on: https://go-review.googlesource.com/c/build/+/313533
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Issue 39782 is closed because we have darwin-arm64 builders by now.
A misc-compile TryBot currently provides pre-submit test coverage
for the darwin-arm64 port. So remove "darwin-arm64" known missing
entry since it's obsolete.
Also improve the test to report a problem when a port is marked as
having a known missing TryBot, yet it's not actually missing. This
should help humans not forget to keep the knownMissing map updated.
Change-Id: Ic5c981a81c2e6016a56c6d872db458c98f215a0e
Reviewed-on: https://go-review.googlesource.com/c/build/+/313209
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
With this change:
- The default FreeBSD builders used on master are 11.4 and 12.2.
- The FreeBSD 12.0 builders have been removed.
- The FreeBSD 11.2 builders have been set to run on at most Go 1.16.
They will continue to be used for Go 1.16.x and 1.15.x minor releases.
- The freebsd-amd64-race builder has been updated to use the FreeBSD
12.2 host.
- The slowbot aliases for FreeBSD have been updated to use 12.2.
Fixesgolang/go#44431
Update golang/go#45727
Update golang/go#40561
Change-Id: Ib558fca65c2de1916b4633711d3e320c390bd2b2
Reviewed-on: https://go-review.googlesource.com/c/build/+/313070
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Now that GOEXPERIMENT includes regabi by default, there is a need to
make sure that the non-regabi paths for the compiler and runtime
continue to function correctly (in case for some reason we need to
turn regabi off). Switch the *-regabi builders to "noregabi" builders,
so that we have test coverage for this scenario.
Updates golang/go#40724.
Change-Id: Id5c0d4fda2f56393992c90ace463674e86b941ee
Reviewed-on: https://go-review.googlesource.com/c/build/+/313071
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
macOS will not be supported after go1.16. This change limits the macOS
10.12 builders to build previous to go1.17.
Updates golang/go#44303
For golang/go#23011
Change-Id: Ib6b4e7939ffb9032b255574d3f0b4fffaad97803
Reviewed-on: https://go-review.googlesource.com/c/build/+/312692
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds builders for amd64 FreeBSD 11.4 and 12.2. These
builders are labeled with a known issue until they have been tested.
They will not be used in trybots until the known issue label has been removed.
Updates golang/go#44431
Change-Id: I902f2f6bd887135bf247feb1be0e0fd49f732614
Reviewed-on: https://go-review.googlesource.com/c/build/+/311869
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Update the expect script to work with with the SeaBIOS built-in VGA
serial console emulation instead of sgabios.
Tested on Ubuntu 20.4.
Updates golang/go#44431
Change-Id: I4f7f1972092416f1d6d54ec7e16d100aeeeaf25f
Reviewed-on: https://go-review.googlesource.com/c/build/+/279392
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Dmitri Shuralyov
Alexander Rakoczy
Carlos Amedee
Michael Anthony Knyszek
Heschi Kreinick
Cody Oss
Daniel Martí
Filippo Valsorda
Cherry Mui
Roberto Clapis
Michael Pratt
Tim King
Antonio Huete Jimenez
Than McIntosh
Meng Zhuo
Yuval Pavel Zholkover
Roland Shoemaker