GOPPC64=power10 is only supported by go1.20 and newer. Don't use
this builder with older releases.
Change-Id: I5dc012165fce32f13aa8316b54f0fbe9ef337b61
Reviewed-on: https://go-review.googlesource.com/c/build/+/456695
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Paul Murphy <murp@ibm.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
QEMU needs to run as root on darwin for working networking. Currently we
run runqemubuildlet as a normal user, and invoke QEMU with `sudo`.
Unfortunately, this means that runqemubuildlet doesn't have permission
to signal QEMU when the health check fails.
Instead, run runqemubuildlet as root so it has permission to signal
QEMU.
For golang/go#48945.
Change-Id: I07bd61168462c7272db05c328eb11dcd39743f79
Reviewed-on: https://go-review.googlesource.com/c/build/+/456042
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
This builder requires a patched bootstrap toolchain to
accept GOPPC64=power10.
Likewise, this folds in a change to update the
container images to ubuntu 20.04. This is and has been
running on the existing ppc64le builders for a couple
months already.
Change-Id: Ia86cb711c99c0d8ab5f9de0ae50129fe11e6ccab
Reviewed-on: https://go-review.googlesource.com/c/build/+/454515
Run-TryBot: Paul Murphy <murp@ibm.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
From the dashboard, it seems the linux-arm64-longtest builder has
been working reasonably well for a while. At this point we don't
have known issues for it. So remove known issues.
Enable it for trybot on 1.20+ release branches, per golang/go#37827.
Only for 1.20+ because it is failing on older versions of Go.
Fixesgolang/go#49649.
Updates golang/go#53851, golang/go#37827.
Change-Id: I682aa4028b791ecd80360fbe05ef615dad19405d
Reviewed-on: https://go-review.googlesource.com/c/build/+/456043
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The tests which require gpg and gpg-agent have been removed. This
change removes them from the container images.
For golang/go#57034
Change-Id: Id33dbc9881bb9a688955612a66f1f549822f3866
Reviewed-on: https://go-review.googlesource.com/c/build/+/455860
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Previously, this environment variable was used to scale test timeout
only in the main repository. Use it when running go test on packages
in other repositories too.
This unfortunately means that if some tests get so slow that they
timeout with the default go test timeout value, builders that use
timeout scale will not report such findings. Hopefully most builders
are as fast as viable, and timeout scaling is only used when there's
no other viable alternative.
Fixesgolang/go#56968.
Change-Id: I84d5ab504c1bd808815ec5962f713d71dfec6758
Reviewed-on: https://go-review.googlesource.com/c/build/+/453975
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
These values come from cmd/dist doing it by default based on GOARCH.
We want to factor out that logic from cmd/dist, so apply it explicitly
in x/build to appropriate builders. CL 455518 removes it from cmd/dist.
The appropriate builders were found by iterating over all builders in
this package and filtering on their GOARCH value.
For golang/go#56968.
For golang/go#57117.
Change-Id: I1bccb7144d9ae13ca17e5f12169924d0fb89e341
Reviewed-on: https://go-review.googlesource.com/c/build/+/455521
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
These two builders have GO_TEST_TIMEOUT_SCALE values set in their local
environment. Since those variables affect the builder, and will soon be
needed for golang.org/x test timeout scale, set them explicitly in the
dashboard package. That makes more of the builder configuration visible
and removes the need to maintain local configuration on those builders.
For golang/go#56968.
Change-Id: I206cbddab91c3628f43716e8b05fd52d94fba7f2
Reviewed-on: https://go-review.googlesource.com/c/build/+/455520
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
This is used to replace env/darwin/aws/start-snapshot.sh on CI
instances.
Run like so:
Buildlet 1:
$ ./runqemubuildlet -guest-os=darwin -macos-version=12 -osk=<OSK VAL> -guest-index=1 -buildlet-healthz-url="http://192.168.64.101:8080/healthz"
Buildlet 2:
$ ./runqemubuildlet -guest-os=darwin -macos-version=12 -osk=<OSK VAL> -guest-index=2 -buildlet-healthz-url="http://192.168.64.102:8080/healthz"
For golang/go#48945.
Change-Id: Ic0010bcd0062c7b77d09bf2addb1297e7d116474
Reviewed-on: https://go-review.googlesource.com/c/build/+/449877
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
Subsequent CLs will add support for running darwin guests. To support
differences between the guests, move windows support to a new file and
selected by -guest-os=windows.
This CL has no functional change. Windows remains the default for
compatibility with existing scripts.
For golang/go#48945.
Change-Id: Iec2827b216f7c6b72c53a61b125d132beb44a779
Reviewed-on: https://go-review.googlesource.com/c/build/+/449876
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Currently, DHCP assigns a dynamic IP to each guest. This means that the
parent program doesn't know the IP of the guest in order to do
health checks.
Add a static IP assignment based on the guest MAC address.
For golang/go#48945.
Change-Id: Icafa4aa5a0b87ab815c882bc8215d5932d1377c0
Reviewed-on: https://go-review.googlesource.com/c/build/+/449875
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
We've been using an okay-after-beta1 label to mark release-blockers
that are safe to resolve after the first beta release, and the task
package has some logic to interpret and manage this label for us.
Add analogous support for the new okay-after-rc1 label,
so that we don't need to do this work manually.
Change-Id: I5e049e316020c7b6bdbcfb841814e9628864540c
Reviewed-on: https://go-review.googlesource.com/c/build/+/453982
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The original intention for the okay-after-beta1 label
was to apply up to and including the release of beta 1.
It did not have any effect on beta 2, beta 3, etc., in releasebot.
This is because we can't see that far into the future when making
decisions of whether to apply that label to some release-blockers.
It exists to let us prioritize what's needed to unblock the first
pre-release of the upcoming major Go release.
This change makes it so again.
Change-Id: I3304cba329b1044dffb7c8c17ad9c92d690cbb55
Reviewed-on: https://go-review.googlesource.com/c/build/+/453981
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
TestMilestones is a destructive test that operates on a real GitHub
repo. This was useful during the initial development of MilestoneTasks,
but now it's preferable to have a small and quick-to-run test to go
alongside small behavior adjustments we might want to make.
It was tempting to add a test-only hook like:
func (m *MilestoneTasks) loadMilestoneIssues(...) {
+ if m.testHookLoadMilestoneIssues != nil {
+ // easily return milestone issues for a test case
+ }
// real implementation
But we already have GitHubClientInterface that's meant to help.
It's possible to mock its Query method, but doing that is very
verbose and fragile. Instead, factor in the loadMilestoneIssues
method to be a part of GitHubClientInterface since it fits well.
While here, also s/load/fetch/ in its name for consistency.
As a result, we now have TestCheckBlockers. The next CL in the stack
changes how beta 2/3/etc. are handled to match our previous behavior.
The one after that adds handling for the new okay-after-rc1 label.
Change-Id: I8fb8df6eedd668c08ea954b3e29176a654801a36
Reviewed-on: https://go-review.googlesource.com/c/build/+/453980
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
I used this as the release coordinator username for a workflow and now
it's stuck. My mistake, but I don't see any harm in registering it.
Change-Id: I37218b2ee855a8e5e8ee928c9546f05bf077f6e5
Reviewed-on: https://go-review.googlesource.com/c/build/+/455255
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
CL 454935 broke the Kubernetes ingress by requiring IAP on health
checks. Move /healthz handling into internal/https, where it
automatically bypasses authentication and removes some duplicate trivial
implementations.
Unfortunately, GKE is not capable of inferring health check parameters
from a multi-container pod like relui, so we have to change our
BackendConfig. That sets off a yak shave -- I made the questionable
decision to use the same backend for all our IAP services, and the
coordinator doesn't currently support /healthz. Split all them up and
delete the devapp configuration I was using for testing way back in the
day.
Change-Id: I45e866d30508a07e9a805de70af731dd64c22d7f
Reviewed-on: https://go-review.googlesource.com/c/build/+/455215
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
We should be requiring access through IAP on HTTP, not just GRPC.
Change-Id: I6d3e3de1c25e401e0727599b758911c9eed7a172
Reviewed-on: https://go-review.googlesource.com/c/build/+/454935
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The netbsd-386 and netbsd-amd64 builders with 9.3 contain various
bugfixes, including to libpthread, that prevent test flakes. Remove the
older version now.
While here, remove issue golang/go#50138 (fixed) from the netbsd-arm*
builders.
Fixesgolang/go#54773.
Change-Id: Ibccf0817a69a3dd74651bd5a3f50ab77c3a92beb
Reviewed-on: https://go-review.googlesource.com/c/build/+/454755
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Select the *-oldcc variants for windows 386/amd64 builders for when
building 1.18/1.19 minor releases. This syncs up relui with similar
changes in the dashboard (e.g. CL 453095).
For golang/go#35006.
Change-Id: I1df3fef9459ca23593571448129eb1d1497c4529
Reviewed-on: https://go-review.googlesource.com/c/build/+/454098
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
As of go.dev/issue/56031, the need to have passing TryBots and no
unresolved comment threads is enforced by a submit requirement in
Gerrit. The code in the auto-submit task is no longer load-bearing,
so remove it to simplify and to avoid creating a false impression of
it doing something important (beyond little differences, like handling
the TryBot-Bypass label as implemented by the Gerrit submit rule, etc.).
Running the "auto-submit CLs" task in dry-run mode did not report
that it would submit any CLs.
For golang/go#48021.
Updates golang/go#56031.
Change-Id: I09c6900199d26bd8e90fe7f7f681fd6227a762e8
Reviewed-on: https://go-review.googlesource.com/c/build/+/452135
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
For golang/go#46229
Change-Id: I817d6af1735fb5ca659d4537d401e93ce8e08df0
Reviewed-on: https://go-review.googlesource.com/c/build/+/453457
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: xiaodong liu <teaofmoli@gmail.com>
This adds the ability to set the size of the root drive for a GCE
host machine. The linux-arm64-longtest boot disk has been increased
from 10GB to 20GB.
Updates golang/go#49649
Change-Id: I74ebf4bd533c91c8716b7df167afacbfdded3ed3
Reviewed-on: https://go-review.googlesource.com/c/build/+/453955
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
The AWS builders have been up and running reliably for a while now.
Switch over.
Unfortunately the macOS 13 builder had -aws in its name, so we're
creating a new builder and will need a backfill. So it goes.
While I'm here, build 1.20 with 13 now that we have it.
For golang/go#48945, golang/go#40561.
Change-Id: Idaac9cfea6fe3f5e190432ecb512a453812618c7
Reviewed-on: https://go-review.googlesource.com/c/build/+/453956
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Apply standard formatting to all of x/build using gofmt from Go 1.19.3.
Change-Id: I066b08bbeb4190793391b2c857852b98085e7d65
Reviewed-on: https://go-review.googlesource.com/c/build/+/453776
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
ARM machines are not available in the us-central1-c zone. This removes
this zone from the configuration.
https://cloud.google.com/compute/docs/regions-zones
For golang/go#53851
Change-Id: Ic30ef617c239c073fa60554a86c832e34e5a4fe1
Reviewed-on: https://go-review.googlesource.com/c/build/+/453658
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
go get cloud.google.com/go/pubsub@v1.26.0
go mod tidy
This brings in loong64 support.
Change-Id: Iff5905f5aa866b240832abf76ce97a4a8763e8f7
Reviewed-on: https://go-review.googlesource.com/c/build/+/453456
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
go get github.com/creack/pty@v1.1.18
go mod tidy
This brings in loong64 support.
Change-Id: Ibbc661e463e855974880fd9b56422fb3dee3650d
Reviewed-on: https://go-review.googlesource.com/c/build/+/453455
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
This change allows ARM based docker images to be built by xb.
For golang/go#53851
Change-Id: I5a2fd92b4a93957551e1f7cb9f46871de54fbb1d
Reviewed-on: https://go-review.googlesource.com/c/build/+/453657
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Revamp the setup for windows-amd64 and windows-386 builders so that we
default to using newer C compilers for Go 1.20 and main branch, but
older compilers for release branches (1.19 and prior). Instead of
having a series of "newcc" canary builders for windows, we now have a
series of "oldcc" builders for release branch use.
Note for posterity: we can prune these changes out in a couple of Go
release (once Go 1.20 becomes the oldest release we're testing).
Updates golang/go#35006.
Change-Id: I329b59a5d67c2c1ae65a30564a1c6a081b2523fa
Reviewed-on: https://go-review.googlesource.com/c/build/+/453095
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change adds gpg-agent to the image used for linux-arm64-longtest.
TestScript/version_buildvcs_git_gpg is failing because it is missing.
This also adds gpg-agent and triggers a rebuild of the
linux-x86-bullseye image.
Upates golang/go#49649
Change-Id: I8adac58f21beeb7a1403d8d672b5a7409fd14f74
Reviewed-on: https://go-review.googlesource.com/c/build/+/453656
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This change replaces linux-arm64-aws with linux-arm64. The new builder runs
on GCP and has an increased set of resources. This should provide a
performance improvement.
The builder will now be used:
- To release linux-arm64
- As the linux-arm64 trybot
Fixesgolang/go#53851
Updates golang/go#54679
Updates golang/go#40561
Change-Id: I9abfe2ed1d1bd8a68bba1e1f924637e829026e6d
Reviewed-on: https://go-review.googlesource.com/c/build/+/449615
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
For streaming the command output from "gomote run", a printf
should be print. Otherwise,
$ gomote run $VM /bin/echo %d
# Streaming results ...
%!d(MISSING)
# Wrote results ...
Change-Id: I8ae879fd6ef6dc68b7cba1f7a723dcd3c6fbd0e7
Reviewed-on: https://go-review.googlesource.com/c/build/+/453096
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
At least on macOS, there is /usr/bin/bundle which is not what we
want. So, besides making sure "bundle" is in PATH, make sure it is
the one we want.
Change-Id: I17bca55f18f384051372ee32eeaa104003476046
Reviewed-on: https://go-review.googlesource.com/c/build/+/452768
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
As we already require a goroot flag, use the go command in that
GOROOT, instead of the one in PATH.
Fixesgolang/go#44862.
Change-Id: Ic49c64cb2ece1828ac0f8ea35a808fb301e6d899
Reviewed-on: https://go-review.googlesource.com/c/build/+/452767
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The current releaselet descriptions are good, as recently discussed,
leaving just one typo in the macOS version name to fix up to reduce
confusion.
Change-Id: I60d12dcc67c2bfa4842b081b0c0e950faa50a067
Reviewed-on: https://go-review.googlesource.com/c/build/+/452856
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Structured buildlet log output would make this easier,
but this works well enough to enable other tooling,
such as automatic flaky test reporting to GitHub.
Change-Id: I9efea12999d55959cd729f94272e27a8ad7a6571
Reviewed-on: https://go-review.googlesource.com/c/build/+/432399
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
This change makes it so that all errors are wrapped and put onto the
error chain. That way, instanceDoesNotExist can consistently identify a
"does not exist" error. This change also removes "statusFromError" which
makes the returned error a little bit less friendly.
Change-Id: I179914bc1f29b5d07868e568d448f37f55f8fad4
Reviewed-on: https://go-review.googlesource.com/c/build/+/451299
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
CL 450315 updated gerritbot to a newer GitHub API client package, where
the optional since parameter is specified as a pointer instead of value.
This gives the caller more control over whether the optional parameter
is sent to GitHub. For better or worse, GitHub doesn't like it when we
ask for all comments since January 1, year 1 UTC. So, stop doing that.
Change-Id: I7593e9a7d03d2f3702549c3dd79ce380f07b73cb
Reviewed-on: https://go-review.googlesource.com/c/build/+/451276
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Paul E. Murphy
Michael Pratt
Bryan C. Mills
Cherry Mui
Carlos Amedee
Russ Cox
Heschi Kreinick
Dmitri Shuralyov
Benny Siegert
Than McIntosh
Dung Le
Guoqi Chen
Michael Anthony Knyszek