A small subset of the pubsubhelper files added in CL 39353, CL 39535,
and CL 39632 accidentally ended up with something other than the usual
"BSD-style" phrase in the copyright header. Fix that.
Change-Id: Id732f3d9e46eefacea5c8202d8272ed67fdc0f58
Reviewed-on: https://go-review.googlesource.com/c/build/+/472375
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
For minor security releases, include a list of CVEs that will be fixed
in the release. These CVEs will be restricted until the release happens,
so no information is leaked, but provides a way for consumers to track
things.
Updates golang/go#56547
Change-Id: Ifcff22da822a7e4c4a54c76ce3c4b870d729c7ca
Reviewed-on: https://go-review.googlesource.com/c/build/+/470795
Run-TryBot: Roland Shoemaker <roland@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Update the "windows-386" slowbot alias to windows-386-2016
from windows-386-2008.
Updates golang/go#58007.
Change-Id: I44e10500fcf0520976a80916b1fc4a42307cd7a3
Reviewed-on: https://go-review.googlesource.com/c/build/+/470715
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Relui replaced release since Go 1.18 or so. We kept it around a bit
longer while there were remaining Go+BoringCrypto releases that still
used the release command. Those are no more, so to avoid confusion,
remove cmd/release code given it's no longer maintained or supported.
Updates golang/go#40279.
Updates golang/go#58659.
Fixesgolang/go#45893.
Change-Id: Id0d641bee49c9584c52e5616322f0656b89cd851
Reviewed-on: https://go-review.googlesource.com/c/build/+/470755
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Use linux-amd64-longtest-race instead of linux-amd64-longtest, and
replace linux-386-longtest with linux-386.
Change-Id: I10c465705989d5e786b94f30c67c66a1e3eb89db
Reviewed-on: https://go-review.googlesource.com/c/build/+/470415
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
The coordinator has a special case for Plan 9 builders to treat
communication errors (when the builder stops responding) as
permanent instead of retrying the build. This isn't appropriate
for the plan9-arm builder (which is not on a virtual machine and
can suffer temporary network disconnects or unexpected reboots).
Exempting plan9-arm from this check will prevent spurious build
failures which need a manual retry.
Fixesgolang/go#52677
Change-Id: I7059eec115f680b3f6cd98368c1c566b7310f86f
Reviewed-on: https://go-review.googlesource.com/c/build/+/470355
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Catch SIGTERM and cancel the main context, which should cause things
to shutdown slightly more cleanly (importantly deleting buildlets,
rather than just orphaning them) when Kubernetes attempts to shutdown a
workload.
Change-Id: Ibfae309db9007778b31b4416578f9a8013286e4e
Reviewed-on: https://go-review.googlesource.com/c/build/+/465935
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Changes applied only to Go comments.
Change-Id: I0019ebe895186aed16daf252d7817c5e095c4b94
Reviewed-on: https://go-review.googlesource.com/c/build/+/469456
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
CL 468937 added a newer Windows 32-bit TryBot that will provide coverage
for the windows/386 port for Go 1.21 and newer. Stop the older Windows 8
builders from running on the relevant branches.
Updates golang/go#58007.
Fixesgolang/go#58008.
Change-Id: I8664a74543b2225986586440ab027cda85b67a3e
Reviewed-on: https://go-review.googlesource.com/c/build/+/463579
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This new builder has minimal flakes, add it to the TryBot set. Note that
CL 463579 will remove windows-386-2012 from tip.
Fixesgolang/go#58007
Change-Id: I1c7e20cb2158f08fe9ead49fb203d92971e0a8cf
Reviewed-on: https://go-review.googlesource.com/c/build/+/468937
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
1.18 is unused, but 1.19 is untested. Replace the 1.18 test with a 1.19
test.
Change-Id: I4e7ae452d5b5bbf375df8487050266c46eb98f9e
Reviewed-on: https://go-review.googlesource.com/c/build/+/468936
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This builder is equivalent to windows-amd64-2016, but using
GOARCH/GOHOSTARCH=386.
Older versions of Windows will eventually drop Go support, so we need to
have builders for newer versions.
For golang/go#58007
Change-Id: Ifdbe38aff735c91f1714e82b3e70346dd9e40b9b
Reviewed-on: https://go-review.googlesource.com/c/build/+/468540
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The linux-arm-aws trybots do not reliably complete within the expected
time limit. This change removes it from the trybot set until we can
reliably run it within the allocated time. Until then the misc-compile
builder will provide minimal coverage during trybot runs. The post
submit builds will still run.
Fixesgolang/go#54679
Change-Id: I712ab4a56dd7ce923c43a08b3461d96ba6638947
Reviewed-on: https://go-review.googlesource.com/c/build/+/468535
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Many Go commands will print usage when run with just the -help flag,
and not attempt to take any other actions. Modify genbotcert slightly
to follow that pattern and fix a few trivial nits while here.
Change-Id: Ieab030d19164c8484bd91ec21926d4e539bd5f12
Reviewed-on: https://go-review.googlesource.com/c/build/+/466679
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
genbotcert is used to issue a CSR for a LUCI bot.
Change-Id: I66e8a889b89c13476e85afd16c0c09ac0d6424f6
Reviewed-on: https://go-review.googlesource.com/c/build/+/466678
Auto-Submit: Heschi Kreinick <heschi@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
A patch (CL 358854) implementing the loong64 GNU format disassembler on x/arch
has been uploaded, and the linux/loong64 builders seem to have enough resources
to handle it.
Change-Id: Ibe4d16e544343a4056ff9bd6b8ae999c4b8b6464
Reviewed-on: https://go-review.googlesource.com/c/build/+/465475
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: xiaodong liu <teaofmoli@gmail.com>
Fix a hole in greenness checking. If:
- the repository has been modified since the last tag
- but not in the last week
- and none of its dependencies have changed
Then the commit we want to tag will be more than a week old and we won't
see it, which triggers the race-prevention logic that wants to see the
commit on the dashboard before proceeding.
Expand the window to 6 weeks, which will cover all the time since the
previous tag run and then some.
Change-Id: Ie5062d98f70a02ad77b85ca26ecae58cf969046e
Reviewed-on: https://go-review.googlesource.com/c/build/+/466437
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
relui uses tags to decide which version of Go is current, and therefore
which release workflows should exist. In the 1.20 release, it
crashed after the tag had been created, but before the workflow had
finished. Because the tag existed, the new relui incarnation decided it
only needed to know how to release 1.21, and the 1.20 workflow couldn't
be finished.
Keep the previous major release workflow definition around for a week
so that we have ample time to get ourselves out of these situations.
Fixesgolang/go#58228.
Change-Id: I33173d240b813199b8beeaac5bfcc8f7a6ead07a
Reviewed-on: https://go-review.googlesource.com/c/build/+/466145
Auto-Submit: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
I had initially added known issues fairly aggressively in order to use
them to reduce noise in 'greplogs -triage'. Now that we are using
'watchflakes' for triage, that noise reduction is no longer important
(the failures are already clustered to their respective known issues),
and having greyed-out cells on the dashboard makes new regressions too
easy to miss.
Concretely:
- golang/go#42212 is mostly specific to x/net at this point (as
golang/go#57841)
- There have been no failures matching golang/go#51001 since October.
- golang/go#52724 has been so rare lately that we hadn't yet added a
'watchflakes' pattern for it.
- There have been no failures matching golang/go#51443 since May.
- There have been no failures matching golang/go#53116 or
golang/go#53093 since I enabled 'watchflakes' for the builder in
December.
- The linux-amd64-perf builder seems to be passing consistently for
x/benchmarks and x/tools, so there is no need to refer to
golang/go#53538 to explain failures on it.
Change-Id: Ia16db2a23e5fa037a299f1f56fb26f1cf84521e1
Reviewed-on: https://go-review.googlesource.com/c/build/+/465156
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
The previous change added a StopAfterMake requirement so that the
misc-compile builders would only ever run make.bash. However, this
is a fairly big hammer as it skips everything after make.bash. Coming
up, we're going to want to runSubrepoTests.
However, we can't call into runTests because of golang/go#58297, so we
need a special exception for that. This change thus also adds the notion
of IsCrossCompileOnly defined by whether the host arch doesn't line up
with the target arch, and adds a test to make sure this only applies to
the misc-compile builders.
This change also removes some hard-coding of the misc-compile prefix in
favor of this new IsCrossCompileOnly notion.
For golang/go#58163.
Change-Id: I40ce91e13b45e8bbbb607aedd302f0ec0fbd608a
Reviewed-on: https://go-review.googlesource.com/c/build/+/464956
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This change removes misc-compile builders' dependence on buildall.bash
and switches to make.bash instead, since they now each build for exactly
one platform.
This change then also removes SplitMakeRun and any paths derived from
that in order to simplify the code.
For golang/go#58163.
Change-Id: I16704cc553c0f6e2c6c34994999693b6d44adb88
Reviewed-on: https://go-review.googlesource.com/c/build/+/464955
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
This change splits up the misc-compile builders to only build for one
platform each. This is the first step in a sequence of CLs to simplify
misc-compile builders by eliminating the !SplitMakeRun paths, of which
misc-compile builders are the only ones.
The end result will be the support of misc-compile builders for
subrepos.
Splitting up misc-compile builders has the potential to increase VM
demand, but each build also takes less time to run. The main way is
could increase overall VM resource usage is the overhead of setting up
and tearing down a VM. The other downside is more visual noise, though
this is fairly minor.
Note that this change also passes GOOS, GOARCH, and GOARM environment
variables to buildall.sh. The goal is to eventually remove buildall.sh
by just doing make.bash. (Right now buildall.sh will essentially ignore
those variables and just set them itself.)
For golang/go#58163.
Change-Id: Ia48f6a16d080e9e078b2959dea3b68fe43def8ec
Reviewed-on: https://go-review.googlesource.com/c/build/+/463777
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
The ad-hoc workflow was successfully used to generate CL 464875 and
won't be needed anymore, so drop it.
Add a "await CL" step so there's a lightweight indicator of when the
goimports CL is submitted, like we have for the DL CL and version CL.
It's a leaf task that doesn't block any other Go release process work,
but helps make it so that when the overall workflow is completed, we
know there's nothing more that needs attention.
Fixesgolang/go#54377.
Change-Id: I00cfd851677e0c6c0041f4f2b913e7740b3f7ab4
Reviewed-on: https://go-review.googlesource.com/c/build/+/464915
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
CL 442157 added a task at the end of the major Go release workflow to
mail a CL to x/tools. There were 3 new fields added to VersionTasks,
but cmd/relui only set one of them, which caused the task not to work
during the Go 1.20 release (go.dev/issue/58227). Due to an unrelated
issue in cmd/relui (go.dev/issue/58228), we didn't get the opportunity
to fix up the task and restart it, so it was skipped.
Set the 2 missing fields in cmd/relui, and add a temporary workflow to
trigger (and test out) the new functionality after the Go 1.20 release.
Also apply a few minor refinements to CreateUpdateStdlibIndexCL. Remove
the unused branch parameter, and avoid GetCurrentMajor to determine the
current major version. GetCurrentMajor will change its report from N to
N+1 sometime during the major Go release, after the tags are published.
We already know the major version in the workflow.
Fixesgolang/go#58227.
For golang/go#54377.
Change-Id: I6377cdf051e4ea8628a88ac3f7eaf70651b34f72
Reviewed-on: https://go-review.googlesource.com/c/build/+/464815
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
After all.bash is passing with Node.js 18, the js/wasm builder can be
enabled as a regular TryBot again (this time with Node 18 in place of
Node 14).
For golang/go#57614.
Change-Id: I714380fba89e37275aed4144a1e8b50e0cc57884
Reviewed-on: https://go-review.googlesource.com/c/build/+/464036
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Two small fixes, one that retries failures when we are attempting to
create AWS-based buildlets, the other which only disables the network
if it is disabled by default for the builder type.
Change-Id: I720ea1938c9c141ad05f7593479a5846d1058525
Reviewed-on: https://go-review.googlesource.com/c/build/+/464337
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Also fixes the higher is better logic for this page. Oops.
Change-Id: I27aa263526bd2be39f0ca55248e35b4b2cc672d8
Reviewed-on: https://go-review.googlesource.com/c/build/+/464356
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
When an advisory trybot run times out, the context is canceled.
The trybot will never complete successfully with a canceled context.
This change records the failure and approves the trybot run.
For golang/go#57725
Change-Id: I79ba2d9cf32c91180cbce70f5b51426aaa11a704
Reviewed-on: https://go-review.googlesource.com/c/build/+/464299
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
This change adds a vertical line at 0% that spans the page (meticulously
removing sources of padding and borders from the table to achieve it)
and also makes the center line thinner.
Change-Id: I79b1bbf77be7a8fc2e2d7cc8e368efedaddcecca
Reviewed-on: https://go-review.googlesource.com/c/build/+/464355
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Currently commits on the per-unit dashboard page have anchors with IDs
that directly contain the commit hash. Although this hash is always a
valid ID, it may not be a valid CSS selector because it may start with a
digit. Fix this my prepending all anchors with the string "commit" and
updating links.
This also cleans up some logic with commitSelected in addTable.
Change-Id: I6d9a9306406c7778261c97a039bb284f17490f5e
Reviewed-on: https://go-review.googlesource.com/c/build/+/464298
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Change-Id: I15769c4302e8dd1d649e0eaa9b16099f0eda603b
Reviewed-on: https://go-review.googlesource.com/c/build/+/464239
Run-TryBot: Ian Lance Taylor <iant@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
The js/wasm port maintainers want to start landing changes for
Go 1.21 that replace Node.js 14 support with Node.js 18 support.
Disable the js-wasm TryBot on tip so that work can begin.
Once done, the js-wasm-node18 builder can become the new TryBot
on tip, and the temporary misc-compile trybot can be removed.
For golang/go#57614.
Change-Id: I18ebbc69c8da2b7296dd06a5a10c8557395d600d
Reviewed-on: https://go-review.googlesource.com/c/build/+/463915
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change introduces retries to each advisory trybot run. A trybot
run will be attempted 3 times before it fails. If it fails then the
operator will be presented with the option to approve the failed
trybot run. There is a follow up task which waits for all advisory
trybot runs to be approved or pass before it continues processing the
workflow.
Fixesgolang/go#57725
Change-Id: I2250289f5d597c7cb493d0267e451691548589c7
Reviewed-on: https://go-review.googlesource.com/c/build/+/463535
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
openbsd-mips64 does not build anymore with the current x/sys,
an intentional decision by the openbsd mips64 maintainers.
Remove it from our build set to ignore that breakage for now.
The maintainers are welcome to add it back once openbsd-mips64
builds again.
Fixesgolang/go#58110.
Change-Id: Idcd251f0087fa80b5a32a87f18a8b7e9412feda8
Reviewed-on: https://go-review.googlesource.com/c/build/+/463856
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Joel Sing <joel@sing.id.au>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
This flag enables some extra consistency checks that were more
applicable before we added the types2 frontends in Go 1.18. And since
CL 458625, there's nothing left to check anyway so the flag has been
removed.
Fixesgolang/go#58104.
Change-Id: If661d2c5b0033208771ff6b883b72125bfec1dcc
Reviewed-on: https://go-review.googlesource.com/c/build/+/463775
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
We don't yet have a macOS 13 darwin/arm64 builder, but the amd64 one
does exist and should be a better default slowbot choice by now.
Change-Id: I41156a37e0903629fc4c2ed3bfb57a7965670c96
Reviewed-on: https://go-review.googlesource.com/c/build/+/463576
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
The staging section was commented out because that environment is not
supported. It's still visible when viewing the .md file in its raw form
and has proven to cause confusion. Since we can easily get it back from
history if/when it becomes needed again, hide it better by deleting it.
Change-Id: Ifb227d3238d88a9d1c6be58dd95e2b7829b85315
Reviewed-on: https://go-review.googlesource.com/c/build/+/463575
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
With Go 1.20, we've switched the default to GOEXPERIMENT=unified, but
still support GOEXPERIMENT=nounified. For Go 1.21, we're going to
remove the experiment knob.
This CL updates the builders accordingly: continues to test
GOEXPERIMENT=nounified only for the 1.20 release branch, and stops
testing GOEXPERIMENT=unified entirely (since that's the default
everywhere we care about testing it).
Fixesgolang/go#52150.
Fixesgolang/go#57977.
Change-Id: Ice5be7c3db3453989ab12a48e2c93760590492ef
Reviewed-on: https://go-review.googlesource.com/c/build/+/463156
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
A generated file (src/time/tzdata/zzipdata.go) was added in CL 455357.
Also add a test to catch any generated files added in the future.
Updates golang/go#43350.
Change-Id: I4965744c7023a68a68609506b9cdc99a6f27ea4a
Reviewed-on: https://go-review.googlesource.com/c/build/+/463155
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
This change makes a few improvements to the regressions page:
1. It binds regressions to benchmark+unit, so now the regressions page
might break up the groupings compared to before (which is probably
OK).
2. This binding lets us avoid putting regression information into the
benchmark name, which previously broke the title's link, so this
change also moves that information to just above each graph.
3. This change adds a link to the regression information which jumps to
the offending commit on the per-benchmark+unit page.
4. It adds a file-an-issue link to the regressions page which
streamlines some of the overhead of triaging.
Note that deltaScore isn't exported to the regressions page anymore
because JSON can't tolerate negative infinities, and the new code is
trying to be as simple as possible. The next step is probably to filter
out non-regressions entirely, rather than try to make the deltaScore
work. We can also always bring it back as a string if we feel it's very
useful.
Change-Id: Ib7cf16ef92534fd1d9b9c23798e9474e20f4e8c2
Reviewed-on: https://go-review.googlesource.com/c/build/+/459518
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Dmitri Shuralyov
Roland Shoemaker
Than McIntosh
miller
Oleksandr Redko
Michael Pratt
Carlos Amedee
David Chase
Heschi Kreinick
Guoqi Chen
Bryan C. Mills
Michael Anthony Knyszek
cui fliter
Russ Cox
Matthew Dempsky
Roberto Clapis
Julie Qiu