The cmd/go tests are timing out on the plan9/amd64
builder because they take more than 20m to complete.
This change disables the cmd/go tests on the
plan9/amd64 builder, like it was done on the
plan9/386 builder.
Updates golang/go#31910.
Change-Id: I157b472da8498ddce0f641cccb79bc50ae65ca3b
Reviewed-on: https://go-review.googlesource.com/c/build/+/175898
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Building with GOHOSTARCH=arm on a GOHOSTARCH=arm64 android device
should work in theory, but results in an error about text relocations:
Building Go cmd/dist using /data/data/com.termux/files/home/go-android-arm64-bootstrap.
Building Go toolchain1 using /data/data/com.termux/files/home/go-android-arm64-bootstrap.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
warning: unable to find runtime/cgo.a
Building Go toolchain2 using go_bootstrap and Go toolchain1.
CANNOT LINK EXECUTABLE "/data/data/com.termux/files/usr/tmp/workdir-host-android-arm64-corellium-android/go/pkg/tool/android_arm/go_bootstrap": /data/data/com.termux/files/usr/tmp/workdir-host-android-arm64-corellium-android/go/pkg/tool/android_arm/go_bootstrap: has text relocations
go tool dist: FAILED: /data/data/com.termux/files/usr/tmp/workdir-host-android-arm64-corellium-android/go/pkg/tool/android_arm/go_bootstrap install -gcflags=all= -ldflags=all= -i cmd/asm cmd/cgo cmd/compile cmd/link: signal: aborted
I tried switching linker to gold, lld to no avail. Drop GOHOSTARCH
as a workaround.
Updates golang/go#31722
Change-Id: Id00564406582122f254c08b357668d7d0a9bae43
Reviewed-on: https://go-review.googlesource.com/c/build/+/175078
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also remove dead nacl-arm. It hasn't run in ages.
And update netbsd comment about why 386 doesn't run. And correct its
VM image name.
Updates golang/go#31705
Updates golang/go#31726
Change-Id: I9de4605f34a052d0a84684fca098388d75602a82
Reviewed-on: https://go-review.googlesource.com/c/build/+/174637
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Drop linux-amd64-stretch (which is redundant with linux-amd64, which
is now Stretch since CL 170282) and add linux-amd64-jessie, and use
Jessie in cmd/release for Linux releases)
Updates golang/go#31293
Change-Id: I21b7a43a24385d5976296d0e5f1c6009cbc18b05
Reviewed-on: https://go-review.googlesource.com/c/build/+/171121
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Make exp off by default, as it barely passes anywhere. Lock in the
places where it does pass.
Also disable x/net master combined with Go 1.11 on FreeBSD 32-bit. It
doesn't work on our builders and it'll never be fixed (we're not going
to make changes to Go 1.11) and there's resistance to skipping those
tests (my CL 170777), so I'm just turning off the builder. That's not
ideal, but it's better than people getting used to red on the
dashboard.
Fixesgolang/go#31221
Change-Id: Id0228e4b0ee73715a0c2da84f68dcfc989a48aaf
Reviewed-on: https://go-review.googlesource.com/c/build/+/170782
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The plan9 port doesn't need to be tested against older Go releases.
Its userbase runs at master.
Change-Id: I710d98560b234c7555c7be526aa2efdb6473c439
Reviewed-on: https://go-review.googlesource.com/c/build/+/170519
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Exp is experimental. It's hard enough keeping it passing on master.
We're not going to fight release branches as well. If somebody wants
to see test coverage against three versions of Go, they can graduate
their code out of experimental.
Change-Id: I4695ce479c47bd56a4a58dba05d367d3de020c58
Reviewed-on: https://go-review.googlesource.com/c/build/+/170518
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Fixes a TODO that this was untested. (It used to be scattered all over
and hard to test, but now we have all the policy behind a single
method, so test it.)
And add tests for golang/go#29509 too, which seems like it should work.
Change-Id: I6d1f517e2014766c26538193c6b42106a4078a9b
Reviewed-on: https://go-review.googlesource.com/c/build/+/170398
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
We have limited Mac resources. It's not worth wasting time testing
portable things on them.
Change-Id: Iaaa1d02582da7f8435217fbb32dcb7235c560a41
Reviewed-on: https://go-review.googlesource.com/c/build/+/169681
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
There were some copy-paste mistakes affecting the documentation of
these two identifiers. This change corrects that.
Change-Id: Ic619f19c4a659a9357c816ff7fb6b0cd7b3bccd1
Reviewed-on: https://go-review.googlesource.com/c/build/+/169437
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
As of CL 169198 for golang/go#31040, the coordinator no longer supports
placing the x/tools files out for Go 1.11 and Go 1.12's cmd/vet/all to
find, so their misc-vet-vetall builds will start failing.
We could in theory still either backport CL 169237 to
release-branch.go1.11 and release-branch.go1.12, and/or we could keep
running the misc-vet-vetall builder for the future Go 1.13 release
branch, but it's not obviously even worth it; the vetall builder is
most useful during development anyway. The tree is pretty stable once
it's release branch time. The main use of misc-vet-vetall is catching
assembly vet failures (since go test now does most the other vet
checks), and assembly doesn't often change in release branches.
Updates golang/go#31040
Change-Id: I7b827ecbcd206f3dcf63e04cc94fb78854befd7d
Reviewed-on: https://go-review.googlesource.com/c/build/+/169339
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
And add a test that indirectly verifies that the BuildConfig and
HostConfig are JSON serializable. They weren't due to an exported func.
But that exported func shouldn't be exported, so unexport it and move
more policy into dashboard/builders.go. (There's been a number of
recent cleanup CLs to move all policy into dashboard/builders.go
instead of sprinkled all over the coordinator)
A future CL will use this JSON in gomote create.
Updates golang/go#30929
Change-Id: I726eaf6a4f3eeaab27d31e2642cb7642111ccd67
Reviewed-on: https://go-review.googlesource.com/c/build/+/168341
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This seems to be the last builder still using the old builder
binary and not buildlet. It needs an entry in here to switch
to buildlet and stage0.
Change-Id: If2fdd2298ab88d56b6850061050caf27ca7c8983
Reviewed-on: https://go-review.googlesource.com/c/build/+/168061
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It's not important to run the new "reboot" bootstrapping test on all
builders; a few is fine. Skip it on plan9-arm, etc, and on trybots that aren't
super widely sharded.
Change-Id: I35d5408eb5e034f42df5976f2b9b7f7d478d580a
Reviewed-on: https://go-review.googlesource.com/c/build/+/167998
Reviewed-by: David du Colombier <0intro@gmail.com>
The NetBSD builders apparently have a tiny filesystem.
And this test doesn't need to be run everywhere. A few builders is enough.
Fixesgolang/go#30839
Change-Id: I60df10173112ef9957c0e4cd6d414a4c5efaa940
Reviewed-on: https://go-review.googlesource.com/c/build/+/167637
Reviewed-by: Bryan C. Mills <bcmills@google.com>
* add support for longtest builders for subrepos.
* fix race builders for subrepos (they weren't passing the -race flag).
* adjust the policy for the js-wasm builders to build fewer subrepos
where it'll never work or isn't worth it.
* fix the android emu builders which disappeared because an empty
string was being passed to buildsRepoAtAll. In some places in the
code an empty string for goBranch for the "go" repo meant the same
as branch, but I forgot that in the new code, so an old caller was
confusing the new config hooks. Rather than make all policy funcs be
aware of both ways, the new code in this CL now maps an empty string
to the same as the repo's branch when the repo == "go". Adds a test
too.
* fix some outdated comments.
Change-Id: Icf3fb85e5542a4d314443b59d02517b306ef46b7
Reviewed-on: https://go-review.googlesource.com/c/build/+/166897
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The x/website repository uses go.mod to specify precise versions of
its dependencies, and therefore requires the use of GO111MODULE=on
to build correctly. So set GO111MODULE=on when running its tests.
Change-Id: I4acc80fd207e257aa77dc0e296b1039c83fa3d2a
Reviewed-on: https://go-review.googlesource.com/c/build/+/165743
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Mostly some regressions (building too much) from the massive refactoring
in CL 166218, but also some minor changes. See test updates.
Change-Id: Ie30f51b425367f18a49764ac971e262131959bc8
Reviewed-on: https://go-review.googlesource.com/c/build/+/166557
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This removes a bunch of TODOs about scattered policy and moves it all
into builders.go.
While here,
* add a bunch of tests
* unexport some things
* rename some things
* document some things
* adjust FreeBSD policy as function of branch (per Go 1.12 being
last to support FreeBSD 10.x, and to unblock CL 165801)
* set GO_BUILDER_SET_GOPROXY=coordinator for reverse buildlets,
which is necessary to remove the oauth2 & build special cases
in the config
* change Elias Naur's mobile builder to how I think he wants it
(he was fighting the old system)
* add $HOME on the Solaris smartos builder, which was missing &
causing tests to fail lately
* make the (currently failing) longtest builder have GOPROXY set
* remove an allocation in version.ParseReleaseBranch
Fixesgolang/go#9603
Updates golang/go#14594
Change-Id: I50a23ad7cdf478c95b14bee9b3931ba361baacfa
Reviewed-on: https://go-review.googlesource.com/c/build/+/166218
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
They've been decomissioned for some months now. Our arm64 builders are
on packet.net these days.
Change-Id: Iaede189157e0298812b2971cdd63599f6096d73d
Reviewed-on: https://go-review.googlesource.com/c/build/+/165781
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Brad Fitzpatrick
Elias Naur
David du Colombier
Dmitri Shuralyov
Yuval Pavel Zholkover
Benny Siegert
Tobias Klauser
Bryan C. Mills