It was using some CPU.
Kinda useless to save a virtual screen.
Change-Id: If2ca5a39818e190b44f87299837a305cfe966c3c
Reviewed-on: https://go-review.googlesource.com/37493
Reviewed-by: Kevin Burke <kev@inburke.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
These never work and are a waste of resources and unnecessary scary
red on the page.
Change-Id: I2d8f8908096dee01618129a9082e98f3ffd92bb7
Reviewed-on: https://go-review.googlesource.com/37467
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
macOS Sierra's network stack gets wedged after a few runs of all.bash.
Instead, halt the machine after a build is complete. cmd/makemac will make
a new one for the next build.
Change-Id: Icb1b21c045376cff9958a0d3b4cfaf784c9948d0
Reviewed-on: https://go-review.googlesource.com/37465
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Poll the local VMWare status and the farmer.golang.org status and compare
the two, deleting or creating VMs as appropriate.
Change-Id: Ifaee94b0b3ce062f0865bd9c4fb80937a560f650
Reviewed-on: https://go-review.googlesource.com/37464
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Will be used for dynamic creation/destruction of Mac VMs in subsequent CL.
Updates golang/go#9495 (Mac virtualization)
Updates golang/go#15760 (monitoring)
Change-Id: I48b17589b258d5d742bad5a3ddae18de98778149
Reviewed-on: https://go-review.googlesource.com/37457
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Now you can actually pass repos to maintnerd and tell a Corpus to
track/store them. Adds a hook to "catch up" a given repo, though it's
unimplemented at the moment, so all requests hit the API. Also only
Github is implemented.
Change-Id: Ib074c02437d6530fc8d57dd433486c05cd75ee64
Reviewed-on: https://go-review.googlesource.com/37299
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The latest master for go-github (google/go-github@23d6cb9c) adds
Context parameters as the first argument to every function call.
Update code that calls go-github to have contexts, where appropriate,
and adds timeouts to some long-running commands that didn't
previously have them.
Fixesgolang/go#19208.
Change-Id: I25203de5d10ada1dcd3a97eb5434a85bb328ce7e
Reviewed-on: https://go-review.googlesource.com/37293
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(been in production for past few days)
Updates golang/go#19166
Change-Id: Iee301aac5aa87c6644ac1253d7c0bd6c522ff066
Reviewed-on: https://go-review.googlesource.com/37380
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Probably not doing this right yet, but it's done.
Change-Id: Ic38b02c6cb0d42eb7e661c67f860254ff9f2fc76
Reviewed-on: https://go-review.googlesource.com/37296
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
If new commits are submitted to the remote repository while gitmirror
is running, gitmirror won't be able to find them when a user asks for
that commit to be exported.
If a request asks for an unknown commit, attempt to fetch it
on-demand from the remote and serve from there.
I checked that this worked by starting a local gitmirror, verifying
the commit was not present in the local repo, submitting a changeset,
asking for that commit, and verifying that gitmirror fetched the
remote commit to serve it.
Adds a very basic test for the archive functionality that won't go
over the network or hit the disk.
Fixesgolang/go#19166.
Change-Id: I1ad017b9c8cd258849585c091122c889ea656017
Reviewed-on: https://go-review.googlesource.com/37225
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This adds more utility to the Gerrit client and lets us reuse the
Gerrit API logic, instead of inventing it on an adhoc basis inside
the gitmirror code.
I added a test that this deserializes the correct data from the
Gerrit API for go.googlesource.com (and then removed it).
Change-Id: I449594b0257ed15d9b5aa7aa1eda7fb371fad6c1
Reviewed-on: https://go-review.googlesource.com/37252
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also add closing HTML tags to the /debug/watcher page.
Change-Id: I487874802a2a79ae442ca996f00ef2f04ef6dc16
Reviewed-on: https://go-review.googlesource.com/37221
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The talks repo got too big.
Also clean up the gitmirror fetching a code while there. It no longer
runs as a subprocess, so we don't need to account for its start-up
time.
Fixesgolang/go#19162
Change-Id: I0f80b95360d079989254c26ea0406dab9633f0c1
Reviewed-on: https://go-review.googlesource.com/37217
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
golang/go placeholder had to be changed to 19117 given the previous
placeholder cannot be reopened.
golang/oauth2 is using the correct PR number now.
Change-Id: I9ee4801d6b4abc340fa1c9a74e3c0a6649f537f0
Reviewed-on: https://go-review.googlesource.com/37108
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This lets us set a timeout on the HTTP request, which lets us time out the
writeSnapshot call in cmd/coordinator.
Fixesgolang/go#18812.
Change-Id: I370448df4d95130c9c5b30ba32459ce844a6c967
Reviewed-on: https://go-review.googlesource.com/36897
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It would be nice to run these alongside the tests. There is only one
vet error left in the x/build tree, an unreachable return next to a
TODO.
Change-Id: Ic31d96cdee5bb0f6b9795237ff3b743a4b76e3cf
Reviewed-on: https://go-review.googlesource.com/36898
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
If the Gerrit query reported no CLs needed trybot runs, we returned
too early and didn't clear our state. Remove that 'if len(cis) == 0'
early return. The optimization was buggy and not even worth much if
correct.
Also rename some confusing variables.
Change-Id: I485d303c36cc477e3ac651ec25b2c777f512b658
Reviewed-on: https://go-review.googlesource.com/36808
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It's now running, but not hooked up the coordinator yet.
Updates golang/go#18817
Change-Id: I5870af1e0bfe5213886f7faeb138127986a7234c
Reviewed-on: https://go-review.googlesource.com/36801
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Windows installer will not broadcast WM_SETTINGCHANGE when a reboot is
pending. This message is required for explorer.exe to reload the PATH
from the registry so future cmd.exe processes will launch with go/bin in
the PATH.
Use the Wix extension to always broadcast this message after install.
More info:
http://wixtoolset.org/documentation/manual/v3/customactions/wixsettingchange.htmlFixesgolang/go#18680
Change-Id: I4f3af49f167f3875bbf8e898f4d50ee358b4e35d
Reviewed-on: https://go-review.googlesource.com/36324
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Per discussion on the mailing list we want to make this app run
on more environments than App Engine and hopefully with a backing
datastore that is just in-memory, or at the very least is not App
Engine specific.
Puts the datastore implementation detail behind an appengine build flag.
Adds an in-memory datastore if you are not running on App Engine; it's slow
since you have to fetch issues every time, but you can get all of the issues
and browse them. Adds a single test so we have the most basic of protections
against a regression.
Add a cmd/devapp main package so we can run the server outside of an
App Engine context.
Rename gg.Percentile to gg.Quantile to match the change in the latest
version of the downstream library.
Change-Id: Icbdef29676ecbf7078b0fb8c3920f61df60a5e2e
Reviewed-on: https://go-review.googlesource.com/34928
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Currently the Gerrit polling & git mirroring & serving & syncing
functionality is in the "watcher" process, which is in the same binary
as the cmd/coordinator (farmer.golang.org), but runs as a separate
process on that machine, and actually run in a separate Docker
container so it has a cache volume and the /usr/bin/git binary, etc. A
flag determines where func main delegates to: the build coordinator,
or the git mirror.
Start cleaning this up, in prep to run on Kubernetes as a separate service.
This copies the env/watcher-world/Dockerfile into a new gitmirror
Dockerfile, and copies the existing cmd/coordinator/watcher_process.go
into a new cmd/gitmirror/gitmirror.go process.
None of this is deployed or working yet. Once it's running and happy,
I'll then switch the coordinator to find & use it on GKE, and then
delete the old code.
Updates golang/go#18817
Change-Id: Ibaa87f244f08ce61662e689b815740c72c997536
Reviewed-on: https://go-review.googlesource.com/35911
Reviewed-by: Jaana Burcu Dogan <jbd@google.com>
Also, make the Darwin builder start-up script add a cache buster to
the URL, so it actually fetches the latest buildlet binary when
rebuilt.
Change-Id: I948182b25d234474170a7c967804c1bfef3e3d99
Reviewed-on: https://go-review.googlesource.com/35846
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Moving all the Go bots and services everything to Kubernetes.
Change-Id: I811c370ea8b650e1553bab891325fee7e110f029
Reviewed-on: https://go-review.googlesource.com/35810
Reviewed-by: Kevin Burke <kev@inburke.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The second section of the template was removed from the default
kubeConfig and the Staging environment now has 32 cores instead of
16.
After this the only failing tests are in the devapp package and fixed
by CL 34928.
Fixesgolang/go#18769.
Change-Id: I719ee8368ce85ae6837b6df915bfa69753e24417
Reviewed-on: https://go-review.googlesource.com/35630
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Switch all API methods that make requests to Gerrit to take a
context.Context as their first argument. Adds a package example and
a simple test that we make requests to the correct endpoint and that
the Client can handle correct responses and error responses from the
Gerrit server.
Switches all code in the x/build tree to use the new Gerrit
client. There are several projects outside the tree that import
x/build/gerrit; I'll submit CL's against those to pull in the new
interface once this gets merged.
Documents that the API is unstable.
Fixesgolang/go#18742.
Fixesgolang/go#18743.
Change-Id: Ifa78cbb058981e23cf5769955f6312fcbe08e174
Reviewed-on: https://go-review.googlesource.com/35559
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
So it really builds an ARMv6 binary when GOARM=6.
Tried "release -rev go1.8rc2 -tools release-branch.go1.8 -version go1.8rc2 -target linux-armv6l -watch"
and the generated binary works on my Raspberry Pi 1.
Fixesgolang/go#18748.
Change-Id: I11113f98703049dc9990fe8c8abf505dcfd980f2
Reviewed-on: https://go-review.googlesource.com/35501
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Changes for the new cloud.google.com/go/bigquery surface that came out a
couple of weeks ago.
Change-Id: I4e9d66c606df67fe24058e72665bde10bde5ca8d
Reviewed-on: https://go-review.googlesource.com/32444
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Brad Fitzpatrick
Kevin Burke
Chris Broadfoot
Jaana Burcu Dogan
Jeff Johnson
Cherry Zhang
shawnps
Jonathan Amsterdam
Russ Cox