It was using some CPU.
Kinda useless to save a virtual screen.
Change-Id: If2ca5a39818e190b44f87299837a305cfe966c3c
Reviewed-on: https://go-review.googlesource.com/37493
Reviewed-by: Kevin Burke <kev@inburke.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
These never work and are a waste of resources and unnecessary scary
red on the page.
Change-Id: I2d8f8908096dee01618129a9082e98f3ffd92bb7
Reviewed-on: https://go-review.googlesource.com/37467
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Go policy is to support the past two released Go version, which is
currently Go 1.7 and Go 1.8. Most of the Go repos are broken for Go 1.6 now
because everybody is using subtests and contexts.
Previously:
https://golang.org/cl/31767 removed Go 1.5.
https://golang.org/cl/20843 removed Go 1.4.
Change-Id: I64b4af609a8be79a0f25a855430b73ba4d442ae0
Reviewed-on: https://go-review.googlesource.com/37466
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
macOS Sierra's network stack gets wedged after a few runs of all.bash.
Instead, halt the machine after a build is complete. cmd/makemac will make
a new one for the next build.
Change-Id: Icb1b21c045376cff9958a0d3b4cfaf784c9948d0
Reviewed-on: https://go-review.googlesource.com/37465
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Poll the local VMWare status and the farmer.golang.org status and compare
the two, deleting or creating VMs as appropriate.
Change-Id: Ifaee94b0b3ce062f0865bd9c4fb80937a560f650
Reviewed-on: https://go-review.googlesource.com/37464
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Will be used for dynamic creation/destruction of Mac VMs in subsequent CL.
Updates golang/go#9495 (Mac virtualization)
Updates golang/go#15760 (monitoring)
Change-Id: I48b17589b258d5d742bad5a3ddae18de98778149
Reviewed-on: https://go-review.googlesource.com/37457
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Now you can actually pass repos to maintnerd and tell a Corpus to
track/store them. Adds a hook to "catch up" a given repo, though it's
unimplemented at the moment, so all requests hit the API. Also only
Github is implemented.
Change-Id: Ib074c02437d6530fc8d57dd433486c05cd75ee64
Reviewed-on: https://go-review.googlesource.com/37299
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The latest master for go-github (google/go-github@23d6cb9c) adds
Context parameters as the first argument to every function call.
Update code that calls go-github to have contexts, where appropriate,
and adds timeouts to some long-running commands that didn't
previously have them.
Fixesgolang/go#19208.
Change-Id: I25203de5d10ada1dcd3a97eb5434a85bb328ce7e
Reviewed-on: https://go-review.googlesource.com/37293
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(been in production for past few days)
Updates golang/go#19166
Change-Id: Iee301aac5aa87c6644ac1253d7c0bd6c522ff066
Reviewed-on: https://go-review.googlesource.com/37380
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Probably not doing this right yet, but it's done.
Change-Id: Ic38b02c6cb0d42eb7e661c67f860254ff9f2fc76
Reviewed-on: https://go-review.googlesource.com/37296
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
If new commits are submitted to the remote repository while gitmirror
is running, gitmirror won't be able to find them when a user asks for
that commit to be exported.
If a request asks for an unknown commit, attempt to fetch it
on-demand from the remote and serve from there.
I checked that this worked by starting a local gitmirror, verifying
the commit was not present in the local repo, submitting a changeset,
asking for that commit, and verifying that gitmirror fetched the
remote commit to serve it.
Adds a very basic test for the archive functionality that won't go
over the network or hit the disk.
Fixesgolang/go#19166.
Change-Id: I1ad017b9c8cd258849585c091122c889ea656017
Reviewed-on: https://go-review.googlesource.com/37225
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
WIP; not functional yet, but submitting so
Kevin can continue if he wants.
Change-Id: I1dab38f9845ebcbd69ec2a6f07e98793d3ed7cfb
Reviewed-on: https://go-review.googlesource.com/37053
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This adds more utility to the Gerrit client and lets us reuse the
Gerrit API logic, instead of inventing it on an adhoc basis inside
the gitmirror code.
I added a test that this deserializes the correct data from the
Gerrit API for go.googlesource.com (and then removed it).
Change-Id: I449594b0257ed15d9b5aa7aa1eda7fb371fad6c1
Reviewed-on: https://go-review.googlesource.com/37252
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also add closing HTML tags to the /debug/watcher page.
Change-Id: I487874802a2a79ae442ca996f00ef2f04ef6dc16
Reviewed-on: https://go-review.googlesource.com/37221
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The talks repo got too big.
Also clean up the gitmirror fetching a code while there. It no longer
runs as a subprocess, so we don't need to account for its start-up
time.
Fixesgolang/go#19162
Change-Id: I0f80b95360d079989254c26ea0406dab9633f0c1
Reviewed-on: https://go-review.googlesource.com/37217
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
In the last iteration, Brad got an inconsistent (i.e. non-working) set
of packages because (a) the CDN uses different mirrors, some of which
are more stale than others and (b) it was using bleeding-edge packages.
Switch to a hardcoded mirror (the main one) and stable (2016Q4)
packages.
Change-Id: I45e5ec8596b522c6284ff4b8f08edd1a29f5597b
Reviewed-on: https://go-review.googlesource.com/37190
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
They were moved around a few months ago and I didn't
update the notes.
Change-Id: I435864acbb967a5c9f0eb6a0f969fe711cd720c9
Reviewed-on: https://go-review.googlesource.com/37143
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
golang/go placeholder had to be changed to 19117 given the previous
placeholder cannot be reopened.
golang/oauth2 is using the correct PR number now.
Change-Id: I9ee4801d6b4abc340fa1c9a74e3c0a6649f537f0
Reviewed-on: https://go-review.googlesource.com/37108
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
We stopped using the system gzip some time ago
and removed the option in golang.org/cl/29432
Change-Id: I6f41af16357a5b29bbf337c4820409c78a75fff8
Reviewed-on: https://go-review.googlesource.com/36907
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Add $GOPATH/src to the --proto_path so we can import the google
Timestamp definition instead of redefining a copy in our tree.
Change-Id: I09c3554fb025a32c9db4892b702ee2bedb3c0e53
Reviewed-on: https://go-review.googlesource.com/36899
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This lets us set a timeout on the HTTP request, which lets us time out the
writeSnapshot call in cmd/coordinator.
Fixesgolang/go#18812.
Change-Id: I370448df4d95130c9c5b30ba32459ce844a6c967
Reviewed-on: https://go-review.googlesource.com/36897
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It would be nice to run these alongside the tests. There is only one
vet error left in the x/build tree, an unreachable return next to a
TODO.
Change-Id: Ic31d96cdee5bb0f6b9795237ff3b743a4b76e3cf
Reviewed-on: https://go-review.googlesource.com/36898
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
If the Gerrit query reported no CLs needed trybot runs, we returned
too early and didn't clear our state. Remove that 'if len(cis) == 0'
early return. The optimization was buggy and not even worth much if
correct.
Also rename some confusing variables.
Change-Id: I485d303c36cc477e3ac651ec25b2c777f512b658
Reviewed-on: https://go-review.googlesource.com/36808
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It's now running, but not hooked up the coordinator yet.
Updates golang/go#18817
Change-Id: I5870af1e0bfe5213886f7faeb138127986a7234c
Reviewed-on: https://go-review.googlesource.com/36801
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
From golang.org/cl/36692
Change-Id: Icc63edd28b687cf30c222a3125371ad912bc6da7
Reviewed-on: https://go-review.googlesource.com/36802
Reviewed-by: Kevin Burke <kev@inburke.com>
Reviewed-by: Matt Layher <mdlayher@gmail.com>
And moves Dial methods to *kubernetes.Client, instead of a separate
Dialer type.
Updates golang/go#18817
Change-Id: I045ac48441b9139cb0e01ceb4969b29cf5e72507
Reviewed-on: https://go-review.googlesource.com/36692
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This will be a package and server for working with Git, Github, and
Gerrit data.
Change-Id: I12c04d31c792d6cf752ce63b05a0b155d1f53f26
Reviewed-on: https://go-review.googlesource.com/36554
Reviewed-by: Kevin Burke <kev@inburke.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Windows installer will not broadcast WM_SETTINGCHANGE when a reboot is
pending. This message is required for explorer.exe to reload the PATH
from the registry so future cmd.exe processes will launch with go/bin in
the PATH.
Use the Wix extension to always broadcast this message after install.
More info:
http://wixtoolset.org/documentation/manual/v3/customactions/wixsettingchange.htmlFixesgolang/go#18680
Change-Id: I4f3af49f167f3875bbf8e898f4d50ee358b4e35d
Reviewed-on: https://go-review.googlesource.com/36324
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Brad Fitzpatrick
Kevin Burke
Yuval Pavel Zholkover
Benny Siegert
Chris Broadfoot
Jaana Burcu Dogan
Jeff Johnson