Fix an error where we are using the wrong "log" variable to log to
the console and where we are continuing to process a request after we
have written an error to the browser.
Change-Id: I3d37b7e7ef00cc2263072890be222340246f3ff3
Reviewed-on: https://go-review.googlesource.com/36128
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
CommentInput field is needed to post inline comments.
Fixesgolang/go#18830
Change-Id: I04a77621f0bbbc587bbeb2e050ac363c3bbc7cf5
Reviewed-on: https://go-review.googlesource.com/35991
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Per discussion on the mailing list we want to make this app run
on more environments than App Engine and hopefully with a backing
datastore that is just in-memory, or at the very least is not App
Engine specific.
Puts the datastore implementation detail behind an appengine build flag.
Adds an in-memory datastore if you are not running on App Engine; it's slow
since you have to fetch issues every time, but you can get all of the issues
and browse them. Adds a single test so we have the most basic of protections
against a regression.
Add a cmd/devapp main package so we can run the server outside of an
App Engine context.
Rename gg.Percentile to gg.Quantile to match the change in the latest
version of the downstream library.
Change-Id: Icbdef29676ecbf7078b0fb8c3920f61df60a5e2e
Reviewed-on: https://go-review.googlesource.com/34928
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Currently the Gerrit polling & git mirroring & serving & syncing
functionality is in the "watcher" process, which is in the same binary
as the cmd/coordinator (farmer.golang.org), but runs as a separate
process on that machine, and actually run in a separate Docker
container so it has a cache volume and the /usr/bin/git binary, etc. A
flag determines where func main delegates to: the build coordinator,
or the git mirror.
Start cleaning this up, in prep to run on Kubernetes as a separate service.
This copies the env/watcher-world/Dockerfile into a new gitmirror
Dockerfile, and copies the existing cmd/coordinator/watcher_process.go
into a new cmd/gitmirror/gitmirror.go process.
None of this is deployed or working yet. Once it's running and happy,
I'll then switch the coordinator to find & use it on GKE, and then
delete the old code.
Updates golang/go#18817
Change-Id: Ibaa87f244f08ce61662e689b815740c72c997536
Reviewed-on: https://go-review.googlesource.com/35911
Reviewed-by: Jaana Burcu Dogan <jbd@google.com>
Thanks to Benjamin Bytheway for pointing out its omission.
Change-Id: Iee53e3d77fe575d1bbde7f3bc0c4693d293857a2
Reviewed-on: https://go-review.googlesource.com/35845
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Also, make the Darwin builder start-up script add a cache buster to
the URL, so it actually fetches the latest buildlet binary when
rebuilt.
Change-Id: I948182b25d234474170a7c967804c1bfef3e3d99
Reviewed-on: https://go-review.googlesource.com/35846
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Moving all the Go bots and services everything to Kubernetes.
Change-Id: I811c370ea8b650e1553bab891325fee7e110f029
Reviewed-on: https://go-review.googlesource.com/35810
Reviewed-by: Kevin Burke <kev@inburke.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This is particularly useful for mode=json; this way, you can fetch
specific commits instead of having to page through results.
Change-Id: I756315e08665ba5b84a212384b01bdad26a6824d
Reviewed-on: https://go-review.googlesource.com/35790
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The second section of the template was removed from the default
kubeConfig and the Staging environment now has 32 cores instead of
16.
After this the only failing tests are in the devapp package and fixed
by CL 34928.
Fixesgolang/go#18769.
Change-Id: I719ee8368ce85ae6837b6df915bfa69753e24417
Reviewed-on: https://go-review.googlesource.com/35630
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Switch all API methods that make requests to Gerrit to take a
context.Context as their first argument. Adds a package example and
a simple test that we make requests to the correct endpoint and that
the Client can handle correct responses and error responses from the
Gerrit server.
Switches all code in the x/build tree to use the new Gerrit
client. There are several projects outside the tree that import
x/build/gerrit; I'll submit CL's against those to pull in the new
interface once this gets merged.
Documents that the API is unstable.
Fixesgolang/go#18742.
Fixesgolang/go#18743.
Change-Id: Ifa78cbb058981e23cf5769955f6312fcbe08e174
Reviewed-on: https://go-review.googlesource.com/35559
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
So it really builds an ARMv6 binary when GOARM=6.
Tried "release -rev go1.8rc2 -tools release-branch.go1.8 -version go1.8rc2 -target linux-armv6l -watch"
and the generated binary works on my Raspberry Pi 1.
Fixesgolang/go#18748.
Change-Id: I11113f98703049dc9990fe8c8abf505dcfd980f2
Reviewed-on: https://go-review.googlesource.com/35501
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Let's try this again with a release (candidate) that has a vioscsi
driver.
Update golang/go#8643
Change-Id: Ib438b506a2a2a3c9046a16bedb69da54fd81ab00
Reviewed-on: https://go-review.googlesource.com/35170
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The homepage linked only to the older godash package, when in reality
dev.golang.org is being served by the devapp package.
Adds a <title> to the page and adds closing </body> and </html> tags.
Change-Id: I71ee1e8739094c4cc8489d9759e5b3aabf610771
Reviewed-on: https://go-review.googlesource.com/34927
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The existing implementation of GetChangeDetail does not allow for
an optional QueryChangesOpt. QueryChangesOpt adds the ability to
pass options such as CURRENT_FILES and CURRENT_REVISION in order
to receive a more detailed ChangeInfo struct.
Change-Id: I7925e75821538b2720fff7d62c8404ed97e18791
Reviewed-on: https://go-review.googlesource.com/34922
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Adding ahead of the release so it's ready to go once the binaries land
and it's announced.
Change-Id: I04a68f5a6a50ae7a22df9cba14005237a276ffaa
Reviewed-on: https://go-review.googlesource.com/34913
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Changes for the new cloud.google.com/go/bigquery surface that came out a
couple of weeks ago.
Change-Id: I4e9d66c606df67fe24058e72665bde10bde5ca8d
Reviewed-on: https://go-review.googlesource.com/32444
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This permits a user with any halfway recent version of Go to run:
$ go get golang.org/x/build/version/go1.8beta1
$ go1.8beta1
go1.8beta1: not downloaded. Run 'go1.8beta1 download' to install to /home/bradfitz/sdk/go1.8beta1
$ go1.8beta1 download
Downloaded 0.0% (15225 / 90818333 bytes) ...
Downloaded 50.1% (45514752 / 90818333 bytes) ...
Downloaded 100.0% (90818333 / 90818333 bytes).
Unpacking /home/bradfitz/sdk/go1.8beta1/go1.8beta1.linux-amd64.tar.gz ...
Unpacked /home/bradfitz/sdk/go1.8beta1/go1.8beta1.linux-amd64.tar.gz.
Success. You may now run 'go1.8beta1'
$ go1.8beta1 version
go version go1.8beta1 linux/amd64
$ go1.8beta1 run ~/helloworld.go
Hello, world from go1.8beta1!
Updates golang/go#18136
Change-Id: I4297df19138facbf90dfab790ab30b942151b096
Reviewed-on: https://go-review.googlesource.com/34385
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Start of OpenBSD 6.0 builders. Not trybots yet, and don't have 386 yet.
Waiting on tmpfs resolution first, and then I'll delete the 5.8 builders.
Updates golang/go#16951
Change-Id: Ib9c68090d531344125ac5410e732ae0c664a0dc4
Reviewed-on: https://go-review.googlesource.com/34276
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The network configuration specified by the GCE DHCP server does not
work correctly on OpenBSD 6.0. Add a hack that reconfigures the
network using a 10.0.0.0/8 network with a high priority route.
Updates golang/go#16951
Change-Id: I8100f34ac48411c885478e72c083754e57c14aa7
Reviewed-on: https://go-review.googlesource.com/34172
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
We hit GKE bugs and changes when upgrading from GKE 1.2 to 1.4.
The main issue is that Kubernetes does't reserve CPU or memory for
itself on nodes, so things were OOMing and getting killed. And when
Docker or Kubernetes got killed themselves, they were wedging and not
recovering.
So we're going to run a daemonset (POD on all nodes) to reserve space
for Kubernetes for it. That's not in this CL.
But this CL got us limping along and was already in production. It
doubles resource RAM usage for jobs, so fewer things schedule per node.
While we're at it, let jobs use more CPU if it's available.
Also, disable auto-scaling. It was off before by hand. Force it off
programatically too. And make the node count 5, like it was by hand.
Also, force un-graceful pod deletes, since GKE 1.3 or something
introduced a graceful-vs-ungraceful distinction, which we weren't
handling previously and therefore pods never were being deleted.
Change-Id: I3606e4e2e92c496d8194503d510921bd1614d34e
Reviewed-on: https://go-review.googlesource.com/33490
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
On the plan9-386 builder, the cmd/go tests sometimes
take a little more than 3 minutes to complete.
We set GO_TEST_TIMEOUT_SCALE=2, so the cmd/go tests
doesn't time out anymore.
Updates golang/go#18047
Change-Id: I16ce26917ee785ebed8ad16e0370d575a0fdd638
Reviewed-on: https://go-review.googlesource.com/33774
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Elias Naur
Kevin Burke
haya14busa
Brad Fitzpatrick
Chris Broadfoot
Quentin Smith
Cherry Zhang
Benny Siegert
shawnps
Jonathan Amsterdam
Russ Cox
Daniel Theophanes
Joel Sing
David du Colombier