Remove the requirement for a final release to have an RC, since
point releases may not have one.
Additionally adds some error logs when running ./make.bash
Change-Id: If52d19d01e9e2a49c16d9b55c782bd922637292b
Reviewed-on: https://go-review.googlesource.com/89037
Reviewed-by: Russ Cox <rsc@golang.org>
Add an android/386 and an android/amd64 builder, both running on an
emulator. Use the new GOANDROID_ADB_FLAGS to direct the build to
either a device (android/arm, android/arm64) or an emulator
(android/386, android/amd64).
Change-Id: I8e25aa5efcbbb186c71c4e108a37ae11b0246c98
Reviewed-on: https://go-review.googlesource.com/88775
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
+ Switch to alpine linux as the base container for the
Docker image so that git and curl can be easily installed
+ Remove ca-certificate copying since alpine has the cert
+ Although the git committer must remain GerritBot in order
for the gitcookies auth to work, this will cause the original
author to be CC’d on the Gerrit change and the proper owner
will be attributed in the git history
+ Download the git http cookies file from GCE metadata to
properly authorize GerritBot to upload changes
Update golang/go#18517
Change-Id: I3acc7323c8f1b35ed2145f610cb03fbcd29dcdf4
Reviewed-on: https://go-review.googlesource.com/88615
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
When a Gerrit change moves into a "closed" state (merged or abandoned),
close the linked GitHub Pull Request with the appropriate message.
If the change has been merged, there is no need to mention the commit
in the message on the PR because the commit message will be linked
from the PR by virtue of the GitHub-Pull-Request: git label. See
https://github.com/golang/scratch/pull/2#issuecomment-358105675 for
an example.
Closed changes are also be cleaned up within b.pendingCLs.
Also removes a nil pointer dereference in the case where the
Gerrit CL does not exist yet, surmising its link from the output
of the push command.
Updates golang/go#18517
Change-Id: Ieb28c1b9d31216d48076b256bf6a65a099a38552
Reviewed-on: https://go-review.googlesource.com/87915
Reviewed-by: Ian Lance Taylor <iant@golang.org>
*github.PullRequest has since introduced the method GetBase(),
which we rely on.
Change-Id: I198eb7771ee6bd70e9e7de801e4369f6abfde435
Reviewed-on: https://go-review.googlesource.com/87597
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
It’s not present on all platforms
Change-Id: Icbb5525084c9a5dbe5b429363729c406ed326478
Reviewed-on: https://go-review.googlesource.com/87396
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Adds an Owner() method to GerritCL that returns the GitPerson author of
the Gerrit change’s first commit, which is how Gerrit assigns the owner.
Updates golang/go#18517
Change-Id: I27cf185d5c68db44732170d583f1851491f2d8a3
Reviewed-on: https://go-review.googlesource.com/87157
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Additionally, changes the behavior to squash commits automatically
to better support GitHub user workflows.
Updates golang/go#18517
Change-Id: I4aa9cb1b88b6a78759f2fb56603e8cf1b055eb13
Reviewed-on: https://go-review.googlesource.com/87022
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
There's no point to keeping this in releases.
It probably shouldn't be created at all, but since it is,
delete it.
Change-Id: Id82cb7412ac22260a507877dcf9bbec90667a224
Reviewed-on: https://go-review.googlesource.com/82095
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
CL 73334 limited the number of files listed during a push, but there is
an offf-by-one. Only 4 files are listed, but the messages says "only
showed 5". Fix the check such that 5 files are listed.
Before:
2018/01/03 09:39:11 Remote doesn't have "src/cmd/vendor/github.com/google/pprof/internal/symbolizer/symbolizer_test.go"
2018/01/03 09:39:11 Remote doesn't have "src/regexp/example_test.go"
2018/01/03 09:39:11 Remote doesn't have "src/runtime/debug/stubs.go"
2018/01/03 09:39:11 Remote doesn't have "src/runtime/defs_netbsd_386.go"
2018/01/03 09:39:11 Remote doesn't have 7245 files (only showed 5).
After:
2018/01/03 10:19:28 Remote doesn't have "src/cmd/vet/testdata/shift.go"
2018/01/03 10:19:28 Remote doesn't have "src/syscall/ztypes_linux_mips64le.go"
2018/01/03 10:19:28 Remote doesn't have "src/os/os_unix_test.go"
2018/01/03 10:19:28 Remote doesn't have "src/runtime/duff_amd64.s"
2018/01/03 10:19:28 Remote doesn't have "src/runtime/rt0_dragonfly_amd64.s"
2018/01/03 10:19:28 Remote doesn't have 7079 files (only showed 5).
Change-Id: I0a2fa401883b609727a5bf3d72bac3d242bdecbd
Reviewed-on: https://go-review.googlesource.com/85757
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
GithubIssueEvent added three new fields: Requested Reviewer, Review
Requester, and Dismissed Review. Parse these fields from the API JSON
and also handle them in the Protobuf file.
Fixesgolang/go#23151.
Change-Id: I07f2004f300223045636c3e32027468b29dd6329
Reviewed-on: https://go-review.googlesource.com/84375
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Demonstrate how to load data from a network source and how to load
data from a local disk source.
Change-Id: I1710eca8a1b3be7b7f7458de6aa5d3372934450a
Reviewed-on: https://go-review.googlesource.com/84377
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Additionally:
+ Check that git-codereiew is installed or exit
+ Use fully qualified git-codereview commands (don't
assume the user has installed the aliases)
Change-Id: Iaeaa28affec06d58b90ec295120169fd945edf90
Reviewed-on: https://go-review.googlesource.com/84615
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The slow test directory was previously skipped in 7b0a998e (CL
82395) for the slower + VM builders, but I forgot Windows XP.
The test directory is slow and doesn't have port-specific code. It's
mostly low-level compiler tests. We can safely skip it on most
builders, especially the slow & scarce ones.
Change-Id: I5c830509628e7eb1ab9649d31a47970afe135c33
Reviewed-on: https://go-review.googlesource.com/84335
Reviewed-by: Andrew Bonventre <andybons@golang.org>
The .[56789] extentions are no longer used since Go 1.5. and the
object files are already covered by isGitIgnored.
Change-Id: I0f2fe2bc248a8a3f0b2bdc1b59dd31f2242a6797
Reviewed-on: https://go-review.googlesource.com/83695
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
We want to pass this down to the coordinator so each
dashboard.BuildConfig can have its own policy on which branches to
build. For example, we'll have NetBSD skip building subrepos for Go
versions that are too old.
Updates golang/go#23102
Change-Id: I40d35c9c5a6d4455772430c169dbea054929545e
Reviewed-on: https://go-review.googlesource.com/83536
Reviewed-by: Andrew Bonventre <andybons@golang.org>
The EDITOR env var is set to true to prevent git commit --amend
from pulling up an editor. Use the --no-edit command instead since
the desired behavior is the same only without the hack.
Change-Id: I29df9a566669ce56605169014b9e534b15811368
Reviewed-on: https://go-review.googlesource.com/83335
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Add *GitHubIssue.HasLabelID method to maintner API.
Since the text will change to “help wanted”, adjust the logic to
make it a bit more future-proof.
Updates golang/go#22329
Change-Id: I22e9f06d6e2aca8ae4da31532f9cde2317a709ff
Reviewed-on: https://go-review.googlesource.com/83297
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Verified it now ups it:
2017/12/07 21:27:03 initial NOFILE rlimit: {Cur:128 Max:1024}
2017/12/07 21:27:03 updated NOFILE rlimit: {Cur:7030 Max:7030}
Not sure why it caps out at 7030 instead of the requested 32k, but
better than 128.
Change-Id: Ic9d12673ebfd1a584215f7c3e4a3d2496412ae2e
Reviewed-on: https://go-review.googlesource.com/82815
Reviewed-by: Ian Lance Taylor <iant@golang.org>
We used to do this only by necessity on Sierra, due to Sierra issues,
but now that x/build/cmd/makemac is better, we can just do this all
the time. Doing it always is better anyway, to guarantee fresh
environments per build.
Also add the forgotten sudo in the Mac halt. The
env/darwin/macstadium/image-setup-notes.txt even calls out how to
setup password-free sudo to the images, but then I forgot to use it.
It only worked before (if it did?) because the process ended and
failed its heartbeat, at least some of the time. It's also possible it
was never working. The old reason that Sierra machines were
special-cased to reboot was reportedly fixed anyway, in
https://github.com/golang/go/issues/18751#issuecomment-343175368.
Updates golang/go#9495
Change-Id: Iea21d7bc07467429cde79f4212c2b91458f8d8d8
Reviewed-on: https://go-review.googlesource.com/82355
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This adds a darwin-amd64-race builder. Of the four platforms that
support the race detector, this was the only one missing a builder.
To make up for the extra work, skip some redundant tests that the Mac
(and other) builds do. The test directory is really slow, and doesn't
have platform-specific code. We have amd64 & 386 test coverage for
that directory via the Linux builders, which is fine. No need to do it
on some of the heavier VM builders, or for trybots.
Fixesgolang/go#17674
Change-Id: I888119b3fdd28884b87a59d78746ab1fef6960c7
Reviewed-on: https://go-review.googlesource.com/82395
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also update the bootstrap toolchain (verified in VMware VM locally).
Updates golang/go#20852
Change-Id: Iac875419ed8dc51fb9db09d8948067f24c601e17
Reviewed-on: https://go-review.googlesource.com/82018
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Until issues are fixed. No point in wasting resources on column of
red.
Updates golang/go#22968
Change-Id: I2de5a4d8aca6fcbdab2f43d87818c7d8f333f8bc
Reviewed-on: https://go-review.googlesource.com/81637
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Otherwise, post a message to the PR saying that the commits must
be squashed into one.
Updates: golang/go#18517
Change-Id: I800ef7283224cae81bc04ba6d395585c412d3fbd
Reviewed-on: https://go-review.googlesource.com/81116
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also clean up some redundant comments, move trybots from OpenBSD
6.0 to 6.2, and add some missing MaxAtOnce caps.
Updates golang/go#20852
Change-Id: I3d862ca7a7172952ec2254b583e4bf6102b026e6
Reviewed-on: https://go-review.googlesource.com/80876
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Due to maintner’s async nature, there is a period of time where
a Gerrit change may exist for a Pull Request but it is not reflected
in the corpus. Account for this by keeping an in-memory map of PRs
with stale data, and query Gerrit (should that map be incorrect due
to a restart) before creating a new change.
Update: golang/go#18517
Change-Id: Ife142697b15269caca088c3616c4acd4b227bfeb
Reviewed-on: https://go-review.googlesource.com/80840
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
We had a bunch running for weeks and months with no "delete-at" field.
I'm not sure why. Perhaps related to gomote instances.
I need to debug that more and dig into git history, but for now clean
them up.
Change-Id: I7bde12357fbe2daa5f75d62e720b94028a0be6b5
Reviewed-on: https://go-review.googlesource.com/80655
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Andrew Bonventre
Elias Naur
Caleb Spare
Brad Fitzpatrick
Russ Cox
Tobias Klauser
Kevin Burke