This adds a builder for the GOEXPERIMENT=regabi configuration of the
compiler. We'll want this builder until we enable regabi by default.
Update comments and buildsRepo test, since it's now merged with master.
Updates golang/go#40724.
Change-Id: I424ca7bf6243e6b4660f4ec54c248a1813b3a83d
Reviewed-on: https://go-review.googlesource.com/c/build/+/305849
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
This sets the GO_TEST_TIMEOUT_SCALE=2 for ppc64 builders. The
runtime tests have been timing out intermittently on ppc64le
power8; it has happened on ppc64 and ppc64le power9 but
very rarely.
Updates golang/go#44422
Change-Id: I663f3f211a368a59e38fbff9ce43c925c6c7a209
Reviewed-on: https://go-review.googlesource.com/c/build/+/300870
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
This improves the selection of slowbot aliases for ppc64.
Updates golang/go#42067
Change-Id: I180fe2f49a1e44c422e64c311e601dd93b07f7a7
Reviewed-on: https://go-review.googlesource.com/c/build/+/301769
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
Some of README.md files were initially generated by update-readmes.go,
but later had some additional information appended. Re-running update-
readmes.go blasts away those changes, and requires manually reverting
the deletions. This makes it expensive to re-run update-readmes.go to
add new READMEs or update existing ones.
Solve this problem by adding support for a special "<!-- End of auto-
generated section -->" comment and making update-readmes.go preserve
any content after it.
After this change, re-running update-readmes.go produces a zero diff.
Also set the working directory when using build.Import so that packages
inside nested modules work okay.
Add the missing first word 'Package' to ./internal/datastore/fake doc.
Change-Id: If7ba92a297eebeec8029d48d760acb1daa7f263e
Reviewed-on: https://go-review.googlesource.com/c/build/+/300229
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
We can drop the 32-bit and 10.11 macOS builders, they're unused.
Remove FreeBSD 11.1 builder, it's unused.
Update freebsd-amd64-race to use the latest available FreeBSD builder.
Simplify build policy and comments, removing anything that mentioned
Go version 1.14 or older, since they're not relevant anymore.
Drop Go 1.14 support from minSupportedMacOSVersion, and add support
for the future Go 1.17 release, which will increase minimum macOS
version requirement to macOS 10.13.
Fixesgolang/go#40562.
Change-Id: I7beeec0952a516afe99a5154b22c7f25ceeb3da1
Reviewed-on: https://go-review.googlesource.com/c/build/+/293771
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The Go 1.17 tree has started adding the windows/arm64 port.
Change-Id: Id9557160704688feea3667d5b18b0a37371aa0cd
Reviewed-on: https://go-review.googlesource.com/c/build/+/293772
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change adds macOS 11.0 Big Sur builder to the dashboard. It will
not spawn an instance on the older MacStadium cluster which we are
migrating away from. It will be marked with a known issue until until
we have migrated away from the old cluster and makemac has been
updated to process the new macOS versioning convention.
Updates golang/go#40762
Updates golang/go#40757
Updates golang/go#40761
Change-Id: I24ce615a2c0c55dd75beed4f821119d4058ad8af
Reviewed-on: https://go-review.googlesource.com/c/build/+/288192
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The goal in CL 279512 was to reduce numTryTestHelpers from 5 to 4,
but it unintentionally set the field only in the 386 builder, not
the amd64 one. This caused the amd64 OpenBSD TryBot to get very
slow (20-25 minutes), making it very much a bottleneck for overall
TryBot completion time.
Also stop explicitly setting some fields in openbsd-amd64-62
builder that have no effect by now, to simplify configuration.
For golang/go#17104.
Updates golang/go#35712.
Change-Id: I22823e4848cab65f11bde2a1cc70527929d0792d
Reviewed-on: https://go-review.googlesource.com/c/build/+/279723
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Based on the data we have so far, 4 helpers seems like a good number
to pick. It provides a balance between resource use and diminishing
returns. We may need to adjust it as future work for issue 42661,
but a first step will be to reduce overhead in accessing historical
build timing data.
Fixesgolang/go#37439.
Updates golang/go#42661.
Change-Id: I1bfddf85f2dba8b42dc7b8f8749bbf45b614e93d
Reviewed-on: https://go-review.googlesource.com/c/build/+/279513
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The known issue with OpenBSD 6.8 builders appears to be resolved
via CL 278732 and CL 279134. Promote them to the primary OpenBSD
post-submit builders and TryBots.
Having test coverage from OpenBSD 6.8 and 6.4 builders gives us
us more confidence that Go works on supported OpenBSD versions
(which are 6.8 and 6.7 at this time, per past policy decision
in https://golang.org/issue/15227#issuecomment-293319876).
Reduce numTryTestHelpers from 5 to 4 based on some data from
golang.org/issue/37439 showing that going from 3 to 5 helpers
doesn't make a significant difference. We can adjust further
if we learn that OpenBSD TryBots become the bottleneck.
Fixesgolang/go#35712.
For golang/go#42542.
For golang/go#42064.
Updates golang/go#42426.
Change-Id: Id2fa4be7c3161f89752c1428146846fe06ca63db
Reviewed-on: https://go-review.googlesource.com/c/build/+/279512
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
This adds a builder for the GOEXPERIMENT=regabi configuration of the
compiler. We'll want this builder until we enable regabi by default.
Updates golang/go#40724.
Change-Id: Ib1c7ae1e914116dd8a4440db8ee46d6af3ed1ad6
Reviewed-on: https://go-review.googlesource.com/c/build/+/279673
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
These images were regenerated after the fix in CL 278732.
For golang/go#35712.
Updates golang/go#42542.
Updates golang/go#42426.
Change-Id: Ib9c9dc316e4f68e7fed2cafe5400942a94ba8fd2
Reviewed-on: https://go-review.googlesource.com/c/build/+/279134
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Joel Sing <joel@sing.id.au>
The builder successfully passes all.bash and produces binary releases.
Updates golang/go#42756Fixesgolang/go#39782
Change-Id: I554a1e3541d185958103e11dcc4b2514445d8275
Reviewed-on: https://go-review.googlesource.com/c/build/+/278772
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The openbsd/mips64 port is now functional and stable.
Fixesgolang/go#40995
Change-Id: I959e6ab53777a3e048d89434f60aec365b0900b4
Reviewed-on: https://go-review.googlesource.com/c/build/+/275333
Trust: Joel Sing <joel@sing.id.au>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
These builders are run by the Go team. They are non-hermetic.
For golang/go#39782
Change-Id: Ie402faf9a92ff6c667c8da6fc0dac8528331df48
Reviewed-on: https://go-review.googlesource.com/c/build/+/278432
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
update-readmes.go is updated to add a pkg.go.dev badge instead of a
godoc.org badge.
The GoDoc badge is added or changed in all READMEs by running
update-readmes.go
For golang/go#42251
Change-Id: I0c49df26a6c695f938c98c9a7b26325d991b3cfb
Reviewed-on: https://go-review.googlesource.com/c/build/+/276032
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This CL changes the owner for host-linux-s390x as
Michael will be leaving IBM at the end of this week.
See https://groups.google.com/g/golang-dev/c/obUDaYbaxXw.
Change-Id: Ic140743387cff02be7c0471f803c5a30d812d0c3
Reviewed-on: https://go-review.googlesource.com/c/build/+/274512
Reviewed-by: Michael Munday <michael.munday@live.co.uk>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Michael Munday <michael.munday@live.co.uk>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
See https://golang.org/issues/40561#issuecomment-731482962
for the plan description and rationale.
Add new builder definitions that are needed for the plan.
Don't rely on generic builder name like "linux-amd64" to
avoid a repeat of golang.org/issue/31293; use a specific
builder name instead.
Remove support and test cases for Go 1.13, it's unsupported
per release policy.
For golang/go#40561.
Change-Id: I070744e15be9f1932d649a27ee7e4599e467553f
Reviewed-on: https://go-review.googlesource.com/c/build/+/276034
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This builder has very slow I/O and could benefit from some extra time on
a few tests. At the moment, the tests for x/review/git-codereview are
failing with a time out, for example.
Updates golang/go#42925.
Change-Id: I532f4ddd3b9e7fd0a66ea9631b3fa7ce363e05a4
Reviewed-on: https://go-review.googlesource.com/c/build/+/274572
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
We originally left the issue attached to the builder, before we knew
that it worked. But it appears to be working well, with no shortage of
work to do from farmer.
Fixesgolang/go#38607.
Change-Id: I0e654c825a92b64132efbc409b768e5e83967802
Reviewed-on: https://go-review.googlesource.com/c/build/+/273786
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds the netbase package to the host. The netbase package
includes several components necessary for TCP/IP based networking.
Network related unit tests were failing on builders using this host
without this package.
Fixesgolang/go#42750
Change-Id: Id98d46efac4fe98ecf475035218be181c3d8dec0
Reviewed-on: https://go-review.googlesource.com/c/build/+/272486
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds a Debian Buster builder.
Fixesgolang/go#42410
Change-Id: If11ebe6df3bad88aac40b0a6f841edc5fb3a5b4a
Reviewed-on: https://go-review.googlesource.com/c/build/+/267937
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This partially reverts CL 229559, while adjusting it to use a new
builder. The builder will be used now for windows/arm and later for
windows/arm64.
Updates golang/go#42604.
Updates golang/go#38607.
Updates golang/go#36439.
Change-Id: I1ab661a6585e64de8196955c077715b32dc732b8
Reviewed-on: https://go-review.googlesource.com/c/build/+/272106
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Alex Brainman <alex.brainman@gmail.com>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
The linux-arm-aws builder was initially labeled with a known issue
because it was experimental. The builder has been tested and is no
longer considered experimental.
Fixesgolang/go#41867
Updates golang/go#40872
Updates golang/go#35628
Change-Id: I61f43f2c2651c26d3f5d4db01b779686ddb6a92b
Reviewed-on: https://go-review.googlesource.com/c/build/+/270517
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change builds on top of CL 268297, using the updated env script
to build OpenBSD 6.8 images, and adding new builders that use them.
This has been tested with cmd/debugnewvm on a recent Go tip commit,
as well as Go 1.15.4 and 1.14.11 commits. It passed, although there
were also some failures seen. Once the builder is added, we'll know
the test results for a wider set of commits, and can decide how to
proceed from there.
Minimize the configuration to a bare minimum. Specifically, remove
MinCPUPlatform since setting it "Intel Skylake" was found not to
have a noticeable effect on the speed of the build compared to the
zero value:
# With MinCPUPlatform = "Intel Skylake":
$ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4
[...]
real 17m8.308s
# With a zero MinCPUPlatform value:
$ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4
[...]
real 16m28.518s
For golang/go#35712.
Updates golang/go#42426.
Change-Id: I517a85738a034a3a4074488ccecd4408a91a4a07
Reviewed-on: https://go-review.googlesource.com/c/build/+/269577
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
For golang/go#42426.
Change-Id: Id8a87ef1952291e06f0076f27ae019bf7ef0e6a2
Reviewed-on: https://go-review.googlesource.com/c/build/+/268880
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change adds the linux-arm-aws builder. This builder will be
started on a EC2 instance which will spawn a single instance
of the container. After the builder work is done, the instance will be
destroyed.
Updates golang/go#41867
Change-Id: I09d911c2f99d1dff8fe02feb458457e07e7d0cdd
Reviewed-on: https://go-review.googlesource.com/c/build/+/260797
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The longtest builders are currently primarily post-submit builders,
where it's okay for them to be as slow as they need to be in order
to provide additional test coverage. In this context, whether they
take 40 minutes or 50 makes little difference.
The longtest builders are also sometimes requested via SlowBots for
changes that are riskier than usual, or otherwise desire additional
coverage beyond the normal TryBots. They're also always enabled for
CLs to release branches. In such contexts, speeding up SlowBot runs
from 40 minutes to 20 or less would be appreciated and in turn help
people use longtest SlowBots more frequently.
Longtest builders are already configured to use sharded tests.
Configure them to use additional helpers to speed up test execution.
Try out 3, 5, and 9 helpers to see how much it helps before settling.
For golang/go#37439.
Change-Id: I425bc0257b7a54bb32c0eb1719fea7ba3f4fd461
Reviewed-on: https://go-review.googlesource.com/c/build/+/268037
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Testing shows that misc-compile-darwinarm64 is working as expected
on recent commits. Promote it to a normal misc-compile TryBot now,
with the exception that it needs to run on Go 1.16 and newer only.
Fixesgolang/go#42341.
Change-Id: Ib4de19a2ff904fb9de056db5076ac63690eb934c
Reviewed-on: https://go-review.googlesource.com/c/build/+/267123
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Create the builder as a post-submit builder with a non-zero KnownIssue
value first. Once we know it works well, we'll have the confidence to
be able to safely promote it to a normal TryBot, without the risk of
causing disruption for contributors.
It's different from misc-compile-darwin since it needs to run on recent
Go 1.16 commits only.
For golang/go#42341.
Change-Id: I67170988d7323cb73439755a3961532c668040e7
Reviewed-on: https://go-review.googlesource.com/c/build/+/267105
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change updates which source ami is used as a base for the
creation of the linux-arm64-aws builder. Packer will now search for
the latest version of the arm64 Debian image to use as the source ami.
For golang/go#36841
Change-Id: I036dbaf7ee65d4e7028cd6a0cdf6710bf898fdd2
Reviewed-on: https://go-review.googlesource.com/c/build/+/266697
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Corellium recently wiped the existing virtual iPhone and Android
builders because of a cloud provider switch. This change reflects
the updates to the setup scripts matching newer Corellium software.
Bump the expected builders numbers to reflect the increased capacity.
Change-Id: I93196dd22b81e66cb2cad82b1ef3dcff64e852d8
Reviewed-on: https://go-review.googlesource.com/c/build/+/266377
Run-TryBot: Elias Naur <mail@eliasnaur.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Elias Naur <mail@eliasnaur.com>
It's known there is no builder for it yet.
Skip it so that TestSlowBotAliases passes.
For golang/go#42177.
Updates golang/go#42100.
Change-Id: I5f1a6b17e6aa4b57cbdea44f2eeb1d4817e5f67f
Reviewed-on: https://go-review.googlesource.com/c/build/+/264738
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Also use this as the riscv64 slowbot, since linux-riscv64-unleashed has
been MIA for quite some time.
For golang/go#27532
Change-Id: I01309a66b96d4c35dbc9d1e08f55f5357b0acba0
Reviewed-on: https://go-review.googlesource.com/c/build/+/257917
Trust: Joel Sing <joel@sing.id.au>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Update golang/go#40995
Change-Id: Ie733438ab1823d65109e684a6a5e3098cdfdb252
Reviewed-on: https://go-review.googlesource.com/c/build/+/250118
Trust: Joel Sing <joel@sing.id.au>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Update golang/go#31656Fixesgolang/go#34035
Change-Id: I7e3d20be148ad5111efeb78702352da14274938e
Reviewed-on: https://go-review.googlesource.com/c/build/+/250117
Trust: Joel Sing <joel@sing.id.au>
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The builder is producing expected results.
Fixesgolang/go#41840.
For golang/go#41848.
Change-Id: I08de0457b5ead7ac5dcc15edb95517f0f3e377fe
Reviewed-on: https://go-review.googlesource.com/c/build/+/261097
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
The dashboard is green.
Fixesgolang/go#41610
Change-Id: If2d7c8457b08b3e6d39f54e5b991b06c88019061
Reviewed-on: https://go-review.googlesource.com/c/build/+/259579
Trust: Elias Naur <mail@eliasnaur.com>
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
It's based on the linux-386-387 builder, but with GO386=softfloat
and Debian 9 (stretch) instead of Debian 8 (jessie).
Test it on a subset of golang.org/x repos (golang.org/x/crypto),
since that should provide sufficient test coverage.
For golang/go#41840.
For golang/go#41848.
Change-Id: Ida95fce198056a05c359ac5ab816c582bdd5930f
Reviewed-on: https://go-review.googlesource.com/c/build/+/260201
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Go 1.13 was the last release with nacl, and it's not supported by now.
For golang/go#30439.
Change-Id: Ic690aa388ab4505d5e755bbe40fed850a7300c69
Reviewed-on: https://go-review.googlesource.com/c/build/+/260200
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change adds the use of TLS certificates when connecting to a
remote buildlet via port 443. This change only applies to the
ConnectSSH, all other remote buildlet connections already use the TLS certificate.
Fixesgolang/go#41697
Change-Id: Ibc3e85edb562c42c9da2b1025f4b291b4a88deaa
Reviewed-on: https://go-review.googlesource.com/c/build/+/258097
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Also update some test cases to be more relevant.
For golang/go#40255.
Fixesgolang/go#41799.
Change-Id: Ie63e068a46058bcaf7866f2090049fb888612cbe
Reviewed-on: https://go-review.googlesource.com/c/build/+/259449
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
There are no tethered iOS builders left. If we add some in the future,
they should use all.bash directly.
Change-Id: Ieef7454af706c7e99c0d10fc37a337fb2c3ba130
Reviewed-on: https://go-review.googlesource.com/c/build/+/259357
Run-TryBot: Elias Naur <mail@eliasnaur.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Elias Naur <mail@eliasnaur.com>
Since sending CL 257617, I've learned that iOS was never a supported
target for misc-compile. It was always filtered out unconditionally
in GOROOT/src/buildall.bash, and the comment suggesting that we test
iOS targets was inaccurate.
Remove the naive misc-compile-ios builder since it's not expected to
start working soon, and update misc-builder architecture filtering
code and comments to match the current reality better.
After this change, it will be viable to remove mobile target filtering
from GOROOT/src/buildall.bash. If that's done, then x/build/dashboard
will become a centralized place for all misc-builder target selection.
Ignore darwin-arm in TestTryBotsCompileAllPorts so the test doesn't
fail when executed with Go 1.14. Not having that builder is intended.
For golang/go#41610.
Updates golang/go#25963.
Change-Id: Ic6f5dc95edb67f8e6ebc0a77979e55eb0cc325cb
Reviewed-on: https://go-review.googlesource.com/c/build/+/258057
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Create the builder as a post-submit builder with a non-zero KnownIssue
value first. Once we know it works well, we'll have the confidence to
be able to safely promote it to a normal TryBot, without the risk of
causing disruption for contributors.
For golang/go#41610.
Change-Id: If871addf325b7728109afbe094b72d40e27ceec1
Reviewed-on: https://go-review.googlesource.com/c/build/+/257617
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
We are aware that a builder is missing, and have the tracking issue
golang.org/issue/41610 for resolving that. Add a skip to the tests
so that the build dashboard is green until the work of adding the
builder is complete.
For golang/go#41610.
Change-Id: I69dbeb4c28d5567f24b4570f44715d8b5443365f
Reviewed-on: https://go-review.googlesource.com/c/build/+/257117
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
This change sets the default module proxy address for EC2 builders.
EC2 builders should have the same proxy address set as reverse builders.
Fixesgolang/go#40914
Change-Id: I4de2ed178170f60fdbe4e2f9aa6f024bb43ee020
Reviewed-on: https://go-review.googlesource.com/c/build/+/249577
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The current linux-arm builder is known to have trouble when used as
a SlowBot. Start warning about it when the builder is requested via
the TRY= SlowBot UI.
I've considered also removing or disabling the "arm" SlowBot alias,
but that would make it easier to miss that there's an issue, since
SlowBots don't warn about unknown builders:
If you specify an unknown TRY= token, it'll just ignore it
and won't report an error.
We can consider making further changes as this situation evolves.
The goal here is to start notifying about a known problem sooner.
For golang/go#35628.
For golang/go#40872.
Change-Id: Ibc1205720c44ec4823c632c04fc2f887368258c1
Reviewed-on: https://go-review.googlesource.com/c/build/+/249420
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Add the host-linux-arm64-aws builder. The HostConfig IsVM method has
been modified to support the concept that an EC2 VM can be created
which runs the buildlet binary in a container. This configuration
would have both a VM image and a container image set in the host
configuration.
For golang/go#36841
Change-Id: I092b48b1dda24d24bcd0b10dff0b2126f5f43017
Reviewed-on: https://go-review.googlesource.com/c/build/+/249118
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
FreeBSD 9.3, FreeBSD 10.x, and OpenBSD 6.0 have
reached end-of-life and are no longer supported.
Go 1.12 was the last release¹ that ran on FreeBSD 10.x.
Go 1.10 was the last release² that ran on OpenBSD 6.0.
These builders have long since been disabled and won't be needed in
the future, so remove them. This work helped detect golang/go#40563.
Modify TestHostConfigsAllUsed to report errors instead of warnings
when it finds unused host configs. Make a map of known exceptions
with rationale or a linked issue for each entry.
¹ https://golang.org/doc/go1.12#ports
² https://golang.org/doc/go1.10#ports
Updates golang/go#36841.
Updates golang/go#19938.
Change-Id: Id7fcdc671bfacf7e70174f4168c9c9cc46ba53d7
Reviewed-on: https://go-review.googlesource.com/c/build/+/246639
Reviewed-by: Alexander Rakoczy <alex@golang.org>
These builders are still used for making minor Go 1.14 and 1.13
releases at this time (see golang.org/issue/40563). Re-enable
them on relevant release branches so that we are better informed
for future minor releases.
For golang/go#40563.
Updates golang/go#40562.
Change-Id: I20a6becbdb1078b92dbf6042edca7f482bca6432
Reviewed-on: https://go-review.googlesource.com/c/build/+/246638
Reviewed-by: Carlos Amedee <carlos@golang.org>
The defaultBuildsRepoPolicy function was very important in that any
changes to it would affect many builders, but it was not documented
well.
This refactor attempts to improve the situation. It turned out better
to also rename defaultBuildsRepoPolicy to buildRepoByDefault and limit
its scope to report whether a given repo should be built by default.
The branch and goBranch parameters were never used, and thus misleading.
If they're needed in the future, we can easily re-add them.
The name defaultBuildsRepoPolicy made it sound as if it was the entire
"builds repo" policy, bun reality most of the policy is implemented in
the BuildConfig.buildsRepoAtAll method and is non-configurable. Only a
small part of the policy was in defaultBuildsRepoPolicy.
For golang/go#39156.
Change-Id: Ie7c6a68bd624056362dc7d964bd8d640f665b35a
Reviewed-on: https://go-review.googlesource.com/c/build/+/240687
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Both golang.org/x/exp and golang.org/x/mobile are experimental,
and do not support the linux/386 port. Stop running post-submit
longtest builds on it. If support for linux/386 is added, tests
should start to pass and the builder can be re-enabled then.
It appears to have been enabled previously due to a misconfiguration
rather than on purpose.
Fixesgolang/go#39156.
For golang/go#29641.
For golang/go#11811.
Change-Id: I12437880380b9015f6ed9d584db11717f4f024e6
Reviewed-on: https://go-review.googlesource.com/c/build/+/240512
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This updates the instruction for creating a VM image and
a buildlet container image. The instructions will provide
a better description for the steps required to create the images.
The VM image has been updated to no longer require sudo when
the docker command is executed.
The host configuration has been updated with a new VM type and
VM image.
The rundockerbuildlet service configuration has been modified:
* The memory limit has been removed because rundockerbuildlet will
now use all of the available memory for buildlets running on AWS.
* The service will report as running even after rundockerbuildlet has
exited. Rundockerbuildlet will initiate a single buildlet and then exit.
* The service will not be restarted after rundockerbuildlet has exited.
Changes made to rundockerbuildlet which required these changes have been
made in CL 234114.
Updates golang/go#36841
Change-Id: I3ff51e414b11a2b1427cbd7c6e24e9135fc2a5c3
Reviewed-on: https://go-review.googlesource.com/c/build/+/236297
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The purpose of the -race builder is to check for bugs on the Go side,
so use the newer available Windows version with the expectation that
there should be fewer unfixed bugs left in it.
Take this easy step to eliminate a variable for issue golang/go#39196.
Also delete host-windows-amd64-2008-big, since it's no longer used.
For golang/go#39196.
Change-Id: I9095a73ab21a151e5972219bccd5a16b249765b4
Reviewed-on: https://go-review.googlesource.com/c/build/+/235419
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The goal of this test policy change is to decrease the chance of a
Go repository release branch from getting into a state where some
longtest post-submit builders are failing, as this will interfere
with the ability to issue releases after golang/go#29252 is fixed.
There are not that many CLs sent to release branches, so the extra
latency caused by slower longtest builders being a part of trybots
should not be very disruptive.
For golang/go#37827.
For golang/go#29252.
Change-Id: I819b120bb7b763df4acf4583375cdb840793d323
Reviewed-on: https://go-review.googlesource.com/c/build/+/235338
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This test data will be modified to match a change in behavior
in the next commit. Update it to a supported Go version first.
For golang/go#37827.
Change-Id: I83ad967a11f0fdde454edc541e9a8e7cf061f0e0
Reviewed-on: https://go-review.googlesource.com/c/build/+/235337
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The linux-386-longtest builder was added in CL 202479 with these
environment variables unset, which caused the builder to run long
tests for the linux/amd64 pair. Setting these to "386" makes the
builder run long tests for linux/386 instead, which increases
32-bit test coverage as originally intended.
For golang/go#29641.
Change-Id: I9fbebc9e37e5f27f21d840d86006192daeaee8c5
Reviewed-on: https://go-review.googlesource.com/c/build/+/234520
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Previously, it was possible to define a builder whose IsLongTest method
would report positively, such that it'd test golang.org/x repos in long
test mode, but the main Go repository in short test mode. This would be
the case for any builder with "-longtest" suffix if it did not manually
include GO_TEST_SHORT=0 in its environment configuration.
It's unlikely we would want to do that intentionally, so this refactor
makes such misconfiguration less likely by inserting the GO_TEST_SHORT
environment variable assignment into the output from Env automatically.
Now, a longtest builder is defined in one consistent way: it must have
a "-longtest" suffix, so that the IsLongTest method reports positively.
For golang/go#39054.
For golang/go#29252.
For golang/go#12508.
Change-Id: Ic24df7b3b7de7db728bba6dc6ad4dd38a2e61e82
Reviewed-on: https://go-review.googlesource.com/c/build/+/233901
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change adds a boolean which identified when an instance is an
EC2 instance. Various EC2 related variables have been renamed to be
more consistent.
Updates golang/go#36841
Change-Id: Ief385bf9d41e320ebd7d31bc0108e8053f337afd
Reviewed-on: https://go-review.googlesource.com/c/build/+/233801
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The plan9-arm builder is currently passing fairly reliably on the
dashboard, whereas the plan9-386-0intro builder is frequently failing
with an "unexpected fault address".
Until the plan9-386-0intro build is fixed, the plan9-arm builder seems
more useful as a SlowBot to check architecture-agnostic changes that
affect plan9.
Updates golang/go#35456
Updates golang/go#22227
Change-Id: Ib5ecddafec91ca9274f9f0e15cb98621b41dda85
Reviewed-on: https://go-review.googlesource.com/c/build/+/233797
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds an AWS buildlet client which allows us to
create EC2 instances on AWS. With this change we have also
moved a portion of the gce creation logic into a helper
function which allows multiple clients to use it. Metadata
for the instances are stored in the user data fields.
The creation of a buildlet pool and modifications to
rundocker buildlet be made in order to enable this change.
Updates golang/go#36841
Change-Id: Ice03e1520513d51a02b9d66542e00012453bf0d9
Reviewed-on: https://go-review.googlesource.com/c/build/+/232077
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The host-windows-arm-iotcore builder has been missing for an
extended period of time. Attempts to contact the maintainer have
failed. This removes the builder until we can find a replacement
for windows-arm instances.
Fixesgolang/go#38493
For golang/go#38607
Change-Id: Ia7d2168f676a86bced754688b4e2d52e61f3125b
Reviewed-on: https://go-review.googlesource.com/c/build/+/229559
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Given the performance of this hardware, reduce the amount of work that
it is trying to do.
Updates golang/go#25498
Change-Id: I943ab2b01bd10c5217c097464d3904b0f4de2d0a
Reviewed-on: https://go-review.googlesource.com/c/build/+/228597
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
The builder network is too slow/distant to upload snapshots successfully.
Updates golang/go#25498
Change-Id: Ida86eb1f84e34c9810227c98370cef980529796f
Reviewed-on: https://go-review.googlesource.com/c/build/+/228238
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This is a followup to CL 214433. Start using n1-highcpu-16 machine type
instead of n1-highcpu-8 for the freebsd-amd64-race builder.
Increasing the RAM from 3.6 GB to 7.2 GB has helped golang/go#36444
significantly: the builder stopped failing consistently on x/tools
and resulted in many data races being uncovered in golang/go#36605.
However, by now, it has started to fail consistently again. This
time it seems to be due to low performance, causing the tests in
golang.org/x/tools/internal/lsp/regtest package to fail due with
"context deadline exceeded" errors.
FreeBSD is one of the ports that stays visible when "show only first-
class ports" is checked on build.golang.org. The other -race builders
have all been upgraded to the n1-highcpu-16 machine type by now out
of necessity.
It seems fair to provide the FreeBSD port with an equal amount of
resources, even if the increased memory isn't strictly required yet.
Once this change is applied, if the failures persist, we can be more
confident that the problem is due to the code or the port, rather
than due to this -race builder having 2𝗑 less CPU and RAM resources
compared to other -race builders.
An alternative is to increase timeout for this builder type, but I'm
opting to defer exploring that after equalizing the machine type.
For golang/go#36444.
For golang/go#34621.
For golang/go#29252.
For golang/go#33986.
Change-Id: I41f149365128c7bc6f576c778ac07618acc04612
Reviewed-on: https://go-review.googlesource.com/c/build/+/227859
Reviewed-by: Alexander Rakoczy <alex@golang.org>
When a user explicitly requests a SlowBot builder via the TRY= syntax,
it is a signal that they're willing to wait longer for test results.
It's more useful to not skip any tests and give the user confidence
that the SlowBot run will catch all issues that would otherwise be
caught only by post-submit builders after the CL is submitted.
This is done by considering a TryBot that isn't an explicit SlowBot
to be a "normal TryBot", and the ShouldRunDistTest policy function
is provided a parameter specifying whether it's a normal TryBot
(non-SlowBot) run.
Tests are only skipped during normal TryBot runs, not SlowBot runs.
Fixesgolang/go#38279.
For golang/go#34501.
Change-Id: Ia11fd51c71f9de1089b6b6f4c027014893f224b9
Reviewed-on: https://go-review.googlesource.com/c/build/+/227779
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Previously, the behavior of ShouldRunDistTest could be overridden
by an individual builder by setting a the shouldRunDistTest field
to a custom policy implementation.
A pitfall of this approach is that it requires each custom policy
to reimplement the default cmd/dist test policy as well. If that
isn't done when attempting to make a small adjustment to the default
policy, the result is that the default policy is ignored.
The fasterTrybots policy, as the name suggests, exists to skip some
tests in trybot mode. Due to the problem above, it was causing some
builders to run more tests in trybot mode than they would if it
weren't applied. For example, the freebsd-amd64-12_0 builder should
have been skipping the "api" test in trybot mode, but wasn't.
This refactor fixes that by modifying the approach for how individual
builders can customize the cmd/dist test behavior. Now, a function
distTestAdjust is called with the first parameter specifying the
default policy decision. That function can adjust the decision as it
sees fit, but otherwise it preserves its initial value in situations
where no change is intended to be made.
For golang/go#38279.
Change-Id: I220248f51abfc8e77195ae0c9134a17f7cac9bc2
Reviewed-on: https://go-review.googlesource.com/c/build/+/227777
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The NetBSD 9.0 builders are operational as of CL 227538. They've been
running on a few commits in all repositories without issues.
The netbsd/386 builder is passing, no longer hanging in the runtime
tests as the NetBSD 8.0 version did, so keep it enabled.
If anything unexpected comes up, we should investigate.
For golang/go#37244.
For golang/go#31726.
Change-Id: Ie3167fa3eabb7f707487561ca2cd4505572df741
Reviewed-on: https://go-review.googlesource.com/c/build/+/227545
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
CL 207619 has been submitted to master, fixing golang.org/issue/38029.
The linux-amd64-staticlockranking builder has been passing since then.
Unset its known issue so that if there are regressions in the future,
they can be investigated.
For golang/go#38029.
For golang/go#37937.
Change-Id: I0de8e4ac122effee56aac73c741fab41512ff0c2
Reviewed-on: https://go-review.googlesource.com/c/build/+/227544
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
Update NetBSD amd64 and 386 builders to the latest NetBSD 9.0 release,
using the latest versions of anita (2.3) and pkgsrc packages (2019Q4).
Also increase the image disk size from 4 GB to 16 GB. The motivation
is to help tests that require more disk space and large dependencies.
Additional adjustments to the image building script will need to be
made to make use of increased disk space for the /tmp volume, as it
is currently being mounted in RAM with size equal to 25% of memory.
Remove the manual invocation of the mozilla-rootcerts install command.
It no longer works as is in NetBSD 9.0. The mozilla-rootcerts-openssl
package is added instead, which successfully performs that same task.
Hopefully this will be a more robust approach for the future.
Continue to use an explicit URL for the NetBSD release download, and
remove unused find_latest_release.
The plan is to roll out these builders first (without trybots), gain
more confidence, enable trybots, and then remove NetBSD 8.0 builders.
For golang/go#37244.
For golang/go#30839.
For golang/go#31858.
For golang/go#31726.
For golang/go#38283.
Change-Id: Id41278eaebe64cfbcf7b1ab9bfd64e550ee0bbf1
Reviewed-on: https://go-review.googlesource.com/c/build/+/226977
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The linux-amd64-staticlockranking builder was added pre-emptively so
that it could be tested and used during the development of a CL that
implements a new feature. It's expected to fail until that work is
completed. Mark it as a builder with a known issue, golang/go#38029.
The new BuildConfig.KnownIssue field can be used by builders being
added in the future so that if they fail at first, it doesn't take
away time for people looking at build.golang.org, which we always
aim to have as green as possible¹.
¹ https://groups.google.com/d/msg/golang-dev/y0yM_Xi665Q/hUpBiUPiCAAJFixesgolang/go#38283
For golang/go#38029
For golang/go#37937
For golang/go#11811
Change-Id: Iba1606c7021ffa7e67ddbaae2fc6b65f4e46ab34
Reviewed-on: https://go-review.googlesource.com/c/build/+/227379
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The 32-bit pairs darwin/386 and darwin/arm are removed in Go 1.15,
and the master branch is where Go 1.15 is being developed.
The builder has started to fail after CL 226985 (as intended),
so remove it. Keep it running on Go 1.14 and 1.13 release branches.
Also update the misc-compile-darwin builder description.
For golang/go#37610.
For golang/go#37611.
Change-Id: Ia70386c5ae2821b4397048dcb0862a066463d6de
Reviewed-on: https://go-review.googlesource.com/c/build/+/227181
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
* DragonFly BSD 5.8 was released on March 3rd, 2020. This is the next release after 5.6.
* Gobuilder VM has been upgraded to 5.8 and the scripts adjusted.
Change-Id: I1d885359aedef8182e57f1ea004982f5060ae7af
GitHub-Last-Rev: 25fa394d4c
GitHub-Pull-Request: golang/build#27
Reviewed-on: https://go-review.googlesource.com/c/build/+/222517
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The policy has changed its meaning in CL 167998.
Make its name more explicit and descriptive.
Remove netBSDDistTestPolicy, since it's actually
no different than the new noTestDirAndNoReboot.
There should be no behavior change, this is a refactor.
Change-Id: I17b3f25cf3e865444e9dae65db5190feb75afcb6
Reviewed-on: https://go-review.googlesource.com/c/build/+/226881
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
When the compiler's backend became concurrent, we introduced the
racecompile builder to run the compiler with the race detector
enabled to catch races. In the new linker work the linker will
become more concurrent as well. It is probably a good idea to run
the linker with the race detector as well.
Change-Id: Ib50f030cba0509730714b74462f5a8942fe2fd2d
Reviewed-on: https://go-review.googlesource.com/c/build/+/226369
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This is a re-send of CL 216765, which was reverted in CL 217723
due to the misc-compile-other trybot being broken on linux/riscv64.
By now, the problem that was caught by the misc-compile-other trybot
has been fixed in CL 217777, so we can try again.
Fixesgolang/go#36871Fixesgolang/go#37022
Change-Id: Id9e7d7f3e610b17a2d37a2216ab5d3eed139ee1e
Reviewed-on: https://go-review.googlesource.com/c/build/+/224580
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
If a dev branch is active, it will be current. If it is not
active, it is probably not current, but we don't build on the
branch so it doesn't matter anyway.
Specifically, the dev.link branch is currently under active
development, and it would be good to have a large set of builders
run on the branch to catch problems. (E.g., AIX build was broken
but not noticed.)
Fixesgolang/go#37953.
Change-Id: Idd7e3edaaff1b4d2cee17da552a96df2b00716e9
Reviewed-on: https://go-review.googlesource.com/c/build/+/223381
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This is a new linux/amd64 GCE builder for the purpose of
testing the GOEXPERIMENT=staticlockranking configuration
which is landing to master branch soon.
It runs only on the main Go repository master branch and
release branches 1.15 and newer. No golang.org/x repos.
Not included in trybots by default, but can be requested
via SlowBots by saying TRY=linux-amd64-staticlockranking.
Also expand documentation of BuildConfig.buildsRepo field
to make it more clear how to use it. A common mistake for
custom buildsRepo functions that are added is to create a
custom policy with a minor adjustment and forgetting to
preserve the rest of the default build repo policy.
Fixesgolang/go#37937
Change-Id: Ic56f82e9ede30cb6fe8f6cc7d0282d6a0a12c1b8
Reviewed-on: https://go-review.googlesource.com/c/build/+/224078
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Go 1.15 will require macOS 10.12 and newer¹, so keep the OS X 10.11
builder enabled only on release branches for 1.14 and older.
¹ https://golang.org/doc/go1.14#darwinFixesgolang/go#37425
Change-Id: I89ab0eb56729fe16fb3a524c8f7b9bb25751d708
Reviewed-on: https://go-review.googlesource.com/c/build/+/222797
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
These have been consistently failing for weeks and attempts to
contact the owner have been unsuccessful.
Updates golang/go#37611Fixesgolang/go#31497
Change-Id: I43c8b9de18c758d256290ee42eb3755dd9eacf3f
Reviewed-on: https://go-review.googlesource.com/c/build/+/222720
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
OS X 10.10 is no longer supported by the latest versions
of Go (1.13 and 1.14). It is no longer in use.
Fixesgolang/go#37713
Change-Id: Ibc4a527c17f2dafd00ee0fba2e312394e1ceac9c
Reviewed-on: https://go-review.googlesource.com/c/build/+/222337
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
A kernel bug in macOS 10.14 is causing a set of tests to be flaky.
Upgrading to macOS 10.15 fixes this issue. This change moves more
testing towards the current version of macOS.
Fixesgolang/go#37695
Change-Id: Ide69693e760639a9d680738cad0541d79a0a0443
Reviewed-on: https://go-review.googlesource.com/c/build/+/222238
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
A trybot for linux/riscv64 still needs to be added. That work is
being tracked in issue golang.org/issue/36871.
Fix the failing test by skipping riscv64 for now, because a failing
test makes it hard to make other unrelated changes in x/build.
Updates golang/go#36871
Updates golang/go#27532
Change-Id: Ibbd17cd068c8eedc409ee5677074a404e6ac6d65
Reviewed-on: https://go-review.googlesource.com/c/build/+/216841
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
When we moved the ppc64le builders to Docker, GOPPC64=power9 was not set
for the POWER9 builders. This variable has to be passed to the environment
so the compiler can generate POWER9 instructions.
Fixesgolang/go#36802
Change-Id: I13e99eb316e2126302e26ee771aaf8bbfbbc1c8c
Reviewed-on: https://go-review.googlesource.com/c/build/+/216577
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
macOS 10.8 is very old and not supported by Go 1.13 nor Go 1.12.
There are no instances of this builder type available because
macOS builders are not created on demand and the ExpectNum value
is set to zero. Remove it and various files related to it.
Fixesgolang/go#36560
Change-Id: Ife36624f3695fccff2f5a12af4518e25645b4f0d
Reviewed-on: https://go-review.googlesource.com/c/build/+/215257
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Start using n1-highcpu-8 machine type instead of n1-highcpu-4
for the freebsd-amd64-race builder.
The freebsd-amd64-race builder has produced good test results
for the x/tools repo for a long time, but by now it has started
to consistently fail for reasons that seem connected to it having
only 3.6 GB memory. The Windows race builders needed to be bumped
from 7.2 GB to 14.4 GB to run successfully, so this change makes
a small incremental step to bring freebsd-amd64-race closer in
line with other builders. If memory-related problems continue to
occur with 7.2 GB, the next step will be to go up to 14.4 GB.
The freebsd-amd64-race builder is using an older version of FreeBSD.
We may want to start using a newer one for running tests with -race,
but that should be a separate change so we can see the results of
this change without another confounding variable.
Also update all FreeBSD builders to use https in buildletURLTmpl,
because it's expected to work fine and will be more consistent.
Updates golang/go#36444
Updates golang/go#34621
Updates golang/go#29252
Updates golang/go#33986
Change-Id: Idfcefd1c91bddc9f70ab23e02fcdca54fda9d1ac
Reviewed-on: https://go-review.googlesource.com/c/build/+/214433
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
David Chase
Lynn Boger
Dmitri Shuralyov
Carlos Amedee
Baokun Lee
Austin Clements
Alexander Rakoczy
Joel Sing
Julie Qiu
Ruixin Bao
Jason A. Donenfeld
Meng Zhuo
Elias Naur
Tobias Klauser
Benny Siegert
Bryan C. Mills
Antonio Huete Jimenez
Cherry Zhang
Andrew Bonventre
Brad Fitzpatrick
Carlos Eduardo Seo