CL 363474 added a 2012 builder, which is good, but it also took a major
step in sunsetting Windows 7 support by removing all 2008 builders from
trybots and for Go 1.18+. This will surely bitrot Windows 7 support and
force us to remove support for it, which isn't okay. Rather than line up
dominoes to force our hand on policy, such huge policy changes with
sweeping ramifications should be properly decided.
So, this commit keeps the 2008 builders in the running, alongside the
2012 ones.
Updates golang/go#47845.
Updates golang/go#49490.
Change-Id: I574f51ea22f638d2f9b09fcd00fdfc3097631771
Reviewed-on: https://go-review.googlesource.com/c/build/+/366656
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This change mounts the gomote and coordinator servers in the proper
locations.
Updates golang/go#47521
Updates golang/go#49191
Change-Id: I7c0054028fa928ba025b3c511701512e183894fd
Reviewed-on: https://go-review.googlesource.com/c/build/+/365735
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change:
- Adds a simple GRPC gomote server.
- Updates the documentation for the audiance required for IAP authentication.
- Adds a field for the backend service id in the build enviornment package.
- Creates middleware for the GRPC server use in the existing HTTP servers.
Updates golang/go#47521
Updates golang/go#48742
Change-Id: I2a56e39b96bf1b429f807f79c58aee3f72a45a33
Reviewed-on: https://go-review.googlesource.com/c/build/+/361098
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The x/talks repository followed suit after x/blog and x/tour
and has been merged into x/website. CL 366177 removes all of
its moved content, leaving just a README.
Stop displaying it on the build dashboard and running post-submit
tests. Keep TryBots enabled in case a CL is sent with new Go code.
Change-Id: I8c13945b5ae04560d254ba679bf80696f44bed25
Reviewed-on: https://go-review.googlesource.com/c/build/+/366574
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Accidentally removed in the fix for an accidental removal because I am
in too much of a hurry today.
Change-Id: I67a5518f36b051c2e99c0d3cabed3d61ce3401e9
Reviewed-on: https://go-review.googlesource.com/c/build/+/366234
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
This change refactors the existing remote buildlet session management
implementation. It implements logic which was originally found in the
HTTP handlers and moves it into a session manager. This change also
introduces a fake buildlet client intended to be used for testing when
additional functionality is added to the session pool.
Updates golang/go#48735
Change-Id: Ib7d66cefb9847cf2659e7049f707d78536fbbbea
Reviewed-on: https://go-review.googlesource.com/c/build/+/361097
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change updates the version of FreeBSD used for the
freebsd-amd64-race builder to 13.0. The slowbot aliases have been
updated to use FreeBSD 13.0.
Updates golang/go#46272
Updates golang/go#45903
Change-Id: I1092f9e6bf66a9f429b463dce5d0d5647d44eec8
Reviewed-on: https://go-review.googlesource.com/c/build/+/365616
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
We need this on every build and I forgot to put it on the new ones. Move
it to the host where it's not forgettable.
Hopefully fixesgolang/go#49723.
Change-Id: I9263f8aa9d847250bb438f59c04fe48bcfd5b1da
Reviewed-on: https://go-review.googlesource.com/c/build/+/366136
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
The x/website repository is unusually large due to having content
from x/blog, and as of CL 365135 also from x/talks. Increase its
limit to 200 MB, but leave other repositories as they were.
Updates golang/go#46379.
Change-Id: Ib18766cb5903e602899c1777f1fba7d7cb2a5767
Reviewed-on: https://go-review.googlesource.com/c/build/+/366135
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
The build system enforces a limit on the compressed tree tarball size
that it's willing to fetch and propagate throughout the rest of the
system. If that limit is exceeded, consider it a terminal error and
fail the build, since fetching the exact same commit again will not
produce a different result.
Such situations will always involve some human intervention:
• if the limit was exceeded unexpectedly, for example due to unwanted
content being accidentally checked in, a different commit will be
pushed and tested
• if enough time has passed that what used to be deemed as enough
no longer holds, the size limit will need to be updated
Factor in buildgo.FetchSubrepo into the two places in cmd/coordinator.
Its behavior was so trivial (just 2 function calls) that the overhead
of creating an additional abstraction overshadowed any small benefits.
Fixesgolang/go#49707.
Updates golang/go#46379.
Updates golang/go#11224.
Change-Id: I7219da97a888ce621d71a51f828400a11e343bf9
Reviewed-on: https://go-review.googlesource.com/c/build/+/365974
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Forgot to do this in CL 365777.
For golang/go#49149.
Change-Id: I50d090d84408898b4ceb19da660de9c3a79beeda
Reviewed-on: https://go-review.googlesource.com/c/build/+/366134
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
- Add more Monterey builders and remove the known issue: it's stable.
Also use it for race and nocgo. Update slowbot aliases to point to it.
- Don't test 1.16 on OpenBSD 7.0, it segfaults.
- Pin the Linux (ContainerOS) builders to an older version to avoid the
pprof kernel bug.
For golang/go#49065, golang/go#49149, and golang/go#48977.
Change-Id: Ibec2fa735183ec65e5066c7c752ac356b7360550
Reviewed-on: https://go-review.googlesource.com/c/build/+/365777
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
We recently migrated in CL 354757 from n1 to e2 hosts around the same
time issues started appearing with these builders. n1 hosts are notably
different in that they are older generation CPUs with hyperthreading
disabled.
For golang/go#49209
Change-Id: I8b6822fbd4910602f61d504b34580282c97c0ca7
Reviewed-on: https://go-review.googlesource.com/c/build/+/365776
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Take a small step to bring the dashboard
towards the current state of the builder.
For golang/go#49325.
Change-Id: I4a2aa4efcb374ad6d2affa167e0eba2c55f52e50
Reviewed-on: https://go-review.googlesource.com/c/build/+/365695
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Now that we're not allocating external IP addresses to our VMs, you
can't get to them directly from outside our GCP project. The way to fix
that is to use an IAP tunnel. Sadly, there is no API for creating an IAP
tunnel other than gcloud; we have to shell out to it.
Change-Id: I577734aae669a952705276f88f878f040a4b3bf0
Reviewed-on: https://go-review.googlesource.com/c/build/+/364414
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The standard Go unit tests fail when the disk size is 8GB. This change
increases the size of the disk for freebsd-amd64 based hosts to 16GB.
Updates golang/go#45903
Change-Id: I1f72d019c847f10867d3071f6c4525d04e660939
Reviewed-on: https://go-review.googlesource.com/c/build/+/365254
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds builders for FreeBSD 13.0.
Updates golang/go#46272Fixesgolang/go#45903
Change-Id: I92f68f8d5eeee2d3bae8864dbfe5ee61b93ea677
Reviewed-on: https://go-review.googlesource.com/c/build/+/365314
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
I'm not 100% sure they'll work, so just one for now.
I've updated the documentation according to my very shaky understanding.
For golang/go#49149.
Change-Id: Ic8f3b7fe96a1a6c18c0940a4aa2d08ec9dc2138b
Reviewed-on: https://go-review.googlesource.com/c/build/+/365194
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The loader in FreeBSD-13.0 now boots into graphical mode since
https://cgit.freebsd.org/src/commit/?id=b6d85a5f51e4147452b35d76478fb9e191b7734b.
Add a "blind" menu interaction mode to the expect script to enable
the dual video/serial consoles, so that the video mode switches
to text mode when the kernel boots (which is scriptable using SeaBIOS sercons).
Updates golang/go#45903
Change-Id: I3da18b7e016111d04878c963f37ffd66573b9404
Reviewed-on: https://go-review.googlesource.com/c/build/+/315277
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
The playground is moving to go.dev/play,
so we will start seeing those URLs in removal requests.
Change-Id: Ic8e5ffcb95b12ebbcaa899efa61945fed7ba916c
Reviewed-on: https://go-review.googlesource.com/c/build/+/365014
Trust: Russ Cox <rsc@golang.org>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
all.bash takes a long time on these builders. I'll keep an eye on them
to see if it causes trouble.
For golang/go#48977.
Change-Id: I0239a93c004157855968dab397e68abe38f5f439
Reviewed-on: https://go-review.googlesource.com/c/build/+/364094
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Change-Id: I11edfc452bdab5c873217cd8e57defe35ed9c026
Reviewed-on: https://go-review.googlesource.com/c/build/+/364515
Trust: Roland Shoemaker <roland@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Also set ExpectNum 2, since there are 2 known reverse builders.
Updates golang/go#49557.
Change-Id: I639f88701b62004619b8dbeacda79cb2469d1595
Reviewed-on: https://go-review.googlesource.com/c/build/+/363984
Reviewed-by: Heschi Kreinick <heschi@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Prefer displaying GitHub usernames for convenience of pinging in GitHub
issues, since all current builder owners have them. Keep it possible to
use an email or something else if no GitHub account exists.
Update the owner of the Corellium builders to be individual GitHub
account, so that it can be pinged in an issue. The GitHub organization
is already mentioned in the builder notes.
Also switch to html/template (instead of text/template) for rendering
the builders page.
Fixesgolang/go#49596.
Change-Id: I89a96eb8f7a3057bc1f3aaee16abc9c776c45ee7
Reviewed-on: https://go-review.googlesource.com/c/build/+/363983
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Otherwise, the strict match will not match endpoints other than the
home, which redirects.
For golang/go#47401
Change-Id: I1317e6c097374a40be69481a5b36934bb15e5b81
Reviewed-on: https://go-review.googlesource.com/c/build/+/363979
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This fixes creation in a production environment.
For golang/go#47401
Change-Id: I9aa83e77b98c512c6efe75a30ecbb745aad5a1f4
Reviewed-on: https://go-review.googlesource.com/c/build/+/363978
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Nested http.ServeMux should be configured with the appropriate
trailing slash, but we should not use the trailing slash when using
http.StripPrefix. This simplifies ServeHTTP slightly, and corrects
behavior when handling nested mux.
For golang/go#47401
Change-Id: I2e6ab792e210a500025b8b07a28e3db67696397d
Reviewed-on: https://go-review.googlesource.com/c/build/+/363977
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
In non-development environments, the default will be a database that is
the same as the username, which is not likely to exist.
For golang/go#47401
Change-Id: I2e4664f7917d1a63417cc1a19f800a043dff9d43
Reviewed-on: https://go-review.googlesource.com/c/build/+/363976
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
This change allows relui to correctly serve from a path, like
build.golang.org/releases. It adds a base-url flag which is used to
prefix all paths referenced in the application.
For golang/go#47401
Change-Id: Ib8f6fe429591ceabfaf0f419e5258a677b375ff8
Reviewed-on: https://go-review.googlesource.com/c/build/+/363975
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Order matters for path matching.
For golang/go#47401
Change-Id: I92f5fb716b1d893313a7d2883f8de63cb8278156
Reviewed-on: https://go-review.googlesource.com/c/build/+/363697
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
This mounts relui to the appropriate locaiton.
For golang/go#47401
Change-Id: I247ac925b47206acc2a6b4a109da003645af3a68
Reviewed-on: https://go-review.googlesource.com/c/build/+/363696
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Add missing IAM flag for cloud_sql_proxy, and use the correct user and
database in relui environment.
For golang/go#47401
Change-Id: I2fa760c00f7000552d87069f259750fa455cce92
Reviewed-on: https://go-review.googlesource.com/c/build/+/363695
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Add deployment configuration for relui using IAM database
authentication.
For golang/go#47401
Change-Id: Ifde113bd3e09d19eb69bffb5a0ce3689e6c6410a
Reviewed-on: https://go-review.googlesource.com/c/build/+/363535
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
x/review is fairly disk-intensive (it shells out to 'git'), and also
mostly for use by Go contributors (a smaller subset of Go users in
general). It frequently times out on two particular 32-bit builders.
I don't think we particularly need the coverage from those two
builders for this repo, so rather than trying to speed up the test or
tweak the scale factors, let's just skip it.
Fixesgolang/go#49529Fixesgolang/go#49530
Change-Id: I8da1216ebdf9287ae78d52bb03187b65eb33c9ee
Reviewed-on: https://go-review.googlesource.com/c/build/+/363495
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This enables module graph pruning for modules that depend on x/build,
and lazy loading within x/build proper.
It may also help somewhat with build timeouts for small Playground
programs that import from x/build, such as the one observed in
https://play.golang.org/p/Jj_dmqq6de0.
Change-Id: Ic963ebf8d6b3d1580e9c11012ce37a8d22e6ac11
Reviewed-on: https://go-review.googlesource.com/c/build/+/363494
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The plan9 builders have relatively slow filesystems, and the website
repo is relatively filesystem-intensive — many of its tests walk and
process large trees of website content.
Instead of trying to precisely tune the x/website tests to pass on the
plan9 builders, let's skip this repo on them.
For golang/go#49338.
Change-Id: Ieaf50fb6955a6b39012a23ff72e61c1c31e4ce7c
Reviewed-on: https://go-review.googlesource.com/c/build/+/362975
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change adds a Windows 386 builder with version 2012 of Windows
server. It replaces Windows 2008 as the version of Windows used for
trybot runs. It also ensures Go 1.17 is the latest version of go being
tested on Windows 2008 builders. Windows 2008 has reached its end of
life and will be phased out.
Updates golang/go#47845Fixesgolang/go#49490
Change-Id: I2307c68a74dfb41eb6a1a24177cc58835989d56b
Reviewed-on: https://go-review.googlesource.com/c/build/+/363474
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
This change also updates rmplaysnippet to
report to the user and exit early if no
snippet with the given ID exists.
Fixesgolang/go#49531
Change-Id: I8dfc5c1badba268b02ea1d39f9835c25f85050bf
Reviewed-on: https://go-review.googlesource.com/c/build/+/363454
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
coordinator.go has grown to about 4100 lines and has become difficult to
navigate. The largest related chunk of code is buildStatus, which we now
organize into its own file, which should help navigation a little.
Also, clean up a couple comments, deperecated, and unused code along the
way.
Change-Id: I83508a915a63074cf6ec44b4c21229389377e1a5
Reviewed-on: https://go-review.googlesource.com/c/build/+/359434
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Previously, Run had a race on cancellation: if Run noticed
cancellation first then failures would not be recorded and the task
could be resumed, but if the task itself noticed the cancellation and
returned before Run happened to notice then its error would persist.
Fixesgolang/go#49318
Change-Id: Iad7b7ff35649725ef062535c64d8668f0d6bd079
Reviewed-on: https://go-review.googlesource.com/c/build/+/362974
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
After creating some new resources in our project, we have gone over 500
disks in some zones, which is the default pagination size. This change
filters to just the disks we care about, which should remain at well
under 500 for the foreseeable future.
For golang/go#49483
Change-Id: I4c5c4698624453fe51373a5668cc0a40b4813dbc
Reviewed-on: https://go-review.googlesource.com/c/build/+/362539
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
These make it possible to tell what was run, as well as a convenience
field stating whether this was a post-submit build or a trybot run.
For golang/go#49207
Change-Id: Iba979bcfd5a3bbdc11e2df0b8de4094cc7212356
Reviewed-on: https://go-review.googlesource.com/c/build/+/361874
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change copies the remote buildlet session management logic from
the cmd/coordinator/remote.go file. This copies the existing
implementation without including the HTTP and SSH handlers which also
contain small portions of logic. This is the first step before
refactoring the implementation which will be used in the GRPC server.
Updates golang/go#48735
Change-Id: Idb26616ddb5494a8f96f8b66369e20f19f2871dc
Reviewed-on: https://go-review.googlesource.com/c/build/+/361096
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This change adds an access package which is intented to contain
functions which will handle Identity Aware Proxy authentication. It
may be extended to include authorization logic in the future.
Fixesgolang/go#48729
Updates golang/go#47521
Change-Id: I68cd90c3e83066763e3194fcb58e324c3630f811
Reviewed-on: https://go-review.googlesource.com/c/build/+/358915
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Since this builder doesn't build the go repo, it will be waiting forever
for a snapshot. Instead, just build Go for each run.
For golang/go#49207
Change-Id: I34a73b507278db402c478b4f5956633996772aae
Reviewed-on: https://go-review.googlesource.com/c/build/+/361754
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Show our quotas on the farmer homepage making it easier to see when
we're at capacity.
Change-Id: I8c6820298914b320c4165e0ec7d9d9d9f1d7a5c4
Reviewed-on: https://go-review.googlesource.com/c/build/+/361657
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
We currently use E2, C2, and N2 instances on GCE. C2 and N2 instances
have their own quotas, which are accounted separately from the CPUS
quotas.
This could probably be cleaned up to keep track of all CPU quotas and
handle more instance types, but this should work for the time being.
See: https://cloud.google.com/compute/quotas#cpu_quota
For golang/go#49207
Change-Id: Ida1e8de3c857560637095d57e972bca7222284ed
Reviewed-on: https://go-review.googlesource.com/c/build/+/361656
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Roland Shoemaker
Jason A. Donenfeld
Carlos Amedee
Dmitri Shuralyov
Heschi Kreinick
Alexander Rakoczy
Yuval Pavel Zholkover
Russ Cox
Bryan C. Mills
Katie Hockman
Michael Pratt