Matching what's currently defined in the Gerrit package, instead of
the int32 type defined in maintner.
Change-Id: I463c7a83e9c9e7d933a2375790d35d59056ea09d
Reviewed-on: https://go-review.googlesource.com/48570
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
GetChange returns details about a specific change, and we need it for
CL 46390.
Change-Id: I0047e7170e4c9f822663640e28ee4eaf24b184de
Reviewed-on: https://go-review.googlesource.com/48553
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
There have been a number of fixes for issues found with the Go test
suite in kqueue, signal handling and vio drivers.
Updates golang/go#20852
Change-Id: I95861220990c05f3e89a4a40893e17758d29ebe0
Reviewed-on: https://go-review.googlesource.com/48091
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
+ Add html/css/js base code. Does not do real-time updating
+ Currently only registration is supported as an activity
Change-Id: I82c3d62ec1ffce30e6a20eb85503be6be52194a6
Reviewed-on: https://go-review.googlesource.com/47935
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
+ Add UpdateWithLocker method to maintner.Corpus to allow an
external locker to be passed that will be held during mutations.
+ Add OwnerID to maintner.GerritCL that returns the Gerrit user ID
of a change using its meta commits.
+ Add maintner corpus to server.
+ Add /imfeelinglucky and /imfeelinghelpful endpoints that redirect
to a random HelpWanted GitHub issue.
+ Add initial scaffold for GopherCon dashboard.
Change-Id: I2567b084f012cad5a9b4dee07e92be05088ac9d8
Reviewed-on: https://go-review.googlesource.com/47830
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
CL 46838 added the update-needs task, to remove the prior NeedsFoo
label when NeedsBar was added.
Prematurely worrying about making it cheaper, I added some last
modified tracking code to avoid running a task on an issue if it had
already been run before the issue was last modified. For unknown
reasons, that code didn't work and this task wasn't being run. Add a
TODO for now, and avoid it. Use a different check to keep it cheap
instead.
Also adds a maintner.GitHubIssue.ForeachLabel method I used to find
label IDs. Not used otherwise, but might be useful later.
Fixesgolang/go#20819
Change-Id: Ia6260661310c9f25a99b256bbf4d398853271577
Reviewed-on: https://go-review.googlesource.com/47134
Reviewed-by: Andrew Bonventre <andybons@google.com>
If we got a webhook update, we know there's new data. We're not in
polling mode, so don't use the caching transport.
The caching transport was being too agressive and we were missing
label changes to issues, since the Issues.ListByRepo call to get
issues sorted by mod time descending was being cached.
This speeds up gopherbot. Gopherbot can react in realtime to changes,
but only if they make it into maintner in realtime.
Updates golang/go#20819
Change-Id: I5c0a0bbcb4bf0d9d484b9279ff5a80732b4e1269
Reviewed-on: https://go-review.googlesource.com/47133
Reviewed-by: Andrew Bonventre <andybons@google.com>
build.golang.org does't use any cookies or allow any non-read actions,
but fix anyway.
Change-Id: Ib9002753de268083d7e16ce41cd7ff950f7f28a4
Reviewed-on: https://go-review.googlesource.com/47091
Reviewed-by: Chris Broadfoot <cbro@golang.org>
It will differ depending on the box it’s being run on, breaking
tests depending on the environment.
Change-Id: I9d6e6ef3c89c922ab8fa3a4a52c364ed02230b7e
Reviewed-on: https://go-review.googlesource.com/47033
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This change removes all but the / and /release endpoints, moving
things around and deleting all App Engine-specific code while
attempting to not make many core logic changes (those will come in a
follow-up change).
Updates golang/go#20691
Change-Id: Ie8fa184578177cc2cb3c070e9108cf27d9e6f689
Reviewed-on: https://go-review.googlesource.com/46832
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Windows installer will not broadcast WM_SETTINGCHANGE when a reboot is
pending. This message is required for explorer.exe to reload the PATH
from the registry so future cmd.exe processes will launch with go/bin in
the PATH.
- Updated to wix v3.11[1]
- Added sha256 validation of wix binary after download
- Use the Wix extension[0] to always broadcast WM_SETTINGCHANGE after install.
- Removed to RegistryKey/@Action in installer.wxs suppress warning CNDL1138.
The param is deperacated and not needed.
[0] http://wixtoolset.org/documentation/manual/v3/customactions/wixsettingchange.html
[1] https://github.com/wixtoolset/wix3/releases/tag/wix311rtmFixesgolang/go#18680
Change-Id: I645b1e4a32bf0c1df2925d53474a38a7d7ddec94
Reviewed-on: https://go-review.googlesource.com/46458
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
+ Remove superfluous check for PORT env var since only the flag
will be used.
+ Remove HTML being written to the page before escaping step,
causing jank.
+ Grab the GitHub token from GCE metadata if it’s available.
Updates golang/go#20691
Change-Id: I10fbc163ee91907ef0b843c823f40fd87a62f476
Reviewed-on: https://go-review.googlesource.com/46210
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Since we can’t run an App Engine Flex app on *.golang.org (see
issue), the Flex app.yaml file is removed.
Updates golang/go#20691
Change-Id: Id775962349a88b119c9fe671f9a5180f70528836
Reviewed-on: https://go-review.googlesource.com/46133
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Currently maintnerd prints
2017/06/17 15:00:16 Unknown error type <nil>: <nil>
if it successfully downloads a file. It shouldn't log if there was no
error.
Change-Id: I01c4f2bde616d709d5c081219f9c123d6ea6a678
Reviewed-on: https://go-review.googlesource.com/46007
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This is "Airplane mode". I had cached the latest maintner data before
a flight, but using godata.Get in flight failed when it tried to
update it.
Instead, detect the lack of network and just use whatever's available
instead.
Change-Id: Ieea29f844353377b3c36a531642a716f91f34436
Reviewed-on: https://go-review.googlesource.com/44813
Reviewed-by: Kevin Burke <kev@inburke.com>
It'll need to be expanded later to let the caller specify which
release, but the lack of flags works for now since we just started
using RELNOTE annotations.
Change-Id: I2a7d7cde050fe50e53010cbe6358ad1887618725
Reviewed-on: https://go-review.googlesource.com/44814
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This moves getSourceTgz* to a new package called sourcecache. The
original functions couldn't be left in coordinator.go because that
would cause a single process to have multiple caches.
The code for building and running benchmarks is moved into the buildgo
package, and the public API becomes GoBuilder.EnumerateBenchmarks and
Run on the resulting BenchmarkItem objects.
Updates golang/go#19871
Change-Id: I28b660e1cdaa6d1c6b0378c08de30f5e58316cc6
Reviewed-on: https://go-review.googlesource.com/44211
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This moves RunMake from coordinator.go, allowing other packages to
build Go on a buildlet.
Updates golang/go#19871
Change-Id: Ic0e7c056020ef434f0620ae816f52b9112ea1c8d
Reviewed-on: https://go-review.googlesource.com/44176
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This package contains the BuilderRev type moved from cmd/coordinator.
The rest of the CL is simply updating coordinator with the new
exported names of the type and its fields.
This refactoring is in preparation for moving the benchmark building and running
code into a separate package.
(Most of the diff could have been avoided with a type alias, but I
assume we'd rather not do that.)
Updates golang/go#19871
Change-Id: Ib6ce49431c8529d6b4e72725d3cd652b9d0160db
Reviewed-on: https://go-review.googlesource.com/44175
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This moves main.spanLogger and main.eventSpan to spanlog.Logger and
spanlog.Span. This change is necessary to start pulling build and
benchmark code out of coordinator. The interfaces cannot simply be
copied because Logger contains a function whose return type is
Span, so the interface must be defined in exactly one place.
Updates golang/go#19871
Change-Id: I0a48192e6a5c8f5d0445f4f3d3cce8d91c90f8d3
Reviewed-on: https://go-review.googlesource.com/44174
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This refactoring is in preparation for moving benchmarks.go to a
separate package.
Updates golang/go#19871
Change-Id: I2b30bf5416937e52b603aec8102131fdccceee42
Reviewed-on: https://go-review.googlesource.com/44173
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Jeff Johnson
Kevin Burke
Shawn Walker-Salas
Brad Fitzpatrick
Benny Siegert
Andrew Bonventre
Andrew Bonventre
Chris Broadfoot
Sarah Adams
Jess Frazelle
QiuxuanZhu
Quentin Smith
