There was a typo in the redirection code, causing invalid logic.
This change fixes it.
Change-Id: I71f1e98fff488689c988eb72a83b37e031d35b87
Reviewed-on: https://go-review.googlesource.com/56251
Reviewed-by: Kevin Burke <kev@inburke.com>
Added drchase -> dr2chase, for ssh access
Change-Id: Id36cf3cde94f785db0202d0100d528f4f7e017f6
Reviewed-on: https://go-review.googlesource.com/56270
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Add instructions for updating the systemd service file on the host.
Change-Id: Ifb73845c32992cea58b3bd734b2980fcb231c0f9
Reviewed-on: https://go-review.googlesource.com/55814
Reviewed-by: Sarah Adams <shadams@google.com>
Fixesgolang/go#21383
Change-Id: I58582709fd83bb5c6ee452bdc7e53658f58dcad8
Reviewed-on: https://go-review.googlesource.com/54751
Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Also, adds a test that would have failed CL 51432.
Change-Id: Icdc5b8a1a94efecd4422618b58ea4733002f0819
Reviewed-on: https://go-review.googlesource.com/53632
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The Mac builders were a bit weird in how they started up and refreshed
their buildlet binaries. (Problematically, they DIDN'T refresh their
buildlet binaries properly compared to all the other environments)
This makes them mostly like the other environments and documents the
process more. Instead of booting and downloading a weird ltitle shell
script that only downloads the buildlet binary once, it now downloads
the stage0 binary instead, and the stage0 binary handles the looping
and the smart conditional re-downloading of the buildlet binary per
build.
This also adds a --destroy-all flag to makemac (used to test the new
setup) and fixes a bug found in makemac while testing: it tried to
start twenty 10.8 instances because it didn't account for their boot
time when considering what was needed next. Now instead of just using
what's currently connected to the coordinator, it uses the versions
of the VMs created, even if they're booting and not connected yet.
Change-Id: Ie76b35d3a8c032136568bc0812d8c7dd54e7fa28
Reviewed-on: https://go-review.googlesource.com/53416
Reviewed-by: Herbie Ong <herbie@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Currently the buildlet ignores any GOROOT_BOOTSTRAP defined on the host,
assuming it'll always come from the coordinator.
Relax that a bit to make it easier to migrate people to buildlet from
the older builder.
This doesn't change behavior for any existing builder.
Updates golang/go#21191
Change-Id: I3c3ef77b073d7cecf41855e6d060773b8558935b
Reviewed-on: https://go-review.googlesource.com/53492
Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
On Plan 9, the home environment variable contains the
user's home directory.
Updates golang/go#21191
Change-Id: Ia421aebe5b3cfec6a2baa1bb7972183c8be19b97
Reviewed-on: https://go-review.googlesource.com/53473
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
I didn't realize that the freebsd-arm builder was actually called
freebsd-arm-paulzhol before and I mistakenly created the replacement
buildet-based builder as "freebsd-arm".
Name it how it was.
Change-Id: Ib7d73947ce599c82c628ab323001213e1b4ee20b
Reviewed-on: https://go-review.googlesource.com/53358
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
No point snapshotting for non-sharded builders.
And snapshotting is too slow and hits the timeout on freebsd-arm.
Updates golang/go#21191
Change-Id: I225aa6af493b92aa45589491c69853e13d513dd1
Reviewed-on: https://go-review.googlesource.com/53493
Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
In prep for better alerting when dedicated (reverse) buildlers
disappear, normalize the the MacStadium host names to remove the
extraneous guest OS version from them, so we can track the host's
last-seen time reliably over time, even as the guest OS version
changes.
This CL also cleans up makemac while it's there and fixes some bugs
and adds some paranoia checks and cleans up logging and adds an HTTP
status handler.
A future change will improve coordinator monitoring of reverse
buildlets.
Updates golang/go#21315
Change-Id: I3d09168cc91f37715b65ae2924a1642401e18808
Reviewed-on: https://go-review.googlesource.com/53353
Reviewed-by: Jessie Frazelle <me@jessfraz.com>
- Use a ¶ for in-page links like Godoc does, instead of a "link" emoji
- Only underline it if you are hovering
- Make the link target bigger by making the entire <h2> selectable
Change-Id: I48c2f0c5aa3c03403f20fd9774b8cdde26d5e9e5
Reviewed-on: https://go-review.googlesource.com/52051
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
The GCE bug is fixed and these VMs boot again.
(Previously: golang.org/cl/50011)
Change-Id: I3f330b8d0c6a6ae6708b2299bba13945a06fa36f
Reviewed-on: https://go-review.googlesource.com/53270
Reviewed-by: Herbie Ong <herbie@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This should fix the latest set of errors that bradfitz@ was seeing.
Updates golang/go#20852
Change-Id: Iad7d6a479c5546395de907731643c1d817fe625d
Reviewed-on: https://go-review.googlesource.com/53010
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
And some cleanups in the originally-auto-generated tables used by
stats above.
Change-Id: Ie2279e1926fa05cfc124e04ce074e05df4af2a0c
Reviewed-on: https://go-review.googlesource.com/53230
Reviewed-by: Sarah Adams <shadams@google.com>
This CL is almost entirely code movement. There is new code in
cmd/coordinator/gce.go.
This library-itizes the buildstats code and makes it used by both
cmd/buildstats (when run by hand) and cmd/coordinator, which now runs
it in a loop in the background.
Running cmd/buildstats by hand is still pretty useless because it
doesn't yet(?) have any query subcommands. It only has the original
-sync command, which is now automatic in the coordinator. But it could
still be useful for debugging or running manually in the staging
environment.
This will permit running BigQuery queries at any time, without Brad or
somebody first manually running cmd/buildstats -sync.
This also means we'll be able to get rid of a bunch of the static (and
stale) timing information in the coordinator code and use empirical
numbers instead for buildlet creation times and per-test durations.
This will help the test sharding schedule things better and result in
faster builds.
Updates golang/go#12669
Change-Id: If9a3b414f8d458a65305c4916ea16d59e5a3971c
Reviewed-on: https://go-review.googlesource.com/53072
Reviewed-by: Sarah Adams <shadams@google.com>
So Ian can ssh to gomote instances.
Change-Id: If03187f9038bc3753e0cc69479ce71d260409044
Reviewed-on: https://go-review.googlesource.com/53190
Reviewed-by: Ian Lance Taylor <iant@golang.org>
maintserve is a program that serves Go issues over HTTP, so they
can be viewed in a browser. It uses x/build/maintner/godata as
its backing source of data.
Note that it statically embeds all the resources it uses, so it's
possible to use it when offline. During that time, the corpus will
not be able to update, and GitHub user profile pictures won't load.
This is an iteration of an existing command named servegoissues,
with import path github.com/bradfitz/go-issue-mirror/cmd/servegoissues.
That program served the same purpose, but was located in another
repository. It used a "previous generation" approach to having
a corpus of GitHub issues data for Go projects, namely the
github.com/bradfitz/go-issue-mirror/issues package, which used
github.com/bradfitz/issuemirror technology.
The intent of maintserve is to replace servegoissues. It uses
the golang.org/x/build/maintner/godata package as its source of
data, which is built on top of the golang.org/x/build/maintner
technology.
Currently, maintserve has 2 types of pages:
- Index page, which lists repositories.
- Issues pages, which display a read-only version of issues.
This functionality is implemented in external issuesapp package.
By default, maintserve starts as an HTTP server at on port 8080,
so you should visit http://localhost:8080/ in a browser after
running the command. Note that the first run may take a while,
since godata.Get will need to download the entire corprus:
The initial call to Get will download approximately 350-400 MB
of data into a directory "golang-maintner" under your operating
system's user cache directory. Subsequent calls will only
download what's changed since the previous call.
Helps bradfitz/go-issue-mirror#7.
Depends on shurcooL/issues#5.
Change-Id: I421147df08c6f664afff0e70abb5d6aa6a42b2d5
Reviewed-on: https://go-review.googlesource.com/52932
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Since Go 1.9, the cmd/go tool has rearranged and the Go build now
writes some auto-generated files in different places. Don't delete
these auto-generated files in a "gomote push".
Otherwise you can't iteratively:
* hack locally
* gomote push
* test remotely
... without getting remote errors about missing files.
Change-Id: Iaf4d03f4a2cde46f5022b63066186495b3ae2c01
Reviewed-on: https://go-review.googlesource.com/53070
Reviewed-by: Andrew Bonventre <andybons@golang.org>
We want to kill off the --reverse vs --reverse-host code. This will
point out any clients still using the old way. There might not be any.
Updates golang/go#21260
Change-Id: Ic4b283b02891655ee43f2b7db76088df3f12065a
Reviewed-on: https://go-review.googlesource.com/52633
Reviewed-by: Sarah Adams <shadams@google.com>
Also, remove logic in addBuilder that sets HostType for mobile configs.
Change-Id: Id87f885fb56887abf52f656d06981f5b36b73310
Reviewed-on: https://go-review.googlesource.com/52634
Reviewed-by: Tuo Shan <shantuo@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Change bootstrap logic for solaris builders to avoid applying it to
Oracle Solaris builders. Additionally, update the location of the
Go bootstrap to reflect actual Oracle Solaris builder configuration.
Fixesgolang/go#21241
Change-Id: Ia2f21fab1581b4c195256c0dca7a87b4212798bf
Reviewed-on: https://go-review.googlesource.com/52310
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Step 1 of migrating cmd/builder users to cmd/buildlet users: delete
unused code to make sense of what actually remains.
Updates golang/go#21191
Change-Id: I74d52d49ea0f3ff347ff188dcc0f2c491afca2ff
Reviewed-on: https://go-review.googlesource.com/51830
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Herbie Ong <herbie@google.com>
This mirrors TimeStamp.UnmarshalJSON. Helps in emulating a Gerrit server
in integration tests.
Add tests for TimeStamp.UnmarshalJSON and .MarshalJSON.
Fixesgolang/go#21261
Change-Id: I972164c35308f5c5c46cf68847d52da2475182c3
Reviewed-on: https://go-review.googlesource.com/52471
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
"Dev" should refer to local development, not the staging server.
Change-Id: Icb02095ee24b7f890ca1c867a13cbdc45d1232bc
Reviewed-on: https://go-review.googlesource.com/52290
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
In https://golang.org/cl/51590 I tried to calculate the Run-TryBot and
TryBot-Result vote sums using the Gerrit NoteDB mirror we have in
maintner, but after two days of fighting it now, I've concluded it's
tricky. While I work on the tricky bits in parallel, this CL partially
reverts CL 51590, which had enough other cleanup and progress that it
wasn't worth reverting in its entirety.
Instead, move the Gerrit querying to maintnerd (instead of coordinator).
This isn't bad because maintnerd already queries Gerrit.
And coordinator will still be polling every second (introduced in
51590) instead of the old 60 seconds, but this CL now adds caching in
the RPC handler.
Change-Id: I80a519d9026a0981e3abf43d54a32b4684bda0e5
Reviewed-on: https://go-review.googlesource.com/51970
Reviewed-by: Kevin Burke <kev@inburke.com>
Dmitri Shuralyov
David Chase
Jess Frazelle
Yuval Pavel Zholkover
Sarah Adams
Brad Fitzpatrick
Chris Broadfoot
David du Colombier
Kevin Burke
Benny Siegert
Herbie Ong
Shawn Walker-Salas
Lann Martin
Andrew Bonventre
Jeff Johnson